Commit Graph

3899 Commits

Author SHA1 Message Date
Régis Hanol 2a99f1b15e BUGFIX: HOME/END keyboard shortcuts on non-topic pages
This make sure both HOME/END keyboard shortcuts are only applied when viewing a topic
2014-03-05 16:08:45 +01:00
Régis Hanol bce4130d39 Merge pull request #2036 from ArmedGuy/profile-backgrounds
FEATURE: Profile Backgrounds
2014-03-05 16:00:49 +01:00
Johan Jatko 98c479c3c4 FEATURE: Profile Backgrounds
Shares a modified codebase with avatars called "user_image"
2014-03-05 15:10:44 +01:00
Sam adb6541635 FEATURE: mailing list mode always available 2014-03-05 14:21:53 +11:00
Sam 69b498da24 Merge pull request #2034 from birarda/custom_username_length
allow for custom username length via site setting
2014-03-05 12:06:23 +11:00
Stephen Birarda 4a2dab9c5e allow for custom min_username_length
change constant in user to be global range and not default
2014-03-04 16:37:05 -08:00
Sam ea553202f0 Merge pull request #2033 from birarda/master
add option to override user attributes from SSO payload
2014-03-05 11:33:32 +11:00
Sam eb3a535c38 Merge pull request #2038 from fantasticfears/poster_expansion
poster_expansion will only slide down now.
2014-03-05 11:27:03 +11:00
Sam 24356cd807 Merge pull request #2050 from verg/unify_scroll_to_first_post
Scroll to Top of Topic instead of Reloading
2014-03-05 11:22:54 +11:00
Sam b0fc834e09 Merge pull request #2054 from ligthyear/fix-broken-cats
BugFix: email-in on categories wasn't null-ed properly
2014-03-05 11:16:20 +11:00
Benjamin Kampmann bf77c84095 BugFix: email-in on categories wasn't null-ed properly
Causing a problem if two categories got saved with an empty string because the corresponding Database constraint on the index would complain about dublicate values
2014-03-05 00:42:05 +01:00
Robin Ward aa3f7f764d You can only reuse email tokens within 24 hours. 2014-03-04 14:03:04 -05:00
Robin Ward 15c9c90533 When links have thousands of clicks, display them like 3.3K 2014-03-04 13:44:53 -05:00
Robin Ward e276045112 TRIVIAL: Change some variables to `self` 2014-03-04 13:09:11 -05:00
Robin Ward 90a1cb5bec Change email token expiry to 24 hours instead of 1 week 2014-03-04 13:02:48 -05:00
Stephen Birarda c3eb2025d8 add option to override user attributes from SSO payload
add an external_username attribute for username from SSO payload

repair the field name in SingleSignOnRecord migration

move setting of external_username for sso to controller

add settings toggle to override username/email from SSO payload

fix changing of external username after override toggle

complete tests and logic for sso override

add some extra context to username override option

add external_email and external_name to single sign on record

add setting for name override from SSO payload

complete override with stored external_email and external_name

add missing checks to tests

remove an unneeded describe block

break up a monster method for single sign on

fixes for sso attribute override after failed tests
2014-03-04 09:52:21 -08:00
verg 7f440532a7 Jump to First Post instead of Reloading Topic 2014-03-03 19:09:42 -05:00
Robin Ward 28f84ef0e1 TEXT: Change to "Dismiss New" 2014-03-03 17:15:53 -05:00
Robin Ward 4b61d6af28 BUGFIX: new date was incorrect 2014-03-03 16:11:59 -05:00
Robin Ward f9cd354a2c FEATURE: Button to reset new 2014-03-03 15:47:01 -05:00
Robin Ward 3abe84941f FEATURE: Add `new_since` column to `UserStat` so we can reset the "New"
date.
2014-03-03 15:47:00 -05:00
Kris Aubuchon 3d39dd3137 fixing an issue where a horiztonal scrollbar appears 2014-03-03 13:53:07 -05:00
Robin Ward 158487dfc2 FIX: Clean up next/prev rel links 2014-03-03 12:56:37 -05:00
Robin Ward 6143753fef Support uppercase bbcode too. 2014-03-03 11:59:57 -05:00
Erick Guan b5ca30bf56 poster_expansion will only slide down now. 2014-03-03 09:32:45 +00:00
Jeff Atwood 13f82f856f Merge pull request #2045 from awesomerobot/master
changed some topic page widths so the gutter fills the availible space...
2014-03-02 23:52:48 -08:00
Kris Aubuchon dd4a01896b changed some topic page widths so the gutter fills the availible space, also right-aligning user-dropdown 2014-03-03 01:16:30 -05:00
Sam ceb80611d6 PERF: defer last_ip_address and last_seen updates 2014-03-03 15:16:38 +11:00
Sam 172e517b31 Merge pull request #2012 from ligthyear/incoming-emails
Advanced New-Topic via Email Feature
2014-03-03 10:58:10 +11:00
Sam 7004b3f3b9 Merge pull request #2037 from infogulch/abandon-button-text
Explicit button text in abandon dialog in all lang
2014-03-03 10:37:32 +11:00
Jeff Atwood 66ae439ded rel="prev" and rel="next" for topic also 2014-03-01 02:16:40 -08:00
infogulch bf21a55571 Explicit button text in abandon dialog in all lang
The current post abandon dialog displays typical yes/no buttons and should
instead show more informative button text.

This commit updates all `config/locales/client.*.yml` files and *alters the
structure* of the `post.abandon` node, and *adds three new nodes* under it:
`confirm`, `yes_value`, and `no_value`. The current value of the
`post.abandon` node is moved into `post.abandon.confirm` for all languages.
For English language text, the nodes `post.abandon.yes_value` and
`.no_value` are changed to `"Yes, abandon"` and `"No, keep"`, respectively.
For other languages, the standard yes/no values are copied, allowing simple
copyedits to make them more explicit in the future.

I also make the necessary changes to the `composer_controller.js` file so
the new values are used correctly.
2014-02-28 23:42:14 -06:00
Neil Lalonde b40313559b FIX: moderators should not be able to see site setting changes in the staff action logs. Fixes #2027 2014-02-28 16:30:54 -05:00
Robin Ward 7d6984a915 Make the back button less awkward when leaving a topic. 2014-02-28 15:35:45 -05:00
Robin Ward 61ff04d68b Upgrade ember-cloaking to not trigger scroll events when the back button
is hit.
2014-02-28 15:35:45 -05:00
Régis Hanol 6b83ed0347 OPTIM: change Top Topic's score computation algorithm
New algorithm will not wipe the entire table anymore and will only remove
invisible topics and add new visible topics.
2014-02-28 20:33:52 +01:00
Régis Hanol 5e1019adba FEATURE: better UX when backing-up the site
Users won't be prompted whenever the site goes into read-only mode.
Instead, a banner will be shown at the top of every pages.

Also, the browser won't automatically reload whenever read-only mode is
disabled. This really was bad UX.
2014-02-28 18:09:48 +01:00
Robin Ward 67463af4f4 BUGFIX: Don't include deleted topics in activity. Deleted posts are OK. 2014-02-28 11:15:05 -05:00
Benjamin Kampmann 024597e643 Switch to proper exception handling system for better user feedback
- Replace implicit return code-system in Email::Receiver with proper exception system
 - Update tests to check for exceptions instead
 - Test the PollMailbox for expected failures
 - Add proper email-handling of problematic emails
"
2014-02-28 17:02:58 +01:00
Benjamin Kampmann d32cb55837 Add public-inbox to Email-In-Feature
- Adds the advanced option to accept email from non-users per category email-address
 - Adds tests covering the new feature
 - Adds UI to configure this feature in the frontend
2014-02-28 16:53:58 +01:00
Benjamin Kampmann 37cea49459 Add Email-In-Per-Category
- allow the configuration of an inbox-email-address per category
 - post emails to that email into that category instead of global

 - Adds UI for configuration
 - Adds Documentation for configuration
 - Adds Tests for new feature
2014-02-28 16:53:58 +01:00
Allen Hancock dad43b9853 Optionally allow discourse to create new topics from email. 2014-02-28 16:53:58 +01:00
Régis Hanol ca9f6e9137 BUGFIX: couldn't upload backup on OSX
--B is not a valid df option on OSX
2014-02-28 15:43:50 +01:00
Sam 560b5356d5 Revert "Use symbols instead of strings in order clause"
Breaks 1.9.3 compat

This reverts commit 09a2d9e12c.
2014-02-28 15:08:50 +11:00
Neil Lalonde 3ddd71ffd1 Don't tell you that you successfully flagged a topic. 2014-02-27 18:31:37 -05:00
Sam 6e0e628ff5 BUGFIX: don't force load drafts when composing.
It will still be there after post is made.
2014-02-28 10:30:05 +11:00
Robin Ward 4d798abe50 BUGFIX: this fixes a chrome bug... I would laugh if I wasn't already
crying.
2014-02-27 16:56:03 -05:00
Régis Hanol e5a4dc6eac FEATURE: add a banner when read-only mode is enabled 2014-02-27 19:50:20 +01:00
Robin Ward fee9870427 FIX: New counts were taking into account muted categories 2014-02-27 12:35:33 -05:00
Régis Hanol 70ca6171d1 BUGFIX: fix math & unit when checking disk space 2014-02-27 16:55:12 +01:00
Nick Borromeo 09a2d9e12c Use symbols instead of strings in order clause
This simply changes the strings in the order clauses in the model. The
reason of the change is because the SQL generated when using symbols
automatically name spaces the column with the table name.

Topic.order(:title).to_sql
=> SELECT "topics".* FROM "topics" ORDER BY "topics"."title" ASC

This also changes the scopes using lamba to use stabby lambas for
consistency with other scopes.
2014-02-26 22:43:03 -08:00
Sam 1992271bf9 FEATURE: white_listed_spam_host_domains for domains that are not blocked for spam
BUGFIX: bypass host spam detection for current host
2014-02-27 15:43:57 +11:00
Kris Aubuchon adde163447 fixing width of poster section of topic-list 2014-02-26 22:23:48 -05:00
Kris Aubuchon 190f075fae small logos should always be proportionate 2014-02-26 22:00:22 -05:00
Sam 1b0c567729 OOPS 2014-02-27 12:43:44 +11:00
Sam a4d7942dbd BUGFIX: Don't blow up on junk referers 2014-02-27 12:03:38 +11:00
Sam 9551f4aeea PERF: calculate scores for topics/posts faster
Only look at topics that changed in last day for 15 minuted schedule
Do a full recalc weekly, just in case
2014-02-27 11:45:40 +11:00
Sam e4909c017c PERF: only rebuild entire top topic table daily 2014-02-27 11:45:40 +11:00
Jeff Atwood cceed615a3 make sure onebox h3,h4 suppress topmargin 2014-02-26 16:13:36 -08:00
Neil Lalonde d15d5e2525 Also put the envelope glyph beside topic title edit form for private messages 2014-02-26 18:01:59 -05:00
Neil Lalonde 7322345039 FIX: when shown 403 error page and logging in, it will take you to the same page 2014-02-26 17:53:53 -05:00
Jeff Atwood 534dadf1be Merge pull request #2016 from awesomerobot/master
removing background gap on topic closures
2014-02-26 14:37:26 -08:00
Kris Aubuchon 1f8fa09846 removing background gap on topic closures 2014-02-26 17:34:15 -05:00
Jeff Atwood 78188cd713 Merge pull request #2015 from awesomerobot/master
small design tweaks
2014-02-26 14:22:32 -08:00
Kris Aubuchon 9e4181dbe5 small design tweaks 2014-02-26 17:15:57 -05:00
Régis Hanol 9571eb07a4 BUGFIX: you should not be able to edit the category on a PM 2014-02-26 22:45:19 +01:00
Robin Ward 9267c162a1 FIX: Showing Unread(1) when you weren't tracking the topic. Also
includes performance fix when having MANY new or unread topics.
2014-02-26 15:39:45 -05:00
Neil Lalonde ed201b1b5b FIX: on mobile, don't scroll background when showing a modal. iOS goes bananas. Thanks shobhit007 2014-02-26 13:46:15 -05:00
Neil Lalonde 1165aa2dae Don't show description text on Create Category modal 2014-02-26 13:45:01 -05:00
Régis Hanol 043901ef46 FEATURE: warn the user when there is not enough space on disk to upload a backup 2014-02-26 19:38:06 +01:00
Régis Hanol c6bc324259 CLEANUP: remove unused pseudo locale 2014-02-26 19:03:04 +01:00
Neil Lalonde 8167cefe36 Add envelope glyph to private message topic titles 2014-02-26 12:24:21 -05:00
Robin Ward cae7af4b07 BUGFIX: Do not scroll to top / show spinner when leaving a topic. 2014-02-26 12:04:55 -05:00
Robin Ward c668d49822 REFACTOR: Use the `ScrollTop` mixin instead of custom scrolling code. 2014-02-26 11:54:15 -05:00
Sam 50a8d3caae BUGFIX: sso to send welcome emails 2014-02-26 10:28:03 +11:00
Sam 74a1145a0b BUGFIX: sso to respect must_approve_users 2014-02-26 10:27:39 +11:00
Sam 440435f023 FEATURE: SSO to handle return_path automatically 2014-02-26 09:58:30 +11:00
Neil Lalonde 8cbff3672f Fixes on mobile signup form 2014-02-25 16:40:30 -05:00
Neil Lalonde 0b1d1ffcba FIX: problems with mobile login modal 2014-02-25 16:40:30 -05:00
Robin Ward 4e1a628ff9 Hooks for extra nav items. 2014-02-25 16:02:27 -05:00
Robin Ward d079538a6d Allow the `customHTML` helper to look up fragments outside of the
preloadStore, so plugins can stuff HTML in there when overriding a whole
template doesn't make sense.
2014-02-25 16:02:27 -05:00
Robin Ward 8a96f1a7b6 FIX: Margin in onebox 2014-02-25 14:50:21 -05:00
Jeff Atwood 0e6325d172 unnecessary CSS suppression of li paras 2014-02-25 10:28:48 -08:00
Neil Lalonde b15e771d67 Oops, I meant 1 2014-02-25 12:19:22 -05:00
Neil Lalonde 7288bf1f31 Add previous page link for crawlers 2014-02-25 12:15:48 -05:00
Robin Ward 9ebcdfba1f Merge pull request #2005 from eriko/plugin_store_delete
clean up plugin store when removing data instead of setting the value to...
2014-02-25 11:36:05 -05:00
Erik Ordway dfa6960799 clean up plugin store when removing data instead of setting the value to nil and do it a reasonable way. 2014-02-25 08:26:35 -08:00
Neil Lalonde 8134113b22 Add rel=next to next page link for crawlers 2014-02-25 10:18:07 -05:00
Jeff Atwood d0f5e1f53e Merge pull request #2006 from awesomerobot/master
adding word-wrap: break-word back to usernames, fixing onebox bg in quotes
2014-02-24 20:07:59 -08:00
Kris Aubuchon 8f6ab4fb85 adding word-wrap: break-word back to usernames, fixing onebog bg in quotes 2014-02-24 22:36:30 -05:00
Sam 6f31d3f0e5 FEATURE: single sign on support
Added support for outsourcing auth to a different website, documentation on meta
2014-02-25 14:31:03 +11:00
Erik Ordway db411860c2 clean up plugin store when removing data instead of setting the value to nil. 2014-02-24 16:11:31 -08:00
Neil Lalonde 46d1c8c1e0 FIX: n+1 queries in CategoryList 2014-02-24 15:07:46 -05:00
Robin Ward 4cd5ccdf1f BUGFIX: Don't return child categories if you can't see the parent
category.
2014-02-24 14:52:41 -05:00
Robin Ward 3151f59bc9 REFACTOR: We don't cache the json for the Site model anymore, so let's
rename and remove the methods leftover from that.
2014-02-24 14:25:37 -05:00
Wojciech Zawistowski 227c0af20b Removes unnecessary instance vars. 2014-02-24 18:03:29 +01:00
Benjamin Kampmann 1e609aac77 Fix: apply excludes for user aliases in user selection view
- fixes a missing reassignment to the new named variable causing the selection of group aliases to fail in the user selector view of private messages
 - apply the list of excludes when a user selects a group alias to prevent double selection of users already in the list and selection of oneself
2014-02-24 10:35:47 +01:00
Kris Aubuchon 6b050825ff revising color variables appwide, also some adjustments to "topic not found" page 2014-02-23 20:47:44 -05:00
Jeff Atwood 142e39f5f3 we need a bit more top-margin on h1,h2,h3 2014-02-23 00:22:11 -08:00
Robin Ward 27d3fae4df BUGFIX: Typo was causing dismiss read to use id = 0 instead of id = 1 2014-02-21 21:14:07 -05:00
Régis Hanol 68a935c36b FEATURE: upload backups 2014-02-22 01:41:01 +01:00
Robin Ward 23066edbe1 FIX: undefined method error for some digests. 2014-02-21 16:25:19 -05:00
Robin Ward b21949c7cb FIX: Amazon favicon was missing 2014-02-21 16:10:20 -05:00
Robin Ward 80176cb4cf TRIVIAL: Move button to the bottom of the topic list 2014-02-21 15:59:28 -05:00
Robin Ward 1aa27ade17 FEATURE: If you don't select any topics to "Dissmiss Read" it does all
by filter.
2014-02-21 15:18:45 -05:00
Robin Ward a07e9f7e71 FEATURE: Bulk `reset read` status. 2014-02-21 15:18:45 -05:00
Robin Ward 7a07f14dfc FEATURE: Can select topics and hit `Dismiss Read` on the `/unread` filter 2014-02-21 15:18:45 -05:00
Neil Lalonde 5fd390c600 FIX: nuke spammer from flags page 2014-02-21 14:14:30 -05:00
Neil Lalonde 9545e2e46e FIX: broken 404 page. don't bother showing current_usre stuff 2014-02-21 12:24:45 -05:00
Wojciech Zawistowski ed311eb65a PostsController refactoring. 2014-02-21 17:12:43 +01:00
Sam Saffron 451598c511 BUGFIX: regresses correct job execution 2014-02-21 16:05:19 +11:00
Sam Saffron 9a3af8997b BUGFIX: handle partial job failure in multisite
log all failures
2014-02-21 15:31:15 +11:00
Robin Ward d95887c57d CHANGE: We now include the `_escaped_fragment_` support by default, but
only if the crawler check fails. It is a fallback for non-google search
engines that support the Ajax crawling API.
2014-02-20 17:02:26 -05:00
Robin Ward c4b5455c21 REFACTOR: Rename `GooglebotDetection` to `CrawlerDetection` because we
will likely whitelist more crawlers in the future.
2014-02-20 16:07:02 -05:00
Robin Ward b8448b6e39 Merge pull request #1982 from velesin/posts_controller_replies_tests
Adds tests for PostsController#replies.
2014-02-20 13:36:31 -05:00
Neil Lalonde b696c96a19 Look at the age of a user's first post to determine if the user can be nuked, instead of looking at when the user registered. 2014-02-20 12:29:40 -05:00
Wojciech Zawistowski cfbeba84d2 Adds tests for PostsController#replies. 2014-02-20 17:38:13 +01:00
Robin Ward a57ecef253 BUGFIX: Do not allow `font` tags. 2014-02-20 11:10:56 -05:00
Robin Ward 2d398903c0 Allow jump to top on post 2 or 3. 2014-02-19 14:23:43 -05:00
Robin Ward 0c45cf1ee7 FIX: Allow closing the category dropdown when clicking on the same
category
2014-02-19 14:17:38 -05:00
Robin Ward 634b769cda Merge pull request #1903 from vikhyat/poll-plugin
Add poll plugin
2014-02-19 13:15:43 -05:00
Robin Ward 40585637fe Merge pull request #1948 from riking/patch-3
Removing more stuff from the sanitizer whitelist
2014-02-19 12:30:56 -05:00
Robin Ward d56b1b1c74 Merge pull request #1975 from orend/simplify_topic_posters_summary
simplify TopicPostersSummary
2014-02-19 12:30:10 -05:00
Régis Hanol d443ddd43d Merge pull request #1922 from joallard/language-toggle
Allow users to toggle interface language in their preferences
2014-02-19 18:28:00 +01:00
Robin Ward ef18e415cf Merge pull request #1978 from velesin/posts_controller__by_number_tests
Adds specs for PostsController#by_number.
2014-02-19 12:26:57 -05:00
Régis Hanol a682c8fc91 BUGFIX: do not push read-only signal to ALL sites 2014-02-19 18:21:41 +01:00
Wojciech Zawistowski 5e8db5ce14 Adds specs for PostsController#by_number. 2014-02-19 17:41:17 +01:00
Oren Dobzinski d0fbabeb0b simplify TopicPostersSummary 2014-02-18 23:53:30 -05:00
Kane York 9f8f0f115c Restore 'article' to whitelist 2014-02-18 16:22:42 -08:00
Neil Lalonde 7f6b2e5563 Show login button on 404 page. Add routes to show login and signup modals when page/route loads. If logged in and showing 404 page, load ember app. 2014-02-18 17:18:53 -05:00
Robin Ward 18e98851e3 Use lower case group names in URLs 2014-02-18 16:43:19 -05:00
Sam 43612e9fde Merge pull request #1971 from velesin/posts_controller_refactoring
Refactors PostsController and adds unit tests.
2014-02-19 08:34:40 +11:00
Sam 3eec3136d5 Merge pull request #1972 from verg/user_pref_save_btn
Add Save button to top of user preferences
2014-02-19 08:30:17 +11:00
Robin Ward f19b0b5fe0 Include members count on groups page. 2014-02-18 16:17:04 -05:00
Neil Lalonde 997a7c676e If flagging a topic with only one post, flag the post instead 2014-02-18 15:18:31 -05:00
Jonathan Allard 0592420e52 Add a site setting to allow users to toggle I18n.locale
It is false by default.
2014-02-18 14:54:00 -05:00
Jonathan Allard c513725f26 Allow users to toggle interface language in their preferences 2014-02-18 14:53:59 -05:00
Robin Ward 3f3c07f136 FEATURE: Can bulk update the notification level of topics 2014-02-18 13:02:22 -05:00
Neil Lalonde d0ecccb7e4 Translate asterisks in ip addresses to mask format so people can enter things like 127.*.*.* in screened ip addresses form 2014-02-18 13:00:55 -05:00
verg d087783fe8 Add Save button to top of user preferences 2014-02-18 12:51:37 -05:00
Régis Hanol 74f1db11e9 remove useless binding 2014-02-18 18:23:28 +01:00
Régis Hanol 30ccdf3fb7 BUGFIX: calling _super() won't actually set the model to the controller
cf.
351719f7c1 (commitcomment-5410366)
for more information
2014-02-18 18:21:35 +01:00
Wojciech Zawistowski 5b9a4d3581 Refactors PostsController and adds unit tests. 2014-02-18 17:19:38 +01:00
Neil Lalonde 6c23a1903e FIX: show ip address with mask again on /admin/logs/screened_ip_addresses 2014-02-18 10:33:08 -05:00
Sam 884346cbea Merge pull request #1951 from thoughtbot/bb-erb
Use ERB to pull conf files into app
2014-02-18 16:23:55 +11:00
Sam 887e835a9b Merge pull request #1969 from riking/scroll-position
Put requested post in middle of page
2014-02-18 16:17:26 +11:00
Sam 983c7567aa BUGFIX: seen recently key needs to be public so mock can easily reach in to it 2014-02-18 16:09:24 +11:00
riking 19922ff174 Have keyboard_shortcuts use Discourse.TopicView.jumpToPost
Instead of _scrollList, which is more appropriate on the topic list.
2014-02-17 16:45:36 -08:00
riking ebb001c24a When entering a topic, place the desired post in the middle of the page 2014-02-17 16:38:01 -08:00
Sam 6360868341 Merge pull request #1968 from stephankaag/drop_rails3
Drop Rails3 support
2014-02-18 10:50:36 +11:00