e074651fdc
PERF: refactor user search so works more efficiently
...
Stop scanning entire user table
2015-05-14 14:38:47 +10:00
e6f73a1c80
PERF: optimise front page category security lookup query
2015-05-14 12:19:22 +10:00
5fdbc6c4b2
FIX: Replies to PMs should never been enqueued
2015-05-13 12:08:53 -04:00
bb29bff5d8
Merge pull request #3463 from techAPJ/patch-2
...
FIX: match subdomain with email domain blacklist
2015-05-13 17:56:54 +02:00
220b9c5abe
FIX: match subdomain with email domain blacklist
2015-05-13 21:02:02 +05:30
d90e0fe66b
Merge pull request #3460 from techAPJ/patch-3
...
FIX: rate limit topic invitations
2015-05-13 12:55:20 +02:00
4324a157e0
FIX: rate limit topic invitations
2015-05-13 14:44:37 +05:30
4c00eef8b5
FIX: category custom slug can't be set when generation method is none
2015-05-13 16:54:19 +08:00
51d82fc25d
PERF: Active Record #pluck is twice faster
...
PERF: SqlBuilder bypasses AR converters and uses PG directly
2015-05-13 16:46:17 +10:00
406c8bb340
PERF: don't recompile css files that have already been compiled
2015-05-12 16:12:49 -04:00
5ef641126f
remove s3 deprecation warning, we will continue to support it
2015-05-12 08:27:25 +10:00
0b65c88003
Upgrade Notifications to fix deprecations and use store
2015-05-11 11:20:45 -04:00
9f9825bb6b
FIX: don't send emails to anonymous users
...
Also changes behaviour of real to not return anonymous users.
This means user counts will no longer include them, and the
mailing list system will ignore them even if they somehow end up
with the feature turned on.
2015-05-11 00:56:34 +01:00
124ae8ada6
correct spec
2015-05-06 12:01:47 +10:00
0f53fc8328
correct emergency regeneration in the controller
2015-05-06 07:33:32 +10:00
a48dd1cc28
store the slug as the title is, only sanitize the slug
...
and prettify code
2015-05-05 18:33:16 +08:00
b772ff6e13
FEATURE: add slug geneartion options
2015-05-05 18:08:30 +08:00
f58d85edea
FEATURE: move stylesheet cache out of the uploads directory
2015-05-05 15:50:13 +10:00
963ebf5963
FIX: if approving a user when must_approve_users is false, don't send an email
2015-05-04 15:30:25 -04:00
7e3eaf5b02
FIX: Never enqueue private messages
2015-05-04 11:07:46 -04:00
d9ec6888e1
FIX: allow site_name to be present in rejection email subject
2015-05-04 11:22:54 +05:30
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
f9069c350f
FIX: Permission issues when editing topics
...
If a user can't create a topic in a category, they should'be be
able to edit topics.
2015-04-30 17:08:12 -04:00
16408cee06
Allow Postgres to trigger readonly mode for the site.
2015-04-29 11:49:58 -04:00
439d0d2e37
Check Rails.version instead of ENV
...
Like that we can have code that works on multiple Rails versions, and we
dont need to mix a new method on Kernel.
Also, this makes easier to have multiple versions.
For instance, before master was 4.2, which is not the case anymore, so
on the code we should check versions and not Environment variables
2015-04-28 22:27:47 -04:00
cf0c2d09d4
Handlers can be added with a priority
2015-04-28 15:06:47 -04:00
6a338afbdd
Merge pull request #3403 from zzakcanncode/rspec_up
...
Rspec 3
2015-04-28 07:50:30 +10:00
729aaa826b
Merge pull request #3404 from techAPJ/patch-1
...
FEATURE: magic login route for admin when SSO is enabled
2015-04-28 07:47:50 +10:00
2932284293
FEATURE: magic login route for admin when SSO is enabled
2015-04-27 22:54:48 +05:30
de42c627c5
Allow plugins to specify a minimum `requires version`
2015-04-27 13:07:12 -04:00
8f0fb511c3
Fix warnings for rspec 3
2015-04-25 21:02:06 -04:00
e0ea68b9ca
Fix tests on site_setting for new rspec
2015-04-25 11:33:26 -04:00
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
151b559e4c
FIX: If you delete a user, delete their queued posts as well.
2015-04-24 16:04:44 -04:00
15dbce5886
Show pending posts count in modal when your posts are enqueued
2015-04-24 15:44:59 -04:00
3660fe4f60
FIX: When approving/rejecting a post it should delete the user action
2015-04-24 15:25:47 -04:00
3a6efa25f0
Allow ReadOnly to propogate up to the Ember app via Response Header
2015-04-24 14:37:16 -04:00
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
923c164d54
workaround: pg app installs a poorly encoded db, so skip CI will catch
2015-04-24 07:23:02 +10:00
a737090442
- FEATURE: revamped poll plugin
...
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
2ee033caa5
FIX: validate integer site setting
2015-04-23 18:15:14 +05:30
85320f919b
FEATURE: user list csv includes approved, suspended_at, suspended_till, blocked
2015-04-22 12:40:12 -04:00
5bf8c31af4
Users can see their pending posts
2015-04-21 16:44:47 -04:00
26693c16ac
Don't show the link to "Needs Approval" unless approval is enabled.
...
Note that any plugin that extends the NewPostMananger to support
enqueuing will enable it.
2015-04-21 13:59:57 -04:00
f600ead587
FIX: Don't validate approved posts.
...
A moderator has already validated them. Otherwise we hit things like
rate limits.
2015-04-21 11:59:35 -04:00
2cdd967188
Adds support for invisible approval queues, which we'll need for Akismet
2015-04-20 17:19:05 -04:00
5990ab855b
PERF: Move post alerting into async
2015-04-20 13:34:57 -04:00
296add56e6
correct letter avatar template
2015-04-20 13:07:12 +10:00
9fbc763902
Replace Hash#keys.each with Hash#each_key for some perf boost
2015-04-18 21:53:53 +10:00
51b747346e
PREF: speed up grabbing unread counts
2015-04-17 16:01:20 +10:00
832cb9fdc3
FIX: admin check missing from topic tracking state
...
FIX: handle muted categories correctly
2015-04-17 14:03:08 +10:00
2459f52c71
Merge pull request #3375 from techAPJ/patch-2
...
FEATURE: invite existing users to private topic
2015-04-16 11:13:42 -04:00
94fea09416
Merge pull request #3383 from techAPJ/patch-4
...
FIX: handle error for duplicate email_in address
2015-04-16 11:13:36 -04:00
866d1cd8e3
FIX: handle error for duplicate email_in address
2015-04-16 16:23:22 +05:30
4387e05162
PERF: speed up query
2015-04-16 17:29:37 +10:00
a5b25ad2af
FEATURE: scale up likes per day as users increase trust level
...
tl2 = 1.5 times the likes
tl3 = 2 times the likes
tl4 = 3 times the likes
configurable via tl[234]_additional_likes_per_day_multiplier site setting
2015-04-16 09:44:30 +10:00
d2ed64751e
UX: Show category badge on enqueued posts
2015-04-15 15:29:37 -04:00
d491d4f997
FEATURE: invite existing users to private topic
2015-04-16 00:52:54 +05:30
9ffec28076
Allow posts in any queue to support topic/post attributes
2015-04-15 14:54:37 -04:00
af1571a58f
Site Settings for post approval
2015-04-15 14:54:37 -04:00
0c233e4e25
Interface is wired up for Approving/Rejecting posts
2015-04-15 14:54:37 -04:00
96d2c5069b
Interface for reviewing queued posts
2015-04-15 14:54:37 -04:00
f1ede42569
Add the posts that need to be reviewed to the hamburger
2015-04-15 14:54:37 -04:00
19a9a8b408
`NewPostManager` determines whether to queue a post or not
2015-04-15 14:54:36 -04:00
a5ee45ccbe
`PostEnqueuer` object to handle validation of enqueued posts
2015-04-15 14:54:36 -04:00
8ba6a45cd7
Post Queue model to enqueue creation of posts
2015-04-15 14:54:35 -04:00
499bed69e2
FIX: show error message if user already exist in group
2015-04-15 14:15:58 +05:30
2a3f71a9a1
SECURITY: log off all existing sessions when resetting password
2015-04-15 08:57:43 +10:00
869d8e25ad
Promotion fails if the user account isn't old enough yet.
2015-04-14 12:14:59 -04:00
eaf5d21c41
Don't store post timings that are greater than the account lifetime
2015-04-14 11:49:44 -04:00
c3b461f58d
Add blank alt attribute to avatars.
...
This was giving an ugly border to avatars in the user card as the full size version loaded in Firefox.
2015-04-14 14:39:40 +01:00
db4c04d606
FIX: Moderators shouldn't be able to see secure deleted posts
2015-04-13 11:48:31 -04:00
5650428052
FIX: Sort page views report records
...
Adding a sort ascending by date to the page views report.
2015-04-12 10:46:13 -07:00
e6df97f01d
FIX: add email reply error message for topic not getting created in restricted category
2015-04-10 17:11:52 +05:30
75890aed26
FEATURE: allow admins to choose a group as a primary group
...
FEATURE: allow admins to set a default title for a group
2015-04-10 12:17:28 +10:00
4bfca12b11
FEATURE: anonymous_account_duration_minutes , cycle anon accounts after N minutes from last post
...
fixes it so anon users can not like stuff
2015-04-08 12:30:02 +10:00
f5d89169e2
FEATURE: initial implemenation of anonymous posting mode
2015-04-07 18:05:31 +10:00
5d31290dbc
FIX: cleanup old letter avatars if needed
...
FEATURE: use image magick version as a key for letter avatars
2015-04-07 13:03:43 +10:00
1a3fa52cde
fix broken build (cc @riking)
2015-04-06 12:12:27 +02:00
c6a5081763
FEATURE: reorder participants in topic so always chronological
...
FEATURE: tie breaker for same number of posts is last post date
UX: highlight for latest poster when it is OP
2015-04-06 17:27:05 +10:00
0e1c4a0a44
Merge pull request #3313 from techAPJ/patch-1
...
FEATURE: invite existing user to a topic
2015-04-03 11:41:10 +02:00
8c2d7dcaac
FEATURE: invite existing user to a topic
2015-04-03 15:00:04 +05:30
30b063c08b
FEATURE: make full names a required field of user profiles with the full_name_required setting
2015-04-02 17:08:04 -04:00
682656fa6c
FIX: only redirect to whitelisted hostnames
2015-04-01 22:59:25 +02:00
0f4a4651a9
FIX: youtube preview video title link doesn't work
2015-04-01 18:23:27 +02:00
eec1921ba9
FIX: notifications inconsistencies + never notify system user
2015-04-01 11:55:59 +02:00
14741b5dac
FIX: only ONE user on site could have a list of muted users
2015-03-31 10:16:23 +11:00
28864e74bc
FIX: Don't show the filter title on the default route
2015-03-30 11:40:44 -04:00
48c58601a6
fix spec
2015-03-27 13:14:50 +11:00
58c95f64d2
FIX: stop stripping zero-width-whitespace
...
This char is used for formatting khmer words
2015-03-27 13:03:24 +11:00
05737effef
FIX: stop stripping dots from SSO names
...
This could upset Louis C.K.
2015-03-27 10:25:51 +11:00
0c287d7d6b
ensure usernames do not keep cycling
2015-03-27 10:04:16 +11:00
94fceaf517
Remove non-legit test, we should always change attributes even if external is unchanged
...
Overriding should be all or nothing
2015-03-27 09:57:43 +11:00
4566a1e30a
FIX: sso override code not triggered when attaching to existing user
2015-03-27 09:39:35 +11:00
2cc5858163
Add site setting to disable User Directory, include restricted info
2015-03-26 11:26:19 -04:00
5aa1272f05
clean up first day user definition and object model
2015-03-26 16:48:36 +11:00
9834d11503
Staff and TL2 up are immune to newuser checks and not considered new users
2015-03-26 16:04:46 +11:00
cfa511e35d
FIX: correctly mute likers
...
FEATURE: disallow all muting of staff
2015-03-26 12:08:04 +11:00
fb0e7dc0b2
FIX: do not delete already redeemed invite
2015-03-25 23:30:09 +05:30
90de61ee3d
S3 deprecation warning
2015-03-25 18:34:07 +01:00
2b46b52b64
Merge pull request #3296 from techAPJ/patch-1
...
FIX: delete duplicate invites
2015-03-25 13:25:05 -04:00
4862a93804
FIX: delete duplicate invites
2015-03-25 22:43:41 +05:30
33e35930b0
FIX: Server error when no results on user directory while logged in
2015-03-25 11:18:46 -04:00
92e371f0b3
FEATURE: civilized mute
...
Allow user to mute all notifications generated by specific users
2015-03-24 11:55:22 +11:00
ff3e1e1dd7
FIX: User's topic lists weren't consistent WRT visibility
2015-03-23 18:13:06 -04:00
1601211617
Revert "FEATURE: allow end users to opt out of getting any private messages"
...
This reverts commit 229ecc4f8a
2015-03-23 17:21:58 +11:00
229ecc4f8a
FEATURE: allow end users to opt out of getting any private messages
2015-03-23 15:50:45 +11:00
853c91d7d0
Merge pull request #3289 from fullfatthings/suppress_sso_welcome_emails
...
Add an sso option to suppress welcome emails
2015-03-23 10:36:58 +11:00
6d38005a22
Allow staff to change uneditable user fields
2015-03-20 15:18:43 -04:00
3c0fee1786
Fixes broken spec
2015-03-20 13:24:03 -04:00
e8648350eb
Add an sso option to suppress welcome emails
...
As discussed here: https://meta.discourse.org/t/create-new-sso-users-without-sending-welcome-emails/24894
2015-03-20 17:04:52 +00:00
5084e2bdf1
Merge pull request #3284 from techAPJ/patch-1
...
FEATURE: new site setting min_first_post_length
2015-03-19 19:55:27 +01:00
b706307ac7
FEATURE: new site setting min_first_post_length
2015-03-20 00:20:38 +05:30
7ef306cd3b
A bunch of tweaks to the Users directory
...
- Move user directory from `/directory` to `/users/`
- Defaults to 'weekly' time period
- Don't include deleted topics/posts in the results
- Move heart icon to header instead of on each row
- "Users" instead of "Users found"
2015-03-19 12:29:38 -04:00
3d2d224312
FEATURE: User Directory, with sorting and time period filter
2015-03-18 15:20:34 -04:00
89ea125c73
automatic need only be added once to the hash
2015-03-18 17:47:39 +11:00
4720d0c12b
Merge pull request #3277 from techAPJ/patch-1
...
FIX: return proper error message when replying to a closed or deleted topic
2015-03-17 07:38:00 +11:00
5d74cadf2f
FIX: picture would be hidden when [details] block was closed in the composer
2015-03-16 18:57:15 +01:00
484ae8b6b7
FIX: return proper error message when replying to a closed or deleted topic
2015-03-16 16:43:22 +05:30
df7c38dd51
FIX: don't add an automated message when *a* moderator already replied (as opposed to *the* moderator)
2015-03-16 12:02:34 +01:00
3a40875e0b
Merge pull request #3247 from jmay/group-manager-invites
...
group manager can issue invitations from restricted topics
2015-03-16 09:53:04 +01:00
a82530012a
FEATURE: Allow selection of highlight js languages
...
PERF: stop loading highlight js on load
To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00
12d59d13a7
stop randomly failing here
2015-03-12 13:44:13 +11:00
2585962552
fix spec that can fail when comparing timestamps. I only care that it isn't null.
2015-03-11 16:51:29 -04:00
dece5a351a
more fixes for post ownership change and user deletion
2015-03-11 15:54:20 -04:00
afd2417945
FEATURE: new 'auto_respond_to_flag_actions' site setting
2015-03-11 19:29:09 +01:00
c8631a7a8b
FIX: auto-message shouldn't generate notifications
2015-03-11 19:07:17 +01:00
6cd4330335
FIX: show all deleted posts
2015-03-11 18:07:47 +01:00
608647d02f
FEATURE: Anonymize User. A way to remove a user but keep their topics and posts.
2015-03-10 11:59:08 -04:00
ff063f4f9b
play around with mock_redis, add comment explaining what happened
2015-03-09 13:14:29 +11:00
79a17d5c22
FIX: discourse.conf not parsing out comments correctly
2015-03-09 13:14:29 +11:00
a26853c1a4
try to work around caching bug in spec
2015-03-05 17:47:34 +11:00
c4fa75918b
FIX: If a category of a topic changed, watching/tracking didn't kick in
2015-03-04 13:39:50 -05:00
0f36774246
group manager can invite members into the group from any restricted topic
2015-03-03 12:18:42 -08:00
35c58c1b00
FIX: after changing post owner, profile pages still showed previous owner and incorrect topic and post counts
2015-03-03 14:15:11 -05:00
f432b9f5b7
correct spec failure, only test code was affected
2015-03-03 10:21:01 +11:00
474c947427
temporarily disable test while debugging
2015-03-03 09:51:10 +11:00
336c15672a
clear cache to fix spec
2015-03-03 08:27:27 +11:00
7c14db44cc
UX: improve message when admin login is blocked because of admin ip address whitelisting
2015-03-02 12:13:22 -05:00
1bf4f34049
FIX: topic and post counts are not updated when ownership of a post is changed
2015-03-02 12:13:21 -05:00
37fefc16de
workaround, something about report spec is messed up
2015-03-02 12:29:56 +11:00
c04b214910
FEATURE: don't allow username and email to be the same
2015-02-27 13:47:43 -05:00
0742f340f9
FEATURE: allow for a localized error when a regex fails in site settings
...
FEATURE: apply string validation to list site settings (so we get regex)
2015-02-27 11:45:56 +11:00
ea40dd08e6
correct tests
2015-02-27 09:41:08 +11:00
7d8dd9d93b
fix some rspec deprecations
2015-02-26 13:05:20 +01:00
83f719fb80
FIX: Cleaned the commit
...
Only changing the code I changed, not other tests.
2015-02-26 01:24:21 +00:00
73068d5fa3
ADD: Spec tests for User Badge triggers
...
NOTE: The DiscourseEvent trigger mechanism is VERY weird.
If there are ANY triggers triggered in the chain, you can't only list the one you're looking for, you have to list all triggers in the order they will come.
Example: line 98-100
:user_created and :user_verified are triggers that are introduced in PR #3237 so if this PR is accepted but not PR #3237 then lines 98-99 need to be removed.
2015-02-26 00:55:17 +00:00
cbe18eb0df
FEATURE: allow view exclusion using custom header
...
Set Discourse-Track-View to either "0" or "false" to exclude request
2015-02-26 11:41:11 +11:00
3e2ba5b30b
FIX: If an IP is blocked, don't allow people to login using it
2015-02-25 16:02:40 -05:00
1a070b16e4
FIX: use the 'post edit time limit' for topics too
2015-02-25 20:53:21 +01:00
005b8bf7c3
FIX: When creating a SSO user via sync, do not user the IP address.
2015-02-25 14:41:23 -05:00
cf81b3f86d
FEATURE: don't allow username and password to be the same
2015-02-25 12:00:13 -05:00
1c545d4c1e
Allow adding and removing members of groups by username or id
...
As discussed here: https://meta.discourse.org/t/discourse-gem-group-add/25668/2 .
2015-02-25 14:52:13 +00:00
9ca61efa97
correct test
2015-02-25 18:09:45 +11:00
b760d22460
PERF: avoid expensive order by random for suggested topics
2015-02-25 17:19:12 +11:00
7b6e85cb6c
remove unused api call
...
correct spec
2015-02-25 14:39:50 +11:00
3658c21fc5
REGRESSION: incorrect ordering when featuring topics
2015-02-25 14:24:25 +11:00
fe578f9944
FEATURE: Allow manual assignment of related post to badge
...
PERF: clean up performance of user badges admin when large number of badges exist
2015-02-25 12:53:01 +11:00
34dc1f9e10
Spec to ensure that SSO respects blocked emails
2015-02-23 17:14:54 -05:00
ca5730018a
FIX: SSO code should respect IP address filters
2015-02-23 16:01:46 -05:00
8186d86f38
FIX: Enforce max length for custom user fields
2015-02-23 13:02:30 -05:00
6960639c58
Merge pull request #3190 from riking/thrown_logging
...
Delete old ErrorLog, use Logster for 500 errors
2015-02-23 14:19:16 +11:00
20c9a312c7
FIX: clicks counter on attachments wasn't always working
2015-02-22 20:47:18 +01:00
17927b2e8b
FIX: don't use flash cause we are not redirecting
...
(we should probably change that though)
2015-02-20 10:28:58 +11:00
e74b9ee5da
FIX: should not count disagreed flags
2015-02-19 18:11:07 +01:00
103d42a9d9
FIX: emoji cache could get corrupt
...
FEATURE: enforce 1 day expiry by default on discourse cache
remove family expiry concept as the implementation was fragile
2015-02-19 16:58:22 +11:00
709ab731c7
don't put missing notifications in the stream for tests.
2015-02-19 13:20:25 +11:00
451788b95d
FIX: allow searching in PMs when "search this topic" is selected
2015-02-19 12:56:49 +11:00
b041b3f67f
FIX: bookmark topic was not working intuitively
...
- explicitly call out "clear bookmarks"
- correct keyboard shortcuts
- properly remove bookmarks when toggeling
2015-02-19 10:58:57 +11:00
f3daae6dec
Improve auto generated email reply error message
2015-02-18 18:58:51 +05:30
395654bf24
Fix regression on editing private messages
...
v1.2.0beta9 has introduced a regression in edit of a private topic
(first post). Previously a check for no change in TopicsController was
made but it has been changed without considering that the topic could
be private.
By simply forcing a conversion of `topic.category_id` to integer, the case
where its value is nil is handled correctly as it was previously.
2015-02-18 00:41:16 +01:00
6e5540c107
FIX: do not show name in email if name on posts are disabled
2015-02-18 01:39:41 +05:30
cdef67667a
PERF: allow background jobs to flush between requests in same thread
2015-02-17 09:58:43 +11:00
3cad4824d7
FEATURE: allow moderators to see flagged private messages
2015-02-16 13:03:04 +01:00
0b45054e2b
FIX: couldn't uncategorize a topic
2015-02-16 10:31:36 +01:00
3ce2077aa8
Migrate unsubscribe keys to the database.
...
This should reduce a lot of the keys in redis.
2015-02-13 14:24:15 -05:00
e207ca36ee
Easier helper for filtering secured categories
2015-02-12 11:52:59 -05:00
276fd702e8
missed a send which caused code to break
2015-02-12 15:01:14 +11:00
c4e427cf73
FEATURE: filter screened IP addresses
2015-02-10 19:38:59 +01:00
8d46de4819
Add a spec for the new plugins controller
2015-02-10 12:35:53 -05:00
acda6ebd60
FIX: view tracking needs to release data earlier
...
retaining data during queuing was causing huge memory spikes
2015-02-10 17:03:33 +11:00
68ccd2d664
FEATURE: All 500 errors now show up in Logster
...
Added Discourse.handle_request_exception()
2015-02-09 12:48:33 -08:00
5657006aca
Rename handle_exception to handle_job_exception
2015-02-09 12:47:46 -08:00
e36272cb68
fix the build
2015-02-09 17:13:22 +01:00
e8323fa534
FIX: removing a group from a user was not removing primary group
2015-02-09 16:03:09 +11:00
7dea65122e
Support a `url` field in plugin metadata
2015-02-06 18:08:57 -05:00
f7d2fc0524
FEATURE: 'reply by email address' validator
...
Prevent infinite email loophole when the 'reply_by_email_address' site setting is the same as the 'notification_email'.
2015-02-06 12:08:37 +01:00
820ce8765e
refactor traffic report
...
split traffic report in 2, page view vs raw traffic
hide raw traffic report by default
improve flushing logic for application reqs
2015-02-06 14:39:16 +11:00
4e64d16a47
FEATURE: Allow plugins to log staff actions
2015-02-05 15:26:34 -05:00
2fcd199f48
FIX: send a PM to moderators when a post has been flagged as sockpuppet
2015-02-05 19:58:49 +01:00
f1403206ca
Merge pull request #3169 from riking/patch-3
...
SECURITY: Don't leak topic title in the redirect
2015-02-05 12:47:58 +01:00
08b790b3c2
improve metrics gathered using in our traffic section
...
this also pulls out the middleware into its own home and inserts in front
2015-02-05 16:08:52 +11:00
eb7a5c251d
freeze time in report spec so it has consistent results
2015-02-05 11:33:13 +11:00
3b68214210
FIX: Clean up after adding events. Fixes random test failures.
2015-02-04 17:33:18 -05:00
25daca8f23
Helpers for plugins to support enabling/disabling
2015-02-04 16:23:56 -05:00
4c8850108a
SECURITY: Don't leak topic title in the redirect
2015-02-04 11:55:39 -08:00
a4b96adfc5
eliminate cross talk in site setting test
2015-02-04 16:57:16 +11:00
c150c55e2d
FEATURE: rudimentary view tracking wired in
2015-02-04 16:15:16 +11:00
e105f0965c
infrustructure for tracking application web requests
2015-02-04 16:15:16 +11:00
aacf2e6f20
Can add `shadowed_by_global` to a site setting to override
...
If a site setting has `shadowed_by_global: true` then, if
a `GlobalSetting` exists with the same name then that value
will be used instead. Additionally, the setting will be hidden.
This is useful in a multisite environment for private settings
such as API keys. You want to set it globally, yet not display
the key to customers.
2015-02-03 16:49:22 -05:00
f15b0d205f
FIX: The "too similar" check happened when trying to make a post a wiki
2015-02-02 12:44:56 -05:00
64c4bd5dbf
Fix force_avatar_update.to_i error as force_avatar_update is a boolean
...
If force_avatar_update is passed in sso attributes it errors on
force_avatar_update.to_i. The SingleSignOn class forces avatar_force_update
to a boolean, so it should be treated as such.
2015-01-30 09:51:38 +00:00
8264dbd971
Merge pull request #3140 from fullfatthings/fix_missing_sso_avatar_bug
...
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
2015-01-30 10:45:25 +11:00
b1f81c0dca
Merge pull request #3080 from riking/misc
...
Miscellaneous fixes from PR#3000
2015-01-30 10:23:17 +11:00
ea7af7a83b
Merge pull request #3135 from longhotsummer/fix-no-user-params
...
FIX: creating a user shouldn't error when optional fields aren't given
2015-01-30 10:12:57 +11:00
85a7b925c7
Miscellaneous fixes from PR#3000
...
FIX: Don't require login to view post raw
FIX: Don't submit read-guidelines for anonymous users (causes
unnecessary 403 errors from ensure_logged_in)
FIX: Don't pass nil to an array serializer
2015-01-29 13:56:32 -08:00
6a68e8c272
FIX: use CDN for user card/profile background and user avatars (for real this time)
2015-01-29 22:53:48 +01:00
6c410ed093
FIX: strip whitespaces from user email
2015-01-30 01:44:24 +05:30
e42e9bd010
Merge pull request #3149 from techAPJ/patch-2
...
FIX: allow developer emails to bypass email blacklist/whitelist restrict...
2015-01-29 13:42:59 -05:00
58f46137d6
FIX: allow developer emails to bypass email blacklist/whitelist restriction
2015-01-30 00:10:03 +05:30
1f40807001
Add extensibility point for whenever a post is created
2015-01-29 12:46:29 -05:00
bdb0b45834
Merge pull request #3148 from techAPJ/patch-1
...
Do not allow TL0 users topics in email digest
2015-01-29 17:50:21 +01:00
6e862e0e59
FIX: Should flush rate limit keys before testing it
2015-01-29 11:45:12 -05:00
21e94859a9
Do not allow TL0 users topics in email digest
2015-01-29 21:10:26 +05:30
e97755ab5d
FIX: remove custom Discourse headers in email
2015-01-29 17:25:50 +05:30
cd2c9edb46
FIX: 🐛 upload on IE9 wasn't working :'(
...
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
d43944b3ed
Extensibility for tracking changes to a topic
2015-01-28 13:37:06 -05:00
dbf2f4efec
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
...
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)
This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
b0369061e2
FIX: always set a default Message ID in email
2015-01-28 14:49:38 +05:30
12c82bed59
Disable digest emails site setting
2015-01-27 22:41:36 +05:30
d99ccf6d27
FIX: creating a user shouldn't error when optional fields aren't provided
...
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.
Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
5c2ee8ec2a
FEATURE: suppress digest emails for users not seen on the site for more than (n) days.
2015-01-26 22:04:02 +05:30
1ab0d6bd82
FEATURE: Log username changes by staff
...
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
7a86abd105
Merge pull request #3084 from jmay/group-managers
...
table & model changes for group managers with permission to edit members
2015-01-16 12:02:38 +01:00
4a11bb5227
FIX: on topic page, don't try to render post counts for a deleted user
2015-01-15 15:39:34 -05:00
dc801bb442
Merge pull request #3102 from techAPJ/patch-2
...
Add username and date-time in exported file name
2015-01-15 15:35:06 -05:00
505fa9f1cf
FIX: 🐛 Saving the same custom field array twice would raise an error
2015-01-15 15:31:50 -05:00
c619aed8f9
💄 add username and date-time in exported file name
2015-01-16 01:39:46 +05:30
a2b284a0a4
table & model changes for group managers with permission to edit membership
2015-01-15 11:44:42 -08:00
b4e5937850
FIX: 🐛 ensure emoji are case insensitive
2015-01-15 19:00:55 +01:00
c4da9ce62f
FIX: old csv's were not getting deleted
2015-01-15 00:00:39 +05:30
835835832f
FIX: user list export was failing
2015-01-14 16:24:42 +05:30
b94c7922c5
🐎 gzip csv export files
2015-01-14 13:38:37 +05:30
7771d2fb31
remove enable_email_names setting
2015-01-13 13:35:40 +05:30
1032fa7262
Merge pull request #3089 from lucianosousa/enhacement/controllers-rspec3
...
controllers with rspec3 syntax
2015-01-12 16:25:31 +01:00
5f98be6ec5
Merge pull request #3088 from lucianosousa/enhacement/components-rspec3
...
few components with rspec3 syntax
2015-01-12 16:25:25 +01:00
f7f5e39f75
FIX: Minor Admin bug with a setting when creating a new group
2015-01-23 20:31:48 +01:00
256519dddf
FEATURE: automatic group membership based on email address
2015-01-23 18:25:43 +01:00
b3a2c0c45b
SECURITY: The SSO `return_path` was an open redirect
...
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
e300945879
FEATURE: split group admin in 2 tabs (custom & automatic)
...
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
5e751ce90a
FEATURE: 🎁 rate limit invites for non-staff users
2015-01-20 01:12:24 +05:30
bc73238c8f
controllers with rspec3 syntax
2015-01-09 14:04:02 -03:00
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
16156bdc1d
removing rspec3 warning
2015-01-09 09:55:58 -03:00
0b14cfa2c3
skip failing spec, something is off with timezones
2015-01-09 12:03:08 +11:00
6cec925f26
FIX: all PMs should be flaggable
2015-01-08 16:06:43 +01:00
03388e11ab
oops, migration was flipping
2015-01-08 15:26:15 +11:00
3347a48275
FEATURE: add liked and bookmarked classes to topic list item rows
2015-01-08 14:35:56 +11:00
114cc1c851
FIX: We missed some references to `/category/xyz` in the ruby code base.
2015-01-07 11:47:01 -05:00
ea87f5fd8a
FEATURE: support for filter=bookmarked and filter=liked in topic list
2015-01-07 18:20:10 +11:00
efc717c14a
FEATURE: remove star concept from Discourse
2015-01-07 13:43:27 +11:00
6953923a03
remove |starred| from topnav default options
2015-01-06 16:03:45 -08:00
060cda7772
FIX: proper handling of group memberships
2015-01-05 18:51:45 +01:00
b52f12948a
models with rspec3 syntax
2015-01-05 13:04:23 -03:00
b3d769ff4f
Update rspec syntax to v3
...
update rspec syntax to v3
change syntax to rspec v3
oops. fix typo
mailers classes with rspec3 syntax
helpers with rspec3 syntax
jobs with rspec3 syntax
serializers with rspec3 syntax
views with rspec3 syntax
support to rspec3 syntax
category spec with rspec3 syntax
2015-01-05 11:59:30 -03:00
6f72f265cb
A trigger when a topic is updated, adds a couple of custom field tests
2015-01-02 15:57:08 -05:00
4c166942ad
FEATURE: Invite admin api has an optional param send_email which can prevent sending an email to the invited user. The api will return the password reset url so that the caller can send an email with it instead.
2015-01-02 15:48:54 -05:00
c57a1b393f
clean up 'checked_for_custom_avatars' user history entries
2015-01-02 12:37:17 +01:00
9fcaf090ec
Merge pull request #3068 from fantasticfears/category_slug
...
support setting category slug
2015-01-02 11:55:27 +01:00
bfe95966b4
better filenames for export
2015-01-02 15:30:50 +05:30
35edfb5b91
FIX: Don't truncate groups. @ZogStrIP we need to create a better fix for
...
this in the new year.
2014-12-31 12:58:50 -05:00
3d42c2d515
Merge pull request #3070 from techAPJ/patch-3
...
FIX: rate limit user posts export
2014-12-31 11:37:11 -05:00
78537aad39
FIX: rate limit user posts export
2014-12-31 00:54:23 +05:30
97b3914b70
FIX: use utc time when generate reports; set boundary
2014-12-30 22:43:03 +08:00
a04f44d65a
Merge pull request #3065 from fantasticfears/fix-visits-report
...
FIX: today visits not shown
2014-12-29 21:23:47 +01:00
f7955406cc
As an optimization, don't return suspended users in the query that
...
determines who to send digests to.
2014-12-29 15:16:29 -05:00
1e166d89ff
support setting category slug
2014-12-30 03:14:54 +08:00
fe7f2c6979
FIX: today visits not shown
2014-12-30 03:09:22 +08:00
7ca092da17
Merge pull request #3057 from jaanus/s3-frankfurt-bucket
...
Add eu-central-1 to list of S3 buckets.
2014-12-29 18:02:14 +01:00
f6026ad1d0
Added eu-central-1 S3 bucket.
2014-12-29 18:31:21 +02:00
1055fc0919
Merge pull request #3021 from jmay/custom-category-slug
...
optional custom value for category slug (create and update)
2014-12-29 10:34:23 -05:00
267de04e2d
Merge pull request #3061 from techAPJ/patch-1
...
Rename CsvExportLog to UserExport
2014-12-29 12:39:53 +01:00
bfbc49ef6f
FIX: log only 1 'show email' record
2014-12-29 11:50:36 +01:00
ef62933034
Ruby 2.2 fixes
2014-12-29 13:31:15 +11:00
68e66f3a25
Rename CsvExportLog to UserExport
2014-12-28 22:31:12 +05:30
9932bea7ce
FEATURE: default emoji override
2014-12-25 17:58:15 +01:00
7c7474aa10
create a new table to maintain csv export log
2014-12-24 16:25:36 +05:30
bb152a5b3f
FEATURE: download user posts archive
2014-12-24 15:13:48 +05:30
e23e008682
FIX: buggy unhoisting of escaped \*
2014-12-23 18:25:10 +11:00
5b844f5320
FEATURE: more than 1 site customization can be enabled at once
...
FIX: more robust site customizations
Rewrote site customization to use distributed cache and a much cleaner
css delivery mechanism
2014-12-23 13:03:48 +11:00
45dbdb6896
FEATURE: custom emojis
2014-12-23 01:12:26 +01:00
9bb2ab6265
Merge pull request #3034 from fantasticfears/filter_system_user
...
disable sending email or show presence when forgot system user password
2014-12-19 16:52:01 -05:00
3cb25b019e
FIX: when private messages are disabled in settings, flag modal shouldn't show private message options
2014-12-19 16:47:39 -05:00
ceca85c9eb
use system user helper and constant when it's referred
2014-12-18 18:21:14 +08:00
ae16186100
FEATURE: post chunk size should not be configurable
...
If people need to configure post chunk size use a plugin
Core only supports out of the box settings, if changed can lead to
severe performance issues.
2014-12-15 10:57:34 +11:00
768027f0e3
Merge pull request #3046 from gdpelican/feature/insensitive-group-names
...
Remove group name validation case sensitivity
2014-12-17 10:52:45 -05:00
f5317a519f
Merge pull request #3035 from oblakeerickson/update_username_return_json
...
Update username should return a json response
2014-12-17 11:23:33 +01:00
84bed4f9ce
Remove group name validation case sensitivity
2014-12-17 18:44:30 +13:00
521226f4c9
FIX: registration fails with timeout on gravatar
2014-12-15 22:10:27 +01:00
b2e2a99898
FIX: Don't raise an error when trying to log nothing
2014-12-15 14:14:12 -05:00
2d6b15a34d
Load fewer posts when the android platform is detected
2014-12-12 11:47:39 -05:00
1353557575
FIX: custom flags not possible on very long topic titles
2014-12-11 19:34:52 +01:00
02ade72ceb
Update username should return a json response
...
- Have update username return json response that contains the updated
username and id. I figured this would be better than just return "OK".
- Add test to verify that the new username is returned.
2014-12-10 09:43:16 -07:00
6027073547
FIX: properly unescape HTML entities in excerpts
2014-12-10 12:52:51 +01:00
9937af7ac4
disable sending email or show presence when forgot system user password
2014-12-10 14:17:56 +08:00
663cd93c6d
Move `register_asset` into `PluginRegistry` -- the logic works better
...
there.
2014-12-09 14:20:53 -05:00
1d0eccf710
Have activate user return json
...
- Change activate user from admin controller to return json
- Test that it returns json
- Remove unnessary test from log_out spec
This commit was created so that when you activate a user through the api
it returns a json response.
2014-12-08 11:16:57 -07:00
fdecd69228
Merge pull request #3026 from oblakeerickson/legacy_avatar
...
Remove legacy avatar code
2014-12-08 11:03:55 +11:00
e9e88c9b82
Remove legacy avatar code
...
- Remove method that was only left around because the
[api](https://github.com/discourse/discourse_api/pull/53 ) called it
- Modify test to use new route instead of legacy route
https://meta.discourse.org/t/legacy-route-for-avatars/22838/2
2014-12-07 06:13:14 -07:00
a4ce039c85
demock spec
2014-12-07 18:11:38 +11:00
Sam
Robin Ward
Régis Hanol
Arpit Jalan
Erick Guan
Neil Lalonde
Luke Granger-Brown
Arthur Neves
Tan Le
Ben Hadley-Evans
Ed Gibbs
Dan Singerman
Jason W. May
Sigurður Guðbrandsson
Loïc Guitaut
riking
Greg Kempe
Luciano Sousa
Jeff Atwood
jaanus
James Kiesel
Blake Erickson