4422d9a4bf
DEV: Provide a nicer error when JSON is malformed
...
This is very useful for development. It will give a much nicer error if
the JSON that comes back from the server is missing a required key.
2019-11-12 13:04:52 -05:00
c9bd463e9d
DEV: Let is not supported, use var instead
2019-11-12 14:58:16 -03:00
213ebc3b32
DEV: Deprecation warning for aliased module usage ( #8341 )
2019-11-12 10:20:14 -06:00
cf4356cd81
UX: Do not add leading/trailing spaces when copying API key in Firefox
...
If there is any other whitespace in the container, then Firefox will add a leading/trailing space when double clicking the key. This commit wraps the key in a div with no whitespace, to work around the problem.
2019-11-12 16:00:57 +00:00
f49494b0bf
REFACTOR: Remove a few `Discourse.Site` globals
2019-11-12 10:53:22 -05:00
afadf361b3
REFACTOR: `idMap` should be a private API
2019-11-12 10:53:22 -05:00
7f651b9666
REFACTOR: Deprecate `Discourse.Site` and `Discourse.User`
2019-11-12 10:53:22 -05:00
3dd2f2f701
DEV: Remove RSS feed polling in favor of plugin ( #8233 )
2019-11-12 09:49:02 -06:00
241d9a3034
FIX: Topic lists filtered by tag and a specified filter don't work
...
This was a regression caused by 59241df2
2019-11-12 11:34:52 +00:00
9b841ea83f
DEV: Run prettier
2019-11-12 11:49:31 +01:00
5d4b240453
DEV: Provide radix argument to parseInt ( #8281 )
...
* DEV: Provide radix 10 argument to parseInt
* DEV: Provide radix 16 argument to parseInt
* DEV: Remove unnecessary parseInt calls
* Fix year formatting
parseInt was used here to convert decimals to ints
2019-11-12 10:47:42 +01:00
34665d3f96
FIX: In case `@ember/object` hasn't been loaded yet
2019-11-11 15:56:58 -05:00
e39d89ecd9
REFACTOR: Remove `InputValidation` which was simply an `Ember.Object`
2019-11-11 15:48:56 -05:00
211410c3b9
DEV: It doesn't make sense for a filterMode to be weekly, quarterly, etc
2019-11-11 18:46:27 +00:00
da04c602ba
REFACTOR: Remove `debounce` to `discourseDebounce`
...
Otherwise it can be confused with the ember debounce
2019-11-11 13:34:01 -05:00
e8dae447bd
REFACTOR: Remove `discourse/lib/throttle`
2019-11-11 13:21:03 -05:00
4ddb69e9c6
DEV: Removed needless indirection
...
An artifact of when tagging was a plugin no doubt.
2019-11-11 17:59:26 +00:00
e79cec9fc7
DEV: Remove handling of category top menu items
...
Support for these kinds of navigation items was dropped in 88f52514
2019-11-11 17:36:29 +00:00
55bdd9e6a2
FIX: Do not skip some emails in user search ( #8317 )
...
It used to skip the email addresses containing the plus sign.
2019-11-11 18:42:45 +02:00
20266325fc
combined import definitions in discourse-loader
2019-11-11 10:37:21 -05:00
1bbb9b30fc
DEV: Import isNone for @ember/utils
2019-11-11 10:37:21 -05:00
0c8ae1e849
FIX: More missing RSVP imports
2019-11-11 09:25:33 -05:00
2a6713c2ba
FIX: Was using a native browser Promise instead of RSVP
2019-11-11 09:23:26 -05:00
920f8c6d75
REFACTOR: Remove `Discourse.Route` in lieu of importing
2019-11-08 15:18:13 -05:00
c0e105fc8c
FIX: Return a deprecation for `Discourse.Session`
2019-11-08 14:55:36 -05:00
bd92fdeb4d
FIX: Add deprecation for Discourse.NavItem in case themes are using it
2019-11-08 14:14:51 -05:00
f03edb36be
REFACTOR: Remove `Discourse.Model`
2019-11-08 14:13:35 -05:00
291572a97a
REFACTOR: Remove `Discourse.Session` constants
2019-11-08 13:46:50 -05:00
7ac2a55588
REFACTOR: Remove `Discourse.Category` constants
2019-11-08 13:31:00 -05:00
e51efce356
DEV: Remove all instances of Ember.computed ( #8324 )
2019-11-08 12:28:11 -06:00
7e44065bcb
REFACTOR: Migrate `Discourse.Post` to imports
2019-11-08 13:13:13 -05:00
932c169d46
REFACTOR: Remove Discourse.NavItem constants
2019-11-08 12:56:13 -05:00
779ee3558d
REFACTOR: Remove `Discourse.UserAction` from code
2019-11-08 12:52:39 -05:00
562acb21ca
FIX: Ran prettier to fix build ( #8323 )
2019-11-08 10:50:03 -06:00
7f3812b90a
DEV: Removed all Ember.computed. in select-kit ( #8322 )
2019-11-08 10:32:20 -06:00
47e3e56905
FIX: Alias modules that are required AND imported ( #8315 )
2019-11-08 09:48:02 -06:00
5a016b7eb0
DEV: Adds a new plugin outles to add custom icons on the admin users list ( #8277 )
2019-11-08 10:32:57 -03:00
edec922803
FIX: use 'about.json' endpoint instead of using ember model to get the data.
2019-11-08 14:17:51 +05:30
ba5b78a348
FEATURE: support to mute all categories by default. ( #8295 )
...
Instead of enabling `suppress_from_latest` setting on many categories now we can enable `mute_all_categories_by_default` site setting. Then users should opt-in to categories for them to appear in the latest and categories pages.
2019-11-08 08:28:11 +05:30
99b0697bd9
FIX: Correct display of last used date in API key details UI
2019-11-07 23:41:43 +00:00
6275c05c0d
DEV: Move computed to discourseComputed ( #8312 )
2019-11-07 15:38:28 -06:00
d74546f50e
REFACTOR: Remove `Discourse.Topic` constant
2019-11-07 15:46:58 -05:00
9d457fa51f
REFACTOR: Remove `Discourse.TrustLevel` constant
2019-11-07 15:26:26 -05:00
f8d69253e8
FIX: Prettier to fix build ( #8311 )
2019-11-07 12:07:08 -06:00
9ffdbf912f
DEV: Import ember ENV instead of Ember.testing ( #8305 )
2019-11-07 11:20:35 -06:00
063a1d4077
Revert "FIX: The internal position on the topic timeline is a scroll position"
...
This reverts commit 9c1a713c6e
2019-11-07 11:04:39 +00:00
9c1a713c6e
FIX: The internal position on the topic timeline is a scroll position
...
... instead of a post index. This is so that updatePosition is called
when switching between the last two scroll positions.
2019-11-07 10:10:17 +00:00
7d25d65ccb
DEV: adds support for input/change events on widgets ( #8309 )
2019-11-07 10:15:05 +01:00
cf0f2c70cd
FIX: regression not showing excerpts in mobile timeline
...
I think this is a result of: 87f0b56191
2019-11-07 16:10:31 +11:00
f611aa6ada
FIX: Correct translation key for api key revoke button
2019-11-06 16:13:12 +00:00
e3b7f07916
DEV: Run prettier
2019-11-05 22:30:23 +00:00
59241df251
FIX: Display tags topic list correctly when none is selected for subcategories
2019-11-05 20:12:36 +00:00
ca14e3d83c
FIX: Build with prettier for imports ( #8298 )
2019-11-05 13:32:43 -06:00
edc135d9c5
DEV: Import set, setProperties, helper, and string functions ( #8297 )
2019-11-05 12:43:49 -06:00
61b1f9c36b
FEATURE: Load translation overrides without JS `eval`
2019-11-05 19:16:38 +01:00
014f19b6ea
DEV: Import Promise from rsvp ( #8296 )
2019-11-05 10:37:32 -06:00
52c5cf33f8
FEATURE: Overhaul of admin API key system ( #8284 )
...
- Allow revoking keys without deleting them
- Auto-revoke keys after a period of no use (default 6 months)
- Allow multiple keys per user
- Allow attaching a description to each key, for easier auditing
- Log changes to keys in the staff action log
- Move all key management to one place, and improve the UI
2019-11-05 14:10:23 +00:00
c008443f2d
FIX: filterQueryParams mutates state that is essentially global
...
Let's prevent it from doing this by duplicating the input first.
2019-11-05 11:47:29 +00:00
8e419a772f
FIX: improve regex used for image sizing controls ( #8291 )
2019-11-05 18:40:02 +08:00
5502128105
DEV: Remove uneeded comment
...
followup to 4b43816b
2019-11-05 16:26:32 +11:00
2b3e248927
FIX: on mobile setting active on navItem would not work
...
navigation bar would not have the current nav item selected when it overrode
2019-11-05 16:15:43 +11:00
4b43816bb6
FIX: Skip composer blur event when switching apps in iOS
2019-11-04 22:16:31 -05:00
fa56ba89a5
Import getProperties from @ember/object
2019-11-04 14:24:30 -05:00
d43e7354ec
DEV: Convert <button> tags to {{d-button}} components ( #8224 )
...
* DEV: Convert <button> tags to {{d-button}}
* Fixes
2019-11-04 11:23:54 +01:00
f66e5d38d3
FEATURE: add an "init" method for extra nav items
...
This allows us to trigger special initialization code prior to adding an
extra nav item to the navigation menu.
2019-11-04 19:07:31 +11:00
8d69944b4e
FIX: update action should be in setting-component mixin ( #8287 )
...
This was causing an exception on some component (eg: value-list in a theme-component setting) which couldn't find an action named update.
2019-11-02 18:24:41 +05:30
29ee467a04
FIX: do not add personal message link in user menu if they are disabled
2019-11-01 22:40:41 -07:00
0e2261c414
FIX: Linting
2019-11-01 13:57:22 -04:00
dceb72bc69
FIX: Move `makeArray` to discourse-common
2019-11-01 13:50:15 -04:00
6300ac699a
FIX: Missing `run` import
2019-11-01 13:50:15 -04:00
75b751c108
REFACTOR: An ember.get we missed
2019-11-01 13:50:15 -04:00
785ebb674d
REFACTOR: Split off raw handlebars helpers from compiler
...
This allows us to compile without Ember being present
2019-11-01 13:50:15 -04:00
640a05c4ee
REFACTOR: Remove `Ember.get`
2019-11-01 13:50:15 -04:00
89f602f66b
REFACTOR: `Ember.makeArray` was removed from the public API
2019-11-01 13:50:15 -04:00
90f934a660
REFACTOR: Use a module for `Ember.isEmpty`
2019-11-01 13:50:15 -04:00
72aa26c8c5
FEATURE: New site settings for default tags in user preferences. ( #8283 )
2019-11-01 12:40:13 +05:30
9fb09d147d
DEV: allow positioning of nav items and allow selection
...
Previously we could not place extra nav items in a particular order.
This change introduces a new `before` attribute to addNavigationBarItem
with this attribute we can place a nav item before "top" or any other place.
Additionally this allows navigation items to force active state. In some
cases we may want an items that is simply a "filter" on latest using `?query_params`
when we do that we can "force" the filter active.
A concrete example is the assign plugin that adds a nav item for
Unassigned => `/c/cat-slug/l/latest?assigned=nobody&status=open`
If we did not force then latest would be selected even though the filter
is clicked.
2019-11-01 13:52:25 +11:00
b93f253486
FIX: Hide muted subcategories for mobile ( #8273 )
...
That bug was mentioned in [meta](https://meta.discourse.org/t/muting-categories-hides-them-muting-subcategories-should-too/131316 )
Fix was done in that PR https://github.com/discourse/discourse/pull/8239
however I forgot about mobile template
2019-11-01 08:22:21 +11:00
5a0d30105f
FIX: Enter key on forms submits rather than refresh ( #8274 )
...
Both for forgot password form, and confirm password for second factor
2019-10-31 15:44:20 -05:00
d777844ed6
FEATURE: categories can require topics have a tag from a tag group
...
In a category's settings, the Tags tab has two new fields to
specify the number of tags that must be added to a topic
from a tag group. When creating a new topic, an error will be
shown to the user if the requirement isn't met.
2019-10-31 16:10:19 -04:00
e1679d744c
DEV: Add plugin outlets to advanced search options
...
Also adds classes for the filter containers, allowing for more granular styling.
2019-10-31 16:06:39 -04:00
5efa95b5f8
FIX: make notification consent banner usable via keyboard and screenreader ( #8255 )
...
* update d-button to support btn-link class
* add display attribute to d-button rather than computing on class
2019-10-31 15:36:24 -04:00
11f50eee3b
DEV: Remove pretty_text import hack & still work server-side ( #8266 )
...
* FIX: move attachment_css_class constant out of upload-short-url for discourse-markdown-it
* Use setTimeout instead of ember later
* WIP. Not sure if this worked.
* oneboxer cache in separate file
* Reset onebox cache still
* set functions for oneboxers cache
2019-10-31 11:54:46 -05:00
c5e67726fd
FIX: under some conditions draft would say it was saving when not
...
This is a major change to draft internals. Previously there were quite a
few cases where the draft system would say "draft saved", when in fact
we just skipped saving.
This commit ensures the draft system deals with draft ownership handover in
a predictable way.
For example:
- Window 1 editing draft
- Window 2 editing same draft at the same time
Previously we would allow window 1 and 2 to just fight on the same draft
each window overwriting the same draft over an over.
This commit introduces an ownership concept where either window 1 or 2 win
and user is prompted on the loser window to reload screen to correct the issue
This also corrects edge cases where a user could have multiple browser windows
open and posts in 1 window, later to post in the second window. Previously
drafts would break in the second window, this corrects it.
2019-10-31 17:15:58 +11:00
d355506123
FEATURE: Option to update user preferences of all users when default site setting changed.
2019-10-31 06:48:03 +05:30
7a264217f2
FIX: default user preferenced categories are not updating in admin site setting UI.
2019-10-31 05:45:57 +05:30
13cca3eaa0
DEV: run files through prettier
...
2ae21e9
2019-10-31 10:18:29 +11:00
02a886ce13
DEV: Import `Ember.on` from @ember/object/evented ( #8268 )
...
* DEV: Import `Ember.on` from @ember/object/evented
* Dont import "on" outsie of the js or admin app
* Fixed error when resolving merge conflicts
2019-10-30 17:05:27 -05:00
2ae21e9c35
DEV: Import every instance of Ember.computed function ( #8267 )
...
* DEV: Import every instance of Ember.computed function
* export default for Ember.computed
2019-10-30 15:28:29 -05:00
790a7e2095
Ensure page is scrolled up on new query in full page search
2019-10-30 16:18:43 -04:00
ced3807b23
FIX: Prettier on importing mixin ( #8270 )
2019-10-30 15:13:48 -05:00
ba4b557114
DEV: Remove Ember.Mixin to import @ember/object/mixin ( #8269 )
2019-10-30 15:03:08 -04:00
e7eeb7c47f
Update log banner close from div to button
2019-10-30 14:36:45 -04:00
1772682b0a
FIX: ensure there's an excerpt before showing the bio
2019-10-30 19:09:25 +01:00
080e899b8c
DEV: Tag group improvements ( #8252 )
...
* DEV: Add the actual "tag_groups/new" route
Allows refreshing the "new" page without an error.
* DEV: Prevent attempts to create group tags if tagging is disabled
* DEV: Refactor the tag-groups controller
Gets rid of `selectedItem`, `selected`, and `selectTagGroup` action.
* DEV: Rename tag-groups-show to tag-groups-edit
* DEV: Refactor tag-groups form
* Extracted the tag-groups-form that's used by tag-groups-new and tag-groups-edit
* The model is now a buffered property
* Serialization relies more heavily on RestAdapter now
* Data is sent as JSON
* Payload is now namespaced ("tag_group")
* Update app/assets/javascripts/discourse/controllers/tag-groups-new.js.es6
Co-Authored-By: Joffrey JAFFEUX <j.jaffeux@gmail.com>
* Update app/assets/javascripts/discourse/components/tag-groups-form.js.es6
Co-Authored-By: Joffrey JAFFEUX <j.jaffeux@gmail.com>
* Update app/assets/javascripts/discourse/controllers/tag-groups-edit.js.es6
Co-Authored-By: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-10-30 16:57:13 +01:00
7191835989
DEV: Support custom server-side names in rest models ( #8265 )
2019-10-30 15:25:42 +00:00
8d34f4bbd9
Revert "Revert Ember.run refactors"
...
This reverts commit fcb1ca52f9
2019-10-30 09:48:24 -04:00
fcb1ca52f9
Revert Ember.run refactors
...
This reverts commit 5ca60fcb6b
2019-10-29 17:10:47 -04:00
cfa5d123a3
Temporary fix: Don't use ember imports in pretty text
2019-10-29 16:45:05 -04:00
249dff85c7
FIX: Use modules for `Ember.run.debounce` hack in testing
2019-10-29 16:25:37 -04:00
Robin Ward
romanrizzi
Mark VanLandingham
David Taylor
Daniel Waterworth
Jarek Radosz
Dan Ungureanu
Mark VanLandingham
Vinoth Kannan
Joffrey JAFFEUX
Sam Saffron
Gerhard Schlager
Joe
Penar Musaraj
Jeff Wong
Krzysztof Kotlarek
Neil Lalonde
Leo McArdle
Kris
Régis Hanol