1957d12670
SECURITY: Don't use backticks for exporting your archive
2017-03-16 16:24:59 -04:00
0a87547cbc
Fix broken tests.
2017-03-16 10:22:15 +08:00
cfbfea0596
FEATURE: Allow easier customization to the web hook event serialization.
2017-03-16 10:09:05 +08:00
1a7e954e09
FIX: Store custom emojis as uploads.
...
* Depending on a hardcoded directory was a flawed design
which made it impossible to debug when custom emojis go
missing.
2017-03-14 13:07:18 +08:00
23b06d2895
FIX: should not try to send digest to users who reached the bounce threshold
2017-03-08 19:19:11 +01:00
cf8bc4483f
FIX: always send critical emails even when bounce score threshold has been reached
2017-03-08 10:06:16 +01:00
d5bcc70e9c
FIX: grant trust level when bulk adding users to group
2017-03-06 14:39:53 +05:30
80858bae2c
FEATURE: further restrict downloading of backups
...
- send email to logged in admin when they press the "download" button
- show pop-up that email was sent
- create email template
- require a valid token to download backup
2017-03-01 08:28:34 -07:00
0a41da6bad
FEATURE: Add order logic to admin users controller
...
Added order and direction parameters for sorting admin user pages. This
commit only includes backend api changes.
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649
Now you can pass in `order` and `asc` parameters to the
`/admin/users/list/<query>.json` endpoint.
Example:
`/admin/users/list/active.json?&order=post_count` which defaults to desc
and
`/admin/users/list/active.json?order=post_count&asc=true`
2017-02-24 17:11:17 -07:00
f07b4b310a
should not have renamed this setting in 460665895c
2017-02-08 18:11:34 +01:00
ff49f72ad9
FEATURE: per client user tokens
...
Revamped system for managing authentication tokens.
- Every user has 1 token per client (web browser)
- Tokens are rotated every 10 minutes
New system migrates the old tokens to "legacy" tokens,
so users still remain logged on.
Also introduces weekly job to expire old auth tokens.
2017-02-07 09:22:16 -05:00
19f7beaa2c
FIX: topic links were getting dropped when post is rebaked
2017-01-30 14:55:53 +05:30
496682c442
Merge pull request #4662 from tgxworld/fix_localized_group_name_change
...
Fix localized group name change
2017-01-26 10:50:00 -05:00
706b4f6b9f
FEATURE: Remap group mentions when group name has been changed.
2017-01-18 13:39:34 +08:00
b60e9b7330
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-16 10:50:07 +00:00
7a1ff59822
FIX: PM email to suspended member was broken
2017-01-05 13:58:14 +05:30
076a08d8e1
FIX: Unactivated users should not be automatically added into groups as well.
2016-12-21 18:15:01 +08:00
7228081820
FIX: Automatic group membership should not add staged or unactivated users.
2016-12-21 18:04:26 +08:00
923cf73c6e
Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox.
2016-12-19 14:54:07 -05:00
f867af6bf9
bye bye byebug
2016-12-15 15:52:25 +11:00
3666575b46
UX: Improve styling for groups page.
2016-12-15 12:19:13 +08:00
664feca199
FIX: don't send emails from muted users in mailing list mode
2016-12-12 15:28:26 +01:00
9a800107cb
FIX: Associate category logo and background to uploads record.
2016-12-12 17:37:28 +08:00
05f55dbc10
FEATURE: Group logs.
2016-12-12 17:29:54 +08:00
424fc8e2e2
FIX: Don't raise an error if the RSS endpoint is 404
2016-12-05 12:29:14 -05:00
ce974da9e5
FIX: simplify CSV file upload
2016-12-05 14:09:08 +05:30
55b35a05ed
FIX: This should not have been checked in.
2016-12-05 11:49:04 +08:00
22059d4df9
Add Rake task to clean up unused multisite Redis keys.
2016-12-05 11:46:34 +08:00
0dfac2dd24
Merge pull request #4545 from hiveeyes/pop3_polling_openssl_verify
...
Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification
2016-11-15 19:33:44 +01:00
43fd3ebd4a
Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification like “smtp_openssl_verify_mode”. Defaults to “true”, so it does not change current behavior.
2016-11-11 21:59:15 +01:00
ac2c035856
FIX: stop raising exceptions when a post goes missing
2016-11-08 14:51:56 +11:00
dd58c00699
FEATURE: Add instance id in the webhook payload
2016-11-04 15:21:41 +01:00
f03d9cad06
PERF: `NOT IN` query is really inefficient for large tables.
2016-11-02 13:09:18 +08:00
478418e780
FIX: notify_old_email template did not had new_email
2016-10-25 23:50:55 +05:30
52b338db62
FIX: category logo & background URLs should not use the CDN
2016-10-25 10:43:57 +02:00
923db2e559
FIX: download avatar from facebook/twitter in a job in order to prevent hangs when avatars are huge
2016-10-24 17:15:13 +02:00
aee943486a
FEATURE:'No Echo' option for mailing list mode.
...
Mailing list mode now includes the 'no echo' option: to only receive emails of posts not created
by you. If you reply to an email thread in mailing list mode, your reply will not then be echoed
back to you in a duplicate email by the system.
2016-10-19 13:14:36 -04:00
e5a13b0ac1
FIX: specify CSV file encoding and better error reporting
2016-10-18 00:31:35 +05:30
af83c8dc14
Upload Logos Step
2016-09-22 09:52:19 -04:00
707fcb9434
FIX: Content-Lenght should be the size in octets
2016-09-21 10:31:20 +08:00
00d5facf36
FEATURE: prompts new webhook events
2016-09-19 12:07:17 +08:00
451050c6c4
Merge pull request #4437 from fantasticfears/webhooks-event-name
...
FIX: show event name in webhook headers
2016-09-16 14:27:12 +08:00
baacb30ba1
FIX: Incorrect folder.
2016-09-15 15:20:07 +08:00
7423140825
FIX: show event name in webhook headers
2016-09-12 17:48:54 +08:00
0fbb949af5
Merge pull request #4432 from tgxworld/migrate_upload_scheme_to_scheduled_job
...
FIX: Make `Jobs::MigrateUploadScheme` a scheduled job.
2016-09-06 08:39:27 +08:00
9ce61b4586
FEATURE: Webhooks.
2016-09-05 18:44:00 +08:00
340874d345
FIX: post notifications in JSON so we properly support arrays and so on
2016-09-04 15:51:16 +10:00
a869d861f4
FIX: Make `Jobs::MigrateUploadScheme` a scheduled job.
...
This reverts https://github.com/discourse/discourse/commit/9d8db11c
If the job fails during execution or if `SiteSetting.migrate_to_new_scheme`
has been set to `false`, the job will be considered as executed even
though the migration has not been completed. As a result, the job
will have to be executed manually which is not desirable.
2016-09-02 11:48:45 +08:00
929730c008
FIX: properly insert images in markdown inline format (take 2)
2016-09-01 17:56:39 +05:30
54a1180140
FIX: properly insert images in markdown inline format
2016-09-01 11:55:40 +05:30
896732975e
correct url linked in push notification
2016-08-26 13:45:56 +10:00
4fe52c8cbe
FEATURE: backend support for pushing notifications to clients
2016-08-26 12:47:10 +10:00
394cd43d77
Scrub only after converting strings to UTF-8
...
Scrubbing an ASCII-8BIT string isn't ever going to remove anything, because
there's no code point that isn't valid 8-bit ASCII. Since we'd really
prefer it if everything were UTF-8 anyway, we'll just assume, for now, that
whatever comes out of SimpleRSS is probably UTF-8, and just nuke anything
that isn't a valid UTF-8 codepoint.
Of course, the *real* bug here is that SimpleRSS [unilaterally converts
everything to
ASCII-8BIT](https://github.com/cardmagic/simple-rss/issues/15 ). It's
presumably *far* too much to ask that it detects the encoding of the source
RSS feed and marks the parsed strings with the correct encoding...
2016-08-25 16:09:07 +10:00
a2220feaea
FEATURE: new site setting rebake_old_posts_count
2016-08-15 16:34:13 +05:30
7db2083d45
FIX: 'cancel_scheduled_job' was deleting all jobs in multisite
2016-08-12 13:10:52 +02:00
e55e2aff94
FIX: FirstReplyByEmail badge wasn't granted
...
DEPRECATED: PostProcess badge trigger
2016-08-10 19:24:01 +02:00
51322a46b3
FEATURE: retry processing incoming emails on rate limit
2016-08-08 22:28:27 +02:00
8b252f19d7
Merge pull request #4365 from gdpelican/fix/daily-mlm-notifications
...
Don't halt notification emails for those on daily mailing list mode
2016-08-08 14:30:56 -04:00
c064e946b2
FIX: custom reason for flags were not showing for non-english locales
2016-08-05 18:41:11 +05:30
c2819e99f4
Don't halt notification emails for those on daily mailing list mode
2016-08-03 12:29:38 -04:00
c591429868
FIX: don't destroy uploads in queued posts and drafts
2016-08-01 18:35:57 +02:00
12dc511fea
PERF: make score calculator cheaper when site has long topics
2016-07-22 09:48:44 +10:00
f1566ef80b
FIX: escape comma in exported CSV file
2016-07-19 13:19:46 +05:30
1ea1cefb35
Extract Nginx log analyzer into a plugin that ships with Discourse.
2016-07-19 15:44:00 +08:00
a80e8cb9bd
FIX: do not execute onceoff badge queries if the badges are disabled
2016-07-06 13:04:08 +05:30
17890f95a1
FIX: don't send emails to mailing_list users when bounce threshold is reached
2016-07-05 12:20:07 +02:00
bd07658a37
PERF: Split queries when cleaning uploads.
...
This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.
2016-07-04 16:34:32 +08:00
813fcebdd1
FIX: email_always was not respected correctly
...
In the past email always meant, email me even if active UNLESS I read post
Now emails always means, always, even if I read the post
2016-07-01 11:22:07 +10:00
5dcdfb9777
ensure default locale is 'en' instead of nil
2016-06-30 17:37:00 +02:00
76766a25bf
FIX: wrong translation key
2016-06-28 17:22:34 +02:00
2ecd0da59f
REFACTOR: use same code path for handling emails via API and POP
2016-06-22 15:50:49 +02:00
e9a293beeb
FIX: clean up uploads job
2016-06-20 22:05:41 +02:00
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
e97e0bb311
FEATURE: new FirstReplyByEmail bronze badge
2016-06-13 15:37:14 +02:00
7b205ebba4
FEATURE: customize invite email message
2016-06-06 20:15:30 +05:30
99ad251731
different email footer when mailing_list_mode is enabled
2016-06-03 15:48:54 +02:00
c9dcffe434
FEATURE: store history for scheduled job execution
2016-05-30 11:38:08 +10:00
f13470b96b
Use db schema for tags instead of plugin store and custom fields
2016-05-26 14:29:48 -04:00
86d50d0017
PERF: stream CSV exports so they don't fail when they are too big
2016-05-25 22:20:35 +02:00
feffe23cc5
FEATURE: More granular mailing list mode ( #4068 )
...
* Rearrange frontend to account for mailing list mode
* Allow update of user preference for mailing list frequency
* Add mailing list frequency estimate
* Simplify frequency estimate; disable activity summary for mailing list mode
* Remove combined updates
* Add specs for enqueue mailing list mode job
* Write mailing list method for mailer
* Fix linting error
* Account for stale topics
* Add translations for default mailing list setting
* One query for mailing list topics
* Fix failing spec
* WIP
* Flesh out html template
* First pass at text-based mailing list summary
* Add user avatar
* Properly format posts for mailing list
* Move make_all_links_absolute into Email::Styles
* Apply first_seen_at to user
* Send mailing list email summary hourly based on first_seen_at
* Branch and test cleanup
* Use existing mailing list mode estimate
* Fix failing specs
2016-05-21 15:17:54 +02:00
b68860ee28
FIX: Do not send email when user of the post has been deleted. ( #4228 )
2016-05-17 17:42:15 +02:00
ce5867cce2
workaround issue where orphan user_avatar record exists
2016-05-17 09:40:17 +10:00
3df8f184c3
FEATURE: clean up 1 year old and unused staged users
2016-05-16 22:13:23 +02:00
21ce674546
fix translation when receiving a bounce or an auto-reply
2016-05-16 08:42:30 +02:00
d224966a0e
FIX: retry sending an email in 1 hour when SMTP server is busy
2016-05-09 20:37:33 +02:00
1e57bbf5c8
Lots bounce emails related fixes
...
- Show bounce score on user admin page
- Added reset bounce score button on user admin page
- Only whitelisted email types are sent to emails with high bounce score
- FIX: properly detect bounces even when there is no TO: header in the email
- Don't desactivate a user when reaching the bounce threshold
2016-05-06 19:34:33 +02:00
1d9e175bc2
MigrateUploadScheme should use execute_onceoff
2016-05-05 16:04:24 -04:00
9427e0c732
FIX: bootstrap mode should not amend setting that is not in default state
2016-05-04 16:46:46 +05:30
8e611ec7a1
FEATURE: handle bounced emails
2016-05-02 23:15:32 +02:00
74b3807f60
FEATURE: new bootstrap mode settings for brand new Discourse community ( #4193 )
...
* FEATURE: new bootstrap mode settings for brand new Discourse community
* new SiteSetting.set_and_log method
2016-04-26 13:08:19 -04:00
a556d9ad4e
FIX: Expiry should be 3 times polling interval.
2016-04-21 15:04:03 +08:00
b4e0c5afe0
FIX: Fetch stats if it has not been cached.
2016-04-21 14:50:25 +08:00
e7d1fa8120
Merge pull request #4186 from shaktikatare1989/suspention-details-in-log
...
Fix: Suspensions and Blocks do not give enough details in logs
2016-04-21 09:00:36 +05:30
cd4c34204d
Fix: Suspensions and Blocks do not give enough details in logs
2016-04-20 10:45:19 +05:30
7d9f2265b9
FIX: improve support for handling emails coming from screened email addresses
2016-04-18 23:01:54 +02:00
0119a2f980
FIX: only ever send users 1 email per post
...
in the past ninja editing a post to add a mention could trigger duplicate
emails to a user (and a few other edge cases)
2016-04-15 15:59:01 +10:00
a26bd2c549
FIX: If the user can't be found to award a badge, skip them
2016-04-14 11:52:26 -04:00
976056bc41
FIX: Ignore problems cooking
2016-04-14 11:40:23 -04:00
f95cefd09a
FEATURE: Add POP3 timeout error only after 3 failures in a row.
2016-04-14 08:55:19 +08:00
8fcd359e2a
Revert "FIX: Jobs.cancel_scheduled_job wasn't working anymore due to our move to using multiple queues"
...
This reverts commit b7c16991f7
2016-04-13 18:30:25 +02:00
b7c16991f7
FIX: Jobs.cancel_scheduled_job wasn't working anymore due to our move to using multiple queues
...
FIX: Don't queue more than 1 'update_gravatar' job per user
2016-04-13 18:12:28 +02:00
4d9c81fde7
Merge pull request #4148 from tgxworld/dont_reply_to_emails_that_are_autogenerated
...
FIX: Don't send rejection mailer to bounced emails.
2016-04-13 15:36:14 +02:00
4ceb04517f
Bump grant emoji job back to default queue.
2016-04-13 08:18:37 +08:00
fa369bcc3e
Add onceoff job to backfill oneboxes
2016-04-12 15:31:22 -04:00
f4672a9e05
Instead of a Distributed Mutex, use a Redis SETNX guard
2016-04-12 15:31:21 -04:00
eda6084d4b
FIX: don't allow concurrently queued once off jobs to do work
2016-04-12 23:08:10 +10:00
144bf07886
PERF: improve performance of emoji grants
2016-04-12 22:07:55 +10:00
ad1d14ecbe
FIX: Bump `GrantEmoji` job to low priority queue and reduce batch size.
2016-04-12 17:05:47 +08:00
7f0b1691c4
FEATURE: add pop3 timeouts and auth errors to admin dashboard. Admins will get notified along with other problems.
2016-04-08 17:33:47 -04:00
9c934e27be
FEATURE: notify admins if problems have been reported on the dashboard for a while
2016-04-08 16:44:13 -04:00
4f3f6c60c4
FIX: Rename Scheme job due to Queue Manager
2016-04-07 17:02:25 -04:00
9d8db11cf3
Move `MigrateScheme` to new Onceoff thing
2016-04-07 15:31:32 -04:00
3f7ced9236
Try running once off jobs outside of db:migrate
2016-04-07 15:07:24 -04:00
078b3bc87e
Log once off jobs and enqueue on `db:migrate`
2016-04-07 14:32:31 -04:00
526573074c
Add one off job to grant the emoji badge retroactively
2016-04-07 13:49:44 -04:00
5734c7f3f3
FIX: Don't send rejection mailer to bounced emails.
2016-04-07 22:21:17 +08:00
a130cb8305
FEATURE: move more urgent emails notifications to critical queue
...
Move signup, admin login and password change email notifications
to critical queue
2016-04-07 14:39:01 +10:00
8ec7fd84fd
FEATURE: prioritize sidekiq jobs
...
This commit introduces 3 queues for sidekiq
"critical" for urgent jobs (weighted at 4x weight)
"default" for standard jobs(weighted at 2x weight)
"low" for less important jobs
"critical jobs"
Reset Password emails has been seperated to its own job
Heartbeat which is required to keep sidekiq running
Test email which needs to return real quick
"low priority jobs"
Notify mailing list
Pull hotlinked images
Update gravatar
"default"
All the rest
Note: for people running sidekiq from command line use
bin/sidekiq -q critical,4 -q default,2 -q low
2016-04-07 12:56:43 +10:00
79639e2dec
FIX: ensure group's users counters are kept in sync
2016-04-04 17:03:18 +02:00
9e9c81c30b
improve error log when timing out while connecting to mail server
2016-03-25 16:44:08 +01:00
39863953cd
new 'enable_staged_users' site setting
2016-03-23 18:56:03 +01:00
c095304d6d
FEATURE: limit daily emails per user to 100 per day via site setting
...
- controlled via max_emails_per_day_per_user, 0 to disable
- when limit is reached user is warned
2016-03-23 15:08:48 +11:00
a202ec2028
don't run mailing list if mailing list mode is disabled
2016-03-22 14:50:35 +11:00
9c61f45bf9
FIX: properly handle failure in poll mailbox job
2016-03-21 18:49:01 +01:00
433fa74d87
FIX: ensure consistency of user options
...
Edge case during upgrade can cause accounts registered after migration
prior to restart to have missing user option records
2016-03-17 10:03:56 +11:00
162fcb75da
FEATURE: admin dashboard check when email polling errored in the past 24 hours
2016-03-16 21:17:48 +01:00
4a3cb4a000
FIX: use MD5 of the email_string when there's no 'Message-Id'
2016-03-14 18:18:58 +01:00
5771d2aee2
SECURITY: Support for confirm old as well as new email accounts
2016-03-08 14:52:22 -05:00
622d804d46
FEATURE: Add rejection message on rejected IncomingEmail
...
FIX: Better RateLimit description in rejected IncomingEmail
FEATURE: Send email when hitting a rate limit
2016-03-07 16:56:17 +01:00
05288144b5
FIX: export user list based on trust level filter
2016-03-07 18:49:31 +05:30
bc4087b9bb
FIX: RSS description might be `nil`.
2016-03-07 17:42:17 +08:00
05f0db0a20
FIX: don't use `destroy_all` when `delete_all` is enough
2016-03-05 00:41:22 +01:00
c1aea91d63
FEATURE: More digest email frequency options. Digests can be sent as often as every 30 minutes.
2016-03-02 15:43:47 -05:00
f89e9024ba
FIX: Topic and Post may be `nil`.
2016-02-24 16:27:28 +08:00
e8d837269b
FEATURE: pending flags reminder is sent as a group message to staff instead of sending an email to the contact email site setting.
2016-02-19 15:21:18 -05:00
3de390c067
quote fields in case they are still in the db
2016-02-19 13:57:07 +11:00
f0e942f647
PERF: move 3 more option columns out of the user table
2016-02-18 16:57:22 +11:00
3829c78526
PERF: shift most user options out of the user table
...
As it stands we load up user records quite frequently on the topic pages,
this in turn pulls all the columns for the users being selected, just to
discard them after they are loaded
New structure keeps all options in a discrete table, this is better organised
and allows us to easily add more column without worrying about bloating the
user table
2016-02-17 18:08:25 +11:00
bf96025507
link email logs to the post that generate the email notification when available
2016-02-16 16:35:57 +01:00
4ad5660615
add slightly more logs when skipping email notifications
2016-02-15 17:53:07 +01:00
40b099f1a6
FIX: keep whitespaces when replacing direct link to external images with local images
2016-02-15 12:34:45 +01:00
06c9e79984
FIX: pending flags reminder email was ignoring the 'notify about flags after' site setting.
2016-02-12 14:33:23 -05:00
cad7fc1062
FIX: don't allow blocked user to send emails in
2016-02-11 10:39:57 +01:00
460665895c
properly name purge emails/email logs site settings
2016-02-08 22:18:52 +01:00
ac863bab91
FEATURE: new 'suppress_email_logs_after_days' site setting
2016-02-08 18:47:35 +01:00
62cd6a4122
Merge pull request #3995 from devonestes/reducing-duplication-csv-export
...
Reducing duplication and string allocation in Jobs::ExportCsvFile
2016-02-06 11:10:21 +01:00
ea0e63b150
FIX: handle cases where we only pass the notification type rather than the notification id when sending user email
2016-02-05 20:07:30 +01:00
0aa59956fa
Extract method refactoring in Jobs::ExportCsvFile
...
I was combing through some of the files with worse grades on Code Climate as a guide for places where I could jump in and help, and I saw this as one of the ones in need of some love. I reduced duplication in the #user_list_export method by extracting several methods that were common to both branches of the logic in that method.
2016-02-05 16:47:15 +01:00
eec8436cfe
FEATURE: filter admin reports via user group
2016-02-04 11:23:49 +05:30
7d992cb4c5
FIX: sending emails to mailing list subscribers wasn't working
2016-02-03 19:27:58 +01:00
Robin Ward
Guo Xiang Tan
Erick Guan
Régis Hanol
Arpit Jalan
Blake Erickson
Sam
Leo McArdle
Neil Lalonde
Andreas Motl
Kiril Staikov
Matt Palmer
James Kiesel
shakti katare
Devon Estes