acf262b631
Support for "no subcategories"
2013-12-16 13:06:35 -05:00
ccd0f9c371
add onpdiff tests
2013-12-16 18:39:49 +01:00
206ef3dc08
add discourse_diff tests
2013-12-16 18:11:46 +01:00
c6fb60e0a0
FIX: S3 upload when using dots in bucket name
2013-12-16 11:44:59 +01:00
d93e4fc65d
add more info to rss feeds
2013-12-15 01:17:39 -08:00
49c3482464
Show topic and post counts by day/week/month/year on categories page
2013-12-13 15:37:45 -05:00
06e9cbc6cb
FIX: Look up a url without the query string if it couldn't be found with it.
2013-12-13 12:56:20 -05:00
05a3c8090f
Merge pull request #1658 from salbertson/sa-refactor-users-controller-create
...
Refactor UsersController#create
2013-12-12 22:16:50 -08:00
1884bd959f
make sure extension-based oneboxes are first to run
2013-12-13 00:56:48 +01:00
1457a3792d
that fix should have been in the emoji plugin
2013-12-12 16:42:27 +01:00
be835785f8
FIX: allow new user to post emojis
2013-12-12 15:05:18 +01:00
06dd7ffe3c
better revision history
2013-12-12 03:41:34 +01:00
5171a23a9c
Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations.
2013-12-11 11:19:22 -05:00
ed3d3ae1e1
Upgrade font-awesome to version 4
2013-12-11 10:31:09 -05:00
6853f37bee
Show estimated reading time near summarize button.
2013-12-10 13:47:36 -05:00
561961eff6
FIX: can grant titles to regular users. Guardian initializer needs current_user, not the target user.
2013-12-10 12:46:35 -05:00
2596f7dec2
Revert "Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations."
2013-12-09 16:28:11 -05:00
ca5d4d5e54
Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations.
2013-12-09 13:28:42 -05:00
9a24d2651d
Allow category to auto-close topics in X hours instead of days. FIX: the system message that says a topic was automatically closed was only counting in days.
2013-12-06 16:39:35 -05:00
79427732b2
Show Gaps in the post stream when filters are active
...
Conflicts:
app/assets/javascripts/discourse/templates/topic.js.handlebars
2013-12-05 16:46:59 -05:00
51eff92170
Refactor UsersController#create
...
* Simplify controller action
* Extract service classes
2013-12-05 10:11:16 -08:00
abed146cc7
FIX: Category description topics shouldn't auto-close
2013-12-04 10:31:25 -05:00
9584ecb295
fixing gender sensitive pronouns
2013-12-03 10:19:54 +05:30
5150376e12
add wrapper class for lightboxes
2013-12-02 10:06:48 +01:00
1a2114d87d
Don't abuse as_json, it's not meant for consumption
...
The `as_json` API is a hook for JSON encoders to call, not meant for
consumption like this, and the result is not guarenteed to be stable
across Rails versions.
There might be other cases like this that we should revisit later, but
this one in particular is causing a test to fail on Rails master.
2013-11-29 21:58:09 -08:00
298b54c0e7
add download link in lightbox
2013-11-29 20:03:39 +01:00
8c8645f158
FIX: Code and Emoticon formatting in HTML emails.
2013-11-28 17:21:14 -05:00
4ec0543362
FIX: emails with embedded posts should always use absolute URLs
2013-11-28 15:57:21 -05:00
1cc72d564f
Add specs for topic create with auto_close_time. Just ignore auto_close_time from users who are not authorized to use it instead of raising an error.
2013-11-28 11:06:04 -05:00
52160179f8
add a tombstone for extra safety
2013-11-27 22:05:11 +01:00
a9ab98ef9e
Auto-close time can be entered in 3 ways, so a topic can close at any time
2013-11-27 09:52:35 -05:00
6b6c3d05dd
FIX stretched thumbnails
2013-11-25 18:36:13 +01:00
d208be14d2
FIX: Ruby 1.9.3 UTF-8 bug
2013-11-25 11:29:58 -05:00
82b78ec6ba
schemaless avatar urls
2013-11-22 19:18:45 +01:00
3cf5a363f7
do not destroy uploads when destroying a user
2013-11-22 18:29:07 +01:00
49b48e1eb6
ensure we have a bigint id
2013-11-22 17:51:36 +11:00
f65cde3cda
do not bump posts when rebaking
2013-11-22 01:52:26 +01:00
bcfbacec16
Don't show category descriptions as suggested topics
2013-11-21 16:43:22 -05:00
69cc1dd689
FIX: don't suggest a username that's already taken, even if hub finds a match
2013-11-20 14:56:21 -05:00
5055da76e6
Abort triggers for email body processing
2013-11-20 13:30:01 -05:00
31fd5b85bc
FIX markdown hotlinked images were not properly pulled
2013-11-20 13:10:08 +01:00
981d8f6aea
Signup form: prefill username if Discourse Hub has a match for the email address. Also, fix some bad specs in username_checker_service_spec that were passing...
2013-11-19 14:15:28 -05:00
ae58a7db95
Add a warning on dashboard if enforce_global_nicknames is checked, but access key is blank.
2013-11-18 13:45:10 -05:00
4ce81e1b01
Rename "Best Of" to "Summary"
2013-11-18 12:48:26 -05:00
ad3e276b4b
Rename TopicSummary -> TopicMap
2013-11-18 12:08:21 -05:00
639394e38a
FIX: Pinned topics within a category weren't working without a refresh
2013-11-18 10:52:01 -05:00
482b752046
add edit reason when editing a post
2013-11-15 23:28:49 +01:00
fc180ccd71
Site settings: move category into the opts hash so that it's compatibale with existing plugins
2013-11-15 14:32:33 -05:00
34bba737ff
Refactor SessionController#create, reduce complexity.
...
Don't compromise readablity
2013-11-15 22:09:03 +05:30
8a83f1a88f
add disk space usage failsafe
2013-11-15 16:48:38 +01:00
e03ae73c5d
Merge pull request #1653 from ScotterC/uri-addressable
...
URI adapter should use Addressable
2013-11-15 07:24:57 -08:00
16267e4887
add download_remote_images_to_local site setting
2013-11-15 15:22:18 +01:00
1e37abc310
Add site setting category support
2013-11-14 16:02:13 -05:00
791f5ac94e
Load site settings from config/site_settings.yml
2013-11-14 16:02:13 -05:00
968c0672ef
Enable column sorting main topic list
2013-11-14 15:50:36 -05:00
67041d1c6d
Support for tracking the count of unique participants in a topic
2013-11-14 14:32:41 -05:00
32e414690a
Handle ugly url targets
2013-11-14 13:14:02 -05:00
bda5a72c6a
Server side support for custom ordering of topics
2013-11-13 14:17:06 -05:00
7207cef7aa
TopicQuery cleanup in advance of custom sorting:
...
- Move SQL method constants into a module
- Removed unused count methods
- Moved methods that don't return a TopicList into Topic
- Replaced some confusing method signatures
2013-11-13 12:26:32 -05:00
77b59b54ce
Refactor UsersController#invited
...
* Add test coverage
* Simplify controller action
* Move finder code to Invite class
2013-11-11 13:23:49 -08:00
2f8866add5
Change admin display-row css so that multiple lines can fit in the control column. Don't hard-code a height on the rows.
2013-11-11 15:03:17 -05:00
d65cd0f97e
Merge pull request #1637 from railsaholic/refactor_users_upload_avatar_action
...
Refactor Users#upload_avatar method
2013-11-11 09:59:30 -08:00
58f78e9001
Refactor Users#upload_avatar method
...
Moved avatar file upload to ```AvatarUploadService``` class and
```AvatarUploadPolicy```
Address review comments + require missing file in spec
2013-11-11 23:21:14 +05:30
d1d661f6e1
add logic that auto closes any topics that missed the queued job (due to redis flush or whatever)
2013-11-11 10:52:44 +11:00
a9c5d843f7
remove problem spec that does not work properly in rails 4 mode into application controller and correct it
2013-11-11 10:50:48 +11:00
af67284995
User ctrl refactor - breaks up large methods, moves some logic into model
...
Includes missing methods from backup for travis to pass
fix missing code, failing specs
keep params handling in the controller.
2013-11-09 18:44:13 +05:30
6e43372e7c
Merge pull request #1610 from salbertson/sa-refactor-users-update
...
Move logic for updating a user to a service class
2013-11-07 12:29:19 -08:00
0c6f794eb0
Used the term suspended instead of banned.
2013-11-07 13:53:49 -05:00
72bfa4471f
Move logic for updating a user into a service class
2013-11-07 08:39:39 -08:00
948a545cb1
Category descriptions should not appear in digests
2013-11-06 15:05:06 -05:00
de30af9302
Support for inviting to a forum from a user's invite page.
2013-11-06 12:56:50 -05:00
8d47215ea5
Fixed Youtube videos appearing on top of compose panel (props to @hrobertson)
2013-11-06 17:19:02 +01:00
f8e2ecfa94
keep track of the user who revised a post
2013-11-06 11:43:40 +01:00
3992aa971d
ninja_edit_window is is seconds, not minutes
2013-11-06 11:08:57 +01:00
25ef66c60b
User invites page now has search, displays first `invites_shown` records
2013-11-05 17:53:26 -05:00
37fd7ab574
pull hotlinked images
2013-11-05 19:07:29 +01:00
415d4df648
work around bust encodings passed in to method
2013-11-05 13:40:39 +11:00
bd9b85f076
Screened Urls page shows results for each domain instead of each url
2013-11-04 16:24:48 -05:00
c86b06e3fa
Fix for non-english email polling.
2013-11-04 15:30:24 -05:00
ede59a4386
FIX: issue 1538. After upgrading and before a new version check request has been made, dashboard might still say that an update is available.
2013-11-04 12:51:09 -05:00
b474babe26
Merge pull request #1602 from salbertson/sa-refactor-users-update-specs
...
Refactor specs for UsersController#update
2013-11-04 07:16:18 -08:00
895d801669
Dont call `SiteSetting.uncategorized_category_id` twice
2013-11-03 15:36:59 +05:30
b56b11d96a
add qunit to autospec
2013-11-01 23:57:50 +01:00
e679ba97a3
FIX: categories created by users who are deleted cannot be deleted
2013-11-01 16:56:15 -04:00
c0cffca1e6
Test title updating
2013-11-01 13:43:31 -07:00
3cc17ad4cd
Add test coverage for #update
2013-11-01 13:43:31 -07:00
58f96bdfb5
Remove duplication in test setup
2013-11-01 13:43:31 -07:00
2e7696630b
Make #update specs consistent
...
* Use expect syntax
* Avoid lets
* Stub Guardian method used in the controller
2013-11-01 13:43:31 -07:00
92a0729937
When banning a user, a reason can be provided. The user will see this reason when trying to log in. Also log bans and unbans in the staff action logs.
2013-11-01 10:47:26 -04:00
52b0c1c45f
When logging the deletion of a user, don't store its id in the target_user_id column. It will never match a user record.
2013-11-01 10:47:26 -04:00
744cd93f28
FIX: Non-English category name regression
2013-10-31 16:25:26 -04:00
ce5ebc3eb5
On sites with login_required enabled, after signup, don't show the /login page again
2013-10-30 16:37:36 -04:00
704adc00ca
FIX: Broken test. No idea why the name randomly changed!
2013-10-30 16:04:26 -04:00
3d6d7c8abe
SiteSetting to hide regular names from users
2013-10-30 15:45:34 -04:00
c8d5db38d6
Emails to banned users will be sent for notifications of PMs from staff users
2013-10-30 15:31:16 -04:00
6063b52d6a
Support for choosing a destination category when splitting topics.
2013-10-29 15:30:06 -04:00
9650dbb97c
Refactor topics controller
...
Refactor: 1) TopicsController to reduce code climate complexity.
2) Topic model, addressed comments
fix typo
2013-10-28 11:42:07 +05:30
95e936c299
cleanup API for looking up a user by email or username, add specs, fix invalid auto association in open id provider
2013-10-28 16:29:07 +11:00
370e961a90
add failing test for AMS upgrade
2013-10-28 15:55:27 +11:00
f4d9bf9181
Merge pull request #1573 from railsaholic/use_existing_find_by_username_or_email
...
Utilize already existing method 'find_by_username_or_email'
2013-10-25 12:57:18 -07:00
4e46d91b8d
Refactor SpamRulesEnforcer so that each spam rule is in its own class
2013-10-25 13:25:02 -04:00
4929c5db71
FIX: when allow_uncategorized_topics was false, PMs can not be created
2013-10-25 09:33:39 +11:00
96ae3cdacc
Utilize already existing method 'find_by_username_or_email'
...
check presence of email using include, dont use =~
2013-10-24 19:26:06 +05:30
cc83b55134
fix incorrect test, that fails if shared test state gets corrupt
2013-10-24 14:55:55 +11:00
666264879c
change it so all topics MUST include a category, we store a special uncategorized category to compensate
...
this cleans up a bunch of internals and removes some settings
2013-10-24 12:08:02 +11:00
8aab2253d0
Whitelisted ip addresses will not be flagged as spam by flag_sockpuppets
2013-10-23 17:11:35 -04:00
541620c115
Routes and support for sub-categories
2013-10-23 15:22:49 -04:00
c814fc16a3
Database structure to support sub categories
2013-10-23 15:22:49 -04:00
f73a64982a
Raise an error if a `api_username` is supplied and does not match the key
2013-10-23 11:05:49 -04:00
e2a5415aca
fix #1567 ; nil reference in spam_rules_enforcer.rb
2013-10-22 19:14:31 -06:00
c1008f4359
Fixes for postgresql inet columns in Rails 4. They're backed by an IPAddr class now, which breaks sql parameter marker support, and automatically sets the attribute to nil when trying to assign an invalid ip address.
2013-10-22 19:19:32 -04:00
348e2e3ef2
Support for per-user API keys
2013-10-22 17:34:39 -04:00
7d582fbee3
Screened ip address can be edited, deleted, and changed to allow or block.
2013-10-22 16:30:46 -04:00
9b2f821012
Merge pull request #1512 from ScotterC/avatar-from-url
...
Build out a URI Adapter to allow uploading an avatar via a url
2013-10-21 13:17:37 -07:00
2308784713
Merge pull request #1543 from railsaholic/small_users_controller_refactoring
...
refactor UsersController to reduce complexity
2013-10-21 12:21:03 -07:00
cbef844a57
Build out a URI Adapter to allow uploading an avatar via a url
...
Currently only really accessible via the API. The UriAdapter creates a
tempfile from a url and gives a ActionDispatch::HTTP::UploadedFile back
to the controller to process as normal.
This will help a lot in being able to transfer avatar urls from another
app without monkey patching a lot of discourse code.
2013-10-21 14:53:03 -04:00
648b11a0eb
Add screening by IP address. When deleting a user as a spammer, block all signups from the same IP address.
2013-10-21 14:50:18 -04:00
fcd85b8a72
allow plugins to be symlinked
2013-10-21 19:59:28 +02:00
451a1620f9
Merge pull request #1545 from railsaholic/lists_controller_refactor
...
Remove duplication of action defintion
2013-10-20 22:19:40 -07:00
31b73171dc
correct ordering algorithm
2013-10-21 16:14:09 +11:00
7dfa99998f
Remove duplication of action defintion, add missing spec for topics_by, extract out URL construction logic
2013-10-21 08:34:18 +05:30
25723de9c8
no need for the undefine
2013-10-21 09:52:28 +11:00
868e4ffe6d
refactor UsersController to reduce complexity
...
Refactored: UsersController#create
2013-10-19 15:18:11 +05:30
d7182d0b14
FIX: Only wrap inline html tags in <p>
2013-10-18 15:21:05 -04:00
5f74cb6bf9
category is not "positionable"
2013-10-18 18:09:30 +11:00
1ee49798b2
work in progress wide category list
2013-10-18 11:10:10 +11:00
7bf96ee690
naive implementation of post_count on categories
2013-10-18 11:10:10 +11:00
0a4f5af4a8
Merge pull request #1531 from railsaholic/topics_model_refactoring
...
Refactored Topic#limit_topics_per_day to improve Code Climate Complexity
2013-10-17 06:56:41 -07:00
1b81f73325
logged in requests were being treated as anon, causing major havoc
2013-10-17 10:37:18 +11:00
cabe8f0d2d
Clean up ScreenUrl normalization and matching
2013-10-16 16:39:29 -04:00
2a8db38c7a
FIX: Smoke test failure
2013-10-16 16:01:41 -04:00
f27413219e
Support for MDTest
2013-10-16 10:28:42 -04:00
7c03076c2a
Refactored Topic#limit_topics_per_day to reduce code climate complexity
...
Extracted 1) #apply_per_day_rate_limit_for, method as generic
RateLimiter , 2) #limit_first_day_topics_per_day as a separate method,
3) Added User#added_a_day_ago?, 4) Fixed private methods indentation.
2013-10-16 14:58:18 +05:30
3d647a4b41
remove rack cache, it has been causing trouble
...
instead implement an aggressive anonymous cache that is stored in redis
this cache is sitting in the front of the middleware stack enabled only in production
TODO: expire it more intelligently when stuff is created
2013-10-16 16:39:18 +11:00
b62913695c
Merge pull request #1528 from JEG2/master
...
Adding post details in preparation for the API importer code.
2013-10-15 08:19:19 -07:00
5281b7f80c
Upgraded and refactored Sanitizing. Much less crap should get through now!
...
Conflicts:
app/assets/javascripts/discourse/components/syntax_highlighting.js
2013-10-15 10:53:11 -04:00
1aa9fc982d
Adding post details in preparation for the API importer code.
2013-10-15 09:21:30 -05:00
4536b5fe04
added a job to clean up orphan uploads
2013-10-15 11:15:48 +02:00
d80f4fa3f7
Merge pull request #1523 from dbarbera/avatar_formats_fix
...
add image authorization on upload_avatar
2013-10-14 05:33:25 -07:00
7df4e4afb9
security fix, anon should not be treated as though they can create anything
2013-10-13 09:54:48 +11:00
9106596a9a
add image authorization on upload_avatar
2013-10-12 14:11:44 +02:00
23bf4436f5
FIX: avatar was attached to the user who uploaded it...
2013-10-12 10:55:41 +02:00
af931f0444
Reverting the Sanitizer commit in case we have to do something urgent
...
before we deploy it early next week. It's in the branch `sanitizer` for
now.
This reverts commit 9e93d8ed52
2013-10-11 16:44:26 -04:00
9e93d8ed52
Upgraded and refactored Sanitizing. Much less crap should get through now!
...
Conflicts:
app/assets/javascripts/discourse/components/syntax_highlighting.js
2013-10-11 16:25:40 -04:00
3c2c6ab24b
Add sockpuppet spammer detection. Automatically flag posts if they are from new users (registered less than 24 hours ago) at the same IP address and one of them started the topic.
2013-10-11 13:34:05 -04:00
c38ba8acdd
add rss links to anonymous homepages
2013-10-11 18:43:29 +02:00
172a85ae14
prettier twitter links, extracted mini api
2013-10-11 11:46:35 +11:00
b0465c517e
(experimental) added framework for filtering all sorts of internals in discourse and consuming by plugins
2013-10-10 18:45:40 +11:00
ad2ed5fe51
rate limits for topics and posts on first day
...
max_topics_in_first_day and max_replies_in_first_day
2013-10-10 10:32:03 +11:00
7993845bfa
add current_user_provider so people can override current_user bevior cleanly, see
...
http://meta.discourse.org/t/amending-current-user-logic-in-discourse/10278
2013-10-09 15:11:54 +11:00
Robin Ward
Régis Hanol
Alexander
Neil Lalonde
Sam
Scott Albertson
Jithu Gopal
Godfrey Chan
railsaholic
Scott Carleton
sirMackk
Vipul A M
Brian Alexander
James Edward Gray II
dbarbera