Commit Graph

473 Commits

Author SHA1 Message Date
Guo Xiang Tan 5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
Sam Saffron 045a2abcec FEATURE: remove the timecop gem
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
Robin Ward 2f480e21a0 Stop using Babel source gem, which is no longer updated 2017-07-05 14:19:16 -04:00
Sam 234694b50f Feature: CommonMark support
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it

As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.

This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
2017-06-23 12:01:33 -04:00
Sam 2181e995f1 remove sinatra 2017-06-19 13:49:11 -04:00
Guo Xiang Tan d82dbd565b FIX: Remove dependency on `rest-client`. 2017-06-16 09:42:41 +09:00
Régis Hanol 5d63a7f4a6 FIX: pull hotlinked images even when they have no extension 2017-06-13 13:27:05 +02:00
Robin Ward 369bb78f8e FIX: Support for cookies in onebox redirects 2017-06-06 15:02:11 -04:00
Gerhard Schlager 8299e7e8c3
Add new, experimental version of mbox importer 2017-05-29 20:59:18 +02:00
Sam 3384a7dd2a proper bootsnap release 2017-05-26 13:26:45 -04:00
Sam 076f079d17 bootsnap upgrade
see: https://github.com/Shopify/bootsnap/pull/43#issuecomment-304281474
2017-05-26 09:37:18 -04:00
Robin Ward 29755be139 Remove bundle-audit, it is not updated frequently enough 2017-05-18 12:31:19 -04:00
Robin Ward e865a44b93 FIX: Forgot to lock gem 2017-05-15 13:35:28 -04:00
Robin Ward e6c6ea79fa Add bundle-audit for security auditing 2017-05-15 13:24:37 -04:00
Sam 704101253d add bootsnap to speed up test and dev 2017-05-11 13:51:38 -04:00
Régis Hanol 9641d2413d REFACTOR: upload workflow creation into UploadCreator
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
Régis Hanol 4b9cc1ad17 import likes & bookmarks in JIVE API importer 2017-05-03 16:00:23 +02:00
Guo Xiang Tan b00886f5c1 Remove sidekiq-statistic gem.
* We don't really use it and there is an on-going issue
  with the gem not expiring keys in a Redis list which
  hasn't been fully resolved.

  https://github.com/davydovanton/sidekiq-statistic/issues/73
2017-04-26 14:54:47 +08:00
Sam Saffron 587653ad73 remove bootsnap till we sort out linux 2017-04-25 14:55:18 -07:00
Sam Saffron 1ae67a21f5 FEATURE: add support for bootsnap in dev
To use bootsnap which speeds up rails boot add

BOOTSNAP=1 to your env
2017-04-25 10:15:12 -07:00
Régis Hanol e6f22725c8 Add some gems only used by imports 2017-04-24 22:59:41 +02:00
Guo Xiang Tan d7b446c174 Install `discourse_image_optim` gem for now. 2017-04-20 15:14:39 +08:00
Guo Xiang Tan 04016f0dec Support Ruby 2.4. 2017-04-15 12:29:00 +08:00
Sam 22214f5e5c Upgrade the Listen gem 2017-04-13 10:39:36 -04:00
Sam a3e8c3cd7b FEATURE: Native theme support
This feature introduces the concept of themes. Themes are an evolution
of site customizations.

Themes introduce two very big conceptual changes:

- A theme may include other "child themes", children can include grand
children and so on.

- A theme may specify a color scheme

The change does away with the idea of "enabled" color schemes.

It also adds a bunch of big niceties like

- You can source a theme from a git repo

- History for themes is much improved

- You can only have a single enabled theme. Themes can be selected by
    users, if you opt for it.

On a technical level this change comes with a whole bunch of goodies

- All CSS is now compiled using a custom pipeline that uses libsass
    see /lib/stylesheet

- There is a single pipeline for css compilation (in the past we used
    one for customizations and another one for the rest of the app

- The stylesheet pipeline is now divorced of sprockets, there is no
   reliance on sprockets for CSS bundling

- CSS is generated with source maps everywhere (including themes) this
    makes debugging much easier

- Our "live reloader" is smarter and avoid a flash of unstyled content
   we run a file watcher in "puma" in dev so you no longer need to run
   rake autospec to watch for CSS changes
2017-04-12 10:53:49 -04:00
Guo Xiang Tan 4cb6880766 Upgrade image_optim. 2017-04-12 10:38:17 -04:00
Guo Xiang Tan 9f299b6842 Use `after_commit` since `after_save` runs within the transaction as well. 2017-03-16 16:02:34 +08:00
Guo Xiang Tan 89f056203e Don't load `thor` in our Rails processes. 2017-03-03 10:14:35 +08:00
Robin Ward 890f1bde89 FIX: Add `thor` to Gemfile. We need it for our CLI tool. 2017-03-02 13:36:06 -05:00
Sam Saffron 1a45fe94a2 drop thin, it is no longer supported 2017-01-20 08:11:36 -05:00
Guo Xiang Tan b5d65d8dda Remove lines that are no longer valid. 2017-01-13 09:51:09 +08:00
Robin Ward 6b4f265a8c Revert "Experimental feature to load gemfiles from plugins"
This reverts commit 64652f98ab.
2017-01-09 16:08:35 -05:00
Robin Ward 64652f98ab Experimental feature to load gemfiles from plugins 2017-01-09 12:49:55 -05:00
Sam Saffron 920050c3ec remove conditional support for ruby 2.0 2016-12-29 16:32:23 +11:00
Sam c531f4ded5 remove rails-observers
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.

For example: if we want to upgrade to rails 5 there is no published gem

Internally the usage of observers had quite a few problem.

The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam ea9f7a41af remove gctools (no longer used) add gctracer for debugging 2016-12-20 15:07:30 +11:00
Robin Ward e03d5e2140 Reapply Ember 2.10 for good this time!
This reverts commit ddd299f4aa.
2016-12-19 11:19:10 -05:00
Robin Ward ddd299f4aa Revert "Revert "Revert Ember 2.10+ for a short while""
This reverts commit 76bbc481cb.
2016-12-16 10:29:30 -05:00
Robin Ward 76bbc481cb Revert "Revert Ember 2.10+ for a short while"
This reverts commit 21682fd60b.
2016-12-16 09:52:29 -05:00
Robin Ward 21682fd60b Revert Ember 2.10+ for a short while 2016-12-15 16:43:38 -05:00
Robin Ward a149913c4d FIX: Template compilation was broken 2016-12-15 10:28:15 -05:00
Robin Ward 28699e66d8 Revert "REVERT: Ember 2.10 -- it's not building properly"
This reverts commit 600541c623.
2016-12-15 10:28:15 -05:00
Guo Xiang Tan 18f400e652 Remove RSpec given. 2016-12-14 10:29:22 +08:00
Robin Ward 600541c623 REVERT: Ember 2.10 -- it's not building properly 2016-12-12 16:19:05 -05:00
Robin Ward a808bcb0b8 Upgrade to Ember 2.10 2016-12-12 14:44:29 -05:00
Robin Ward 765e5e9186 Upgrade to Ember 2.9 2016-12-12 14:44:29 -05:00
Robin Ward 2d3518f475 Enable newer version of Ember 2016-11-25 10:09:58 -05:00
Régis Hanol 343396e182 bump email_reply_trimmer 2016-11-17 23:33:16 +01:00
Régis Hanol 17f2be9f88 FEATURE: new 'enable_forwarded_email' site setting 2016-11-16 19:42:11 +01:00
Guo Xiang Tan 3277fb1c78 Remove unused gem. 2016-11-04 08:30:49 +08:00
Guo Xiang Tan b825a6bc7f Move timecop to test group. 2016-11-03 17:17:45 +08:00
Sam a6ad762189 Revert "why are we loading all these test gems in debug?"
This reverts commit bd4f07b721.
2016-10-19 14:30:43 +11:00
Sam bd4f07b721 why are we loading all these test gems in debug? 2016-10-19 14:29:58 +11:00
Régis Hanol 726eb7bdca bump email_reply_trimmer to latest version 2016-10-12 19:57:05 +02:00
Sam 473363e0fa only enable bullet on demand 2016-07-05 11:10:42 +10:00
Guo Xiang Tan 9ed79d8ecd
Add Bullet gem to detect N+1 queries. 2016-06-28 09:29:42 +08:00
Sam 7f78cf3f1a update message bus to release gem 2016-06-21 10:10:54 +10:00
Régis Hanol 5e2545a578 FEATURE: improve support for (whitelisted) SVGs as images 2016-06-20 10:22:13 +02:00
Sam b9c92a1678 update nokogiri to released version 2016-06-07 16:51:39 +10:00
Régis Hanol 11e303e278 update discourse_fastimage to latest (add support for SVG with doctype) 2016-06-06 17:11:16 +02:00
Guo Xiang Tan cb5be1fe8f
Upgrade rspec to 3.4.0. 2016-05-30 11:38:38 +08:00
Sam f06266f31e execjs 2.7 was just released to support mini_racer 2016-05-23 09:57:37 +10:00
Sam 695773db1c FEATURE: upgrade from therubyracer to mini_racer
This pushes our internal V8 JavaScript engine from Chrome 32 to 50.

It also resolves some long standing issues we had with the old wrapper.
2016-05-23 09:57:15 +10:00
Sam 75d8e6f1ec We need latest nokogiri so it compiles with Ruby 2.3.1 2016-05-17 16:12:06 +10:00
Sam a13b48e001 upgrade profiling gems 2016-05-13 18:30:03 +10:00
Sam Saffron fb513fc936 another messagebus upgrade to work around rubygems bug 2016-05-11 12:01:00 +10:00
Sam Saffron d0b9b69cba FIX: message_bus upgrade to correct CORS issue 2016-05-11 10:42:34 +10:00
Régis Hanol df14926e42 SECURITY: check magic bytes before using ImageMagick tools 2016-05-03 21:54:07 +02:00
Guo Xiang Tan 44868c9e77
Update message_bus. 2016-05-03 13:37:35 +08:00
Guo Xiang Tan 256d7a00e9 Update sprockets. (#4167)
* Update sass-rails.

* FIX: Tilt dependency has been removed from Ember::Handlebars::Template.

* Update `DiscourseIIFE` to new Sprockets API.

* `Rails.application.assets` returns `nil` in production.

* Move sprockets-rails out of the assets group.

* Pin ember-rails to 0.18.5 which works with Sprockets 3.x.

* Update sprockets to 3.6.0.

* Make `DiscourseSassCompiler` work with Sprockets 3.

* Use `Sass::Rails::SassImporterGlobbing` instead of haxxing our own.

* Moneky patch so that we don't add dependencies for our custom css.

* FIX: Missing class.

* Upgrade ember-handlebars-template.

* FIX: require path needs to share the same root as the folder's path.

* Bump discourse-qunit-rails.

* Update ember-template-compiler.js to 1.12.2.

* `prepend` is private in Ruby 2.0.0.
2016-04-18 10:47:52 +08:00
Régis Hanol 59a2720b2a update email_reply_trimmer 2016-03-31 19:06:36 +02:00
Régis Hanol 480e8d0dc7 update 'email_reply_trimmer' to latest version 2016-03-29 12:35:50 +02:00
Sam 963d558bee update message bus 2016-03-11 14:17:06 +11:00
Régis Hanol 6e3dcdeea1 update email_reply_trimmer to latest 2016-03-07 19:17:14 +01:00
Sam fe6ea48123 Merge pull request #4038 from markbiegel/instagram-login
FEATURE: Instagram OmniAuth login methods
2016-03-07 14:05:07 +11:00
Sam Saffron 7598037080 Only pull in gem if it is being used, remove middleware 2016-03-04 23:17:14 +11:00
Régis Hanol 1135d2094a Merge pull request #4006 from scossar/set-locale-from-header
Feature: (WIP) Set locale from Accept-Language header
2016-03-04 09:12:30 +01:00
Sam 5dd746d61f Upgrade message bus to latest 2016-02-29 10:54:40 +11:00
scossar 0a396583ed set locale for anonymous from header
set locale on signup

update spec

add locale option
2016-02-26 13:45:00 -08:00
Ubuntu 5c603bf8ec Added Instagram login method 2016-02-25 12:13:59 +10:00
Régis Hanol 3b9223c5da bump email_reply_trimmer to latest version 2016-02-18 16:56:45 +01:00
Régis Hanol 1beb6070aa update email_reply_trimmer to latest version 2016-02-08 18:29:49 +01:00
Régis Hanol e8969b0c34 use bug-free version of email_reply_trimmer gem 2016-02-04 17:06:12 +01:00
Régis Hanol 5ee845fc5f update email_reply_trimmer to latest version 2016-02-04 16:39:57 +01:00
Régis Hanol 46b6c55197 FIX: replace 'discourse_email_parser' with 'email_reply_trimmer' to better trim replies from plain text emails
FIX: undefined method `number_to_human_size' when email contains attachments
2016-01-30 01:29:31 +01:00
Guo Xiang Tan 9b9f0ab4af Upgrade omniauth-google-oauth2. 2016-01-29 23:14:51 +08:00
Guo Xiang Tan 0e73660c8d Remove addressable from Discourse. 2016-01-25 18:34:58 +08:00
Robin Ward 4bbbdd8dc4 SECURITY: Upgrade Ember to fix CVE-2015-7565. Also upgrade Handlebars 2016-01-15 13:57:45 -05:00
Robin Ward 7a28338a07 Revert "SECURITY: Upgrade Ember to fix CVE-2015-7565"
This reverts commit 211521df4f.
2016-01-15 11:39:07 -05:00
Robin Ward 211521df4f SECURITY: Upgrade Ember to fix CVE-2015-7565 2016-01-15 11:31:02 -05:00
Sam Saffron 38c63c2185 update google oauth
early versions are not working with omniauth so we are stuck with this and addressable
2016-01-11 23:48:31 +11:00
Sam Saffron da25502bed downgrade google omniauth 2016-01-11 23:29:01 +11:00
Sam Saffron 61650edfd4 big gem update 2016-01-11 18:17:13 +11:00
Sam eaab27325d upgrade message_bus, had stray console.log :( 2016-01-06 20:20:23 +11:00
Sam Saffron 93855db158 FEATURE: upgrade message_bus
New version has support for chunked encoding, this cuts down
significantly on network usage when lots of messages are sent

We no longer have to re-establish a connection after we get a message,
 we simply reuse.
2016-01-05 21:39:25 +11:00
Sam Saffron 426299d261 FEATURE: upgrade to Sidekiq 4 2016-01-01 15:40:31 +11:00
Sam af91d6f35b Revert "FEATURE: upgrade sidekiq to version 4.0"
This reverts commit af93a1d94c.

We need to wait a bit to clean up our internal API usage.
2015-12-31 16:35:02 +11:00
Sam af93a1d94c FEATURE: upgrade sidekiq to version 4.0 2015-12-31 16:14:58 +11:00
Sam 0fdac4fc42 Update Gemfile
fix for certain bundlers
2015-12-28 22:32:45 +11:00
Guo Xiang Tan ba29bba987 Add Ruby 2.3 platform to profiling tools in Gemfile. 2015-12-28 09:53:52 +08:00
Sam f3e24bac4f we need spork rails to run our specs 2015-12-21 16:47:42 +11:00
Sam 2e6af399a8 update rails, remove spork 2015-12-21 16:39:15 +11:00
Sam 950b69cfb0 Prepare for Rails 5, don't simply include Rails be explicit 2015-12-21 16:15:30 +11:00
Arpit Jalan 553248de86 FEATURE: new gem discourse_email_parser 2015-12-11 01:02:28 +05:30
Arpit Jalan 7a8e5a50ff FEATURE: better email reply parsing 2015-12-09 23:47:01 +05:30
Robin Ward 434deb1bd3 SECURITY: Backported XSS fixes from Handlebars 2015-11-24 16:08:08 -05:00
kerryliu b7803fc68e FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-11-05 18:51:26 -08:00
Sam a27abf5ce7 we got our gem back! 2015-10-13 15:17:40 +11:00
Sam cf52671feb stop vendoring rails multisite 2015-10-12 17:26:20 +11:00
Gerhard Schlager 8b3b14a704 Disable byebug when RubyMine is used for debugging
Debugger in RubyMine doesn't work well with byebug.
For example, debugging Sidekiq jobs doesn't work when byebug is loaded.
2015-10-09 21:51:47 +02:00
Sam ffb8cb8cac FEATURE: remove dependency of Redcarpet
PERF: cache fancy_title in topics table

New pure ruby implementation is far more flexible and easier to amend.
2015-09-24 13:37:53 +10:00
Sam 613761d1cd FEATURE: upgrade to Rails 4.2.4 2015-09-23 15:24:30 +10:00
Sam cd8d82aa31 correct file size and add note about impending breakage of image_optim 2015-09-10 14:37:46 +10:00
Anton Davydov b97764554b Add plugin for displaying sidekiq statistic in web ui 2015-09-03 01:24:02 +03:00
Régis Hanol 1b44924cb0 replace 'open_uri_redirections' gem with a single freedom_patches file 2015-08-18 14:56:36 +02:00
Régis Hanol a3e76dc193 FIX: allow HTTP <-> HTTPS redirections when downloading images 2015-08-17 19:21:30 +02:00
Guo Xiang Tan 8cdc302d74 DEV: Add byebug. 2015-08-14 15:09:51 +08:00
Sam a269366886 update gemfile to match gem lock 2015-08-14 09:30:18 +10:00
camelmasa f2b3312ee2 Remove actionpack-action_caching gem from Gemfile
Discourse is not using the gem.
2015-06-10 20:12:42 +09:00
Sam 2c3062548b FEATURE: upgrade image compression gem 2015-05-29 12:39:55 +10:00
Sam f079dd63ed PERF: remove "fog" dependency 2015-05-25 17:57:06 +10:00
Sam ff55bcb4d0 eventmachine is no longer a strong dependency 2015-05-25 12:45:08 +10:00
Robin Ward 01d4085125 Removed bad JS tests, upgrade QUnit + ember-qunit 2015-05-13 14:13:37 -04:00
Robin Ward d9e5302a16 FIX: HTMLBars compilation was broken in production mode 2015-05-11 11:20:46 -04:00
Erick Guan b772ff6e13 FEATURE: add slug geneartion options 2015-05-05 18:08:30 +08:00
Arthur Neves 25e28a1bdd
Add rails42 and remove bundler patch 2015-04-28 23:20:07 -04:00
Godfrey Chan 0887f33d77
Bump to sass-rails 4.0.5 for Rails 4.2 support 2015-04-28 23:19:45 -04:00
Godfrey Chan 233f56b6aa
AMS 0.8.3 was released with the patch we want 2015-04-28 23:15:26 -04:00
Godfrey Chan fd5b0bb26b
Remove support for bundler < 1.5 2015-04-28 23:15:26 -04:00
Sam 4eaee8f611 Merge pull request #3377 from scossar/auto-rtl
Auto rtl
2015-04-28 07:58:35 +10:00
Sam 0f6d9f749c Merge pull request #3397 from zzakcanncode/bumprails41
Bump rails to latest patch 4.1 release. (4.1.10)
2015-04-28 07:52:48 +10:00
Sam 531fd97957 Merge pull request #3398 from zzakcanncode/bump_observers
Bump rails-observers to master version.
2015-04-28 07:51:45 +10:00
Arthur Neves f84541b1ba
Update rspec to rspec 3.2.0 2015-04-25 18:29:43 -04:00
Arthur Neves a9b2483277
Bump rails-observers to master version.
876c522184
Has the patched applied on SamSaffron/rails-observers.
2015-04-24 16:38:48 -04:00
Arthur Neves e6655e7d7e
Bump rails to latest patch 4.1 release. (4.1.10)
We should be using the latest patch release of the current supported
version.
Also this adds a more explicit version of rails on the Gemfile. This is
will help to test on rails 4.2 and master.
2015-04-24 15:36:46 -04:00
Sam Saffron fdb434f4a7 correct previous commit 2015-04-16 16:16:15 +10:00
Sam Saffron b2c30d0e34 Revert "travis likes old bundler"
This reverts commit 1adda31cbc.
2015-04-16 16:15:04 +10:00
Sam Saffron 1adda31cbc travis likes old bundler 2015-04-16 16:13:48 +10:00
Sam Saffron 9baebcaf03 Use stackprof and memory_profiler under ruby 2.2 2015-04-16 15:55:21 +10:00
Simon Cossar 0ed67e919c Add r2 gem for rtl stylesheet conversion 2015-04-14 18:53:02 -07:00
Robin Ward 4691fe35b3 FIX: 6to5 was renamed to Babel
I can't believe they just pulled the old gem and broke people deploying
our site to production. I get it, your name changed, but don't break
other people's apps with no deprecations.
2015-03-05 13:08:32 -05:00
Sam 0b7c92166c upgrade pg, appears to be false positive 2015-02-15 08:27:35 +11:00
Sam cd0fa12562 FIX: downgrade pg to stop memory leak 2015-02-13 10:10:15 +11:00
Sam c5fde808cf PERF: remove addressable gem, its consuming huge amount of memory 2015-02-11 14:30:12 +11:00
Robin Ward a65e0a80ba Add support for more ES6 features 2015-02-06 13:26:33 -05:00
Sam e089f699c1 upgrade pg to version 0.18, may fix encoding issue 2015-01-06 06:16:22 +11:00
jaanus f6026ad1d0 Added eu-central-1 S3 bucket. 2014-12-29 18:31:21 +02:00
Régis Hanol 5ac0fd019e Merge pull request #3059 from simi/patch-1
Fix typo in Gemfile
2014-12-29 12:40:33 +01:00
Sam ef62933034 Ruby 2.2 fixes 2014-12-29 13:31:15 +11:00
Josef Šimánek 6d770d0e6e Fix typo in Gemfile
[ci skip]
2014-12-27 14:03:48 +01:00