Sam
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
Sam
f5142861e5
Revert "Revert "FIX: upload URLs from S3 on subfolder installs""
...
This reverts commit 26c96e97e5
.
We have no choice but to run this code
2018-08-22 11:31:33 +10:00
Sam
26c96e97e5
Revert "FIX: upload URLs from S3 on subfolder installs"
...
This reverts commit 357df2ff4f
.
2018-08-22 10:51:40 +10:00
Neil Lalonde
357df2ff4f
FIX: upload URLs from S3 on subfolder installs
2018-08-21 14:58:55 -04:00
Gerhard Schlager
17dc8f2490
UX: Wizard resends activation email when user exists
2018-08-21 19:13:41 +02:00
Régis Hanol
d1607a387a
FIX: only allow printable characters in uploads filename
2018-08-21 18:11:01 +02:00
Régis Hanol
3e436e2daf
FIX: doesn't translate group permission keys
2018-08-21 12:56:56 +02:00
Kyle Zhao
baf413d527
FIX: update TopicEmbed's title and user correctly
2018-08-21 18:31:01 +08:00
Guo Xiang Tan
7dcc69aef4
DEV: Refactor test to not call private method.
2018-08-21 14:29:58 +08:00
Guo Xiang Tan
48f499b324
DEV: Refactor some mail receiver related specs.
2018-08-21 14:00:45 +08:00
Guo Xiang Tan
d104de2a09
Remove line that is no longer required.
2018-08-21 11:48:58 +08:00
Guo Xiang Tan
8bdf14834b
PERF: Restrict number of skipped email log for `Jobs::UserEmail`.
2018-08-21 11:14:43 +08:00
Guo Xiang Tan
2c70d3f443
Take 2 on ba6f11c521
.
2018-08-21 10:06:36 +08:00
Sam
2d96160192
FEATURE: improve API error reporting for invalid records
2018-08-21 11:54:34 +10:00
Bianca Nenciu
860c1c3dcd
FEATURE: Automatically expire keys if not used for a configurable amount of time. ( #6264 )
2018-08-20 17:36:14 +02:00
Gerhard Schlager
14af90df5b
UX: Stop putting usernames in edit reason when changing post owner
2018-08-20 12:28:04 +02:00
Guo Xiang Tan
b4f92a05b3
FIX: Load more on groups page does not account for params.
...
https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259
2018-08-20 17:08:50 +08:00
Sam
f5fe58384f
correct regression around file renaming
2018-08-20 16:08:05 +10:00
Sam
ce4b12ae59
FIX: if we have not target available do not redirect
2018-08-20 13:10:59 +10:00
Sam
d7b1919ead
correct specs
2018-08-20 12:46:14 +10:00
Sam
8b5e42ea16
FIX: always test and coerce to image on upload
...
In the past the filename of the origin was used as the source
for the extension of the file when optimizing on upload.
We now use the actual calculated extension based on upload data.
2018-08-20 12:18:59 +10:00
Bianca Nenciu
975a72ab7a
FEATURE: Make links indexable. ( #6285 )
2018-08-20 10:39:19 +10:00
Robin Ward
a83f662492
FIX: Allow silenced users to like / bookmark, just not flag.
2018-08-17 11:06:18 -04:00
Guo Xiang Tan
010fe479cb
Fix linting.
2018-08-17 17:34:25 +08:00
Guo Xiang Tan
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
Guo Xiang Tan
a26ef7738f
FIX: `FileHelper#download` should return nil if max size is exceeded.
2018-08-17 16:19:59 +08:00
Guo Xiang Tan
4b7c5ba162
Update `UploadCreator` specs to include cropping code path.
2018-08-17 15:22:12 +08:00
Guo Xiang Tan
fae8757cd4
FIX: `Guardian#post_can_act?` shouldn't raise an error if user of post has been deleted.
2018-08-17 15:11:30 +08:00
Guo Xiang Tan
a9e502936f
FIX: Converting PNG to JPEG does not set the correct extension.
2018-08-17 13:09:48 +08:00
Régis Hanol
93201d8dbe
FIX: don't trigger 'flag_reviewed' when no flags were reviewed
2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX
10a3499d68
uses emoji versions for specs ( #6276 )
2018-08-16 13:45:30 +02:00
Sam
f62073a22a
correct regression uploading images
2018-08-16 18:49:08 +10:00
Gerhard Schlager
937ab3f213
FIX: Validation of min_posts and max_posts didn't work
2018-08-16 10:36:53 +02:00
Sam
796164b58c
FIX: automatically correct bad avatars on access
...
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
Sam
243fc9d0f9
FIX: refreshing auto groups when min_username_length is long
2018-08-15 16:59:56 +10:00
Sam
38c10a3dc2
correct the validator
2018-08-15 14:56:24 +10:00
Sam
91e0a77a60
FEATURE: silenced users should not be allowed to edit posts
2018-08-15 14:29:36 +10:00
Misaka 0x4e21
d4fd19d49a
UX: Replace Google search with Discourse search on not found page
...
* UX: Replace Google search with Discourse search on not found page.
* FIX: Update application_controller_spec.rb.
2018-08-15 11:53:04 +10:00
Sam
06f82a7d72
correct exception handling, always do to_i in array
2018-08-15 11:31:42 +10:00
Sam
bc47148d35
add validation to exclude_category_ids
2018-08-15 09:53:28 +10:00
Régis Hanol
12bab65167
FIX: going from /categories to /latest on mobile might break infinite scrolling
2018-08-15 01:22:03 +02:00
Gerhard Schlager
ba0e322fd0
FIX: Validation of topic params broke discourse-assign
2018-08-14 18:45:46 +02:00
Robin Ward
87fa26b6c8
FIX: Silenced users shouldn't be able to act on posts
2018-08-14 11:43:39 -04:00
Gerhard Schlager
c358421ca5
FIX: Bulk updating category failed when topic title was too short
2018-08-14 16:37:52 +02:00
Gerhard Schlager
216f4c99b0
Correct flaky spec
2018-08-14 12:43:57 +02:00
Régis Hanol
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
Sam
ad5f502332
FIX: add a basic validator for topic params
...
This cuts down on log noise when people try out sql injection
2018-08-14 17:01:04 +10:00
Guo Xiang Tan
664186a2a4
DEV: Remove stub to make test more reliable.
2018-08-13 14:48:46 +08:00
Guo Xiang Tan
d10c9d7d75
FIX: Missing extensions for non-image uploads due to 2b57239389
.
2018-08-13 10:58:55 +08:00
Gerhard Schlager
b73950692b
FIX: Parsing non-existent feed should not fail
2018-08-10 18:37:14 +02:00
Osama Sayegh
865cb3feb9
FIX: allow selecting site's default theme from preference
2018-08-10 14:12:02 +03:00
Sam
2b2612d0f5
correct flaky spec
...
after(:all) and before(:all) are to be avoided, state can leak
2018-08-10 16:08:07 +10:00
Simon Cossar
093c3510e6
Rework moderators activity query ( #6230 )
...
* Order rows in query
* Don't increment revisions when moderator revises their own post
2018-08-10 10:51:31 +10:00
Gerhard Schlager
b9072e8292
FEATURE: Add "Reset Bump Date" action to topic admin wrench ( #6246 )
2018-08-10 10:51:03 +10:00
Misaka 0x4e21
6db623ef6b
UX: Improve category filtering and include subcategories
...
* category_filtering
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
* category_filtering with subcategory topics
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
4. report_posts
5. report_topics
6. report_topics_with_no_response
* category_filtering tests (without subcategory topics)
1. report_posts
2. report_topics_with_no_response
* subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb`
1. `in_category_and_subcategories` in `topic_spec.rb`
2. topics, posts, flags and topics_with_no_response in `report_spec.rb`
2018-08-10 10:50:05 +10:00
Gerhard Schlager
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
Simon Cossar
3cd4dc0f5f
Allow users with group_locked_trust_level to be promoted to tl3 ( #6249 )
2018-08-10 10:42:23 +10:00
Osama Sayegh
0d5ebcb21d
fix flaky specs ( #6255 )
2018-08-10 10:38:36 +10:00
Neil Lalonde
d77dccc636
FIX: user-deleted posts with deferred flags can be destroyed
2018-08-09 14:54:31 -04:00
Neil Lalonde
2c4d7225d8
FIX: permalink redirects with subfolder
2018-08-09 11:05:27 -04:00
Sam
ed4c0f256e
FIX: check permalinks for deleted topics
...
- allow to specify 410 vs 404 in Discourse::NotFound exception
- remove unused `permalink_redirect_or_not_found` which
- handle JS side links to topics via Discourse-Xhr-Redirect mechanism
2018-08-09 15:05:12 +10:00
Guo Xiang Tan
ba6f11c521
PERF: Only log the first skipped email when user exceeds daily limit.
...
https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132
2018-08-08 16:25:00 +08:00
Guo Xiang Tan
1ea23b1eae
FIX: Wrong order for `S3Helper#copy_file`.
2018-08-08 15:58:54 +08:00
Sam
a35f2984e9
FIX: support Arrays with Marshal dump in distributed cache
...
Theme cache uses arrays here
2018-08-08 16:44:56 +10:00
Osama Sayegh
0b7ed8ffaf
FEATURE: backend support for user-selectable components
...
* FEATURE: backend support for user-selectable components
* fix problems with previewing default theme
* rename preview_key => preview_theme_id
* omit default theme from child themes dropdown and try a different fix
* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
Guo Xiang Tan
aafff740d2
Add `FileStore::S3Store#copy_file`.
2018-08-08 11:30:34 +08:00
Neil Lalonde
4e6e4a83df
FIX: subfolder digest emails have incorrect URLs
2018-08-07 16:38:17 -04:00
David Taylor
aa9a9a5a72
FIX: Include auth_providers for anonymous users when login_required
2018-08-07 09:24:16 +01:00
Guo Xiang Tan
2b57239389
FIX: Upload's content is the only source of truth for the file type.
2018-08-07 13:15:00 +08:00
Guo Xiang Tan
d1860a4f7d
DEV: Fix test to use an actual PNG instead of a GIF.
2018-08-07 12:02:35 +08:00
Sam
6797395bd0
FIX: staff should be allowed to agree and keep post
2018-08-07 10:05:43 +10:00
David Taylor
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Guo Xiang Tan
4e11811321
FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`.
...
https://meta.discourse.org/t/missing-user-profile-pictures/93844/4
2018-08-06 13:29:44 +08:00
Osama Sayegh
18b396ad56
FEATURE: add link to see new commits when updates are available for themes ( #6233 )
...
* FEATURE: add link to see new commits when updates are available for themes
* shorten regexp
2018-08-06 15:29:15 +10:00
Régis Hanol
bf4d98e89d
FIX: always store topic links using the upload url
2018-08-04 01:29:32 +02:00
Joffrey JAFFEUX
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
Régis Hanol
ac2513b0f2
FEATURE: automatic PM when a user's email is revoked
2018-08-03 16:39:22 +02:00
Sam
280c318c49
FEATURE: allow ruby tags in Markdown
2018-08-03 11:47:36 +10:00
Osama Sayegh
880462a41c
FEATURE: display out of date themes on admin dashboard
...
* FEATURE: disaply out of date themes on admin dashboard
* Update copy
2018-08-03 09:53:48 +10:00
Jeff Atwood
c81bad3232
Merge pull request #6232 from OsamaSayegh/message-email-short-reply
...
UX: better rejection message when reply via email is too short
2018-08-02 14:25:04 -07:00
OsamaSayegh
a157dfd418
UX: better rejection message when reply via email is too short
2018-08-02 22:43:53 +03:00
Sam
0b3d51a8bc
FEATURE: whitelist lang attribute
2018-08-02 16:53:08 +10:00
Penar Musaraj
4a872823e7
Improvements to user drafts ( #6226 )
...
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels
* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
Dan Ungureanu
1a0ffc5ace
FEATURE: Added method to get multiple values at once from PluginStore. ( #6225 )
2018-08-01 18:42:40 +02:00
Gerhard Schlager
f4ca105498
FIX: Moving posts to existing topic didn't update topic metadata
2018-08-01 18:05:43 +02:00
Neil Lalonde
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX
499ed469b0
FIX: disk_space refresh is now on demand
2018-08-01 10:06:20 -04:00
Gerhard Schlager
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
Gerhard Schlager
5d421fb946
FIX: Try respecting charset in HTTP header of RSS feed
2018-08-01 10:41:20 +02:00
Gerhard Schlager
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
Penar Musaraj
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Joffrey JAFFEUX
849f0d00f6
FEATURE: adds revision_count to moderators_activity ( #6218 )
...
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
Guo Xiang Tan
919e8db686
FIX: Check for group name availability should skip reserved usernames.
2018-08-01 11:09:33 +08:00
Joffrey JAFFEUX
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX
8299fe0947
fix report spec ( #6214 )
2018-07-31 18:15:14 -04:00
Vinoth Kannan
6aee22b88f
FIX: Onebox images are not downloaded locally without css class
2018-08-01 02:51:02 +05:30
Neil Lalonde
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
Arpit Jalan
afe3b00c0f
FIX: use hidden setting for max export file size
2018-07-31 11:25:28 +05:30
Vinoth Kannan
50df2d7241
FIX: Should not include regular categories in top_category_ids array
2018-07-30 16:06:36 +05:30
Guo Xiang Tan
87537b679c
Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.
2018-07-30 11:39:28 +08:00