Mark VanLandingham
3d54f497db
DEV: add classes to li's inside user navigation ( #9766 )
2020-05-13 12:22:14 -05:00
Guo Xiang Tan
c405b15914
DEV: Add plugin outlet `revision-user-details-after`.
2020-05-13 15:40:37 +08:00
Martin Brennan
a64cf265fd
FIX: Change /bookmarks URL back to topic list and add bookmark poster avatars ( #9759 )
...
* Changes the /bookmarks URL to show the original "topics filtered by bookmark" list instead of redirecting to user activity bookmarks (see https://meta.discourse.org/t/domain-com-bookmarks-is-showing-domain-com-u-user-activity-bookmarks-with-reminders/149252/12 )
* Add the user avatar for the user who made the post that is bookmarked
2020-05-13 14:03:24 +10:00
Kris
811bc3544f
prettier
2020-05-12 23:12:46 -04:00
Guo Xiang Tan
822e594fc8
UX: Improve display of site setting validation message.
...
Previously, the validation message is shown inline with the label which
leads to the available width for both element being reduced.
2020-05-13 11:10:08 +08:00
Kris
765e842101
UX: remove underline from del & ins elements
2020-05-12 22:51:28 -04:00
Robin Ward
d9f5499f3a
Revert "Revert "DEV: Remove `Discourse.Route`""
...
This reverts commit b4d27d327d
.
Plugins have been updated to not use this anymore.
2020-05-12 14:15:07 -04:00
Mark VanLandingham
9bce91f59f
DEV: Allow plugins to add extra icons to category-link ( #9743 )
2020-05-12 09:41:16 -05:00
Bianca Nenciu
16137308b0
FIX: Show Settings button if plugin has settings ( #9728 )
...
It used to check if the plugin has an enabled_setting.
2020-05-12 11:18:19 +03:00
Martin Brennan
39a2d90e0f
DEV: Pass currentUser to post-menu button builders ( #9752 )
...
Adding this from a review; I was using Discourse.currentUser which is frowned upon now.
Passing currentUser both for regular post menu buttons and extra buttons attached via the plugin API.
Lots of formatting/whitespace changes, best off reviewing with ?w=1
2020-05-12 14:09:38 +10:00
Kris
a009ec597d
remove ember container div
2020-05-11 21:12:33 -04:00
tshenry
6f228b0312
FIX: Remove unnecessary forward slashes in regex
2020-05-11 17:55:44 -07:00
Penar Musaraj
7cdf41d311
DEV: Remove reference to Discourse.Category
2020-05-11 18:28:45 -04:00
Jeff Wong
e744b9efec
FIX: add tabindex=-1 on tabLoc post links
...
This prevents tabbing from confusing screenreaders, as having default tabindex
with aria-hidden confuses screenreaders
2020-05-11 14:43:12 -07:00
Penar Musaraj
90b900704b
FIX: Improve mobile footer nav accessibility
2020-05-11 16:55:34 -04:00
Robin Ward
b4d27d327d
Revert "DEV: Remove `Discourse.Route`"
...
This reverts commit eed7983404
.
2020-05-11 16:50:53 -04:00
Robin Ward
22af44ac49
DEV: Remove `Discourse.Mobile`
2020-05-11 16:13:29 -04:00
Robin Ward
eed7983404
DEV: Remove `Discourse.Route`
2020-05-11 16:11:33 -04:00
Robin Ward
74db317974
DEV: Remove deprecation for `Discourse.Category`
2020-05-11 16:10:21 -04:00
Joffrey JAFFEUX
286b4e535e
DEV: allows buttons to define aria-label ( #9747 )
2020-05-11 22:09:44 +02:00
Robin Ward
b4bd238dd6
DEV: Add safe deprecation to `Discourse.User`
2020-05-11 16:08:12 -04:00
Robin Ward
46730a2f0d
DEV: Allow us to keep the deprecation with Ember CLI
2020-05-11 16:06:06 -04:00
Robin Ward
4c17ff98fa
DEV: Remove deprecation for `Discourse.Session`
2020-05-11 15:51:10 -04:00
Robin Ward
8311374a5a
DEV: Replace `version.js.erb` with pre generated file
2020-05-11 15:43:09 -04:00
Robin Ward
d2b16a7618
DEV: Generate `emoji/data` on demand ( #9744 )
...
These emoji rarely change and can be re-generated when we make changes
to them.
2020-05-11 15:29:46 -04:00
Joffrey JAFFEUX
af6e61defd
FIX: sets a title for notifications button ( #9745 )
2020-05-11 20:46:08 +02:00
jjaffeux
5a073c6a0a
Revert "FIX: title should attempt to fallback to label before name ( #9739 )"
...
This reverts commit c6bf552ca3
.
2020-05-11 20:09:11 +02:00
Dan Ungureanu
141f16eb6b
FIX: Multiple schema.org improvements
...
* Do not show "Uncategorized" category in topics list.
* Use "BreadcrumbList" only if topic is in a category.
* Add tags list as keywords to the first post.
* Add "dateModified" even if it is the same with "datePublished".
* Show "crawler-linkback-list" only if there are links to be shown.
2020-05-11 20:38:49 +03:00
jjaffeux
0deb05740f
Revert "DEV: allows to define an ariaLabel on d-button ( #9716 )"
...
This reverts commit 7a95dd4841
.
2020-05-11 19:19:13 +02:00
Joffrey JAFFEUX
7a95dd4841
DEV: allows to define an ariaLabel on d-button ( #9716 )
...
* DEV: allows to define an ariaLabel on d-button
This topic also adds this function to topic-footer-buttons, simplifies the whole logic of titile/label/arialabel in d-button and adds tests for these properties.
* typo
2020-05-11 18:42:51 +02:00
Joffrey JAFFEUX
c6bf552ca3
FIX: title should attempt to fallback to label before name ( #9739 )
2020-05-11 18:42:18 +02:00
Jarek Radosz
7d3c4a5f13
FIX: Show category name in badge preview on edit ( #9726 )
2020-05-11 17:05:40 +02:00
Jarek Radosz
a2bb33b6d7
REFACTOR: Remove an unused Topic model observer ( #9723 )
...
As far I can tell nothing sets categoryName on the Topic model. Didn't find anything in all-the-plugins/all-the-themes either.
2020-05-11 17:05:05 +02:00
Mark VanLandingham
89c6f697b8
DEV: Plugin outlet after save or cancel composer buttons ( #9725 )
2020-05-11 09:23:36 -05:00
Sam Saffron
77f5bb1419
FIX: stop clearing title by mistake
...
b180e6e737
caused a short lived regression.
This code is very deliberate about ensuring originalTitle is
set correctly
2020-05-11 19:07:32 +10:00
Guo Xiang Tan
a3a464b838
DEV: Improve description of addPosterIcon plugin api.
2020-05-11 16:44:47 +08:00
Sam Saffron
b180e6e737
FIX: default to blank title on open
...
In production `title` was set to undefined causing a
discrepancy between originalTitle and title
This attempts to work around the issue in the production bundle
2020-05-11 18:36:09 +10:00
Martin Brennan
29842e682b
FIX: Resolve issues with Next Monday for bookmarks not working in certain locales ( #9737 )
...
In moment.js the .day() function can accept a day string but this is locale based, so e.g. in Finnish locale the string "Monday" means nothing and will parse incorrectly to Sunday. To resolve this we always use the moment.js number for the day of the week we want.
2020-05-11 13:59:14 +10:00
Martin Brennan
12d4d51d81
FIX: CurrentUser now must be passed to resolveTimezone and user card local time issues ( #9734 )
...
* This is to prevent user's timezones being changed accidentally
e.g. by admin looking at a user
* This problem only occurred via the user card, however the user card
was still calling userTimezone even if the setting to display user
time in card was disabled
2020-05-11 11:01:47 +10:00
Sam Saffron
44712c5f98
FIX: ESC to dismiss empty draft topic composer
...
Previously originalTitle was set to undefined leading to
titleDirty being unconditionally undefined for new topics
That mean you could not dismiss the composer via ESC
2020-05-11 10:04:38 +10:00
Bianca Nenciu
8149bfbaf1
FEATURE: Filter settings by plugin ( #9692 )
2020-05-10 14:07:45 +03:00
Joffrey JAFFEUX
3b2b635e9b
DEV: removes setInterval as it might cause issues ( #9722 )
2020-05-10 08:57:48 +02:00
Joffrey JAFFEUX
862d153f54
REFACTOR: removes dead code ( #9721 )
2020-05-09 11:50:47 +02:00
Joffrey JAFFEUX
9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange ( #9718 )
2020-05-09 10:26:23 +02:00
Penar Musaraj
d653d2f5d9
UX: Prevent timeline overlapping topic footer buttons
2020-05-08 16:20:27 -04:00
Robin Ward
34e5f807ec
DEV: User UPPER_CASE for constants
2020-05-08 15:50:55 -04:00
Mark VanLandingham
da561a430d
DEV: Add data-name to popular-theme-item rows ( #9714 )
2020-05-08 14:38:41 -05:00
Joffrey JAFFEUX
5bac2828ee
DEV: 25ms was too short and causing test failures ( #9712 )
2020-05-08 21:10:52 +02:00
Robin Ward
7f373e8b93
DEV: Don't use `js.erb` for constants
...
Adds a new rake task to auto generate a constants.js file with the
constants present. This makes migrating to Ember CLI easier, but also
slightly speeds up asset compilation by having to do less work.
If the constants change you need to run:
`rake javascripts:update_constants`
2020-05-08 14:14:01 -04:00
Jordan Vidrine
47788da706
FIX: Bookmark Modal Input ( #9707 )
2020-05-08 17:47:01 +02:00