781e3f5e10
DEV: Use `response.parsed_body` in specs ( #9615 )
...
Most of it was autofixed with rubocop-discourse 2.1.1.
2020-05-07 17:04:12 +02:00
9bff0882c3
FEATURE: Nokogumbo ( #9577 )
...
* FEATURE: Nokogumbo
Use Nokogumbo HTML parser.
2020-05-05 13:46:57 +10:00
84be92c067
FIX: Avoid exception when rendering a poll in a trashed post
...
Maintain the poll belongs_to post relation when a post is trashed
2020-04-28 14:43:09 +01:00
330102fd20
FEATURE: Show votes in an "on voted" poll to the creator
...
This required properly plumbing the guardian into the serializer.
Notably, the default state in the client was not changed - if you haven't voted in
the poll, you need to click the button to view the results instead of the results
being immediately visible on page load.
Implements https://meta.discourse.org/t/-/138108
2020-03-20 13:36:42 -07:00
29b35aa64c
DEV: Improve flaky time-sensitive specs ( #9141 )
2020-03-10 22:13:17 +01:00
c62d5b139b
FIX: Allow users to create polls in PMs with non human users ( #9055 )
2020-03-02 14:29:40 -05:00
82b307cd52
FIX: Use correct translation string
2020-02-17 13:49:43 +02:00
5d97286fa7
FEATURE: Allow single option polls ( #8853 )
2020-02-05 08:03:27 -06:00
07222af7ab
FEATURE: Add 'groups' option to polls ( #8469 )
...
This options can be used to restrict polls to certain groups.
2020-01-28 14:30:04 +02:00
9e3fc1111d
FIX: Add a blank poll options validation ( #8652 )
...
Before, saving a post with a blank poll option resulted in error 500.
2020-01-03 15:09:36 +01:00
8c2e27790c
FIX: everyone can see poll results when on_vote and closed ( #8613 )
...
The bug was mentioned here: https://meta.discourse.org/t/poll-name/136436
I added specs to cover existing behaviour and refactored can_see_results method.
Guard condition should apply only if the poll result setting is set to `staff_only`.
In other cases, user can see results when the poll result setting is set to `always` or user voted or poll is closed.
2019-12-24 08:04:35 +11:00
b92a8131c0
FEATURE: Pie chart option for poll results ( #8352 )
2019-11-25 11:51:01 -06:00
79957706b1
FIX: Store custom attributes that are needed by plugins in queuedpost payload ( #8009 )
2019-08-14 15:02:59 -03:00
70b73c2159
DEV: Use proper heredoc name.
2019-06-04 16:31:18 +08:00
63e3d49508
DEV: Add test for poll plugin reduce_excerpt.
2019-06-04 16:30:15 +08:00
227c45107d
FEATURE: Implement Onebox for posts including polls. ( #7539 )
2019-05-29 17:05:52 +02:00
3c1fa3910f
DEV: track the correct channel in specs
...
These tests are erratically failing due to distributed cache messages that
can land between tests
Ensure we are only looking for the correct messages
2019-05-20 18:27:09 +10:00
aeb7143aff
DEV: correct flaky poll specs
...
They were relying on a pristine message bus, however current implementation
still uses redis, stuff can get held up and we can end up publishing
distributed cache messages in the middle invalidating the tests
2019-05-17 16:16:02 +10:00
9059a8ca90
Fix the build.
2019-05-13 10:16:26 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
21b975e71a
FIX: Broken plugin spec
2019-04-23 15:29:26 -04:00
c44371b4ac
FIX: Broken spec
2019-03-28 13:55:04 -04:00
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
b5e32cfe2a
DEV: correct spec to test for correct fidelity
...
This is due to 9ebabc1d
2019-03-28 17:45:36 +11:00
e49bcebb35
FIX: Validate poll arguments. ( #6740 )
...
* FIX: Validate number poll.
* FEATURE: Poll's min can be 0.
* FIX: Fix URL to user profile.
2018-12-31 10:48:30 +01:00
c928386c3e
FIX: Copy old status to new poll. ( #6788 )
2018-12-19 11:29:13 +01:00
71ce9ced47
FIX: Incorrect arguments were being passed to `Jobs::ClosePoll`.
...
Also fix spec that wasn't testing anything.
2018-12-13 16:46:00 +08:00
dcf9c6da59
DEV: Don't publish post messages to non-human users.
2018-12-06 08:24:13 +08:00
aea2d8bbeb
FIX: properly secure poll message bus
...
Co-authored-by: Sam <sam.saffron@gmail.com>
2018-12-05 21:27:49 +01:00
3c9c95ac83
Update Rubocop to 0.60
2018-12-04 10:48:16 +01:00
5142911012
FIX: auto-closing poll wasn't working
2018-11-23 17:42:57 +01:00
f402d0d74f
FIX: couldn't delete users who voted on a poll
2018-11-23 11:45:53 +01:00
439b3fe10a
Fix `MigratePollsData` failing when poll-votes have duplicated options.
2018-11-21 10:52:21 +08:00
4459665dee
REFACTOR: use tables instead of custom fields for polls ( #6359 )
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
2018-11-19 14:50:00 +01:00
a4aa4a9be4
DEV: Remove the use of mocks in our tests.
2018-10-15 10:38:02 +08:00
eacb2593ee
workaround badly denormalized data in polls
2018-08-17 11:15:29 +10:00
10a3499d68
uses emoji versions for specs ( #6276 )
2018-08-16 13:45:30 +02:00
3a8f69c3d2
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 16:11:09 +08:00
e806e6e96f
correct specs
2018-06-07 16:13:15 +10:00
94163d7f1a
add spec for auto-close polls
2018-05-07 11:31:20 +02:00
9ff2d540ba
fix the build
2018-05-03 10:32:01 +02:00
51657d3426
Allow polls to be added/renamed/removed as long as user can edit posts.
2018-03-14 11:00:57 +08:00
b77553a635
FIX: Staff should be able to updates polls when edit window expires.
...
https://meta.discourse.org/t/moderators-cannot-remove-polls-from-posts/81804/7?u=tgxworld
2018-03-08 16:45:06 +08:00
7a2183e8ab
FEATURE: rake task for merging users
2018-03-01 12:28:12 +01:00
dee35b72f2
FIX: must be able to post in a topic in order to vote on a poll
2018-02-27 00:19:44 +01:00
94b2c70c0d
PERF: remove oga gem
...
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri
This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
7e3543d96f
correct plugin specs
2018-01-12 14:42:05 +11:00
316d814130
FIX: staff should always be allowed to create polls if they are enabled
2017-12-05 00:03:56 +01:00
76bc173d47
FEATURE: adds poll_allow_staff_to_create
...
This setting will bypass poll_minimum_trust_level_to_create if set to true
2017-12-04 18:12:17 +01:00
1e0bfa1d97
FIX: poll new_post_manager spec
2017-12-04 16:12:40 +01:00
Jarek Radosz
Krzysztof Kotlarek
David Taylor
Kane York
Dan Ungureanu
Mark VanLandingham
Bianca Nenciu
Roman Rizzi
Guo Xiang Tan
Bianca Nenciu
Sam Saffron
Robin Ward
Régis Hanol
Joffrey JAFFEUX
Gerhard Schlager