Sam
8745f78277
DEV: disable async logging in development on broken Ruby
...
Ruby 2.5.3 has an upatched issue that crashes unicorn after fork:
https://bugs.ruby-lang.org/issues/14634
This will be patched in 2.5.4 however for now just warn people dev is slower
and disable async logging on the older rubies
2019-02-21 17:20:58 +11:00
Sam Saffron
83f13ecf82
FEATURE: bump onebox dependency
...
- Adds support of kaltura oneboxes
- Adds support for typeform oneboxes
2019-02-19 15:22:43 +11:00
Régis Hanol
a3e9b809b2
Update aws-sdk-* gems to latest versions
2019-02-14 11:04:35 +01:00
Régis Hanol
4d674acc25
FEATURE: AWS SNS bounce notifications webhooks
2019-02-13 21:26:40 +01:00
Osama Sayegh
1c00e8a755
Bump logster to 2.1.0 ( #7000 )
2019-02-13 10:57:22 +01:00
Vinoth Kannan
fb911766ee
FIX: Bump onebox version to include imgur security fix
2019-02-13 01:14:06 +05:30
Sam
4cfc201604
DEV: update logster to stable release
...
This update logster to the stable 2.0.1 release instead of running a pre
release
2019-02-06 16:54:42 +11:00
Sam
0098b3072e
DEV: update rack-mini-profiler
...
This gem update fixes an issue with upcoming Rails 6
(without this fix mini profiler will not work on rails 6 and simply renders
text)
2019-02-06 16:51:45 +11:00
Sam
1748ec421e
DEV: gem updates
...
Another group of gems updated, better_errors is fairly safe as its for dev
chunky_png fairly safe, used for getting image info from pngs, erubi update
is very safe. Sanitize is used by onebox and should always be on latest.
Long term we should think of making sanitize an optional dependency on onebox
cause we are happy to just provide methods from core to do this and it would
remove nokogumbo and sanitize deps.
2019-02-05 12:35:42 +11:00
Sam
27c8688f02
DEV: update dependencies
...
This updates some more low risk gems, maxmind, hiredis (c wrapper for
redis), puma, rbtrace and stackprof.
2019-02-05 11:23:21 +11:00
Sam
635bc72ec5
DEV: pin redis to version 4.0.1
...
Version 4.1.0 returns frozen hashes which conflict with our monkey patch
We will follow up unpinning this later
2019-02-05 09:08:44 +11:00
Sam
be24220e95
DEV: update low risk gems
...
This follows up on 03376224
which reverted the redis update which is not
supported, rest of the gems should be fine.(unicorn / nokogiri / sidekiq /
pg)
2019-02-05 06:54:10 +11:00
Sam
0337622420
Revert "DEV: more low risk gem updates"
...
This reverts commit 2c53dde918
Turns out redis upgrade breaks our usage of redis, more internal fixes
are required
2019-02-04 18:11:09 +11:00
Sam
2c57b65bfc
DEV: update more gems including i18n
...
This updates a few more lower risk gems, the main goal here is to have
nothing outdated. Avoiding a giant commit is going to make it slightly
easier to partially roll back if something goes wrong
2019-02-04 17:54:39 +11:00
Sam
ab23615077
DEV: update rubocop gem to latest
...
not much to say here, the new version seems compatible with Discourse,
no changes appear to be needed
2019-02-04 17:52:10 +11:00
Sam
2c53dde918
DEV: more low risk gem updates
...
redis/sidekiq/unicorn/nokogiri and pg all are fairly safe to update
2019-02-04 17:48:31 +11:00
Sam
9f5bbd663d
DEV: update mini_racer and message_bus
...
Two very low risk updates, message_bus has been released no need to depend
on pre-release.
mini_racer update is for a very minor change (shared isolates are not used
in discourse so it is not a fix we technically need)
2019-02-04 17:46:38 +11:00
Sam
1816bdf46e
DEV: upgrade mail gem from pre-release
...
2.7.1 version of the mail gem was released! We no longer need to depend on
the pre-release.
2019-02-04 16:10:13 +11:00
Sam
ab52241d32
DEV: upgrade thor gem
...
0.19.4 was no longer compatible with Rails 6, this prepares us for Rails 6
support.
2019-02-04 15:09:15 +11:00
Sam
377f3efb60
DEV: remove foreman gem and unsupported Procfile
...
Launching Discourse no longer should require foreman in dev. We can simply
use `bin/unicorn` which automatically launches a sidekiq worker.
The foreman gem depends on thor ~> 0.19.1 which is no longer supported in
rails 6. So this pre-emptively prepares us for it.
2019-02-04 15:05:54 +11:00
Guo Xiang Tan
49b21727ee
Update `rails_multisite` to 2.0.6.
2019-01-23 17:42:59 +08:00
Guo Xiang Tan
53c0ad9388
Revert "DEV: Only install danger on Travis."
...
This reverts commit 792dd033e6
.
2019-01-21 11:31:16 +08:00
Guo Xiang Tan
d7f11be575
Bump mini_scheduler.
2019-01-21 10:57:30 +08:00
Guo Xiang Tan
792dd033e6
DEV: Only install danger on Travis.
2019-01-21 09:46:32 +08:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
Guo Xiang Tan
ee7ab3e2ec
Pause MiniScheduler when Sidekiq is paused.
2019-01-18 17:50:24 +08:00
Osama Sayegh
d0dc674875
Bump logster to 2.0.0.pre ( #6897 )
2019-01-17 18:13:47 +03:00
Sam
0890078993
Revert "Bump logster to 1.4.0.pre ( #6866 )"
...
This temporary revert is here cause a certain immune system in logster
when a large number of events are groupes is no longer working in
production.
What this means is that if you have 10 thousand errors grouped it can
impose an very large amount of load on redis.
This reverts commit abee39ecd0
.
2019-01-11 11:25:48 +11:00
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
Gerhard Schlager
6f867660bc
FIX: Push notifications didn't work anymore
2019-01-09 22:47:38 +01:00
David Taylor
af227cada5
FIX: Bump onebox version for gfycat aspect ratio fix
...
Including the `Gemfile.lock` changes this time
2019-01-09 18:08:46 +00:00
David Taylor
286cc72c8b
FIX: Gyfcat onebox should have fixed aspect ratio videos
...
(Fixed upstream in the onebox gem)
2019-01-09 17:15:15 +00:00
Osama Sayegh
abee39ecd0
Bump logster to 1.4.0.pre ( #6866 )
...
2 new features and a few fixes. More details here:
https://github.com/discourse/logster/pull/76
https://github.com/discourse/logster/pull/77
2019-01-09 13:50:48 +03:00
David Taylor
fe20cb4b56
FIX: Enforce a fixed height on generic oneboxed videos
...
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
2019-01-08 16:22:03 +00:00
Arpit Jalan
c76c44bc66
bump onebox version
...
- FEATURE: Add support for Twitter cards.
- FIX: add more https hosts
2019-01-08 09:20:08 +05:30
Joshua Rosenfeld
2fc7d2c56d
Bump omniauth-google-oauth2 version
2019-01-02 10:42:39 +00:00
sau226
828c07b658
Build(deps-dev): Bump rubocop from 0.60.0 to 0.61.1 ( #6835 )
2019-01-02 05:44:19 +08:00
Joshua Rosenfeld
9878274427
Revert "Bump omniauth-google-oauth2 version"
...
This reverts commit 8ac0b721c5
.
2018-12-31 14:59:09 -05:00
Joshua Rosenfeld
8ac0b721c5
Bump omniauth-google-oauth2 version
2018-12-31 14:07:18 -05:00
Osama Sayegh
8bd5c90b0c
Bump logster to version 1.3.4 ( #6834 )
...
Fixes linear-gradient CSS issue on iOS
Increases z-index for the actions menu to prevent the screen divider/splitter from obstructing the menu
e43e98dc61
2018-12-31 06:58:46 +03:00
Osama Sayegh
8f65e4fb01
Bump logster to 1.3.3 ( #6813 )
...
Fixes a UI issue
2018-12-26 18:21:52 +03:00
Osama Sayegh
2ab02d6642
Bump logster version to 1.3.2 ( #6811 )
...
Logster 1.3.2 improves UX on mobile
2018-12-26 14:09:00 +08:00
Arpit Jalan
a8a0f97157
bump onebox version
...
- FEATURE: support YouTube `rel` parameter
2018-12-25 06:36:51 +05:30
Joffrey JAFFEUX
7b253dbe4a
FIX: gfycat oneboxing
2018-12-22 11:16:18 +01:00
Arpit Jalan
59cb907f25
Bump onebox version
...
- update Twitter status icons
2018-12-13 06:25:50 +05:30
Sam
a34bc92e1a
DEV: update mini profiler
...
This provides us with instrumentation missing after rails upgrade
Latest version of rails uses exec_params internally which is no longer
routed to intercepted methods in mini profiler 1.0.0
2018-12-10 14:29:20 +11:00
Sam
fcb3f1e219
DEV: upgrade Rails to version 5.2.2
2018-12-10 11:29:28 +11:00
Régis Hanol
3c9c95ac83
Update Rubocop to 0.60
2018-12-04 10:48:16 +01:00
Sam
8868cfd2e4
FIX: redis leak when visiting large amounts of topics
...
Message bus uses a key to keep track of the last id for each channel
this key was never expired even if channel data expired
This change ensures we also expire the tracking key, it means a lot to us
cause each topic has a channel, so if you have 1 million topics that is
1 million keys that may persist forever
2018-11-30 14:41:15 +11:00
Arpit Jalan
597f170995
bump onebox version
...
- FIX: show Google video preview on iOS devices
- FIX: convert relative image url to absolute url
2018-11-17 13:45:55 +05:30
Sam
296928ec04
FIX: update logster to handle logging of invalid encoding strings
...
Previously if a string had invalid encoding we would explode and log
to STDERR, this often goes lost, instead logster now scrubs as needed
2018-11-13 16:06:06 +11:00
Osama Sayegh
dd0b4c565b
Bump logster version ( #6584 )
2018-11-12 08:49:00 +08:00
Arpit Jalan
cf0acad1e4
bump onebox version (again)
...
- Improve google photos album title
2018-11-09 18:31:25 +05:30
Arpit Jalan
1151c093ad
bump onebox version
...
- Better Google Photos oneboxing
2018-11-09 15:44:06 +05:30
Sam
81ccfa5a8a
there is a new bundler
2018-11-07 10:05:22 +11:00
Sam
3951e9b528
SECURITY: update rack from 2.0.5 to 2.0.6
...
This release contains security fixes to the underlying rack library
used by Discourse.
Impact is not too high as we do not use request.scheme in our templates
2018-11-07 10:05:22 +11:00
Kyle Zhao
57ab6bcba1
SECURITY: update loofah for CVE-2018-16468
2018-10-30 10:51:03 -04:00
Arpit Jalan
7fe3491bc0
bump onebox version
...
- UX: make title on Instagram less redundant
2018-10-25 12:18:16 +05:30
Penar Musaraj
d20fd66286
bump onebox to 1.8.64
2018-10-16 11:10:11 -04:00
Sam
3aceda2dfd
Update to latest version of message bus
...
This includes DistributedCache which we will be using and perf fixes
2018-10-15 13:49:04 +11:00
Bianca Nenciu
1d26a473e7
FEATURE: Show "Recently used devices" in user preferences ( #6335 )
...
* FEATURE: Added MaxMindDb to resolve IP information.
* FEATURE: Added browser detection based on user agent.
* FEATURE: Added recently used devices in user preferences.
* DEV: Added acceptance test for recently used devices.
* UX: Do not show 'Show more' button if there aren't more tokens.
* DEV: Fix unit tests.
* DEV: Make changes after code review.
* Add more detailed unit tests.
* Improve logging messages.
* Minor coding style fixes.
* DEV: Use DropdownSelectBoxComponent and run Prettier.
* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
Guo Xiang Tan
893c0e9d5f
Don't run the pre-release for bundler.
2018-10-08 09:23:39 +08:00
Grey Baker
6995fd12c6
build(deps): [security] bump nokogiri from 1.8.3 to 1.8.5 ( #6455 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.8.3 to 1.8.5. **This update includes security fixes.**
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.8.3...v1.8.5 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-05 09:43:17 -04:00
Sam
378584fdc0
correct under reporting of memory in memory profiler
2018-10-04 17:02:53 +10:00
Arpit Jalan
420e7bccca
bump onebox version (take 2)
...
- better detection of zero dollar amazon price
2018-10-03 17:54:56 +05:30
Arpit Jalan
b56d0026b9
bump onebox version
...
- do not display zero dollar price on Amazon onebox
- fix google play store onebox
2018-10-03 17:05:51 +05:30
Sam Saffron
a2b6eed284
FIX: correct compilation issues on clang 10
...
In MacOS we need different compilation flags now that some are
deprecated in clang 10, this is not specific to mojave which was
the previous fix
2018-09-28 09:42:06 +08:00
Sam Saffron
afd2edabe4
DEV: update mini_racer for Mojave support
...
MacOS Mojave deprecates some libraries making it a bit
harder to compile Mini Racer, this release adds support
2018-09-26 07:43:34 +08:00
Arpit Jalan
80229668f9
bump onebox version
...
- FIX: user correct steam placeholder image url
- catch up Ruby 2.6
2018-09-19 10:06:43 +05:30
Gerhard Schlager
fb9e3e6423
Update aws-sdk-s3
...
In preparation for https://github.com/discourse/discourse/pull/6345
2018-09-17 17:39:46 +02:00
Sam
5bb7cc8710
FIX: update PG gem
...
We need the newer PG gem to fix issues around rb_wait_for_single_fd that
pop up in rare conditions
2018-09-13 21:57:20 +10:00
Gerhard Schlager
0d8c72d8c4
DEV: Add rake task to check locale files for errors
2018-09-05 00:47:39 +02:00
Arpit Jalan
8ce8edaf40
bump onebox version
2018-08-31 15:10:11 +05:30
Arpit Jalan
6b9aeeea73
bump onebox version
2018-08-31 08:40:36 +05:30
Guo Xiang Tan
a928bf4300
Revert `rails_multisite` back to `2.0.4`.
2018-08-30 15:42:51 +08:00
Arpit Jalan
2872b100dc
bump onebox version
2018-08-29 16:55:06 +05:30
Sam
b760f66523
Upgrade PG gem to latest
...
This unlocks some performance improvements
2018-08-27 10:58:19 +10:00
Guo Xiang Tan
6acba44ed9
Revert "Install `mailcatcher` in development."
...
This reverts commit 914ce34e5b
.
* requires sqlite3 to be installed.
2018-08-21 15:40:50 +08:00
Guo Xiang Tan
914ce34e5b
Install `mailcatcher` in development.
2018-08-21 15:28:02 +08:00
Sam
168ffd8384
FEATURE: group warnings about IP level rate limiting
2018-08-13 14:38:20 +10:00
Neil Lalonde
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
Gerhard Schlager
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
Gerhard Schlager
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
Neil Lalonde
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
Arpit Jalan
458d9cd17a
bump onebox version
2018-07-31 22:52:03 +05:30
Joffrey JAFFEUX
b4a2f3fe2f
DEV: implementing danger for travis
2018-07-24 10:12:15 -04:00
Arpit Jalan
22dad7f0e8
bump onebox version
2018-07-17 13:55:00 +05:30
Arpit Jalan
39299fdd8c
bump onebox version
2018-07-16 11:43:32 +05:30
Arpit Jalan
2a5a57a87e
bump onebox version
2018-07-12 21:29:34 +05:30
Guo Xiang Tan
72a3457379
Bump `discourse_image_optim` which uses a global timeout.
...
Our previous solution has the timeout set at the worker level
which means the total timeout would be X timeout secs * N number of
workers.
2018-07-09 10:30:18 +08:00
Sam
564e7e6898
FEATURE: update libv8 to version 6.7
...
This has parity with stable Chrome!
2018-07-09 09:08:25 +10:00
Sam
f662d1135e
FIX: update mini_racer corrects erratic segfaults
...
In some conditions mini_racer would segfault causing sidekiq crash or
web crash, this was automatically recovered from but not ideal.
2018-07-06 11:00:07 +10:00
Guo Xiang Tan
3d2f3ef8ae
Update discourse_image_optim gem.
2018-07-03 15:22:54 +08:00
Arpit Jalan
55a963252d
bump onebox version
2018-07-02 10:36:26 +05:30
Joffrey JAFFEUX
ebd2be9e02
DEV: lower highline requirement
2018-06-27 22:50:00 +02:00
Arpit Jalan
2f5b7beace
bump onebox version
2018-06-25 11:22:06 +05:30
Sam
da8c6e9ac0
bump mini_sql for faster/more correct time conversions
2018-06-24 15:17:47 +10:00
Arpit Jalan
a171464a55
bump onebox version
2018-06-20 16:47:55 +05:30
Guo Xiang Tan
bb959e85e6
Pin exifr to 1.2.5.
2018-06-20 17:27:46 +08:00
Sam
cb824a6b33
DEV: remove all calls to SqlBuilder use DB.build instead
...
This is part of the migration to mini_sql, SqlBuilder.new is being
deprecated and replaced with DB.build
2018-06-20 17:53:49 +10:00