0a5a6dfded
DEV: stop mutating inputs as a side effect
...
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.
This handles all the cases where specs caught this.
Mutating inputs makes code harder to reason about. Eg:
```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```
This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
197e3fd722
FIX: Keep original subject in emails to staged users
...
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
c0a8bb9a91
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
fad9c2b971
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 13:51:53 +08:00
0942e2c795
allow adding tags as a custom subject format for emails ( #5846 )
...
allow adding tags as a custom subject format for emails
2018-07-11 12:24:07 +10:00
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
62a8904729
Feature: Include participants at the bottom of PM emails ( #5797 )
...
* Feature: Include participants at the bottom of PM emails
... as undecorated links.
https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast
Fix: missing translation for PM mentions
* display membership count as `group (count)`
2018-05-03 15:50:06 -07:00
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
85a59c632d
allow header_instructions to be passed in to message builder
2017-12-05 15:12:24 -05:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
6796de8bf2
FIX: replace site_name with email_prefix in subject when use_site_subject is true
2017-06-21 21:15:49 +05:30
9f930125f5
FIX: replace site_name in email subject with site title
2017-03-22 23:38:46 +05:30
1853a4852c
FIX: use email prefix only in subject
2017-03-21 20:29:57 +05:30
ee9d621d9c
FIX: surround the FROM alias with " in order to support the @ character
2017-03-07 23:37:21 +01:00
e634b37f9a
FIX: from field of emails should be including email_site_title or site title settings
2017-02-27 14:23:07 -05:00
d88562e72b
Revert "use RFC-complient signature separator dash-dash-space"
2017-02-14 14:58:08 +01:00
bcd4513963
use RFC-complient signature separator dash-dash-space
...
currently, Discourse uses '---' in its notifications to
separate the signature with unsubscribe links etc. from
the body of the message.
The RFC standard defines '-- '.
https://www.ietf.org/rfc/rfc3676.txt (4.3)
The problem has been discussed in:
https://meta.discourse.org/t/previous-replies-separator-is-not-rfc-compliant/39410
And an incomplete fix has been added a year ago:
86819f08c3
2017-02-10 11:46:02 +01:00
b08ab829b8
added 'X-Auto-Response-Suppress' email header (props to elijah)
2016-08-03 11:02:07 +02:00
926c021125
set 'List-Unsubscribe' email header to new unsubscribe url instead of user preferences url
2016-07-13 22:32:46 +02:00
214f5bff5c
don't send more than 1 reply per day to auto-generated emails
2016-06-28 16:42:05 +02:00
99ad251731
different email footer when mailing_list_mode is enabled
2016-06-03 15:48:54 +02:00
4d9c81fde7
Merge pull request #4148 from tgxworld/dont_reply_to_emails_that_are_autogenerated
...
FIX: Don't send rejection mailer to bounced emails.
2016-04-13 15:36:14 +02:00
a359a973e2
remove useless content when sending email to a staged used
2016-04-11 19:06:10 +02:00
5734c7f3f3
FIX: Don't send rejection mailer to bounced emails.
2016-04-07 22:21:17 +08:00
a20a52b25f
add user locale
2016-03-03 17:21:50 -08:00
21b51090bf
FIX: don't tell staged users they can visit topics in email notifications
2016-02-26 23:56:56 +01:00
82a75c00c0
UX: change 'Visit Topic' to 'Visit Message' for message notification email
2016-02-09 13:39:10 +05:30
7d992cb4c5
FIX: sending emails to mailing list subscribers wasn't working
2016-02-03 19:27:58 +01:00
b92e2b33eb
Hotfix for unsubscribe via email
2016-01-21 21:46:15 +13:00
c7283751a3
Unsubscribe via email
2016-01-20 22:25:25 +13:00
ccf5b1584d
Unsubscribe link needn't be sanitized
2015-12-11 10:06:25 -05:00
df19a27753
FIX: Don't sanitize `header_instructions`
2015-12-10 18:15:32 -05:00
b781b6aea3
Add `header_instructions` overridable translation for email headers.
2015-12-07 16:52:33 -05:00
0d54c18c8b
new hidden 'allow_staged_accounts' setting
2015-11-26 18:31:23 +01:00
515fc49727
FIX: replace polls with a link in emails
2015-10-22 19:10:07 +02:00
6669a2d94d
FEATURE: per-topic unsubscribe option in emails
2015-08-12 23:00:16 +02:00
f7d2fc0524
FEATURE: 'reply by email address' validator
...
Prevent infinite email loophole when the 'reply_by_email_address' site setting is the same as the 'notification_email'.
2015-02-06 12:08:37 +01:00
0ae0552543
FEATURE: show topic category in email subject
2014-10-03 22:08:59 +05:30
330b7ba54a
FEATURE: add site preference for standard subjects, including support for Re
2014-09-29 21:54:29 +05:30
50ac4c6336
FIX: cleanup aliases in email From and Reply-to fields to prevent Bad sender address syntax errors
2014-08-08 13:35:47 -04:00
b3c149de22
FIX: use email_site_title for emails like reset password and account activation too
2014-07-22 15:52:20 -04:00
362adb0498
FIX: add site setting email_site_title, which overrides title in reply by email address in case the title has invalid characters
2014-07-09 16:44:18 -04:00
da9048f3ea
Fix email code & tests
2014-06-27 12:04:31 -07:00
0af1242aa8
Use an appropriate name in the Reply-To header
...
Use "Site Name <>" for the Reply-To header when the reply is to the site or a public topic.
Use "username <>" for the Reply-To header only when the reply is to a private message topic.
2014-06-06 21:09:00 +08:00
f44bd4ec28
Don't allow sending private messages to suspended users. Emails to suspended users should tell them how to respond, since they can't.
2014-05-06 15:01:27 -04:00
4d3effa686
User new `/my/preferences` route in an email
2014-04-29 16:34:31 -04:00
806924dd7e
Option to change the email subject prefix
...
It adds a new setting 'email_prefix' to configure which [label] will be used in the subject of emails. Discourse currently uses '[title]'. The problem is that sometimes you need to set a longer title, that doesn't really work well for emails. I think this is very common since the HTML `<title>` tag is very important for SEO.
It will default to '[title]' if this setting is not used.
See: https://meta.discourse.org/t/where-to-change-the-email-subject-prefix/11989
2014-03-26 23:06:00 +01:00
a28a0bbeeb
PERF: stop messing with strings that come back from I18n.t
...
allows better caching
2014-02-18 14:10:03 +11:00
d51dcd1705
improve email styling, include extra respond link
2013-07-26 17:27:46 +10:00
e0b9117f15
Fix for emails with empty body
2013-07-24 15:07:51 -04:00
Sam Saffron
Gerhard Schlager
Guo Xiang Tan
Maja Komel
Jeff Wong
Leo McArdle
Neil Lalonde
Guo Xiang Tan
Arpit Jalan
Régis Hanol
Robert Riemann
scossar
James Kiesel
Robin Ward
riking
Peter N Lewis
Jorge Manrubia