Commit Graph

7535 Commits

Author SHA1 Message Date
Robin Ward d43944b3ed Extensibility for tracking changes to a topic 2015-01-28 13:37:06 -05:00
Dan Singerman dbf2f4efec Fix bug when sso_overrides_avatar is true but no avatar_url is passed
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)

This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
Régis Hanol b003c2b4f3 let's try category class again 2015-01-27 23:44:47 +01:00
Arpit Jalan 5128aa1052 Minor code optimization 2015-01-27 22:51:57 +05:30
Arpit Jalan 12c82bed59 Disable digest emails site setting 2015-01-27 22:41:36 +05:30
Greg Kempe d99ccf6d27 FIX: creating a user shouldn't error when optional fields aren't provided
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.

Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
Sam fbd18f3b69 Merge pull request #3132 from lidlanca/patch-4
Perf UX : reduce page paint on scrolling, due to fixed header element union with progress bar area
2015-01-27 14:40:49 +11:00
Sam d52b0a2458 temporarily disable category class on body while debugging issue with missing docking header 2015-01-27 13:43:40 +11:00
lidlanca 0ffea11ccb Perf UX : reduce page paint on scrolling, due to fixed header element union with progress bar
Should provide some performance improvement for scrolling on chrome
The fixed header and the fixed progress bar on both ends  of the screen will invoke a complete visible page redraw.

For whatever reason this css should make things better for low performance devices. only tested on chrome superficially.
2015-01-26 20:47:43 -05:00
Sam 497042ddf2 FIX: don't restrict to local filesystem for df check
FIX: check correct directory when looking at backup limits
2015-01-27 08:25:57 +11:00
Régis Hanol efd65dcc8c hard match domains for automatic group membership 2015-01-26 23:17:29 +01:00
Régis Hanol 088260f053 BREAK: improve consistency by using 'category-<slug>' instead of 'category-<id>' as css class 2015-01-26 23:11:41 +01:00
Robin Ward 51827b06ac Merge pull request #3130 from techAPJ/master
FEATURE: suppress digest emails for users not seen on the site for more ...
2015-01-26 13:12:47 -05:00
Régis Hanol 3b3c0d7088 add category name as a css class to topic list item (props to @lagwagon) - closes #3129 2015-01-26 18:43:55 +01:00
Arpit Jalan 5c2ee8ec2a FEATURE: suppress digest emails for users not seen on the site for more than (n) days. 2015-01-26 22:04:02 +05:30
Robin Ward 30cd341b0d UX: Max width of .gifv videos 2015-01-26 11:00:18 -05:00
Robin Ward b3a9f91bd3 UX: You should be able to tab to the "This is a warning" checkbox 2015-01-26 10:52:17 -05:00
Jeff Atwood 8ef2a111a0 fix left margin on tablet portrait w/topic + list 2015-01-25 23:45:36 -08:00
Régis Hanol 78a7fb4b07 Merge pull request #3125 from gschlager/bugfix_01
FIX: Loading of Emoji files depended on working directory
2015-01-25 17:42:16 +01:00
Jeff Atwood bab5167566 tighten up suggested topic table layout 2015-01-25 00:33:52 -08:00
riking 9e9119d1c1 FEATURE: Enable pagination of /posts.json 2015-01-23 21:22:19 -08:00
riking 1d24d8471e FEATURE: Latest posts endpoint at /posts.json 2015-01-23 21:16:03 -08:00
riking fb72e2665f PERF 🐎 Don't calculate preload data for non-xhr json requests
This will help out anyone querying as API instead of through a
browser.
2015-01-23 21:14:58 -08:00
Jeff Atwood 246ae75a31 FIX: language was not being inserted into RSS 2015-01-23 15:57:29 -08:00
Gerhard Schlager 361b3fb07a FIX: Loading of Emoji files depended on working directory
The importer scripts could not be used unless the working directory was
the Discourse root directory.
2015-01-24 00:07:39 +01:00
Jeff Atwood 4904eeaa67 more pastel (desaturated) progress bar 2015-01-23 14:03:27 -08:00
Jeff Atwood 545d5b4906 turn down lightness scale of progress bar a bit 2015-01-23 12:39:07 -08:00
Robin Ward d06d050eb7 UX: When oneboxing a topic, use the stripe category badge 2015-01-23 15:12:42 -05:00
Régis Hanol f7f5e39f75 FIX: Minor Admin bug with a setting when creating a new group 2015-01-23 20:31:48 +01:00
Régis Hanol e6f849f873 FIX: make sure pasting an image in the composer is considered as an image instead of an attachment 2015-01-23 19:17:33 +01:00
Régis Hanol 256519dddf FEATURE: automatic group membership based on email address 2015-01-23 18:25:43 +01:00
Robin Ward 2ea4c1c9de FIX: Groups post page was broken.
Also added integration tests so we don't miss this breaking in the
future.
2015-01-23 11:13:27 -05:00
Robin Ward 848d60d459 FIX: Posts weren't highlighting on initial load 2015-01-23 10:46:44 -05:00
Régis Hanol ea1d53f848 Merge pull request #3121 from techAPJ/patch-1
FIX: full user names were showing up in crawlers and rss feeds in spite ...
2015-01-22 18:28:50 +01:00
Robin Ward b3a2c0c45b SECURITY: The SSO `return_path` was an open redirect
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
Arpit Jalan 63556a904a FIX: full user names were showing up in crawlers and rss feeds in spite enables_names setting being disabled 2015-01-22 22:34:35 +05:30
Robin Ward 7741e4dc02 Change the `admin-menu` outlet to use a tagName of `li` 2015-01-21 16:21:27 -05:00
Robin Ward 9e82c41576 Merge pull request #3119 from techAPJ/patch-3
FIX: user name and title were not showing on post creation
2015-01-21 16:04:00 -05:00
Arpit Jalan 62c1291548 FIX: user name and title were not showing on post creation 2015-01-22 02:28:04 +05:30
Régis Hanol 141f697482 remove unused route 2015-01-21 20:54:07 +01:00
Régis Hanol e300945879 FEATURE: split group admin in 2 tabs (custom & automatic)
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
Robin Ward 03eb4752d1 Add `categories-list` css class to body for customization purposes 2015-01-21 14:34:01 -05:00
Robin Ward 48c7e20d80 DRY up the displaying of topic categories. Should not be duplicated. 2015-01-21 12:20:39 -05:00
Robin Ward df8880a71a FIX: (for IE9) if `console.log` doesn't exist, make it an noop. 2015-01-21 11:53:41 -05:00
Jeff Atwood 1ed34be1b9 make topic list pin color consistent with lock 2015-01-21 03:15:56 -08:00
Jeff Atwood e5cad726fd further tweaks to get post selection OK on mobile 2015-01-20 22:51:15 -08:00
Jeff Atwood c4ddc5b983 quick mobile css fix for post selection buttons 2015-01-20 17:28:06 -08:00
Jeff Atwood aa423212a0 make topic list bookmark color consistent with lock 2015-01-20 16:39:11 -08:00
Robin Ward 614ad4daa7 UX: Formatting on search categories looked weird 2015-01-20 17:51:12 -05:00
Robin Ward 649dfd8d23 Revert "Convert html.js to ES6 module format"
This reverts commit 60523d8e02.
2015-01-20 16:13:42 -05:00
Robin Ward 60523d8e02 Convert html.js to ES6 module format 2015-01-20 16:07:29 -05:00
Robin Ward e3b4d12e46 Merge pull request #3110 from riking/notification_lanaguage
FIX: Respect user locale for reply notifications
2015-01-20 15:17:18 -05:00
Robin Ward 350554e198 UX: Change category badge style to use stripes 2015-01-20 14:56:06 -05:00
Robin Ward f3c9310e12 Merge pull request #3117 from techAPJ/patch-1
FEATURE: rate limit invites for non-staff users
2015-01-20 10:45:00 -05:00
Neil Lalonde 4c0129ccdd PERF: slow user pages in admin. add an index for trust level 3 calculations, and memoize query results 2015-01-19 15:30:16 -05:00
Arpit Jalan 5e751ce90a FEATURE: 🎁 rate limit invites for non-staff users 2015-01-20 01:12:24 +05:30
Neil Lalonde 7412ff4da7 FIX: suspended users are logged out when they are suspended. Show a reason for suspension when they try to log in. 2015-01-19 12:37:02 -05:00
Arpit Jalan 7687c95e7b UX: add file size in CSV export notification 2015-01-19 19:21:53 +05:30
Jeff Atwood 90ff92e008 don't show self-bookmark avatar in user stream 2015-01-19 01:08:39 -08:00
Jeff Atwood 3f7fa46af7 remove unnecessary site header title height 2015-01-19 00:44:23 -08:00
Jeff Atwood 3d0e59942c IE9 doesn't support console.log 2015-01-19 00:33:51 -08:00
riking 03fd275b45 FIX: Respect user locale for reply notifications 2015-01-17 23:17:50 -08:00
riking 1ab0d6bd82 FEATURE: Log username changes by staff
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
Robin Ward 37d73ec488 Support customizing the composer below the textarea 2015-01-16 12:52:40 -05:00
Jeff Atwood 24b282e5e9 clicking expanded post date also jumps to post 2015-01-16 03:06:19 -08:00
Régis Hanol 7a86abd105 Merge pull request #3084 from jmay/group-managers
table & model changes for group managers with permission to edit members
2015-01-16 12:02:38 +01:00
Jeff Atwood 2b877e4fc4 post expansion arrow CSS cleanup 2015-01-16 02:24:49 -08:00
Jeff Atwood d890248963 normalize post expansion arrow on right 2015-01-16 01:56:36 -08:00
Jeff Atwood 992ad7991b UX: change private category to lock glyph 2015-01-15 14:07:21 -08:00
Robin Ward 987504c6ab Rename `no_js` layout to `no_ember`
While *sometimes* `no_js` was used for visitors without js (for example
disabling it on your browser) it was also used for some pages that were
disabled to JS capable browsers, including the 404 page.

Even worse, sometimes it was used on pages that *had* Javascript, such
as our `/activate-account` route. It has been renamed to `no_ember` to
indicate what it really is, a layout for the site that doesn't load our
Ember.js application.
2015-01-15 15:56:53 -05:00
Robin Ward e4e239c159 Add some safety when rendering a dropdown button to make sure it has
content.
2015-01-15 15:43:37 -05:00
Robin Ward dc801bb442 Merge pull request #3102 from techAPJ/patch-2
Add username and date-time in exported file name
2015-01-15 15:35:06 -05:00
Robin Ward 505fa9f1cf FIX: 🐛 Saving the same custom field array twice would raise an error 2015-01-15 15:31:50 -05:00
Jeff Atwood 3ab2f105b4 switch no_js view back to old layout 2015-01-15 12:29:37 -08:00
Arpit Jalan c619aed8f9 💄 add username and date-time in exported file name 2015-01-16 01:39:46 +05:30
Robin Ward 9c977a08cd FIX: 🐛 supress the category badge even when refreshing 2015-01-15 14:59:51 -05:00
Jason W. May a2b284a0a4 table & model changes for group managers with permission to edit membership 2015-01-15 11:44:42 -08:00
Régis Hanol 20d2908c50 FEATURE: add a global notice whenever emails are disabled (disable_emails site setting) 2015-01-15 19:32:19 +01:00
Robin Ward 6c4c542ae3 FIX: Triggering a refresh while subcategory lists was broken.
It would then list all categories isntead of the subcategory you were
viewing at that time.
2015-01-15 13:01:35 -05:00
Régis Hanol b4e5937850 FIX: 🐛 ensure emoji are case insensitive 2015-01-15 19:00:55 +01:00
Régis Hanol beea92a74b FIX: 🐛 show email button wasn't working on user's profile page 2015-01-15 17:58:50 +01:00
Jeff Atwood ef8976d68a better no-js and crawler image sizing 2015-01-15 02:20:38 -08:00
Jeff Atwood 71bfde3b4d meant device-width there, oops 2015-01-15 01:37:02 -08:00
Jeff Atwood 6b30f8444e normalize crawler and no-js views 2015-01-15 01:31:30 -08:00
Jeff Atwood 4cf4f1f252 Merge pull request #3101 from techAPJ/patch-1
set csv compression to optimal speed/size
2015-01-15 00:43:38 -08:00
Jeff Atwood 5c92c39003 remove csrf, font-face, css from js-off + crawler 2015-01-15 00:41:30 -08:00
Jeff Atwood 6a6e254096 move viewport meta tag out of shared header 2015-01-15 00:24:39 -08:00
Arpit Jalan 5039213840 set csv compression to optimal speed/size 2015-01-15 09:07:53 +05:30
Jeff Atwood 655dd66884 change JS-off "emergency" viewport to 720px 2015-01-14 17:06:45 -08:00
Jeff Atwood 0a4582fbc7 add meta viewport tag to JS-off view just in case 2015-01-14 16:56:01 -08:00
Robin Ward a28784c8f7 Add a `{{plugin-outlet}}` for the `admin-menu` 2015-01-14 16:05:29 -05:00
Robin Ward f8d3764d5e Convert many buttons to `d-button` 2015-01-14 15:50:20 -05:00
Robin Ward e7443247dd Adds plugin-outlet for topic menu buttons. Also a `d-button` component. 2015-01-14 15:50:20 -05:00
Robin Ward 28f702a5b6 Refactor app events to more efficiently handle post highlighting 2015-01-14 15:50:19 -05:00
Robin Ward 78d5d22776 FIX: Posts weren't highlighting when jumping using the progress widget 2015-01-14 15:50:19 -05:00
Régis Hanol 07d3f0fc26 Merge pull request #3100 from riking/patch-1
Set Turkish pluralization rules
2015-01-14 19:52:37 +01:00
Kane York 31c8b5763f Set Turkish pluralization rules
Turkish does not have different forms for singulars next to numerals
https://meta.discourse.org/t/turkish-translation-missing-many-singular-strings/23334/
2015-01-14 10:39:31 -08:00
Arpit Jalan c4da9ce62f FIX: old csv's were not getting deleted 2015-01-15 00:00:39 +05:30
Régis Hanol 6734a51b6a move SiteText.{head,top,bottom} to SiteCustomization 2015-01-14 12:15:53 +01:00
Arpit Jalan 835835832f FIX: user list export was failing 2015-01-14 16:24:42 +05:30
Régis Hanol b34ef26f90 Merge pull request #3096 from techAPJ/patch-1
gzip csv export files
2015-01-14 09:23:15 +01:00
Arpit Jalan b94c7922c5 🐎 gzip csv export files 2015-01-14 13:38:37 +05:30
Robin Ward 8b87d8ac2d Refactor sharing dialog for extensibility 2015-01-13 17:26:05 -05:00
Robin Ward 0de6226a20 FIX: Remove Bookmark was broken on bookmarks page
This was particularaly bad now that we removed stars :)
2015-01-13 13:14:58 -05:00
Arpit Jalan 7771d2fb31 remove enable_email_names setting 2015-01-13 13:35:40 +05:30
Jeff Atwood 935df99acf fix minor mobile topic styling issue 2015-01-12 17:26:04 -08:00
Robin Ward f3b72f5d96 Revert "move SiteText.{head,bottom} to SiteCustomization and remove redundant SiteText.top"
This reverts commit 6ee2849df6.
2015-01-12 20:21:22 -05:00
Robin Ward 1e6dea46dd FIX: Jump to post was not respecting gaps 2015-01-12 18:10:30 -05:00
Arpit Jalan bbb23bb736 FIX: users tab in admin panel doesn’t stay highlighted 2015-01-13 02:04:59 +05:30
Robin Ward dba57a4a25 Add title to user header. Refactor `statusIcon` a bit. 2015-01-12 14:45:43 -05:00
Régis Hanol 6ee2849df6 move SiteText.{head,bottom} to SiteCustomization and remove redundant SiteText.top 2015-01-12 19:59:43 +01:00
Régis Hanol 03b053c800 FIX: bookmark button is now solid black by default & blue when bookmarked 2015-01-12 17:48:54 +01:00
Régis Hanol 645a22fdd5 FIX: background fade-in for modal dialogs 2015-01-12 16:29:38 +01:00
Régis Hanol f0f1afff03 FIX: forgot i18n associated with bookmark button (:fired:) 2015-01-12 16:05:17 +01:00
Régis Hanol c681b353f2 FEATURE: bookmark topic button 2015-01-12 12:10:15 +01:00
Jeff Atwood a9ef92f3d8 latest topics on category page too damn small 2015-01-12 02:56:55 -08:00
Jeff Atwood 84286fb501 normalize topic post first element top-margins:0 2015-01-12 02:24:06 -08:00
Jeff Atwood 5f05e1394b consistent post top margins 2015-01-12 00:35:04 -08:00
Jeff Atwood 8d49aec789 clean up leftover bottom-round padding 2015-01-11 23:51:19 -08:00
Jeff Atwood 76c750be68 get rid of .bottom-round css class used once 2015-01-11 23:39:48 -08:00
Jeff Atwood e572ad35ad new topic/post alert div regressed a bit on mobile 2015-01-23 23:39:44 -08:00
Jeff Atwood 7d268ff49f give home icon more breathing room 2015-01-09 15:18:42 -08:00
Robin Ward 38e4defaee Support adding items to the site map via plugin outlet. 2015-01-09 16:15:16 -05:00
Sam d54e2770a1 correct build 2015-01-09 16:54:58 +11:00
Jeff Atwood 625c920c4f fix mobile layout issue with download posts btn 2015-01-08 17:32:24 -08:00
Sam 1358ed2aad FEATURE: show bookmarked topics in topic list 2015-01-09 11:41:10 +11:00
Robin Ward 7124456ae4 Merge pull request #3083 from cpradio/pr-add-class-to-gutter-links
UX: Add class to gutter links so you can infer if they are inbound or outbound using CSS
2015-01-08 17:35:25 -05:00
Robin Ward 0bc0bd7a21 Pass the `current_user` to the topic saved event 2015-01-08 17:29:11 -05:00
cpradio fdfde22d0b UX: Add class to gutter links so you can infer if they are inbound or outbound using CSS 2015-01-08 17:20:50 -05:00
Robin Ward 74051a2df4 Allow plugins to build topic lists 2015-01-08 16:44:27 -05:00
Sam 69cfab62b8 PERF: don't bind all these things
TODO - cleaner pattern and helper for this
2015-01-08 14:50:20 +11:00
Sam 3347a48275 FEATURE: add liked and bookmarked classes to topic list item rows 2015-01-08 14:35:56 +11:00
Sam df7def6628 annotate 2015-01-08 11:18:43 +11:00
Robin Ward c02a31d8b4 Raw templates should resolve their views with the resolver 2015-01-07 14:21:31 -05:00
Régis Hanol 8627a1e507 FIX: making sure {{fa-icon}} don't break when we'll update to latest ember 2015-01-07 18:14:31 +01:00
Régis Hanol 2b3e311e8e FIX: emoji rebuild when changing emoji set for the 1st time 2015-01-07 17:54:09 +01:00
Robin Ward 114cc1c851 FIX: We missed some references to `/category/xyz` in the ruby code base. 2015-01-07 11:47:01 -05:00
Régis Hanol 65f0339146 FIX: un-delete topic wasn't working 2015-01-07 10:53:12 +01:00
Régis Hanol 66882155f0 FIX: emoji toolbar wasn't showing up after a page reload 2015-01-07 10:46:43 +01:00
Régis Hanol 6512e403ae FIX: each helper in raw templates 2015-01-07 09:30:32 +01:00
Sam 6785675150 clean up support for filter=liked and filter=bookmarked 2015-01-07 18:50:28 +11:00
Sam 984f8f0c27 FEATURE: show bookmarked topics when doing filter=bookmarked 2015-01-07 18:20:41 +11:00
Sam ea87f5fd8a FEATURE: support for filter=bookmarked and filter=liked in topic list 2015-01-07 18:20:10 +11:00
Sam da3da6feee each ... in ... support for ember compat handlebars 2015-01-07 18:18:26 +11:00
Sam 95f9788a77 FEATURE: add ?bookmarked=true for topic lists 2015-01-07 13:58:34 +11:00
Sam efc717c14a FEATURE: remove star concept from Discourse 2015-01-07 13:43:27 +11:00
Jeff Atwood fa8493118b remove underline on composer cancel, hide preview 2015-01-06 16:35:57 -08:00
Jeff Atwood 86c13ada44 fix a few places we were using /category vs /c 2015-01-06 15:56:07 -08:00
Neil Lalonde 880dcbb365 Merge branch 'master' of github.com:discourse/discourse 2015-01-06 17:28:58 -05:00
Neil Lalonde 58385248a6 Show contact_email on about page 2015-01-06 17:28:42 -05:00