7896c74c2b
DEV: Remove use of ActiveRecord in migration.
...
It makes the migration brittle to changes. If I could I would go back in
time and tell the 2016 version of me that.
2019-01-10 11:10:21 +08:00
c2bca9cabe
Make rubocop happy.
2019-01-10 10:52:15 +08:00
d10694150e
Revert "FIX: Partial reply key search in email sent logs."
...
This reverts commit e9b2018bc8
2019-01-10 10:05:56 +08:00
798e98a7cc
remove safari check from isAppleDevice ( #6869 )
2019-01-10 13:02:55 +11:00
51b13ec86f
FIX: show lock glyph to a user without permissions to see quote ( #6854 )
2019-01-10 09:48:05 +08:00
cb0f6d653b
DEV: Minor fixes to b63b399799.
2019-01-10 09:38:22 +08:00
b63b399799
DEV: remove uploaded_meta_id column from category ( #6725 )
...
* DEV: remove uploaded_meta_id column from category
* remove uploaded_meta part
2019-01-10 09:37:21 +08:00
a52baf4b28
FEAT: use category logo image as meta image ( #6865 )
2019-01-10 09:33:13 +08:00
e9b2018bc8
FIX: Partial reply key search in email sent logs.
...
Follow up to c85b9c6ed3
2019-01-10 09:25:14 +08:00
35b59cfa78
SECURITY: escape title HTML for inline onebox
2019-01-10 12:02:05 +11:00
c85b9c6ed3
FIX: searching email logs by reply key ( #6868 )
...
* you can't use LIKE or ILIKE on a UUID
2019-01-10 07:51:58 +08:00
6f867660bc
FIX: Push notifications didn't work anymore
2019-01-09 22:47:38 +01:00
e11c6ffa89
FEATURE: allow extending CSP base-uri and object-src
...
Plus, ensure :none is stripped, it cannot be combined with other sources
2019-01-09 15:34:14 -05:00
9ba8bfb1aa
FIX: Multisite DB was leaving old data in test mode
...
This commit introduces a new helper to enable transactional fixtures
when testing multisite. This would show up as tests that passed the
first time then failed the second time due to stale data being leftover.
2019-01-09 15:20:37 -05:00
dec8e5879a
FEATURE: set CSP base-uri and object-src to none ( #6863 )
2019-01-09 15:04:50 -05:00
af227cada5
FIX: Bump onebox version for gfycat aspect ratio fix
...
Including the `Gemfile.lock` changes this time
2019-01-09 18:08:46 +00:00
1f0708981f
FIX: Bump onebox version for gfycat aspect ratio fix
2019-01-09 18:00:28 +00:00
312e282b6a
FIX: Apply classes when lazily loading images
...
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.
This fix copies the classes while loading.
2019-01-09 12:56:25 -05:00
439eff4709
revert null checking around interceptClick
2019-01-09 09:44:30 -08:00
2d3e50ae7c
FIX: Match default `<code>` padding to highlightjs padding
...
Without this, the height of posts changes once highlightjs is lazy-loaded, potentially causing scrolling issues
2019-01-09 17:36:51 +00:00
286cc72c8b
FIX: Gyfcat onebox should have fixed aspect ratio videos
...
(Fixed upstream in the onebox gem)
2019-01-09 17:15:15 +00:00
8b3ddcf646
FIX: Add topic status to flagged topics list
...
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
2019-01-09 10:59:35 -05:00
1f12a377fa
minor refactoring of card-contents-base mixin
2019-01-09 19:32:30 +05:30
abee39ecd0
Bump logster to 1.4.0.pre ( #6866 )
...
2 new features and a few fixes. More details here:
https://github.com/discourse/logster/pull/76
https://github.com/discourse/logster/pull/77
2019-01-09 13:50:48 +03:00
2684ecaecf
minor copyedit
...
Topics will be in closed status until the community flags are handled
2019-01-09 14:49:28 +05:30
b7c501bf52
FIX: full page search results are unclickable
...
data-ember-action can have empty value in favor of data-ember-action-ID attribute
2019-01-09 10:59:37 +05:30
4ddd8fad20
DEV: Raise error with stats.
2019-01-09 10:54:02 +08:00
2748822576
FEATURE: Remove option for Google Plus sharing ( #6864 )
...
* Remove option for Google Plus sharing
* remove google+ share translations
2019-01-09 10:17:50 +08:00
25269a37aa
FIX: do not show #uncategorized in category drop if setting is disabled ( #6856 )
2019-01-09 09:44:24 +08:00
6e7b383ed6
[docs] Add instructions for CentOS/RHEL users in install guide ( #6861 )
2019-01-09 09:31:27 +08:00
4232d32699
PERF: reduce workload when optimizing images
...
Previously, we would initialize an ImageOptim object each time we resize.
This object init is mega expensive (170ms on a VERY fast machine):
```
[1] pry(main)> Benchmark.measure { FileHelper.image_optim }
=> #<Benchmark::Tms:0x00007f55440c1de0
@cstime=0.055742,
@cutime=0.141031,
@label="",
@real=0.17165619300794788,
@stime=0.0002750000000000252,
@total=0.19890400000000008,
@utime=0.0018560000000000798>
```
This happens cause during init it hunts for all the right binaries and sets
up internals.
We now memoize this object to avoid a huge amount of pointless work.
2019-01-09 12:28:18 +11:00
f73fe36772
FEATURE: PWA compatibility checks in the Dashboard ( #6850 )
2019-01-09 08:46:11 +08:00
09cbd08c64
FIX: ensure ember transitions do not get hijacked by discourse intercept-click
...
explicit null checks as a blank string evaluates to false
2019-01-08 15:38:13 -08:00
d75262046d
Revert "FIX: ensure ember transitions do not get hijacked by discourse intercept-click"
...
This reverts commit a2cb2f2366
2019-01-08 15:37:10 -08:00
a2cb2f2366
FIX: ensure ember transitions do not get hijacked by discourse intercept-click
...
explicit null checks as a blank string evaluates to false
2019-01-08 15:09:50 -08:00
824c3420e9
DEV: make Jobs.enqueue tests less fragile
...
Previously we depended on non Sidekiq specific mocking which is not the
official way of testing Sidekiq, this made these tests very fragile
New testing is more robust and complete
2019-01-09 09:51:11 +11:00
df460b4abd
PERF: run sidekiq with nice 5
...
This ensures that unicorn master forks of sidekiq run with a lower priority
than the webs. It means that a busy sidekiq is less likely to impact web
performance
2019-01-09 09:29:14 +11:00
7e4a43afc6
PERF: run ImageMagick conversions with nice 10
...
This lowers the priority of all image resizes so they do not clog CPU on
machines running low on resources
2019-01-09 09:21:58 +11:00
e08a3f719c
FEATURE: push post rebake regular task to low priority queue
...
This allows us to run regular rebakes without starving the normal queue.
It additionally adds the ability to specify queue with `Jobs.enqueue` so
we can specifically queue a job with lower priority using the `queue` arg.
2019-01-09 08:57:20 +11:00
cfb8e157a2
Fixing tag alignment
2019-01-08 16:25:11 -05:00
3ec38f5a3b
Revert "FIX: migrate_to_s3 rake task with folder path"
...
This reverts commit 97fd12e8af
2019-01-08 19:44:31 +01:00
4a01fee41b
UX: use default H2 and H3 sizes on user profiles for better hierarchy
2019-01-08 13:07:29 -05:00
97fd12e8af
FIX: migrate_to_s3 rake task with folder path
2019-01-08 18:56:18 +01:00
fe20cb4b56
FIX: Enforce a fixed height on generic oneboxed videos
...
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
2019-01-08 16:22:03 +00:00
a2d1babac6
UX: tag container should wrap if there's a large number of tags
2019-01-08 23:33:47 +08:00
f181e9cc08
FIX: Add compatibility for bucket folder paths in migrate_to_s3 task ( #6855 )
...
* FIX: Add compatibility for bucket folder paths in migrate_to_s3 task
* Refactor bucket_name split logic into S3Helper
2019-01-08 20:04:48 +05:30
733a60e888
FIX: Remove trailing whitespace to fix build
2019-01-08 17:37:43 +05:30
8f602be2fe
FEATURE: keep the topic in closed status until the community flags are handled
2019-01-08 16:13:10 +05:30
f947e3c6cc
FIX: always serve new avatar for previous version
...
Previously we killed caching on old avatars cause we kept serving blank
this meant we would front many more avatar requests after a version change
This change ensures all old avatars do not cause a flood of requests on the
server
2019-01-08 19:51:33 +11:00
ec27db78be
FIX: Set unique post key for a user outside of transaction.
...
Previously, the Redis key was set within the transaction and the key
isn't deleted if the transaction is not successful.
Note that this isn't tested because we don't have a repro of what can
raise an error within the transaction.
https://meta.discourse.org/t/body-is-too-similar-to-what-you-previously-posted-even-when-previous-post-didnt-go-through/105436
2019-01-08 15:22:22 +08:00
Guo Xiang Tan
Angus McLeod
Maja Komel
Saurabh Patel
Sam
Michael Brown
Gerhard Schlager
Penar Musaraj
Robin Ward
Kyle Zhao
David Taylor
Jeff Wong
Vinoth Kannan
Osama Sayegh
Zach Whitehead
Joffrey JAFFEUX
Justin W. Flory
Rafael dos Santos Silva
Kris
Régis Hanol
Joe
Rishabh