Commit Graph

17404 Commits

Author SHA1 Message Date
Kris f0bea4ae55 Improve PM participant list 2018-08-01 16:20:14 -04:00
Robin Ward 4eef41ea1b FIX: Error with debouncing mentions 2018-08-01 15:57:24 -04:00
Gerhard Schlager 2ec1aec2be FIX: Clicking admin wrench in topic footer didn't hide post select box 2018-08-01 21:29:35 +02:00
Dan Ungureanu 1a0ffc5ace FEATURE: Added method to get multiple values at once from PluginStore. (#6225) 2018-08-01 18:42:40 +02:00
Gerhard Schlager f4ca105498 FIX: Moving posts to existing topic didn't update topic metadata 2018-08-01 18:05:43 +02:00
Robin Ward d7b463a03d FIX: Remove unused import 2018-08-01 11:54:47 -04:00
Robin Ward 7c950321d1 FIX: Allow non-english usernames in autocomplete
Also add support for username formatters
2018-08-01 11:53:20 -04:00
Neil Lalonde b829452c75
Merge pull request #6209 from discourse/mini_scheduler
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX 0b9437cee7
FIX: more resilient/consistent dashboard caching (#6223) 2018-08-01 09:45:50 -04:00
Joffrey JAFFEUX 7c7dfa4e5e
FIX: wraps any query with the slow query guard (#6222) 2018-08-01 07:39:57 -04:00
Vinoth Kannan 8178444382 Make prettier happy 2018-08-01 15:13:54 +05:30
Vinoth Kannan 8556288397 DEV: Export Tag class to modify methods in plugin 2018-08-01 15:10:15 +05:30
Gerhard Schlager a115aae45f Use rchardet instead of charlock_holmes gem 2018-08-01 10:41:20 +02:00
Gerhard Schlager 5d421fb946 FIX: Try respecting charset in HTTP header of RSS feed 2018-08-01 10:41:20 +02:00
Gerhard Schlager ff942ed2f3 FIX: Try detecting encoding of RSS feed 2018-08-01 10:41:20 +02:00
Penar Musaraj 1f45215537 FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream

* improve drafts stream display in user profile

* truncate excerpts in drafts list, better handling for resume draft action

* improve draft stream SQL query, add rspec tests

* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)

* cleanup

* linting fixes

* apply prettier styling to modified files

* add client tests for drafts, includes a fixture for drafts.json

* improvements to code following review

* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix

* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed

* prettier, eslint fixes

* use "username_lower" from users table, added error handling for rejected promises

* adds guardian spec for can_see_drafts, adds improvements following code review

* move DraftsController spec to its own file

* fix failing drafts qunit test, use getOwner instead of deprecated this.container

* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan 70ea153dce Fix lint. 2018-08-01 12:23:36 +08:00
Guo Xiang Tan 53adbf70f3 FIX: Nav item missing for plugins that don't include a custom filter. 2018-08-01 11:50:14 +08:00
Joffrey JAFFEUX 5febe71baa
FIX: prevents crash if flagger doesn’t exist (#6219) 2018-07-31 23:48:54 -04:00
Joffrey JAFFEUX 849f0d00f6
FEATURE: adds revision_count to moderators_activity (#6218)
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
Guo Xiang Tan 919e8db686 FIX: Check for group name availability should skip reserved usernames. 2018-08-01 11:09:33 +08:00
Kris 129268ddc6 Highlighted titles too wide on mobile 2018-07-31 21:24:43 -04:00
Joffrey JAFFEUX 2b2a506a7b
FIX: makes dashboard more resilient to errors (#6217)
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX 0715aa18da
UI: uses tiny avatars for reports (#6215) 2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX 37252c1a5e
UI: improves dashboard table reports
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Neil Lalonde 4ad7ce70ce REFACTOR: extract scheduler to the mini_scheduler gem 2018-07-31 17:12:55 -04:00
Robin Ward 4b166cccc1 FIX: Linting error 2018-07-31 14:19:45 -04:00
Robin Ward b6bb8df622 FIX: We loosened username restrictions some time ago
Additionally, remove `Discourse.User` constant
2018-07-31 13:53:31 -04:00
Vinoth Kannan ece3cb73df Rename humburger_menu_categories_count site setting to header_dropdown_category_count 2018-07-31 09:12:30 +05:30
Neil Lalonde fd29ecb91a UX: include a flag reason in the post-deleted-by-staff-because-of-flags message 2018-07-30 16:45:46 -04:00
Neil Lalonde c12a9279f6 post deleted notification regression because controller was agreeing with all flags too early 2018-07-30 16:45:46 -04:00
Vinoth Kannan c1e62808ed FIX: Top site categories are displayed in random order 2018-07-31 01:01:03 +05:30
Kris 7368dd8e7d Prevent activity-metrics stats from wrapping 2018-07-30 14:40:26 -04:00
Joffrey JAFFEUX c6fd506a15
fix eslint 2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX 2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus 2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX a327393651
fix 1.14.0 prettier offenses 2018-07-30 11:56:48 -04:00
Joffrey JAFFEUX 536f88b95b Revert "DEV: prettier 1.14.0"
This reverts commit 1f899bec21.
2018-07-30 11:52:05 -04:00
Joffrey JAFFEUX 1f899bec21
DEV: prettier 1.14.0 2018-07-30 11:09:08 -04:00
Vinoth Kannan c54b5824d4 REFACTOR: Prioritize unread categories in hamburger menu 2018-07-30 20:20:10 +05:30
David Taylor 6566b2f11a FEATURE: Allow revoke and connect for Instagram logins 2018-07-30 14:38:53 +01:00
Joffrey JAFFEUX d494feaa32
FIX: should not be needed as we have itemprop='url' 2018-07-30 09:31:27 -04:00
Arpit Jalan dfcb2a0d42 FEATURE: include published_time in metadata 2018-07-30 17:09:56 +05:30
Vinoth Kannan 50df2d7241 FIX: Should not include regular categories in top_category_ids array 2018-07-30 16:06:36 +05:30
Maja Komel 04baddf731 DEV: migrate tests to async/await 2018-07-30 12:21:05 +02:00
Vinoth Kannan 176d8ca78d
FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:39:37 +05:30
Vinoth Kannan 249b16e8e3 FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:37:41 +05:30
Guo Xiang Tan 581cf62bcf UX: Allow emojis to be displayed in nav-item. 2018-07-30 18:02:34 +08:00
Guo Xiang Tan ef78268c01 Give `ExtraNavItem` more control over when it can be displayed. 2018-07-30 17:30:13 +08:00
Arpit Jalan ba64ebbf10 FIX: preserve whitespace between uploads when the process is complete 2018-07-30 14:49:33 +05:30
Vinoth Kannan 78d91b1daf
UX: Changes in top categories of hamburger menu (#6200) 2018-07-30 14:13:00 +05:30
Guo Xiang Tan acde8d4323 Fix the build. 2018-07-30 15:07:03 +08:00
Guo Xiang Tan 96a0448c52 FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 14:44:02 +08:00
Guo Xiang Tan 87537b679c Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`. 2018-07-30 11:39:28 +08:00
Guo Xiang Tan b94633e844 FIX: `FileHelper` should prioritize response content-type.
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
2018-07-30 10:54:36 +08:00
Arpit Jalan fc3b904e1f remove "track external right clicks" feature 2018-07-29 15:01:33 +05:30
Joe 3dbaaf0d74
UX: gives wizard language selector more room to expand 2018-07-28 11:51:53 +08:00
Kris 7a1a1eb4c0 improve header scaling with font size 2018-07-27 16:49:28 -04:00
Joffrey JAFFEUX a8f1b07686
FIX: prevents exception when loading old dashboard (#6196) 2018-07-27 16:29:30 -04:00
Kris 3159c46613 Making dataless sections stand out less 2018-07-27 14:55:51 -04:00
Kris 60b2c3207e larger mobile topic list badges 2018-07-27 13:10:13 -04:00
David Taylor 5f1fd0019b FEATURE: Allow revoke and connect for GitHub logins 2018-07-27 17:18:53 +01:00
David Taylor 6296f63804 FEATURE: Revoke and connect for Yahoo logins 2018-07-27 16:20:47 +01:00
Vinoth Kannan a9c959e3e2 Make prettier happy 2018-07-27 20:39:44 +05:30
Vinoth Kannan bc501038cb FIX: Remove null value from categories list 2018-07-27 20:00:39 +05:30
Joe 85291e53f1
UX: more categories link alignment 2018-07-27 22:17:29 +08:00
David Taylor 9c72c00206 FEATURE: Revoke and reconnect for Twitter logins 2018-07-27 12:28:51 +01:00
Vinoth Kannan 5b4e13bfcc Make prettier happy 2018-07-27 13:20:21 +05:30
Vinoth Kannan c0f7d95bb8 Include subcategories in hamburger menu top categories 2018-07-27 13:05:18 +05:30
Vinoth Kannan dac29b5ebc
UX: Display only top categories in hamburger menu (#6146) 2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX b7d1864d0a
FIX: simplify filters on admin-report component (#6193) 2018-07-27 01:22:00 -04:00
Guo Xiang Tan 6f9a91cbd5
Merge pull request #6175 from vinothkannans/post_approval_webhook
FEATURE: Webhook for post approval events
2018-07-27 10:50:49 +08:00
Guo Xiang Tan ccf76d45f2 FIX: Missing variable outside of `begin` block. 2018-07-27 08:19:11 +08:00
Joffrey JAFFEUX 262beed1cf
FIX: fixes regression with category filtering (#6190) 2018-07-26 19:08:06 -04:00
Joffrey JAFFEUX 59684adc43
FIX: shows disk usage even if no backups taken (#6189) 2018-07-26 18:38:55 -04:00
Neil Lalonde 1708ff1808 UX: add a route /rules as an alias for /faq and /guidelines 2018-07-26 15:38:08 -04:00
Joffrey JAFFEUX 56ae826efb
UI: improves no data notice in reports (#6187) 2018-07-26 15:26:53 -04:00
Joffrey JAFFEUX 330cf78c83
FIX: don’t break browser history on dashboard visit (#6186) 2018-07-26 14:59:28 -04:00
Kris 8d67b20d37 z-index fix 2018-07-26 12:11:40 -04:00
David Taylor 88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login 2018-07-26 11:11:16 +01:00
David Taylor 63e15aa41a Add missing semicolon 2018-07-26 10:30:10 +01:00
Maja Komel e8d82f48bc add maxlength attribute for 2FA input fields 2018-07-26 10:31:20 +02:00
Vinoth Kannan af5b88f8e2 Rename approval web hook event type to queued post 2018-07-26 10:29:38 +05:30
Kris 67b6539d98 rounder topic-list badges in iOS 2018-07-25 23:58:23 -04:00
Kris 998b7fb87a Rounder topic-list badges on mobile 2018-07-25 22:30:30 -04:00
Guo Xiang Tan f8b367cc9c Fix the build. 2018-07-26 10:17:51 +08:00
Kris c5e7c60a37 Fixing profile avatar flair poisition on mobile 2018-07-25 22:00:56 -04:00
Kyle Zhao 1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123)
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Guo Xiang Tan 30242972d3 Add spec for 4bf3bf6786. 2018-07-26 09:16:14 +08:00
Nick Shearer def2c977ce allow auth plugins to have a site setting for if they should be full screen vs popup window 2018-07-25 19:20:11 -05:00
Régis Hanol f94aeaf6cf SECURITY: force IM decoder based on file extension - part 3 2018-07-25 23:55:06 +02:00
Régis Hanol 800c57c6ab SECURITY: force IM decoder based on file extension - part 2 2018-07-25 23:08:02 +02:00
Régis Hanol 4bf3bf6786 SECURITY: force IM decoder based on file extension 2018-07-25 22:00:04 +02:00
Kris 0e84024958
Updating style of theme options in wizard (#6177) 2018-07-25 15:32:14 -04:00
Kris 3fd2571abc Fix typo in color scheme 2018-07-25 15:12:01 -04:00
Joffrey JAFFEUX ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Vinoth Kannan 5059dad8f0 FEATURE: Webhook for post approval events 2018-07-25 23:43:19 +05:30
Joffrey JAFFEUX 6ee1ea96ef
fixes tests (#6176) 2018-07-25 14:02:21 -04:00
Joffrey JAFFEUX 01d1f850e9
FEATURE: uses category-chooser for report filtering (#6174) 2018-07-25 13:16:35 -04:00
Joffrey JAFFEUX fa6b7f6b8c
DEV: adds Object.entries and Object.assign polyfills (#6173) 2018-07-25 11:45:29 -04:00
David Taylor 0d0d78841b
FIX: Remove `plugin.enabled?` checks at initialization time (#6166)
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
  - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
  - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.

Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.

I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
  - `post_custom_fields_whitelist`
  - `whitelist_staff_user_custom_field`
  - `add_permitted_post_create_param`
2018-07-25 16:44:09 +01:00