Guo Xiang Tan
1cf3bf016c
Make rubocop happy.
2019-06-10 09:49:02 +08:00
Guo Xiang Tan
29259b46ae
DEV: Verbose mode for `posts:inline_uploads` rake task.
2019-06-10 08:59:11 +08:00
Vinoth Kannan
d74ee9dbce
DEV: skip S3 inventory records without correct multisite prefix.
2019-06-08 18:36:06 +05:30
Vinoth Kannan
45aebd00a5
SPEC: improve the spec using stubbed S3 client.
...
4d1204b5e8
2019-06-08 18:10:35 +05:30
Sam Saffron
1d76b7b7b5
PERF: fix N+A+lot query
...
reviewable_counts could be `{}` which is technically blank.
We wanted to check for nil here
2019-06-08 12:30:21 +10:00
Gerhard Schlager
19edc4abb8
FIX: English locale must not fall back to any other locale
2019-06-07 21:53:01 +02:00
Neil Lalonde
a08b2589d4
FIX: removing hidden tag bumps topic when all tags are removed
...
JS sends empty string to remove all tags.
2019-06-07 14:25:46 -04:00
Joffrey JAFFEUX
af08ab5b7b
Revert "DEV: prevents csrf-token initializer to leak session object ( #7730 )"
...
This reverts commit da5255e560
.
2019-06-07 18:31:16 +02:00
Joffrey JAFFEUX
ebecd0b7d1
Revert "fix tests, crsf token meta is not present on tests ( #7733 )"
...
This reverts commit 240b61e844
.
2019-06-07 18:31:13 +02:00
Joffrey JAFFEUX
8cd13b22a1
DEV: allows smoke test to run on macOS ( #7735 )
2019-06-07 18:20:48 +02:00
Gerhard Schlager
bae7b75e23
FIX: Updating a user profile as admin shouldn't change the user's locale
2019-06-07 17:53:46 +02:00
Joffrey JAFFEUX
2dce650b72
FIX: prevents screen-track from leaking object ( #7734 )
2019-06-07 17:18:27 +02:00
Joffrey JAFFEUX
240b61e844
fix tests, crsf token meta is not present on tests ( #7733 )
2019-06-07 17:11:16 +02:00
Joffrey JAFFEUX
dfb66334c1
DEV: prevents global-notice events to leak ( #7732 )
2019-06-07 16:49:59 +02:00
Joffrey JAFFEUX
55325679ac
DEV: prevents share-popup to leak events ( #7731 )
2019-06-07 16:48:45 +02:00
Joffrey JAFFEUX
da5255e560
DEV: prevents csrf-token initializer to leak session object ( #7730 )
2019-06-07 16:46:55 +02:00
Joffrey JAFFEUX
df01249db4
FIX: removes leaking handler in select-kit ( #7729 )
2019-06-07 16:12:22 +02:00
David Taylor
e3a9a2d2dd
FIX: Avoid infinite loop if disk space is low
...
We now continue to enqueue the pull_hotlinked_images job for optimized images, even if disk space is low
2019-06-07 14:24:22 +01:00
Joffrey JAFFEUX
fca90106b9
FIX: select-kit events were sometimes not cleaned up ( #7728 )
2019-06-07 15:20:01 +02:00
Gerhard Schlager
b26c76e749
FEATURE: Add locale defaults for Unicode username whitelist
2019-06-07 14:39:00 +02:00
David Taylor
65b0cafc03
FIX: Always schedule pull_hotlinked_images in cooked_post_processor
...
The job is now used to pull optimized images, and images from other sites on the same CDN. This needs to run even if download_remote_images is false
2019-06-07 13:08:23 +01:00
David Taylor
54afa314fb
FIX: Do not download emojis in pull_hotlinked_images
2019-06-07 13:00:52 +01:00
Joffrey JAFFEUX
fce34aa799
DEV: prevents Pretender Object to leak between tests ( #7726 )
2019-06-07 11:27:54 +02:00
Gerhard Schlager
d1228f47bb
FIX: Handle missing plural keys on client
2019-06-07 10:24:17 +02:00
Sam Saffron
f88dced0b7
PERF: optimize lookup of reviewable info in post stream
...
This previously was a hot path in topic view. Avoids an expensive active
record operation and instead perform SQL directly which is far more
targeted and efficient
2019-06-07 18:12:30 +10:00
Sam Saffron
cbd4d06da0
PERF: only check for totp record on current user at when needed
...
Previously the check was done a bit too early causing one extra query
per page unconditionally for logged on users
2019-06-07 16:25:04 +10:00
Joffrey JAFFEUX
a652d620f6
FIX: safari desktop doesnt support input[time] ( #7719 )
...
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
2019-06-07 15:50:43 +10:00
Dan Ungureanu
8bd815dab2
FIX: Permit new tags when allow_global_tags true. ( #7722 )
2019-06-07 15:45:16 +10:00
Sam Saffron
a0474a0774
FIX: always take the first post in the RSS fee
...
`.posts.first` may be the first post and may not, depending on luck
Also add protection for corrupt topics
2019-06-07 14:57:56 +10:00
Sam Saffron
ff3a1eae3a
FIX: ensure consistency should handle cases where a topic trashed
...
Followup to c05b6170
2019-06-07 14:57:56 +10:00
Guo Xiang Tan
ee142c2173
DEV: More improvements to `InlineUploads`.
...
* Convert inline links to short path
```
<link> <link>
<link>
```
to
```
<short_path> <short_path>
<short_path>
```
2019-06-07 11:49:30 +08:00
Sam Saffron
c05b617067
FIX: ensure_consistency was able to create corrupt category topics
...
- Correct create_category_definition to skip validations and use a
transaction, no longer able to create corrupt topics
- ensure_consistency now clears topic_id if pointing at deleted or missing
topic_id
- Stop creating category definition topics for uncategorized
2019-06-07 11:20:13 +10:00
Maja Komel
9db1fef4e3
FIX: add support for custom/plugin notification title attribute
2019-06-07 09:09:16 +08:00
Régis Hanol
b1c5ea4289
FIX: use URI.regexp to find URLs in plain text
2019-06-07 01:26:06 +02:00
Neil Lalonde
1f73a3ba6d
FIX: round the calculated heat values
...
Views heats like 12135 will become 12000, like ratios like
1.666666666667 will become 1.67.
2019-06-06 15:44:55 -04:00
Bianca Nenciu
35da531f1d
FIX: Do not resize images in Onebox while lazy loading.
...
Follow-up to 35d0fd0
.
2019-06-06 18:36:18 +03:00
Arpit Jalan
9acd851b9a
FIX: correct link to list of watched words
2019-06-06 20:21:54 +05:30
Vinoth Kannan
b7830680b6
DEV: use cdn url to download the external uploads to local.
2019-06-06 19:17:19 +05:30
dependabot[bot]
4be54d5ae1
Build(deps): Bump js-yaml from 3.12.0 to 3.13.1 ( #7712 )
...
Bumps [js-yaml](https://github.com/nodeca/js-yaml ) from 3.12.0 to 3.13.1.
- [Release notes](https://github.com/nodeca/js-yaml/releases )
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nodeca/js-yaml/compare/3.12.0...3.13.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2019-06-06 09:40:46 -04:00
Penar Musaraj
ffe51ac39c
Minor formatting change in 014-track-setting-changes.rb
2019-06-06 09:39:22 -04:00
Joffrey JAFFEUX
48b6391777
FIX: s/thumb-tack/thumbtack ( #7718 )
2019-06-06 14:43:16 +02:00
Joffrey JAFFEUX
c573fa780b
DEV: prevents asyncTestDiscourse/controllerFor/fixture to leak ( #7717 )
2019-06-06 13:10:41 +02:00
Joffrey JAFFEUX
60c073ae59
typos ( #7716 )
2019-06-06 13:00:23 +02:00
Joffrey JAFFEUX
6d02dd6d8c
DEV: attempts to remove message bus callbacks between tests ( #7715 )
2019-06-06 12:59:02 +02:00
Joffrey JAFFEUX
c462c2f271
FIX: prevents appEvents to leak ( #7714 )
2019-06-06 12:33:52 +02:00
Régis Hanol
84e5d58a0d
DEV: make prettier 💅 happy
2019-06-06 12:28:41 +02:00
Bianca Nenciu
5377d1672f
DEV: Fix linting issue.
2019-06-06 13:20:16 +03:00
Bianca Nenciu
f63b8bb79d
FIX: Periodically ensure consistency of categories. ( #7663 )
2019-06-06 11:30:52 +02:00
Régis Hanol
c131903e56
FIX: clone dateTime before changing timezone
2019-06-06 11:16:58 +02:00
Joffrey JAFFEUX
b339d67401
DEV: refactors select-kit helper to prevent it to leak into global state ( #7708 )
2019-06-06 10:47:10 +02:00