Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
36,316 Commits 216 Branches 500 Tags 879 MiB
Commit Graph

36316 Commits

Author SHA1 Message Date
Dan Ungureanu 2240b1681b
FIX: Show detailed error messages for category pages. (#8832) 2020-02-06 15:32:12 +11:00
Joshua Rosenfeld 3bf870cb24
Update email test email copy 
Most major email providers no longer have long-term free plans.
 2020-02-05 22:30:32 -05:00
Martin Brennan 697d4720df
DEV: Add DEBUG_PRELOADED_APP_DATA to log pre-loaded JSON in development (#8873) 
Extracted from #8772

This will allow developers (in rails development mode only) to log pre-loaded JSON app data to the browser console for inspection.
 2020-02-06 13:14:33 +10:00
Neil Lalonde 542e62ccf0 FIX: tag info misleading message saying it's not restricted 
When a tag is restricted to a secured category that the user can't see,
the message was saying that it wasn't restricted to any categories.
Now it will say it's restricted to categories you can't access.
 2020-02-05 15:23:39 -05:00
Osama Sayegh 6f52bbefb8
DEV: Use scheduleOnce correctly (#8865) 
* DEV: Use scheduleOnce correctly

* remove jquery usage here
 2020-02-05 21:21:00 +03:00
Blake Erickson 926d5f1c0a REFACTOR: Edit title respects min trust to edit post 
Follow up to: 241d8f6452
 2020-02-05 10:36:24 -07:00
Mark VanLandingham 49c750ca78
FIX: Opening new topic draft never creates post (#8828) 2020-02-05 11:17:58 -06:00
Joffrey JAFFEUX 6bee972a5c
FIX: corrects min/max logic for mini-tag-chooser (#8871) 2020-02-05 17:47:20 +01:00
Penar Musaraj 6253ddc74e DEV: Do not trigger missing icon warning in icon picker 2020-02-05 11:39:46 -05:00
Robin Ward f7c0cd1982 Support for Ember Template linting 2020-02-05 11:33:15 -05:00
Mark VanLandingham 499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage (#8782) 2020-02-05 10:14:42 -06:00
David Taylor 88779d849f
UX: Ignore name parameter from IDP when it is equal to email (#8869) 
Some auth providers (e.g. Auth0 with default configuration) send the email address in the name field. In Discourse, the name field is made public, so this commit adds a safeguard to prevent emails being made public.
 2020-02-05 16:03:18 +00:00
Joffrey JAFFEUX 98303ee645
FIX: simplify maximum/minimum logic in sk2 to avoid chicken/egg (#8868) 2020-02-05 16:01:58 +01:00
Jarek Radosz be42b87338
FIX: Allow submitting various forms via keyboard (#8866) 2020-02-05 15:23:35 +01:00
Mark VanLandingham 5d97286fa7
FEATURE: Allow single option polls (#8853) 2020-02-05 08:03:27 -06:00
Jarek Radosz 53529a3427
DEV: Upgrade Ember to version 3.12.2 (#8753) 
* DEV: Use Ember 3.12.2
* Add Ember version to ThemeField's DEPENDENT_CONSTANTS
* DEV: Use `id` instead of `elementId` (See: https://github.com/emberjs/ember.js/issues/18147)
* FIX: Don't leak event listeners (bug introduced in 999e2ff)
 2020-02-05 14:51:00 +01:00
Régis Hanol 0843e3e6ce FIX: add support for sub-sub-categories in base_importer 
Also delegates 'post_already_imported?' and 'user_already_imported?' to the base importer.
 2020-02-05 10:40:28 +01:00
Régis Hanol 13d4b05963 FIX: allow both meta_data and custom_fields when creating a topic 
For some reasons, we have two ways of associating "custom fields" to a new topic:
using 'meta_data' and 'custom_fields'.

However, if we were to provide both arguments, the 'meta_data' would be overwritten
by any 'custom_fields' provided.

This commit ensures we can use both and merges the 'custom_fields' with the 'meta_data'.
 2020-02-05 10:40:22 +01:00
Rishabh 5133e03b99
UX: Improved composer.saved_draft copy (#8863) 2020-02-05 14:45:10 +05:30
Joffrey JAFFEUX d7dffbb13c
UX: caches icon picker full icon's list (#8862) 2020-02-05 09:22:11 +01:00
Joffrey JAFFEUX a9f1652131
REFACTOR: querySelector instead of querySelectorAll to get first node (#8861) 2020-02-05 08:49:02 +01:00
Osama Sayegh a6da0bb1ef
UX: Remove subtle render delay with timeline notification button (#8860) 2020-02-05 18:35:47 +11:00
dependabot-preview[bot] a84c493de2
DEV: Bump msgpack from 1.3.2 to 1.3.3 (#8859) 
Bumps [msgpack](https://github.com/msgpack/msgpack-ruby) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/msgpack/msgpack-ruby/releases)
- [Changelog](https://github.com/msgpack/msgpack-ruby/blob/master/ChangeLog)
- [Commits](https://github.com/msgpack/msgpack-ruby/compare/v1.3.2...v1.3.3)

Very safe update, mostly covering 2.7 compat.
 2020-02-05 16:26:28 +11:00
Sam Saffron 0d6839e8a8 UX: adjust algorithm for picking notification count 
Our current algorithm for picking the number of notifications to display
when expanding the notifications relies on magic numbers.

Previously we only allowed for header and an estimate of maximum height of
notification container, this is not ideal as there is padding at the bottom
and top of the notification container

This adds a special number for padding.

The longer term fix though is to render the notification panel off screen
then grab the correct count, finally adding it back into view with.

This would allow for large fonts, small fonts, custom themes and much more.
 2020-02-05 16:03:44 +11:00
Sam Saffron 15b27f28aa UX: Topic progress bar should not flash on desktop 
Followup on 78725f50

This makes the change a bit safer in case .d-header is not to be found due
to a customization.
 2020-02-05 15:36:39 +11:00
Sam Saffron 78725f5081 Revert "FIX: Topic progress bar shouldn't show up on desktop (#8854)" 
This reverts commit 7133fd8c89.

Unfortunately performCheckSize may have certain situations in topic
navigation where it is unsafe to call.

We need to add som more safety here prior to merging.
 2020-02-05 15:22:44 +11:00
Osama Sayegh 7133fd8c89
FIX: Topic progress bar shouldn't show up on desktop (#8854) 2020-02-05 15:19:20 +11:00
Joffrey JAFFEUX f0fe2ba9ac
UX: introduces icon-picker component for badges (#8844) 2020-02-05 00:41:10 +01:00
Blake Erickson 241d8f6452 FIX: Edit title respects min trust to edit post 
This fix ensures that the site setting `post_edit_time_limit` does not
bypass the limit of the site setting `min_trust_to_edit_post`. This
prevents a bug where users that did not meet the minimum trust level to
edit could edit the title of topics.
 2020-02-04 16:31:16 -07:00
Joffrey JAFFEUX 666a4be888
UX: prevents mini tag chooser header to wrap (#8858) 2020-02-04 23:55:50 +01:00
Joffrey JAFFEUX 7fd5a8db72
UX: adds arrow navigation support to mini-tag-chooser (#8857) 2020-02-04 23:54:59 +01:00
Joffrey JAFFEUX 9252bbbd7d
FIX: prevents firefox to generate a click event on space (#8856) 2020-02-04 23:41:40 +01:00
dependabot-preview[bot] 0497d64849
Build(deps): Bump aws-partitions from 1.269.0 to 1.270.0 (#8855) 
Bumps [aws-partitions](https://github.com/aws/aws-sdk-ruby) from 1.269.0 to 1.270.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-partitions/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-02-04 16:13:31 -05:00
Kris 7ac81a6019 UX: Center titles in docked header when there aren't two rows 2020-02-04 13:40:28 -05:00
Joffrey JAFFEUX 2c2ab474a4
FIX: ensures tags-admin-dropdown is working correctly with sk2 (#8852) 2020-02-04 19:23:44 +01:00
Kris 35a1912e2d FIX: Links in category box descriptions should be clickable 2020-02-04 13:02:55 -05:00
Rafael dos Santos Silva f88fa99b0b
DEV: Fix web manifest short_title tests 2020-02-04 14:46:33 -03:00
Rafael dos Santos Silva 5ead60677a
FEATURE: Ensure we always fill the short_name in the web manifest 2020-02-04 14:16:00 -03:00
David Taylor fec1c0f097
DEV: Handle null notification level when generating data attribute (#8851) 
This happens in tests, but handling it properly will make the production code more robust. Followup to ebdebf152d
 2020-02-04 17:05:49 +00:00
Penar Musaraj 095e3d8946 DEV: Autofilter combo boxes on 10+ dropdown items by default 2020-02-04 11:23:15 -05:00
Robin Ward 71312d9086 FIX: Labels were switched in the wizard for privacy options 2020-02-04 11:09:52 -05:00
David Taylor ebdebf152d DEV: Use a string for category data-notification-level, not an integer 
This makes writing CSS to target specific notification levels more intuitive. Follow-up to 7640914552
 2020-02-04 16:05:45 +00:00
Vinoth Kannan dabba87954 DEV: introduce `diffLocalChangesUrl` attribute to `theme` model. 2020-02-04 21:33:19 +05:30
Mark VanLandingham c8a02161dd
FIX: Warn users of overwriting new topic draft (#8841) 2020-02-04 09:59:56 -06:00
Mark VanLandingham 91b70f8ffc
FIX: Featured topic title on profile HTML parsed (#8850) 2020-02-04 09:33:46 -06:00
dependabot-preview[bot] 14758771c6
Build(deps): Bump msgpack from 1.3.1 to 1.3.2 (#8843) 
Bumps [msgpack](https://github.com/msgpack/msgpack-ruby) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/msgpack/msgpack-ruby/releases)
- [Changelog](https://github.com/msgpack/msgpack-ruby/blob/master/ChangeLog)
- [Commits](https://github.com/msgpack/msgpack-ruby/compare/v1.3.1...v1.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-02-04 10:29:42 -05:00
Joffrey JAFFEUX 14126e9a38
UX: do not display pinned option description on mobile (#8846) 2020-02-04 15:34:56 +01:00
Joffrey JAFFEUX 87e92da085
DEV: makes popper.js part of javascript rake task (#8847) 2020-02-04 15:34:46 +01:00
Joffrey JAFFEUX ca63502ce6
UX: ensures pinned options icon is not on a new line (#8845) 2020-02-04 15:34:37 +01:00
Joffrey JAFFEUX 1d54e78311
FIX: prevents exception on /admin/badges page when model is not set (#8849) 
Exception:

TypeError: Cannot read property 'badge_type_id' of null
 2020-02-04 15:34:19 +01:00