427d54b2b0
DEV: Upgrading Discourse to Zeitwerk ( #8098 )
...
Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains.
We no longer need to use Rails "require_dependency" anywhere and instead can just use standard
Ruby patterns to require files.
This is a far reaching change and we expect some followups here.
2019-10-02 14:01:53 +10:00
67a98946b8
FIX: Do not log 'pull_hotlinked_images' edits in the staff action log
2019-09-12 15:55:45 +01:00
8deaef3872
FIX: Don't replace img tags within anchor tags with markdown format.
...
Follow up to 9a25b0d614
2019-06-21 12:32:02 +08:00
c9db897777
FIX: Remove onebox src from `Jobs::PullHotlinkedImages`.
...
The test that was added is incorrect because the post was not cooked.
2019-06-14 09:21:25 +08:00
9daed05ad0
Fix the build.
2019-06-13 13:53:43 +08:00
f0846ea7cf
DEV: Remove unused line.
2019-06-12 17:38:30 +08:00
fb0a655e8a
FEATURE: Update pull hotlinked images to use `Upload#short_url`.
2019-06-11 15:17:29 +08:00
54afa314fb
FIX: Do not download emojis in pull_hotlinked_images
2019-06-07 13:00:52 +01:00
ca6c919299
DEV: Remove unused variable.
...
Follow up to df1e6eed5a07f49eeda4c0bbd8c63d539aefdb3b..
2019-05-23 16:42:42 +08:00
df1e6eed5a
FIX: Pull hotlinked images for lightbox links as well.
2019-05-23 15:44:37 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
95d5819218
FIX: Re-download hotlinked optimized images ( #7249 )
...
* FIX: Download local images, even if download remote is disabled
2019-03-27 21:31:12 +01:00
b6a139b581
Fix broken spec.
2018-09-06 12:41:43 +08:00
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
ad5082d969
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
90f91bf017
Fix regression due to ee69d58a59.
2018-03-29 10:01:29 +08:00
ee69d58a59
FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.
2018-03-28 14:49:05 +08:00
347e4eadbc
Don't retry trying to download a file in test.
2018-03-28 12:54:11 +08:00
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
9c22c68d39
FIX: only save custom fields if they actually change
2017-11-16 15:14:10 +11:00
7b494a65c9
NEW: large image placeholder added in cooked html ( #5291 )
2017-11-15 11:30:47 +01:00
c838f43a75
let's not generate an error when logging errors...
2017-10-18 23:14:13 +02:00
f7282e4ecd
use force_https site setting when adding scheme for downloading schemaless images locally
2017-10-12 00:06:24 +02:00
4e78abb537
let's try 3 times to download images locally
2017-10-11 23:11:44 +02:00
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
3a75242c38
add more logs to pull hotlinked images
2017-09-28 01:00:13 +02:00
dd07094bd7
bump log level to debug download issues
2017-09-27 23:26:07 +02:00
6e9671c2c3
UX: Placeholder images color changed & tootip added
2017-09-13 15:16:38 +05:30
0fb7831749
FEATURE: Add placeholders to broken and large image files ( #5113 )
2017-09-01 10:26:13 -04:00
a6dff79c2c
change log level to info when failing to download a hotlinked image
2017-07-12 11:06:28 +02:00
e92acb4c40
FIX: `Jobs::PullHotlinkedImages#is_valid_image_src` returns true for a generic string.
2017-07-06 18:31:15 +09:00
061aa261da
Log site name when logging to Logster in `Jobs::PullHotlinkedImages`.
2017-07-05 10:34:24 +09:00
4e8b80c157
Remove unnecessary `ensure` block.
2017-07-05 10:21:42 +09:00
5d63a7f4a6
FIX: pull hotlinked images even when they have no extension
2017-06-13 13:27:05 +02:00
209383faab
FEATURE: pull onebox images
2017-06-06 18:51:58 +05:30
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
b60e9b7330
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-16 10:50:07 +00:00
929730c008
FIX: properly insert images in markdown inline format (take 2)
2016-09-01 17:56:39 +05:30
54a1180140
FIX: properly insert images in markdown inline format
2016-09-01 11:55:40 +05:30
8ec7fd84fd
FEATURE: prioritize sidekiq jobs
...
This commit introduces 3 queues for sidekiq
"critical" for urgent jobs (weighted at 4x weight)
"default" for standard jobs(weighted at 2x weight)
"low" for less important jobs
"critical jobs"
Reset Password emails has been seperated to its own job
Heartbeat which is required to keep sidekiq running
Test email which needs to return real quick
"low priority jobs"
Notify mailing list
Pull hotlinked images
Update gravatar
"default"
All the rest
Note: for people running sidekiq from command line use
bin/sidekiq -q critical,4 -q default,2 -q low
2016-04-07 12:56:43 +10:00
40b099f1a6
FIX: keep whitespaces when replacing direct link to external images with local images
2016-02-15 12:34:45 +01:00
78de89f7a1
FIX: PullHotlinkedImages was messing with URL when using Markdown references
2015-11-09 16:37:51 +01:00
5e3da94c46
FIX: prevent infinite loop in PullHotlinkedImages job
2015-10-30 22:46:46 +01:00
82a6176b08
lower the volume on failed to pull hotlinked image
...
add more diagnostics
2015-08-19 12:32:45 +10:00
827ea641b0
FIX: Use File.size instead of IO.size
2015-08-17 18:57:28 +02:00
b6cd4af2ba
FIX: follow redirects when pulling hotlinked images
2015-08-14 12:46:52 +02:00
Krzysztof Kotlarek
David Taylor
Guo Xiang Tan
Sam Saffron
Régis Hanol
Vinoth Kannan
Vinoth Kannan
Robin Ward
Leo McArdle
Arpit Jalan