0d3d2c43a0
DEV: s/\$redis/Discourse\.redis ( #8431 )
...
This commit also adds a rubocop rule to prevent global variables.
2019-12-03 10:05:53 +01:00
b6ef473a31
DEV: prevents redefinition of various constants ( #8199 )
...
CLEANUP_GRACE_PERIOD
MAX_AWARDED
POLL_MAILBOX_TIMEOUT_ERROR_KEY
2019-10-17 09:18:07 +02:00
427d54b2b0
DEV: Upgrading Discourse to Zeitwerk ( #8098 )
...
Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains.
We no longer need to use Rails "require_dependency" anywhere and instead can just use standard
Ruby patterns to require files.
This is a far reaching change and we expect some followups here.
2019-10-02 14:01:53 +10:00
56c6e8e961
FIX: POP3 doesn't work with TLS 1.3
2019-09-11 18:43:19 +02:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
c5e24da5dd
Update poll_mailbox.rb
2018-06-25 16:18:07 +10:00
43fd3ebd4a
Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification like “smtp_openssl_verify_mode”. Defaults to “true”, so it does not change current behavior.
2016-11-11 21:59:15 +01:00
2ecd0da59f
REFACTOR: use same code path for handling emails via API and POP
2016-06-22 15:50:49 +02:00
21ce674546
fix translation when receiving a bounce or an auto-reply
2016-05-16 08:42:30 +02:00
1e57bbf5c8
Lots bounce emails related fixes
...
- Show bounce score on user admin page
- Added reset bounce score button on user admin page
- Only whitelisted email types are sent to emails with high bounce score
- FIX: properly detect bounces even when there is no TO: header in the email
- Don't desactivate a user when reaching the bounce threshold
2016-05-06 19:34:33 +02:00
8e611ec7a1
FEATURE: handle bounced emails
2016-05-02 23:15:32 +02:00
a556d9ad4e
FIX: Expiry should be 3 times polling interval.
2016-04-21 15:04:03 +08:00
7d9f2265b9
FIX: improve support for handling emails coming from screened email addresses
2016-04-18 23:01:54 +02:00
f95cefd09a
FEATURE: Add POP3 timeout error only after 3 failures in a row.
2016-04-14 08:55:19 +08:00
4d9c81fde7
Merge pull request #4148 from tgxworld/dont_reply_to_emails_that_are_autogenerated
...
FIX: Don't send rejection mailer to bounced emails.
2016-04-13 15:36:14 +02:00
7f0b1691c4
FEATURE: add pop3 timeouts and auth errors to admin dashboard. Admins will get notified along with other problems.
2016-04-08 17:33:47 -04:00
5734c7f3f3
FIX: Don't send rejection mailer to bounced emails.
2016-04-07 22:21:17 +08:00
9e9c81c30b
improve error log when timing out while connecting to mail server
2016-03-25 16:44:08 +01:00
39863953cd
new 'enable_staged_users' site setting
2016-03-23 18:56:03 +01:00
9c61f45bf9
FIX: properly handle failure in poll mailbox job
2016-03-21 18:49:01 +01:00
162fcb75da
FEATURE: admin dashboard check when email polling errored in the past 24 hours
2016-03-16 21:17:48 +01:00
4a3cb4a000
FIX: use MD5 of the email_string when there's no 'Message-Id'
2016-03-14 18:18:58 +01:00
622d804d46
FEATURE: Add rejection message on rejected IncomingEmail
...
FIX: Better RateLimit description in rejected IncomingEmail
FEATURE: Send email when hitting a rate limit
2016-03-07 16:56:17 +01:00
cad7fc1062
FIX: don't allow blocked user to send emails in
2016-02-11 10:39:57 +01:00
8608b5cbc1
FIX: don't poll the mailbox in development
2016-02-01 16:56:32 +01:00
3083657358
FEATURE: better email in support
...
FEATURE: new incoming_email model
FEATURE: infinite scrolling in emails admin
FEATURE: new 'emails:import' rake task
2016-01-19 00:57:55 +01:00
4bb31daa2e
FIX: when getting a reply by email, ensure it's by the same user
2015-12-16 00:43:05 +01:00
93d1cc6294
add support for incoming emails in CC/BCC fields
2015-12-10 23:49:16 +01:00
6f9dc135ba
FEATURE: allow logging of raw body of all unprocessable email
...
set log_mail_processing_failures to true to enable
2015-07-31 15:10:35 +10:00
e6df97f01d
FIX: add email reply error message for topic not getting created in restricted category
2015-04-10 17:11:52 +05:30
a80c742855
FIX: include site name in email reply error subject
2015-04-02 15:46:22 +05:30
6960639c58
Merge pull request #3190 from riking/thrown_logging
...
Delete old ErrorLog, use Logster for 500 errors
2015-02-23 14:19:16 +11:00
f3daae6dec
Improve auto generated email reply error message
2015-02-18 18:58:51 +05:30
5657006aca
Rename handle_exception to handle_job_exception
2015-02-09 12:47:46 -08:00
b37d845dd3
FIX: email replies should not be accepted for deleted topics
2014-10-27 13:05:33 +05:30
08dc0e6ee6
FIX: email replies to closed topic should not be accepted
2014-10-25 23:47:13 +05:30
e28ef099a4
Fix pop3 SSL state leaking over multisite
2014-08-26 17:03:58 -07:00
6d357c9c23
Rename pop3s settings to pop3, remove 'insecure'
2014-08-26 17:03:58 -07:00
b4dc8e7115
Add error reply for new error
2014-08-13 11:47:21 -07:00
c0b2b9b341
Refactor out handle_failure method in PollMailbox
2014-08-01 11:12:06 -07:00
d87edce6c3
Pass rejection message along in rejection mail if present
2014-08-01 09:56:15 -07:00
dcc9923e4b
FIX: failed messages posted via email silently ignored
...
also... test suite over mocking
2014-07-31 18:46:02 +10:00
1359a02128
Merge pull request #2532 from riking/sidekiq
...
Pass more context from Sidekiq jobs to Logster
2014-07-18 10:24:51 +10:00
d90404e830
Change 'code' to 'message'
2014-07-17 15:19:58 -07:00
12cb682548
Start passing more context to Discourse.handle_exception
2014-07-17 14:11:56 -07:00
c8d322d1be
Include the email subject line in rejection messages
...
This change has a tradeoff.
It increases our backscatter vulnerability - the subject could have spammy content - but it's extremely valuable to the user to know exactly which message was rejected.
If you sent two at the same time, and only one was rejected, you would have no way of knowing which worked and which to resend without going to the website (which is what email-in is trying to avoid, kinda).
2014-07-17 10:25:53 -07:00
a7b8f25c50
Even better fix
2014-06-30 15:17:05 -07:00
07cedb7946
Fix specs, handle_exception calls
2014-06-30 15:16:16 -07:00
eb14983dfa
Change pop3 auth errors from admin message to dashboard notice
2014-06-30 14:44:18 -07:00
da9048f3ea
Fix email code & tests
2014-06-27 12:04:31 -07:00
Joffrey JAFFEUX
Krzysztof Kotlarek
Gerhard Schlager
Sam Saffron
Ernesto Serrano
Andreas Motl
Régis Hanol
Guo Xiang Tan
Neil Lalonde
Arpit Jalan
riking