Commit Graph

10633 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 244c03573a
FIX: btn class was duplicated on admin-menu-buttons (#7555) 2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX 0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes (#7557) 2019-05-16 14:37:37 +02:00
Régis Hanol a5a4f9dc1a
DEV: make prettier happy
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
Joffrey JAFFEUX d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 (#7546) 2019-05-16 10:34:19 +02:00
Régis Hanol 501bee56b7 Make prettier happy 2019-05-15 23:46:50 +02:00
Régis Hanol db89722a98 UX: ignore leading/trailing whitespaces in site settings search 2019-05-15 22:22:20 +02:00
Bianca Nenciu b9fcb2bcdf
DEV: Add before button hook in post-menu. (#7550) 2019-05-15 22:48:23 +03:00
Kris a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles (#7549) 2019-05-15 13:26:25 -04:00
Maja Komel 9a17b19636 FIX: don't hide back button at the bottom of timeline (#7544) 2019-05-15 19:02:48 +02:00
Joffrey JAFFEUX d127119549
REFACTOR: user-selector take 2 (#7540) 2019-05-14 09:43:29 +02:00
Régis Hanol 7707d5db2d Revert "REFACTOR: user-selector (#7529)"
This reverts commit 9a56df89f0.
2019-05-13 19:39:30 +02:00
Robin Ward fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX 7326ddea6d
REFACTOR: tags mixin (#7533) 2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX b8db702a02
REFACTOR: admin-user-index route (#7534) 2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX 717aa764b6
FIX: more efficient topic-footer-button-api (#7535) 2019-05-13 17:04:24 +02:00
Joffrey JAFFEUX df18243827
FIX: prevents exception if report doest define filters (#7532) 2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX 9a56df89f0
REFACTOR: user-selector (#7529) 2019-05-13 13:03:12 +02:00
Joffrey JAFFEUX e64ed9dbc1
REFACTOR: edit-category controller (#7527) 2019-05-13 11:30:32 +02:00
Joffrey JAFFEUX 9b75320d63
FIX: track mutations on topic edit category-chooser only on select (#7528) 2019-05-13 10:22:28 +02:00
Penar Musaraj a859ddc77e Improve theme/component delete modal warning 2019-05-10 14:14:12 -04:00
Joffrey JAFFEUX c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases (#7525) 2019-05-10 17:12:10 +02:00
Joffrey JAFFEUX 4096d559b5
REFACTOR: user-stream model (#7515) 2019-05-10 10:05:43 +02:00
Joffrey JAFFEUX a85b7feef4
REFACTOR: composer controller (#7516) 2019-05-10 10:05:29 +02:00
Joffrey JAFFEUX 7aedc92a35
REFACTOR: login-controller (#7514) 2019-05-10 10:05:11 +02:00
Gerhard Schlager 34684af195 FIX: Show error message if message exists 2019-05-09 22:12:51 +02:00
Robin Ward b380ed5282 FEATURE: Claim Reviewables by Topic
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
Bianca Nenciu ea3004ef11
UX: Save scroll position in tags topic list. (#7511) 2019-05-09 20:39:03 +03:00
Dan Ungureanu c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. (#7509) 2019-05-09 14:08:10 +03:00
Joffrey JAFFEUX 977ffa20f4
FIX: variable is different from key (#7512) 2019-05-09 10:03:33 +02:00
Arpit Jalan 427979e7e5
FEATURE: use full screen login by default for social login methods (#7481) 2019-05-09 10:03:01 +05:30
Guo Xiang Tan 8ec1f8cf07 DEV: Correct naming convention for JS file. 2019-05-09 10:18:29 +08:00
Maja Komel 24ca074f3f FIX: short description title on client side when empty description
follow-up 77af097c
2019-05-08 17:07:12 +02:00
Joffrey JAFFEUX 54c2f24ee9
REFACTOR: composer model (#7499) 2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX 4aaee7ee35
REFACTOR: change-timestamp controller (#7498) 2019-05-08 16:26:51 +02:00
Robin Ward b409dab77f Rename `flags_default_topics` to `reviewable_default_topics`
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
Maja Komel 77af097ce0 FIX: add short description to title on client side 2019-05-08 15:03:33 +02:00
David Taylor b717e23ceb FIX: Dynamically adjust scale when rendering wizard canvases
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
Bianca Nenciu 861023f0d6 FIX: Skip attachments in click track. 2019-05-08 11:55:31 +03:00
Guo Xiang Tan 46ea69a73c UX: Initialize client side category model with right search_priority.
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
Robin Ward 5af7c90bab FEATURE: Hide Reviewable scores, change score filter to Priority
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.

You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
Roman Rizzi 0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign (#7497) 2019-05-07 12:25:10 -03:00
Penar Musaraj 446ec1b44a
Set input and textarea font size to 16px on iOS (#7480) 2019-05-07 10:44:43 -04:00
Bianca Nenciu 98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. (#7430) 2019-05-07 16:25:52 +03:00
Arpit Jalan ed70595314 UX: add information about the use of permalinks 2019-05-07 17:13:26 +05:30
Bianca Nenciu 71fb8a4195 DEV: Fix failing click-track tests. 2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX 4bbb34f7cb
REFACTOR: admin-user (#7475) 2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX f73ed45429
REFACTOR: color-scheme model (#7477) 2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX 9507eff927
REFACTOR: resumable-upload (#7474) 2019-05-07 10:51:11 +02:00
Bianca Nenciu 4ff1195537 FEATURE: Use Beacon API for tracking clicks. (#7483) 2019-05-07 16:37:43 +10:00
Guo Xiang Tan abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
Arpit Jalan 03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
Robin Ward 47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Robin Ward 31e100530f FEATURE: Flag count in post menu
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
Dan Ungureanu 33e06dd796
FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
Guo Xiang Tan 8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
Guo Xiang Tan ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
Sam Saffron 267d129f38 FEATURE: only scroll to bottom for discobot
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
Robin Ward 99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Robin Ward 15c9b00307 FEATURE: Show edit indicator on review queue
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX 5f78bbebe9
FIX: forces a reload of emoji list if clicked on more (#7473)
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
Penar Musaraj b948d97c8f
FEATURE: Show diff of local changes before updating remote theme (#7443) 2019-05-02 21:43:54 -04:00
Robin Ward 3cb0d27d38 DEV: Upgrade our widget handlebars compiler
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX e696903c31
FIX: uses translatedTitle to check validity of topic footer btn (#7472) 2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX 75591664e7
FIX: better handling of category filter deselection (#7468) 2019-05-02 10:03:12 +02:00
Guo Xiang Tan d5c9ac7196 PERF: Use cdn when serving site settings upload. 2019-05-02 15:35:07 +08:00
Guo Xiang Tan 24347ace10 FIX: Properly associate user_profiles background urls via upload id.
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
Sam Saffron 157dc5e298 FEATURE: disable native share API on non tablets/phones
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
Arpit Jalan b5ea50a154
FIX: use full screen login for new-topic route (#7467)
DEV: add javascript tests for new-topic and new-message routes

DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
Vinoth Kannan 7869a10d18 Revert "FEATURE: Added unlisted topics option to advanced search (#7447)"
This reverts commit 539723f8ff since it is failing the build.
2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX ae493f4722
UX: fills picker with emoji autocomplete state on `more` click (#7466) 2019-05-01 16:19:45 +02:00
David Taylor 0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons (#7372)
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.

## Core

- Adds an SiteIconManager module which manages automatic resizing and fallback

- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon). 

- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.

- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations

## Wizard

- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload

- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"

- Various copy updates to support the changes

- Remove the "upload-time" resizing for `large_icon`. This is no longer required.

## Site Settings UX

- Move logo/icon settings under a new "Branding" tab

- Various copy changes to support the changes

- Adds placeholder support to the `image-uploader` component

- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings

- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name

## Dashboard Warnings

- Remove PWA icon and PWA title warnings. Both are now handled automatically.

## Bonus

- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
Arpit Jalan c6409fd2cc FIX: pass correct date arguments to server when exporting CSV 2019-05-01 10:46:30 +05:30
Arpit Jalan 002e1f560a FIX: initialize empty object if no custom filters are present 2019-05-01 10:27:19 +05:30
Tim Lange 539723f8ff FEATURE: Added unlisted topics option to advanced search (#7447) 2019-05-01 12:31:13 +10:00
Robin Ward 404b35bd04 FEATURE: Category Reviewable by Group
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
Robin Ward dd29af4475 REFACTOR: `{{avatar}}` and `{{date}}` helpers in vdom templates
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
Roman Rizzi 404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin (#7433) 2019-04-30 15:36:54 -03:00
David Taylor 583226d295 FIX: Linking to `/new-topic` from `/latest`
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.

This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.

Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX 8e68244eea
FIX: prevents google to track certain pages (#7463) 2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX 726dd0fe37 Revert "FIX: prevents google to track certain pages (#7455)"
This reverts commit c863e62998.
2019-04-30 10:17:12 +02:00
Joffrey JAFFEUX c863e62998 FIX: prevents google to track certain pages (#7455) 2019-04-30 13:59:55 +08:00
Guo Xiang Tan dca7f8ecf2 FIX: Loading more broken on groups page.
Regressed in 1f17d52f55.
2019-04-30 10:35:17 +08:00
Neil Lalonde a00354f11f Prettier site-settings/group-list.js.es6 2019-04-29 16:26:13 -04:00
Neil Lalonde 1ba72ccab8 DEV: add site setting type group_list for a list of groups
Add a js test
2019-04-29 16:15:22 -04:00
Penar Musaraj b75720d911 FIX: skip click-tracking for mentions 2019-04-29 12:05:47 -04:00
Joffrey JAFFEUX 5768011cad
FIX: prevents exception in the composer with regexp flags 2019-04-29 16:58:17 +02:00
Penar Musaraj 629ae7a5b7 FIX: Revert tracking links in quotes 2019-04-29 10:30:04 -04:00
Bianca Nenciu aef35faefc FIX: Open links in external tabs. (#7444) 2019-04-29 10:27:29 -04:00
Penar Musaraj ca9fd95a08 FIX: Respect "open external links in new window" in quotes and edit history 2019-04-29 10:13:53 -04:00
Joffrey JAFFEUX 286f2abc65
FIX: prevents exception when clicking directly on site text 2019-04-29 12:07:30 +02:00
Tim Lange 574f39f9d0 FIX: Fixed uploadPlaceholder regex failing on not escaped characters (#7442) 2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX 6952510fc4
FIX: restores skipHeader computed property 2019-04-26 23:43:49 +02:00
Tim Lange 1486328756 UX: Changed post stream placeholder to animation (#7434) 2019-04-26 17:29:48 +01:00
Joffrey JAFFEUX bcca2b5d73
FEATURE: initial implementation of generic filters for reports 2019-04-26 12:17:10 +02:00
Maja Komel 4b455e741e DEV: Ember 3.8.0
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
Vinoth Kannan be0ae2e487 FIX: plain text table detection should work even if html content not found. 2019-04-26 11:16:41 +05:30
Vinoth Kannan dc2ee78f7a UX: Only do plain text table detection in outside code if HTML pasting enabled
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
romanrizzi 34b772575e FIX: Return 'failed' attribute when catching an ajax error and the attribute is present 2019-04-25 14:49:52 -03:00
Joffrey JAFFEUX 7cbc4c1e46
FIX: uses no tags label for tag-drop header (#7438) 2019-04-25 13:16:06 +02:00
Joffrey JAFFEUX e386fa7674
FIX: ensures we have touches when starting pan event (#7435) 2019-04-25 10:36:41 +02:00