d6038ac666
FIX: Clear notification of skipped narrative bot PM ( #10792 )
...
Resets a new user's PM count in their badge after skipping user tips.
2020-10-01 20:32:45 -04:00
5cf411c3ae
FIX: move hp request from /users to /token ( #10795 )
...
`hp` is a valid username and we should not prevent users from registering it.
2020-10-02 09:01:40 +10:00
29f7e0689f
DEV: Hide large commit for moving test directories
2020-10-01 14:19:15 -04:00
901ae1ddd1
FIX: Allow staff to use HTML in the category read only banner
2020-10-01 11:55:35 -04:00
891987a284
DEV: Recover missing files of existing uploads ( #10757 )
...
UploadRecovery only worked on missing Upload records. Now it also works with existing ones that have an invalid_etag status.
The specs (first that test the S3 path) are a bit of stub-a-palooza, but that's how much this class interacts with the the outside world. 🤷♂️
2020-10-01 14:54:45 +02:00
7d5b18b7cf
FIX: Migration should only update ReviewableUsers where the user is not approved. ( #10790 )
...
The reviewable was updated despite the user not being approved because a u.id = r.target_id condition is missing. It only affected user reviewables that were pending when the migration ran. Users were not auto-approved.
2020-10-01 08:49:10 -03:00
3de832248e
Build(deps): Bump rspec-core from 3.9.2 to 3.9.3 ( #10791 )
...
Bumps [rspec-core](https://github.com/rspec/rspec-core ) from 3.9.2 to 3.9.3.
- [Release notes](https://github.com/rspec/rspec-core/releases )
- [Changelog](https://github.com/rspec/rspec-core/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-core/compare/v3.9.2...v3.9.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-01 17:30:25 +10:00
9f95511096
DEV: Add support for `api-initializers` to reduce boilerplate.
...
You can now create a file in your plugin/theme in the `api-initializers`
directory which has a simpler template than previous initializers.
Example:
```
// api-initializers/my-plugin.js
import { apiInitializer } from "discourse/lib/api";
export default apiInitializer("0.8", api => {
console.log("hello world from api initializer!");
});
```
2020-09-30 16:05:44 -04:00
a3c81a85cd
Update server.en.yml
2020-09-30 14:11:26 -04:00
e2b9d93556
Update server.en.yml
2020-09-30 14:11:12 -04:00
8fd8114e97
minor copyedit
2020-09-30 10:46:27 -07:00
fb57fe7e36
FIX: Allow .otf fonts to be delivered via cdn ( #10787 )
...
The discourse-fonts package includes NotoSansJP (bold and regular), but
it is an OTF font, and it results in 404s in CDN requests.
2020-09-30 11:59:46 -04:00
f5c4594f6d
DEV: Fix heisentest
2020-09-30 17:20:56 +02:00
ff44515a18
FIX: better error message if invite is expired ( #10783 )
...
https://meta.discourse.org/t/invite-token-is-invalid/165270/5?u=techapj
2020-09-30 20:32:33 +05:30
a13497dd1f
Build(deps): Bump rotp from 6.1.0 to 6.2.0
...
Bumps [rotp](https://github.com/mdp/rotp ) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/mdp/rotp/releases )
- [Changelog](https://github.com/mdp/rotp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mdp/rotp/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-30 10:58:15 -04:00
445d6ba45f
REFACTOR: Move qunit tests to a different directory structure
...
This structure is closer to how ember-cli expects tests to be placed. It
is not their final position, just the first step towards it.
2020-09-30 10:36:49 -04:00
8945a752f2
FIX: Deprecation overwriting `translatedText` CP
...
This allows us to pass a `textParams` object for options that will be
translated via i18n.
2020-09-30 10:36:31 -04:00
eac5dfd1ef
Update app/assets/javascripts/discourse/app/templates/components/share-popup.hbs
...
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2020-09-30 10:35:46 -04:00
3d6d3e6cb1
REFACTOR: Remove deprecated `action="something"` attributes
...
In newer versions of Ember, `this.sendAction` is deprecated:
https://deprecations.emberjs.com/v3.x/#toc_ember-component-send-action
This patch removes most of our current uses (via `d-button`) but also
some other rogue `this.sendAction` calls too.
2020-09-30 10:35:46 -04:00
da0dea1e94
FIX: Make bundler CI cache setup explicit ( #10785 )
...
Instructions on how to set this up exist at:
https://github.com/actions/cache/blob/master/examples.md#ruby---bundler
The second step was omitted, but it did not seem to prevent caching for unknown reasons.
2020-09-30 13:33:22 +00:00
318dadaf37
FIX: correct value of auto and adds nohighlight to the description ( #10771 )
2020-09-30 15:39:47 +10:00
39b2fb8649
FIX: Invalid URLs could raise exceptions when calling UrlHelper.rails_route_from_url ( #10782 )
...
Upload.secure_media_url? raised an exceptions when the URL was invalid,
which was a issue in some situations where secure media URLs must be
removed.
For example, sending digests used PrettyText.strip_secure_media,
which used Upload.secure_media_url? to replace secure media with
placeholders. If the URL was invalid, then an exception would be raised
and left unhandled.
Now instead in UrlHelper.rails_route_from_url we return nil if there is something wrong with the URL.
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2020-09-30 15:20:00 +10:00
a0bbc346cb
minor copyedit
2020-09-29 16:47:54 -07:00
3d1ab601d0
UI: Remove background from group notifications of @mentions ( #10775 )
...
This commit removes the background color from group @mention notifications. This resolves visual contrast issues when 'unread' styles are applied.
2020-09-29 18:44:12 -05:00
9d4009b0e8
FIX: Use correct locale for error messages ( #10776 )
...
Error messages for exceeded rate limits and invalid parameters always used the English locale instead of the default locale or the current user's locale.
2020-09-29 21:42:45 +02:00
4987d61448
FIX: We were overriding the `canCreateTopicOnCategory` computed property
...
It seems to be set everytime by the route so the old CP was not
required. This is not allowed in newer versions of ember.
2020-09-29 14:57:34 -04:00
025490ecb9
FEATURE: composer option to reload page and force save draft ( #10773 )
2020-09-29 22:29:03 +05:30
d8bf2810ff
DEV: Plugin api function to add saveable user fields ( #10774 )
2020-09-29 08:44:19 -07:00
ecfca965f2
Update translations
2020-09-29 13:01:52 +00:00
de94506c1e
FIX: empty highlighted_languages resulted in ["", "auto", "nohighlight"] ( #10772 )
2020-09-29 14:34:46 +02:00
09381717e8
Build(deps): Bump regexp_parser from 1.8.0 to 1.8.1 ( #10767 )
...
Bumps [regexp_parser](https://github.com/ammar/regexp_parser ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/ammar/regexp_parser/releases )
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ammar/regexp_parser/compare/v1.8.0...v1.8.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-09-29 14:08:36 +02:00
1ba9b34b03
DEV: Move UserApiKey scopes to dedicated table ( #10704 )
...
This has no functional impact yet, but it is the first step in adding more granular scopes to UserApiKeys
2020-09-29 10:57:48 +01:00
91ac70a32d
UX: increase input width on accept invite page.
2020-09-29 10:12:23 +05:30
a8ed0b4612
FIX: Correct corrupt encoding in emails containing attachments
2020-09-29 14:10:57 +10:00
ffdcac9dfc
UX: Replace cog icon in user menu with user icon
2020-09-28 22:26:56 -04:00
4193eb0419
FIX: Respect force download when downloading secure media via lightbox ( #10769 )
...
The download link on the lightbox for images was not downloading the image if the upload was marked secure, because the code in the upload controller route was not respecting the dl=1 param for force download.
This PR fixes this so the download link works for secure images as well as regular ligthboxed images.
2020-09-29 12:12:03 +10:00
aca2697a42
UX: Don't truncate category names in search panel
...
But keep truncating long category names in hamburger menu.
2020-09-28 21:59:45 -04:00
3cd601dcc9
FIX: Admin change email for user process improvements and fixes ( #10755 )
...
See https://meta.discourse.org/t/changing-a-users-email/164512 for context.
When admin changes an email for a user, we were incorrectly sending the password reset email to the user's old address. Also the new email does not come into effect until the reset password process is done, so this PR adds some notes to the admin to make this clearer.
2020-09-29 09:45:45 +10:00
fe86a7c7c8
Build(deps): Bump rubocop-ast from 0.7.0 to 0.7.1
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 0.7.0 to 0.7.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.7.0...v0.7.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-28 14:11:49 -04:00
edad403049
UX: fix styling for posts and views advanced search
2020-09-28 21:44:33 +05:30
72361738d0
DEV: don't add username to share links when badges are disabled ( #10730 )
...
Context: https://meta.discourse.org/t/stop-appending-username-to-url-when-badge-system-disabled/164904
Share links for topics and posts have the current username appended to them when the user is logged in.
If badges are disabled, those added usernames are not beneficial since they're only used to track progress towards certain badges.
This PR makes two change.
1. it moves the logic for the share link url to a centralized helper because it's shared in both topic and post models.
2. it stops username params from being added to share links when badges are disabled.
2020-09-29 00:12:16 +08:00
f7940b1d20
FEATURE: advanced search option for max posts count ( #10761 )
...
This commit adds an option to search for max posts count and updates
the UI for posts count search to show a min/max range in single line.
2020-09-28 21:34:16 +05:30
4d1b18f4c6
Build(deps): Bump puma from 5.0.0 to 5.0.2
...
Bumps [puma](https://github.com/puma/puma ) from 5.0.0 to 5.0.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v5.0.0...v5.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-28 11:50:57 -04:00
4fcb307f84
UX: consistent password label on signup and invites page
2020-09-28 20:45:12 +05:30
cad223c012
DEV: fix broken backend test due to #10749 ( #10758 )
2020-09-28 14:05:01 +02:00
2282fbcedd
fix the build
2020-09-28 16:57:42 +05:30
c230d2e443
FIX: prevents scrollbar jumping in the emoji picker ( #10749 )
...
This was mostly due to `content-visibility: auto;` but setting the width/height is also a good practice.
2020-09-28 13:23:46 +02:00
e00abbe1b7
DEV: Clean up S3 specs, stubs, and helpers
...
Extracted commonly used spec helpers into spec/support/uploads_helpers.rb, removed unused stubs and let definitions. Makes it easier to write new S3-related specs without copy and pasting setup steps from other specs.
2020-09-28 12:02:25 +01:00
50d53508b1
UX: show range for advanced search views filter.
2020-09-28 16:07:44 +05:30
4498c59085
FEATURE: add alias for min_post_count search filter
2020-09-28 16:07:44 +05:30
Penar Musaraj
Krzysztof Kotlarek
Robin Ward
Jarek Radosz
Roman Rizzi
dependabot-preview[bot]
Jeff Atwood
Gerhard Schlager
Arpit Jalan
Daniel Waterworth
Joffrey JAFFEUX
Martin Brennan
Jordan Vidrine
Gerhard Schlager
Mark VanLandingham
Discourse Translator Bot
David Taylor
awesomerobot
Joe