discourse

Commit Graph

Author	SHA1	Message	Date
David Taylor	5a003715d3	DEV: Apply syntax_tree formatting to `app/*`	2023-01-09 14:14:59 +00:00
Jarek Radosz	2361833844	FIX: Don't raise on deleted topic in UpdateHotlinkedRaw (#17901 ) Fixes: ``` Job exception: undefined method `acting_user=' for nil:NilClass ``` in ``` /var/www/discourse/lib/post_revisor.rb:181:in `revise!' /var/www/discourse/app/models/post.rb:646:in `revise' /var/www/discourse/app/jobs/regular/update_hotlinked_raw.rb:24:in `execute' ```	2022-08-13 22:40:26 +02:00
David Taylor	bf6f8299a7	FEATURE: Pull hotlinked images immediately after posting Previously, with the default `editing_grace_period`, hotlinked images were pulled 5 minutes after a post is created. This delay was added to reduce the chance of automated edits clashing with user edits. This commit refactors things so that we can pull hotlinked images immediately. URLs are immediately updated in the post's `cooked` HTML. The post's raw markdown is updated later, after the `editing_grace_period`. This involves a number of behind-the-scenes changes including: - Schedule Jobs::PullHotlinkedImages immediately after Jobs::ProcessPost. Move scheduling to after the `update_column` call to avoid race conditions - Move raw changes into a separate job, which is delayed until after the ninja-edit window - Move disable_if_low_on_disk_space logic into the `pull_hotlinked_images` job - Move raw-parsing/replacing logic into `InlineUpload` so it can be easily be shared between `UpdateHotlinkedRaw` and `PullUserProfileHotlinkedImages`	2022-05-23 14:28:02 +01:00

Author

SHA1

Message

Date

David Taylor

5a003715d3

DEV: Apply syntax_tree formatting to `app/*`

2023-01-09 14:14:59 +00:00

Jarek Radosz

2361833844

FIX: Don't raise on deleted topic in UpdateHotlinkedRaw (#17901 )

Fixes:

```
Job exception: undefined method `acting_user=' for nil:NilClass
```

in
```
/var/www/discourse/lib/post_revisor.rb:181:in `revise!'
/var/www/discourse/app/models/post.rb:646:in `revise'
/var/www/discourse/app/jobs/regular/update_hotlinked_raw.rb:24:in `execute'
```

2022-08-13 22:40:26 +02:00

David Taylor

bf6f8299a7

FEATURE: Pull hotlinked images immediately after posting

Previously, with the default `editing_grace_period`, hotlinked images were pulled 5 minutes after a post is created. This delay was added to reduce the chance of automated edits clashing with user edits.

This commit refactors things so that we can pull hotlinked images immediately. URLs are immediately updated in the post's `cooked` HTML. The post's raw markdown is updated later, after the `editing_grace_period`.

This involves a number of behind-the-scenes changes including:

- Schedule Jobs::PullHotlinkedImages immediately after Jobs::ProcessPost. Move scheduling to after the `update_column` call to avoid race conditions

- Move raw changes into a separate job, which is delayed until after the ninja-edit window

- Move disable_if_low_on_disk_space logic into the `pull_hotlinked_images` job

- Move raw-parsing/replacing logic into `InlineUpload` so it can be easily be shared between `UpdateHotlinkedRaw` and `PullUserProfileHotlinkedImages`

2022-05-23 14:28:02 +01:00

3 Commits