Alan Guo Xiang Tan
6c13d82630
UX: Reduce font-size of sidebar section link suffix icon ( #17919 )
2022-08-15 10:34:30 +08:00
Penar Musaraj
a32019d1e7
A11Y: add focus state for advanced search toggles ( #17894 )
...
Using `focus-visible` to ensure this only shows when navigating using
a keyboard.
2022-08-15 09:36:55 +08:00
Penar Musaraj
3fd929534c
A11Y: Improve group box hover highlight on dark schemes ( #17895 )
2022-08-15 09:36:28 +08:00
Andrei Prigorshnev
fdfac8c720
UX: improve styles of the user status message component ( #17904 )
2022-08-14 18:55:54 +04:00
Jarek Radosz
4f7c29845d
UX: Remove extraneous margins in profile pic modal ( #17896 )
...
(notice horizontal margins around "Gravatar")
2022-08-13 17:52:16 +02:00
Joe
c85921a548
FEATURE: Adds full screen composer submit button and prompt ( #17839 )
...
Context: https://meta.discourse.org/t/still-display-the-reply-create-topic-button-when-using-full-screen-composition/123597/6?u=johani
Right now, we don't show the submit buttons when you enter the full-screen composer. The reasons for that are described in the context link above.
This PR adds the improvements highlighted here: https://meta.discourse.org/t/still-display-the-reply-create-topic-button-when-using-full-screen-composition/123597/12?u=johani
Here's a list of the changes this PR introduces:
1. When you enter full-screen mode, we will now add a prompt that matches the browser fullscreen <kbd>F11</kbd> function. It looks like so
<img width="500" src="https://user-images.githubusercontent.com/33972521/183529813-71a20167-a661-466c-b9ef-c4d34e231000.png ">
The prompt fades away after a couple of seconds.
2. This PR adds the submit buttons to the full-screen composer mode. The submit buttons should work like normal if the post has no errors. If the post has errors (title too short, body too short, required categories/tags), then the button will make the composer exit the full-screen mode so that users will see the errors and fix them. The error logic is based on what we currently have; this PR doesn't add any new validation. Here's a video of what that looks like:
https://meta.discourse.org/t/-/127948/14?u=johani
2022-08-11 14:38:56 +08:00
Kris
3764ebf963
minor padding update for revamped user-menu ( #17864 )
2022-08-10 12:17:31 -04:00
Bianca Nenciu
e029a9b36c
FEATURE: Allow private themes to be partially installed ( #17644 )
...
A public key must be added to GitHub when installing private themes.
When the process happens asynchronously (for example if the admin does
not have admin permissions to the GitHub repository), installing
private themes becomes very difficult.
In this case, the Discourse admin can partially install the theme by
letting Discourse save the private key, create a placeholder theme and
give the admin a public key to be used as a deploy key. After the key
is installed, the admin can finish theme installation by pressing a
button on the theme page.
2022-08-10 13:30:18 +03:00
Kris
424e968538
UX: add left sidebar toggle when sidebar enabled ( #17831 )
2022-08-10 10:12:35 +08:00
Arpit Jalan
10a1b6b0a9
FEATURE: update bootstrap mode notice to add invite and wizard links ( #17822 )
...
* FEATURE: update bootstrap mode notice to add invite and wizard links
* Updates per feedback on PR
* Fix the wizard link not showing
* Remove unneeded function
* Remove router service injection
2022-08-10 00:13:42 +05:30
Arpit Jalan
d57bea4de3
FEATURE: add welcome topic cta banner ( #17821 )
2022-08-09 21:52:39 +05:30
Osama Sayegh
4fdb275683
DEV: Add bookmarks tab to the new user menu ( #17814 )
...
Some of the changes in this commit are extracted from https://github.com/discourse/discourse/pull/17379 .
The bookmarks tab in the new user menu is different from the other tabs in that it can display a mixture of notifications and bookmarks. When there are unread bookmark reminder notifications, the tab displays all of these notifications at the top and fills the remaining space in the menu with the rest of the bookmarks. The bubble/badge count on the bookmarks tab indicates how many unread bookmark reminder notifications there are.
On the technical aspect, since this commit introduces a new `bookmark-item` component, we've done some refactoring so that all 3 "item" components (`notification-item`, `reviewable-item` and the new `bookmark-item`) inherit from a base component and get identical HTML structure so they all look consistent.
Internal tickets: t70584 and t65045.
2022-08-08 17:24:04 +03:00
Andrei Prigorshnev
94ac8611f4
FEATURE: show status on post streams ( #17813 )
2022-08-08 17:35:26 +04:00
Osama Sayegh
0df1c4eab2
DEV: Refactor notification/reviewable items rendering in the new user menu ( #17792 )
...
Prior to this commit, we had a default Glimmer component that was responsible for handling generic rendering of notifications in the user menu, and many notification types had a custom Glimmer component that inherited from the default component to customize how they were rendered. That implementation was less than ideal because it meant plugins would have to create Glimmer components to customize notification types added by them and that would make the surface area of the API too big.
This commit changes the implementation so there's only one Glimmer component for rendering notifications, and then notification types that need to be customized can create a regular JavaScript class - `renderDirector` in the code - that provides the Glimmer component with the content it should display. We also introduce an API for plugins to register a renderer for a notification type or override an existing one.
Some of the changes are partially extracted from https://github.com/discourse/discourse/pull/17379 .
2022-08-05 07:55:00 +03:00
Ghassan Maslamani
2d6bd30dd8
FEATURE: add image delete button in preview. ( #17624 )
...
This commit adds a delete button to the composer preview next to the image scale buttons.
Reference: https://meta.discourse.org/t/image-remover-button-to-composer-preview/233005
2022-08-04 16:33:23 -04:00
jbrw
46f43d4f7c
UX: Display gap between tag sort options on PMs ( #17342 )
...
Adjust whitespace on tag sorting options so that the two links are rendered with a gap between them.
2022-08-04 11:45:54 -04:00
Alan Guo Xiang Tan
e09fd7cde2
UX: Move About and FAQ links into secondary section in More... dropdown ( #17793 )
...
This commit does not change any behaviour of the links and is simply
changing the positions of the links being displayed.
2022-08-04 13:41:08 +08:00
Kris
fc421ca41e
UX: update register admin wizard page styles ( #17785 )
2022-08-03 21:49:21 -04:00
Kris
8177f45369
UX: fix chat lock icon position and background ( #17791 )
2022-08-03 21:49:08 -04:00
Kris
afa7c1ed9b
UX: account for iPad hub nav when calculating top ( #17780 )
2022-08-03 12:00:36 -04:00
Martin Brennan
d2ddb140dd
FEATURE: Show SMTP response on admin email sent list and rearrange columns ( #17143 )
...
Follow up to 4d3c1ceb44
, this commit
shows the SMTP response in the admin email sent list and also moves the
topic/post link into a new column. Reply key is now in its own column.
2022-08-03 08:11:54 +10:00
Meghna
5ac4e82540
UX: add ellipsis for long category names in category chooser dropdown ( #17758 )
2022-08-02 21:57:47 +05:30
Kris
8df2756bba
DEV: set CSS custom property for footer-nav-height ( #17744 )
2022-08-01 18:01:06 -04:00
Krzysztof Kotlarek
af912b4b0e
DEV: Experimental scroll sidebar to specific element event handler ( #17727 )
2022-08-01 12:39:00 +08:00
Kris
2743339a7e
UX: adjust sidebar margin to avoid composer height ( #17731 )
2022-08-01 11:02:11 +08:00
Pixlz
e58c25939c
UX: Fix extra spacing for group metadata in user profile ( #17725 )
2022-07-29 13:47:14 -04:00
Meghna
b5ea6e746c
UX: updated account activation page design ( #17730 )
2022-07-29 22:33:11 +05:30
Kris
c97bfa1c44
UX: Add the TOS disclaimer to the invite signup ( #17717 )
2022-07-29 12:04:36 -04:00
Kris
a737195687
UX: sidebar appearance shouldn't shrink fonts ( #17714 )
2022-07-28 14:18:27 -04:00
Andrei Prigorshnev
2cb97d8de4
FEATURE: show user status on the user profile page ( #17712 )
2022-07-28 21:12:48 +04:00
Kris
391c687afb
UX: sidebar focus styles, remove hover for touch ( #17713 )
2022-07-28 13:04:00 -04:00
Andrei Prigorshnev
023835cdad
DEV: a new `d-tooltip` component ( #17513 )
2022-07-28 18:33:20 +04:00
Kris
a23e934730
FIX: show button bar overflow on iPad & mobile ( #17708 )
2022-07-28 09:26:06 -04:00
Alan Guo Xiang Tan
9efeaf2ae3
UX: Reduce number of links displayed in Community by default ( #17703 )
...
Additional links are hidden by default and can be accessed via the
"more..." link.
2022-07-28 16:46:46 +08:00
Alan Guo Xiang Tan
3bd5f2d411
DEV: Introduce SiteSetting to enable/disable Sidebar. ( #17662 )
...
This commit removes the ability to enable/disable the Sidebar on a per
user basis and introduces a site wide setting. For testing purposes, sidebar can be enabled/disabled via the `enable_sidebar=1` or `enable_sidebar=0` query param.
2022-07-27 13:42:26 +08:00
Alan Guo Xiang Tan
41aa7fa4ef
DEV: Fix mini profiler queries bg covering results ( #17679 )
2022-07-27 11:41:13 +08:00
Kris
126266863d
UX: sidebar transition and styling adjustments ( #17678 )
2022-07-26 23:16:34 -04:00
Arpit Jalan
10f200a5d3
FEATURE: revamped wizard ( #17477 )
...
* FEATURE: revamped wizard
* UX: Wizard redesign (#17381 )
* UX: Step 1-2
* swap out images
* UX: Finalize all steps
* UX: mobile
* UX: Fix test
* more test
* DEV: remove unneeded wizard components
* DEV: fix wizard tests
* DEV: update rails tests for new wizard
* Remove empty hbs files that were created because of rebase
* Fixes for rebase
* Fix wizard image link
* More rebase fixes
* Fix rails tests
* FIX: Update preview for new color schemes: (#17481 )
* UX: make layout more responsive, update images
* fix typo
* DEV: move discourse logo svg to template only component
* DEV: formatting improvements
* Remove unneeded files
* Add tests for privacy step
* Fix banner image height for step "ready"
Co-authored-by: Jordan Vidrine <30537603+jordanvidrine@users.noreply.github.com>
Co-authored-by: awesomerobot <kris.aubuchon@discourse.org>
2022-07-27 06:53:01 +05:30
Kris
b5c1132546
UX: add bulk-select to mobile topic lists ( #15386 )
2022-07-26 15:36:35 -04:00
Joe
994ca8f6de
FIX: Linear gradient with stops makes R2 confused ( #17650 )
...
Context: https://meta.discourse.org/t/the-theme-is-broken-in-right-to-left-languages-even-in-meta/233908
We use the R2 gem to do the magic RTL CSS conversion. There are cases where we feed it too much, and it gets confused. The issue here is that we use a linear gradient with CSS variables, an RGBA function, and we set the stops.
This makes R2 choke and causes it to return jumbled CSS, which means that any CSS that comes after that rule is junk and doesn't apply.
This PR removes the stops from the gradient. This shouldn't cause any visual changes since these are the default stops.
More explanation of the issue here: https://meta.discourse.org/t/user-card-will-not-open-on-the-mobile/171268/6?u=johani
2022-07-26 03:03:02 +08:00
Kris
4cb428ef83
UX: make sidebar hamburger menu occupy full width ( #17649 )
2022-07-25 14:18:57 -04:00
Kris
235878033e
UX: only transition header on sidebar toggle ( #17646 )
2022-07-25 13:27:56 -04:00
Kris
edb931e7e5
UX: let hamburger-sidebar restrict child width ( #17614 )
2022-07-22 10:26:13 -04:00
Joe
9424cfd9b8
UX: Prevent jitter in some onebox images ( #17611 )
...
Internal topic
/t/-/70486/9
2022-07-22 17:14:28 +08:00
Alan Guo Xiang Tan
b4b339b059
UX: Properly size emoji in sidebar section link text ( #17610 )
2022-07-22 15:58:21 +08:00
Alan Guo Xiang Tan
852057a25a
UX: Set width on hamburger menu drop down to prevent overflow ( #17607 )
2022-07-22 15:02:30 +08:00
Alan Guo Xiang Tan
972e51e808
DEV: Fix failing spec due to cf5e59928e
( #17606 )
2022-07-22 14:50:31 +08:00
Alan Guo Xiang Tan
cf5e59928e
UX: Only hide section header icons when sidebar is pinned on Desktop ( #17604 )
2022-07-22 14:27:46 +08:00
Alan Guo Xiang Tan
99073338de
FEATURE: Replace hamburger dropdown with Sidebar when undock ( #17600 )
...
When the experimental Sidebar is enabled, the hamburger drop down is replaced by a sidebar drop down. A user is given the ability to dock and undock the sidebar depending on their personal preference.
Do also note that the experimental sidebar is well, considered experimental at this point so I do not intend for the features here to be perfect. What I aim to do here is to ship the changes fast so that it can be used internally by the team to provide feedback. Custom links added by plugins and dark mode toggle has not been implemented as part of this commit as I aim to tackle it in another commit.
Co-authored-by: awesomerobot <kris.aubuchon@discourse.org>
2022-07-22 13:06:47 +08:00
Bianca Nenciu
7a668460e0
FIX: Make group members bulk operations consistent ( #17561 )
...
This commit improves several parts of the group members bulk operation.
It fixes the bug that did not show the menu button when the Select all
button was clicked. The other changes make the behavior more consistent
with topic list bulk operations.
2022-07-20 16:54:21 +03:00
Kris
a24bcceb19
UX: option to account for the sidebar in the breakpoint mixin ( #17577 )
...
* UX: account for sidebar in breakpoint mixin
* default to false
2022-07-20 10:56:41 +08:00
Alan Guo Xiang Tan
086fb6d6cf
DEV: Refactor sidebar components to prepare for integration into hamburger dropdown ( #17566 )
2022-07-19 14:37:07 +08:00
Osama Sayegh
fac04f3e73
DEV: Introduce a basic version of the new notifications menu behind a feature flag ( #17492 )
2022-07-19 10:35:02 +08:00
Kris
d8714facb6
FIX: can't hide overflow of d-editor-button-bar on mobile ( #17563 )
2022-07-18 20:43:05 -04:00
Kris
80bda4a9db
FIX: use padding, not margin ( #17559 )
2022-07-18 13:30:44 -04:00
Kris
719efc46a9
UX: prevent sidebar count from wrapping ( #17557 )
2022-07-18 12:11:40 -04:00
Alan Guo Xiang Tan
cd82e10d87
FIX: Restrict sidebar specific select kit CSS to sidebar ( #17552 )
...
Follow-up to 0d72a8c458
2022-07-18 16:17:03 +08:00
Alan Guo Xiang Tan
0d72a8c458
FEATURE: API for sidebar ( #17296 )
...
This plugin API can be used to add to sections and links to sidebar
2022-07-18 14:03:37 +10:00
Alan Guo Xiang Tan
54e63b3d31
Revert "UX: Remove experimental sidebar notification text ( #17290 )" ( #17548 )
...
This reverts commit 4df683f88d
.
We've decided to bring back the words for counts in the experimental sidebar.
2022-07-18 10:34:22 +08:00
Jarek Radosz
6a4a7b1d88
UX: Prevent long toolbars from resizing the column ( #17538 )
2022-07-17 20:16:11 +02:00
Jarek Radosz
be6736c940
UX: Make space for scrollbar in mini-profiler ( #17524 )
2022-07-16 10:12:44 +02:00
Kris
9909d001c5
UX: increase text size for mobile exp sidebar ( #17521 )
2022-07-15 17:44:44 -04:00
Kris
e293afad4c
UX: Prevent pre tag from making posts too wide ( #17518 )
2022-07-15 15:51:22 -04:00
Osama Sayegh
3690953a3f
DEV: Assign Mini Profiler badge a z-index below the notifications menu ( #17496 )
...
Follow-up to https://github.com/discourse/discourse/pull/17468 .
The notifications menu has a z-index at the header level, so the badge should be below that.
72889573e6/app/assets/stylesheets/common/base/menu-panel.scss (L26)
2022-07-14 20:14:38 +03:00
Meghna
72889573e6
UX: better account-created page ( #17452 )
...
UX: minor styling updates to accept invite pages
2022-07-14 20:43:00 +05:30
Jarek Radosz
4b935b61eb
FIX: CSS tweak and production position fix for miniprofiler ( #17493 )
...
* DEV: Format miniprofiler html
* FIX: Move miniprofiler to the right in production
* UX: Fix and merge miniprofiler css
2022-07-14 13:03:43 +02:00
Jarek Radosz
abe9b41ddf
DEV: Fix various typos ( #17485 )
2022-07-14 08:56:25 +08:00
Kris
806e0f2885
FIX: adjust topic avatar height to fix stickiness ( #17476 )
2022-07-13 10:00:59 -04:00
Alan Guo Xiang Tan
b4b87454f2
DEV: Move mini profiler badge to the right ( #17468 )
...
In the era where we have left aligned sidebar, the mini profiler badge
gets in the way
2022-07-13 13:40:12 +08:00
Joe
8a3c02c985
FIX: Mobile usability issues in crawler view ( #17465 )
...
Google is complaining about some mobile crawler layout issues. If a post has tables, they extend outside the viewport.
<img height="300" src="https://user-images.githubusercontent.com/33972521/178642976-3d1761ad-d8cb-4c69-92b5-7be799873d5c.png ">
This PR fixes that. We constrain the post to the viewport width (already determined from a parent element) and make it possible to scroll instead.
There is no visual change here, it should act the same as it does today, but it makes Google happy.
This PR also adds a bit of margin to tags in the `/tags` page in the crawler view because Google was complaining about `Clickable elements too close together`
<img height="300" src="https://user-images.githubusercontent.com/33972521/178644327-cc3ff795-24f1-4fef-95c9-e4358a5b37bc.png ">
2022-07-13 11:59:16 +08:00
Jarek Radosz
0e61f332ee
DEV: Make sure testing-container fits in the viewport ( #17446 )
...
This prevents tests failures when the browser viewport is too small.
2022-07-12 15:32:43 +02:00
Chapoi
d90cdba70f
Revert "UX: missing specificity ( #17324 )" ( #17426 )
...
This reverts commit 4730858598
.
2022-07-11 20:20:40 +02:00
Kris
6b57d792bb
UX: Fix exp sidebar toggle alignment, add hovers ( #17414 )
2022-07-11 12:58:48 -04:00
Jarek Radosz
5b70b67e78
FIX: Just inline the QUnit CSS in theme-test html ( #17415 )
...
Side-steps sassc compilation issues.
2022-07-11 12:01:47 +02:00
Jarek Radosz
e5346ed84a
Revert "DEV: Don't vendor old qunit css ( #17410 )" ( #17417 )
...
This reverts commit cf85ccca7d
.
2022-07-11 09:16:00 +10:00
Jarek Radosz
cf85ccca7d
DEV: Don't vendor old qunit css ( #17410 )
2022-07-10 14:57:22 +02:00
Kris
5a26c87fa6
UX: less janky animation for experimental sidebar ( #17396 )
2022-07-08 14:06:01 -04:00
Kris
4c1b8e736d
UX: add border-box to stop padding from overflow ( #17391 )
2022-07-08 10:31:28 -04:00
Kris
7d3b22135c
UX: don't animate experimental sidebar on reload ( #17372 )
2022-07-07 09:33:17 -04:00
Kris
fbc89dd41a
UX: improve experimental sidebar transitions ( #17358 )
2022-07-06 13:31:06 -04:00
Chapoi
63562e8b14
UX: switch highlight/select colours in select-kit ( #17356 )
2022-07-06 16:49:36 +02:00
Jarek Radosz
c3fd91670e
DEV: Update linting setup and fix issues ( #17345 )
...
Re-lands #16119 and #17298
* Update eslint-config-discourse
* Update linting workflow
* Prettier-ignore stuff
* Update template-lint config
* Auto-fix template issues
* Fix various template issues
Mostly incorrect attributes and unused templates
* Prettier js files
* Fix template auto-fix regressions
* Small css tweak
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-06 10:37:54 +02:00
Kris
59c8774957
UX: Prevent experimental sidebar scroll jumps ( #17352 )
2022-07-06 10:36:44 +08:00
Kris
7711d140da
UX: staff notice should utilize full post width ( #17346 )
2022-07-05 15:49:47 -04:00
Andrei Prigorshnev
c59f1729a6
FEATURE: auto remove user status after predefined period ( #17236 )
2022-07-05 19:12:22 +04:00
Kris
56c0d8cf92
UX: mobile experimental sidebar improvement ( #17302 )
...
First pass at the mobile experimental sidebar improvement.
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2022-07-05 11:45:02 +08:00
Chapoi
408ce1312b
UX: remove hardcoded colour value ( #17323 )
2022-07-05 10:47:29 +08:00
Chapoi
4730858598
UX: missing specificity ( #17324 )
2022-07-05 10:46:54 +08:00
Alan Guo Xiang Tan
ef7a518159
UX: Retain category badge style on categories select kit. ( #17332 )
...
Category badge changes based on the `category style` site setting so we
do not want to forcing all category names to the same color.
Follow-up to 3266350e80
2022-07-05 10:05:44 +08:00
Vinoth Kannan
af3262d70a
UX: made "Dismiss New" button clickable by replacing `float` method. ( #17288 )
...
Since we removed the `row:after { clear: both }` CSS we no longer use `float` style here. Instead, we should use `flex` style to align the button in right side.
2022-07-01 09:12:16 +05:30
Kris
199d58461b
UX: hide sidebar li overflow, remove title margin ( #17294 )
2022-06-30 18:24:29 -04:00
Kris
321dc29583
UX: improve experimental sidebar scrollbar ( #17293 )
2022-06-30 16:14:29 -04:00
Kris
b1f7da4fe3
UX: minor experimental sidebar alignment changes ( #17292 )
2022-06-30 16:14:17 -04:00
Kris
4df683f88d
UX: Remove experimental sidebar notification text ( #17290 )
2022-06-30 14:15:39 -04:00
Rafael dos Santos Silva
f130ec35d9
FEATURE: Use full post width for Vimeo embeds ( #17289 )
2022-06-30 13:08:24 -03:00
Alan Guo Xiang Tan
3a6e87ca4f
FEATURE: Store sidebar section display state in local storage ( #17281 )
...
Tests have been intentionally left out as it is hard to test interaction that relies on local storage.
It also isn't the end of the world if the feature regresses.
2022-06-30 15:56:46 +08:00
Alan Guo Xiang Tan
3266350e80
FEATURE: Decouple category/tag presence in sidebar from notifi level ( #17273 )
2022-06-30 14:54:20 +08:00
Kris
f44eb13236
FIX: add clearfix back for admin contents ( #17278 )
2022-06-29 10:17:01 -04:00
Kris
f0005401b7
UX: core adjustments and styles for the experimental sidebar ( #17271 )
2022-06-29 10:49:01 +08:00
Alan Guo Xiang Tan
836b5300fc
DEV: Move sidebar utility class to body tag ( #17259 )
2022-06-28 11:32:06 -04:00