f0620e7118
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
7c9fb95c15
Temporarily revert "FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )"
...
This reverts commit b1d3c678ca
2019-05-28 16:37:01 -04:00
b1d3c678ca
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
761e1e25f7
Remove tables incorrectly excluded in `Upload.migrate_to_new_scheme`.
...
Follow up to 4a03b21f80
2019-04-25 20:27:52 +08:00
84cfe30c1f
Use update_all instead of save to select and update particular columns
...
9ec6ef85b6
2019-04-25 11:56:57 +05:30
4a03b21f80
Exclude large tables when remapping in `Upload.migrate_to_new_scheme`.
...
Those tables do not carry any information about uploads.
2019-04-25 11:55:48 +08:00
be88ac8b7e
Additional old `Upload#url` format for `Upload.migrate_to_new_scheme`.
2019-04-24 18:19:25 +08:00
9ec6ef85b6
Don't validate post when saving in `Upload.migrate_to_new_scheme`.
2019-04-24 17:17:31 +08:00
3c9495b989
DEV: Put a mutex around `Upload.migrate_to_new_scheme`.
...
This ensures that only one migration is running at any given point in
time across the instances.
2019-04-24 17:07:10 +08:00
55f406bb79
Follow up to 845b68f9ab.
2019-04-24 16:57:45 +08:00
845b68f9ab
Update possible upload url format for `Upload.migrate_to_new_scheme`.
2019-04-24 16:26:54 +08:00
c811e59898
Avoid hardcoding db name in `Upload.migrate_to_new_scheme`.
2019-04-24 15:25:24 +08:00
573ddcbbd0
Disable migrate_to_new_scheme once there is nothing to migrate.
2019-04-24 14:00:00 +08:00
3094a603b7
Follow up to 149411ec90.
2019-04-24 12:20:53 +08:00
149411ec90
PERF: Speed up `Upload.migrate_to_new_scheme` by limiting remap scope.
...
Doing a `LIKE` on `Post#raw` and `Post#cooked` takes forever on large
sites.
2019-04-24 11:56:48 +08:00
914ada1c74
DEV: convert scheduled job EnsurePostUploadsExistence into a rake task
2019-04-09 02:07:35 +05:30
52c4711e80
DEV: Fix method that was incorrectly made private.
2019-04-03 12:37:50 +08:00
4037a2fd0b
FIX: Restrict scope of old scheme upload migration.
...
Some sites have external URLs that don't even match `%/uploads/%' and
some sites surprise me with URLs that contains the default path when it
is a site in a multisite cluster. We can't do anything about those.
2019-04-03 11:56:41 +08:00
feb731bffd
FIX: Regenerate optimized images instead of migrating from old scheme.
...
`OptimizedImage.migrate_to_new_scheme` was optimizing optimized images
which we don't need to do. Regnerating the optimized image is way easier.
2019-04-03 09:45:02 +08:00
d0a1922ad9
FIX: `Upload.migrate_to_new_scheme` undefined error when external image fails to download.
2019-03-28 16:00:13 +08:00
161a3c3870
DEV: Don't optimize image when migrating to new scheme.
...
The image has already been uploaded, the migrate to new scheme job's is
just to correct the scheme and not the content of the upload.
2019-03-26 15:12:10 +08:00
0ac6a58b09
FIX: Skip validation when saving in `Upload#migrate_to_new_scheme`.
2019-03-26 14:28:39 +08:00
40b03e717b
FIX: `Upload#migrate_to_new_scheme` should not migrate system uploads.
2019-03-14 12:45:03 +08:00
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
58b0e945bd
UX: Lightbox support for image uploader. ( #7034 )
2019-02-21 10:13:37 +08:00
95f263995d
FIX: Previous annotations were broken
2019-01-11 14:30:19 -05:00
a3839495e0
Update annotations
2019-01-11 12:19:43 -05:00
75dbb98cca
FEATURE: Add S3 etag value to uploads table ( #6795 )
2019-01-04 14:16:22 +08:00
303a535dba
PERF: automatic upload size calculation not persisted
...
Previously if upload had missing width and height we would calculate
on first use BUT we (me) forgot to save this to the database
This was particularly bad on home page cause category images (when old)
miss dimensions.
2018-12-26 17:19:29 +02:00
662cfc416b
FEATURE: Show a blurry preview when lazy loading images
...
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.
We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
2018-12-19 01:57:30 +08:00
e593d68beb
Use an options hash instead of boolean parameters
2018-12-19 01:57:30 +08:00
f8e6a37858
FIX: raise exception when getting dimensions of missing image
...
- follow-up on 0eacd45ab1
2018-12-03 10:19:49 -05:00
0eacd45ab1
FIX: refactor ImageSizer.resize
...
reverts 140d9c2
2018-11-29 15:28:45 -05:00
140d9c2910
FIX: call ImageSizer only if width/height are available
2018-11-29 15:03:02 -05:00
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
3e17ef0507
Merge pull request #6414 from techAPJ/user-field-unique-key
...
FEATURE: add external details to user fields
2018-09-20 22:29:39 +05:30
df45e82377
SECURITY: only allow picking of avatars created by self ( #6417 )
...
* SECURITY: only allow picking of avatars created by self
Also adds origin tracking to all uploads including de-duplicated uploads
2018-09-19 22:33:10 -07:00
72be638728
FEATURE: add external details to user fields
2018-09-20 08:10:51 +05:30
4a92c5b2d6
`UploadRecovery` should recover attachments too.
2018-09-19 10:44:36 +08:00
3884e99e88
Add extra protection in `Upload#get_from_url`.
...
In case the extension goes missing from the URL.
2018-09-12 00:12:14 -07:00
b3469bea2d
FIX: Uploads not being linked correctly to posts.
...
Regression due to 1f636c445b
2018-09-11 23:50:23 -07:00
e1b16e445e
Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.
2018-09-12 09:22:28 +08:00
04d26c65e2
Refactor `Upload.get_from_url` to check length of sha1.
2018-09-10 10:10:39 +08:00
1f636c445b
PERF: Add fast path to find uploads before resorting to `LIKE` query.
...
For a normal upload url
Before
```
Warming up --------------------------------------
264.000 i/100ms
Calculating -------------------------------------
2.754k (± 8.4%) i/s - 13.728k in 5.022066s
```
After
```
Warming up --------------------------------------
341.000 i/100ms
Calculating -------------------------------------
3.435k (±11.6%) i/s - 17.050k in 5.045676s
```
2018-09-06 14:44:24 +08:00
e1975e293f
FIX: when uploads are destroyed clear up avatar refs in user table
...
This also auto corrects twice daily when we ensure consistency
2018-08-31 14:46:42 +10:00
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
9628c3cf97
FEATURE: automatically correct extension for bad uploads
...
This fixes with post thumbnails on the fly
2018-08-17 14:00:27 +10:00
796164b58c
FIX: automatically correct bad avatars on access
...
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
0cd9e2acb9
fix build
2018-08-04 01:56:26 +02:00
bf4d98e89d
FIX: always store topic links using the upload url
2018-08-04 01:29:32 +02:00
875008522d
FIX: `Discourse.S3BaseUrl` did not account for subfolder bucket names.
2018-07-06 15:53:57 +08:00
7163bf9323
FIX: `Upload.get_from_url` not respective subfolder in s3 bucket names.
2018-07-06 11:37:11 +08:00
6c9190357c
fix get from url for external uploads without CDN
2018-06-13 16:21:28 +10:00
290ee312e6
FIX: handle invalid mailto links
2018-05-18 18:02:52 +05:30
539cf32f87
FIX: handle encoded mailto links when looking for upload record
2018-05-17 12:44:53 +05:30
91bf10bd12
FIX: create upload record for exported csv files
2018-04-20 00:27:49 +05:30
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
bfe38b2118
FIX: `limit` wasn't correctly applied to `Upload.migrate_to_new_scheme`.
2018-03-22 10:56:06 +08:00
226ace1643
Update annotations.
2018-02-20 14:28:58 +08:00
b9a343afe7
FIX: Allow shared CDN for s3 and assets
2018-01-12 01:08:15 -02:00
daeb7694bc
update annotations
2017-12-05 21:03:20 +05:30
4ea87b5ab8
Merge branch 's3_refactor'
2017-10-09 10:27:52 +11:00
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
d67f0b39ae
Update annotations.
2017-10-06 11:13:01 +08:00
f766ea4257
Correct short url decoding for sha1s leading with zero
...
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
bcf7dc38c2
FEATURE: server side support for upload:// markdown
...
This allows uploads to be specified using short sha1 hash instead of full
URL
Client side change is pending
2017-08-22 11:46:23 -04:00
c68999e128
annotate models
...
WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db
2017-08-16 10:38:11 -04:00
5d528f0d15
Merge pull request #4958 from dmacjam/search_posts_by_filetype
...
FEATURE: Search posts by filetype
2017-07-31 11:55:34 -04:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
d8c27e3871
Merge branch 'master' into search_posts_by_filetype
2017-07-25 14:41:20 -04:00
c7c93e7159
FEATURE: new 'strip image metadata' site setting
2017-07-25 11:48:39 +02:00
8c445e9f17
Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload.
2017-07-06 19:19:31 +02:00
54e8fb0d89
FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting
2017-06-12 22:41:29 +02:00
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
13e489b4ca
replace the upload type whitelist with a sanitizer
2017-05-18 12:13:13 +02:00
8e5b0c79ae
FIX: allow images to be uploaded in wizard
2017-05-18 13:53:23 +05:30
8c337ecf82
FIX: allow uploading of category logo and background
2017-05-11 12:48:54 +05:30
214939bb87
freeze array constants
2017-05-11 09:08:59 +02:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
bc0b9af576
FEATURE: support uploads for themes
...
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
2af1b9e93c
Add time out when optimizing images.
2017-04-20 15:21:43 +08:00
60f1169077
REFACTOR: Reduce repetition in code.
2017-04-18 17:03:49 +08:00
e7c972ac89
FIX: Don't use backticks that take in inputs.
2017-03-17 15:33:51 +08:00
1a7e954e09
FIX: Store custom emojis as uploads.
...
* Depending on a hardcoded directory was a flawed design
which made it impossible to debug when custom emojis go
missing.
2017-03-14 13:07:18 +08:00
887e9af84f
FEATURE: new 'max_image_megapixels' site setting
2017-01-11 23:37:12 +01:00
8d48779b5c
FIX: don't 💥 with an invalid URI
2016-10-20 12:34:42 +02:00
7db33cc512
FIX: Videos and audio files were not associated to the post.
2016-10-18 16:13:39 +08:00
e4b75f604c
FIX: Make clean up upload script a safer task to run.
2016-09-05 10:06:02 +08:00
1a4a0d7e89
FIX: Don't fail silently.
2016-09-02 11:59:03 +08:00
692ecff3eb
Revert "FIX: Don't fail silently."
...
This reverts commit baa6af93a2
2016-09-02 11:58:56 +08:00
baa6af93a2
FIX: Don't fail silently.
2016-09-02 11:53:53 +08:00
efd7cbd887
Remove limit default.
...
Having the limit makes it harder to migrate all `Upload`/`OptimizedImage`
since the count has to be figured out and passed to the method.
2016-09-02 10:55:11 +08:00
5169bcdb6e
FIX: httpshttps ultra secure URLs
2016-06-30 16:55:01 +02:00
5e2545a578
FEATURE: improve support for (whitelisted) SVGs as images
2016-06-20 10:22:13 +02:00
32d253d484
remove 'crop_tall_images' site setting but keep the behavior
2016-05-23 16:42:19 +02:00
667dd54a23
FEATURE: new 'crop_tall_images' site setting
2016-05-23 16:18:30 +02:00
0634834009
Some fixes related to optimized images ( #4233 )
...
* FIX: No need to manually include relation.
* FIX: OR instead of chaining relation.
2016-05-20 09:12:25 +02:00
df14926e42
SECURITY: check magic bytes before using ImageMagick tools
2016-05-03 21:54:07 +02:00
Guo Xiang Tan
Penar Musaraj
Sam Saffron
Vinoth Kannan
Guo Xiang Tan
Robin Ward
Arpit Jalan
Régis Hanol
Maja Komel
Rafael dos Santos Silva
Neil Lalonde
Jakub Macina