adb7fa5e2f
UX: Use discourse-ready as a baseline for removing the splash ( #17297 )
...
We previously used the window load event as a target to remove the splash. The issue with that is that it means we wait for images to download before we remove the splash.
Ember has a better method that we can use ready(). This PR triggers a custom discourse-ready when that happens and uses that as the baseline for removing the splash.
This PR also adds three new performance marks. discourse-ready, discourse-splash-visible, and discourse-splash-removed
These will help us keep track of performance.
Internal topic /t/65378/81
2022-07-01 21:54:38 +08:00
caa0247f5c
FIX: Incorrect `currentUser` could be cached for requests with API key ( #17279 )
...
This happened when a middleware accessed the `currentUser` before a controller had a chance to populate the `action_dispatch.request.path_parameters` env variable. In that case Discourse would always cache `nil` as `currentUser`.
2022-07-01 10:18:24 +02:00
af3262d70a
UX: made "Dismiss New" button clickable by replacing `float` method. ( #17288 )
...
Since we removed the `row:after { clear: both }` CSS we no longer use `float` style here. Instead, we should use `flex` style to align the button in right side.
2022-07-01 09:12:16 +05:30
199d58461b
UX: hide sidebar li overflow, remove title margin ( #17294 )
2022-06-30 18:24:29 -04:00
321dc29583
UX: improve experimental sidebar scrollbar ( #17293 )
2022-06-30 16:14:29 -04:00
b1f7da4fe3
UX: minor experimental sidebar alignment changes ( #17292 )
2022-06-30 16:14:17 -04:00
4df683f88d
UX: Remove experimental sidebar notification text ( #17290 )
2022-06-30 14:15:39 -04:00
d0a4bc636f
FIX: Vimeo regex pattern ( #17277 )
...
Vimeo has two url structure:
- Normal /video_id
- Private/Unlisted /video_id/hash_string
This changes change the regex pattern thus it would be able to
catch both. Also it tolerate trailing slash.
This shall fixes:
https://meta.discourse.org/t/vimeo-embed-urls-parsed-incorrectly-in-email/231042
2022-06-30 13:13:25 -03:00
f130ec35d9
FEATURE: Use full post width for Vimeo embeds ( #17289 )
2022-06-30 13:08:24 -03:00
49905a4e6c
DEV: Use performance timings to as a baseline for the splash take 2 ( #17284 )
...
We previously relied on CSS animation-delay for the splash. This means that we can get inconsistent results based on device/network conditions.
This PR moves us to a more consistent timing based on {request time + 2 seconds}
Internal topic: /t/65378/65
2022-06-30 21:22:00 +08:00
7343cb9f73
DEV: Convert `{{cook-text}}` to angle-brackets ( #17287 )
2022-06-30 14:03:27 +02:00
16ea7ab248
DEV: Run angle-brackets codemod ( #17286 )
...
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-06-30 12:30:50 +02:00
02e148cbde
Version bump to v2.9.0.beta6 ( #17283 )
...
Needed for https://meta.discourse.org/t/unable-to-find-discourse-version-2-9-0-beta6/231511
2022-06-30 12:25:44 +03:00
c86c709998
UX: Reduces splash animation delay ( #17282 )
...
This PR cuts down the delay before the splash screen is visible.
2022-06-30 17:19:39 +08:00
3a6e87ca4f
FEATURE: Store sidebar section display state in local storage ( #17281 )
...
Tests have been intentionally left out as it is hard to test interaction that relies on local storage.
It also isn't the end of the world if the feature regresses.
2022-06-30 15:56:46 +08:00
3266350e80
FEATURE: Decouple category/tag presence in sidebar from notifi level ( #17273 )
2022-06-30 14:54:20 +08:00
db53c6650b
FIX: max value for SiteSetting.delete_removed_posts_after ( #17270 )
2022-06-30 12:46:48 +08:00
1493cc447e
Build(deps): Bump rubocop from 1.31.0 to 1.31.1 ( #17280 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.31.0...v1.31.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-30 12:45:32 +08:00
09932738e5
FEATURE: whispers available for groups ( #17170 )
...
Before, whispers were only available for staff members.
Config has been changed to allow to configure privileged groups with access to whispers. Post migration was added to move from the old setting into the new one.
I considered having a boolean column `whisperer` on user model similar to `admin/moderator` for performance reason. Finally, I decided to keep looking for groups as queries are only done for current user and didn't notice any N+1 queries.
2022-06-30 10:18:12 +10:00
f44eb13236
FIX: add clearfix back for admin contents ( #17278 )
2022-06-29 10:17:01 -04:00
657256a099
Revert "DEV: Use `performance.timing` as a baseline for the splash ( #17275 )" ( #17276 )
...
This reverts commit 6146da5eb7
2022-06-29 18:34:37 +08:00
6146da5eb7
DEV: Use `performance.timing` as a baseline for the splash ( #17275 )
...
* update styles
* remove unused code
* use request time as a baseline
2022-06-29 20:01:46 +10:00
6ecfdc8f55
FIX: keep unique post checks separate for PMs vs topics ( #17272 )
...
This allows for people to use PMs for drafting and then post them on topics.
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2022-06-29 15:35:07 +10:00
644e05cd4d
DEV: Rename variable in TagSectionLink JavaScript class ( #17274 )
...
Tag is vague and is mostly used in our code base to represent a Tag
ember object.
2022-06-29 13:18:30 +08:00
f070ebca9d
Build(deps): Bump rack-test from 2.0.1 to 2.0.2 ( #17269 )
...
Bumps [rack-test](https://github.com/rack/rack-test ) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/rack/rack-test/releases )
- [Changelog](https://github.com/rack/rack-test/blob/main/History.md )
- [Commits](https://github.com/rack/rack-test/compare/v2.0.1...v2.0.2 )
---
updated-dependencies:
- dependency-name: rack-test
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-29 10:49:47 +08:00
f0005401b7
UX: core adjustments and styles for the experimental sidebar ( #17271 )
2022-06-29 10:49:01 +08:00
9d870f151c
FIX: Uploading large files (> 5GB) failed when `enable_direct_s3_uploads` is enabled ( #16724 )
...
Larger files require a multipart copy.
2022-06-28 21:30:00 +02:00
0bcc478635
DEV: Run some specs with fake S3 implementation instead of stubs
2022-06-28 21:27:52 +02:00
235f172b9c
FIX: Didn't delete upload stub when a new upload is created
...
Reuse `Discourse.store` to prevent creation of multiple new store objects within `UploadCreator#create_for`.
2022-06-28 21:27:52 +02:00
2d6ef232a7
FIX: Markdown handling failed on empty attribute value ( #17199 )
...
Seems to only be a problem when a markdown.it rule inserts links without a attribute value. There's no test, because it's not reproducible with the markdown rules in core.
2022-06-28 21:27:15 +02:00
809f3d37cd
DEV: Update `qunit-dom` ( #17265 )
2022-06-28 21:22:17 +02:00
302fab07a3
DEV: Update `jsdom` ( #17264 )
2022-06-28 21:22:06 +02:00
bfeee1b803
DEV: Update `sinon` ( #17266 )
2022-06-28 21:21:51 +02:00
16f22e3c36
DEV: Add `--forward-host` option to `bin/ember-cli` ( #17244 )
...
This allows to e.g. test multisite setup in a local dev environment. Also fixes some minor proxy issues.
2022-06-28 21:20:14 +02:00
39a025c7af
DEV: Allow newer versions of node ( #17261 )
...
It should now properly work with 18.x, so we should start moving into direction of it being the default.
2022-06-28 20:52:31 +02:00
c6b3d3e4b4
Update translations ( #17267 )
2022-06-28 20:52:09 +02:00
836b5300fc
DEV: Move sidebar utility class to body tag ( #17259 )
2022-06-28 11:32:06 -04:00
4821d44c3c
DEV: Update `webpack` ( #17262 )
2022-06-28 14:39:09 +02:00
a832c94527
UX: update color on arrow tippy box ( #17263 )
2022-06-28 13:25:40 +02:00
ff77ad7ac0
UX: Change copy for user-selector placeholder ( #17260 )
2022-06-28 19:01:16 +08:00
aa38dcd263
Build(deps): Bump rubocop from 1.30.1 to 1.31.0 ( #17258 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.30.1 to 1.31.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.30.1...v1.31.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-28 00:10:41 +02:00
5840fb5c62
UX: Update topics stats automatically ( #17135 )
...
Updates automatically data on the stats section of the topic.
It will update automatically the following information: likes, replies and last reply (timestamp and user)
2022-06-27 18:21:05 -03:00
31a0bf11f2
Build(deps): Bump rack-test from 1.1.0 to 2.0.1 ( #17257 )
...
Bumps [rack-test](https://github.com/rack/rack-test ) from 1.1.0 to 2.0.1.
- [Release notes](https://github.com/rack/rack-test/releases )
- [Changelog](https://github.com/rack/rack-test/blob/main/History.md )
- [Commits](https://github.com/rack/rack-test/compare/v1.1.0...v2.0.1 )
---
updated-dependencies:
- dependency-name: rack-test
dependency-type: indirect
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 22:13:46 +02:00
a7284d3b96
DEV: Auto-allow multisite hosts in dev ( #17246 )
2022-06-27 21:58:33 +02:00
2b80133819
FIX: Fix bulk_invite flaky tests ( #17256 )
2022-06-27 14:50:20 -05:00
f56c44d1c7
FEATURE: Validate tags in WatchedWords ( #17254 )
...
* FEATURE: Validate tags in WatchedWords
We didn't validate watched words automatic tagging, so it was possible
for an admin to created watched words with an empty tag list which would
result in an exception when users tried to create a new topic that
matched the misconfigured watched word.
Bug report: https://meta.discourse.org/t/lib-topic-creator-fails-when-the-word-math-appears-in-the-topic-title-or-text/231018?u=falco
2022-06-27 16:16:33 -03:00
64adf3cba3
DEV: Don't template-lint all files in lefthook ( #17255 )
...
Just templates is a-ok, thx :P
2022-06-27 20:01:13 +02:00
aabb98aedc
DEV: Deprecate `DISCOURSE_DEV_HOSTS` ( #17245 )
...
`RAILS_DEVELOPMENT_HOSTS` is a Rails standard that does exactly the same thing.
2022-06-27 19:04:42 +02:00
94e59ad9b6
DEV: Update `html-entities` ( #17250 )
2022-06-27 18:40:58 +02:00
f8691d12e1
DEV: Update `ember-cli-app-version` ( #17253 )
2022-06-27 18:13:56 +02:00
Joe
Gerhard Schlager
Vinoth Kannan
Kris
Ghassan Maslamani
Rafael dos Santos Silva
Jarek Radosz
Natalie Tay
Alan Guo Xiang Tan
Gabe Pacuilla
dependabot[bot]
Krzysztof Kotlarek
Joffrey JAFFEUX
Sam
Discourse Translator Bot
Chapoi
Sérgio Saquetim
Isaac Janzen