Vinoth Kannan
3e7f7fdde8
FEATURE: category setting for default list filter. ( #9975 )
2020-06-04 00:56:56 +05:30
Robin Ward
ba00cc8ec4
DEV: Move `Discourse.getURL` and related functions to a module ( #9966 )
...
* DEV: Move `Discourse.getURL` and related functions to a module
* DEV: Remove `Discourse.getURL` and `Discourse.getURLWithCDN`
* FIX: `get-url` is required for server side code
* DEV: Deprecate `BaseUri` too.
2020-06-03 12:45:26 -04:00
Robin Ward
a95826f60c
Remove discourse constants ( #9958 )
...
* DEV: `Discourse.baseUri` does not exist
This never could have worked - should have been `Discourse.BaseUri` if
anything.
* DEV: Remove Discourse.Environment
* DEV: Remove `Discourse.disableMissingIconWarning`
* DEV: A bunch more missing environment checks
2020-06-01 16:33:43 -04:00
Joffrey JAFFEUX
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
Joffrey JAFFEUX
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
Joffrey JAFFEUX
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
Bianca Nenciu
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
Michael Brown
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eee
.
* SECURITY: re-adds accidentally reverted commit:
03d26cd6: ensure embed_url contains valid http(s) uri
* when the merge commit e62a85cf
was reverted, git chose the 2660c2e2
parent to land on
instead of the 03d26cd6
parent (which contains security fixes)
2020-05-23 00:56:13 -04:00
Jeff Atwood
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f
, reversing
changes made to 2660c2e21d
.
2020-05-22 20:25:56 -07:00
Joffrey JAFFEUX
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
Robin Ward
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
Robin Ward
6c9c8dfefd
FIX: `guidFor` is not part of `Ember.Object`
2020-05-20 11:31:11 -04:00
Joffrey JAFFEUX
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
Joffrey JAFFEUX
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
Joffrey JAFFEUX
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
Joffrey JAFFEUX
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
Guo Xiang Tan
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
Joffrey JAFFEUX
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
Joffrey JAFFEUX
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
Joffrey JAFFEUX
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
Joffrey JAFFEUX
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
Robin Ward
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
Alan Guo Xiang Tan
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
Joffrey JAFFEUX
b07f1bfd93
FIX: displays a title on sk header if no selected name ( #9794 )
...
none has to be defined.
2020-05-15 17:36:00 +02:00
Guo Xiang Tan
162d125b83
Fix lint.
2020-05-15 20:23:17 +08:00
Guo Xiang Tan
dada1fc417
UX: Better composer-action icon when creating new topic.
2020-05-15 16:40:49 +08:00
Joffrey JAFFEUX
42e5a5bb39
DEV: do not append/prepend if callback returns nothing ( #9778 )
2020-05-14 14:38:03 +02:00
Guo Xiang Tan
fdea969f14
DEV: Minor follow up to d7e230c1b9
2020-05-14 16:02:54 +08:00
Guo Xiang Tan
95a80525ae
DEV: Remove erroneous code introduced in d7e230c1b9
2020-05-14 15:58:44 +08:00
Guo Xiang Tan
d7e230c1b9
UX: Introduce composer-actions when editing a post.
2020-05-14 15:56:08 +08:00
Robin Ward
eab560fe2a
DEV: import I18n instead of global usage ( #9768 )
...
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
2020-05-13 16:23:41 -04:00
Penar Musaraj
7cdf41d311
DEV: Remove reference to Discourse.Category
2020-05-11 18:28:45 -04:00
Joffrey JAFFEUX
af6e61defd
FIX: sets a title for notifications button ( #9745 )
2020-05-11 20:46:08 +02:00
jjaffeux
5a073c6a0a
Revert "FIX: title should attempt to fallback to label before name ( #9739 )"
...
This reverts commit c6bf552ca3
.
2020-05-11 20:09:11 +02:00
Joffrey JAFFEUX
c6bf552ca3
FIX: title should attempt to fallback to label before name ( #9739 )
2020-05-11 18:42:18 +02:00
Joffrey JAFFEUX
9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange ( #9718 )
2020-05-09 10:26:23 +02:00
Joffrey JAFFEUX
9d172eeaa5
REFACTOR: removes implicit operand conversion ( #9700 )
2020-05-08 09:19:36 +02:00
Joffrey JAFFEUX
3cd412ae02
REFACTOR: removes useless variable assignment ( #9666 )
2020-05-07 16:41:26 +02:00
Joffrey JAFFEUX
930989d462
REFACTOR: variable '_postSnapshot' always evaluates to true ( #9671 )
2020-05-07 16:28:28 +02:00
Joffrey JAFFEUX
5a201082c7
REFACTOR: removes useless conditional ( #9667 )
...
This use of variable 'content' always evaluates to true.
2020-05-07 16:25:44 +02:00
Joffrey JAFFEUX
87b1d435d2
FIX: improves positioning of sk in mobile when inside a modal ( #9657 )
2020-05-07 09:10:29 +02:00
Joffrey JAFFEUX
c99ecba68f
DEV: improves sk api ( #9653 )
...
- reduces the API to 3 actions for now: appendContent/prependContent/onChange
- well tested
- removes all previous APIS which were only half supported or too dangerous as they could collide with other plugins or core behaviors
- this plugins also puts every sk test helpers in one file
2020-05-06 17:16:20 +02:00
Joffrey JAFFEUX
6b14a0f352
FIX: apply sameWidth from 450px screen width
2020-05-05 13:01:02 +02:00
Joffrey JAFFEUX
bd0abddf6f
UX: attempts to have a better use of available space with sk ( #9639 )
2020-05-05 12:59:47 +02:00
Joffrey JAFFEUX
5e9c96dfed
REFACTOR: minor tweaks to user's notifications-filter ( #9623 )
2020-05-04 09:09:13 +02:00
Ahmed Gagan
99abdf51cd
FEATURE: adds a filter for all/unread/read on user's notifications page ( #9535 )
2020-05-04 08:36:59 +02:00
Joffrey JAFFEUX
07e6452759
FIX: makes tracking shortcuts working when tracking button is not visible ( #9575 )
2020-04-28 20:12:16 +02:00
Joffrey JAFFEUX
a8308e73e7
FIX: improves tag-list setting ( #9574 )
...
- Prevents setting to display an empty tag
- Updates dropdown when selecting/removing tag
2020-04-28 20:05:30 +02:00
Joffrey JAFFEUX
d83f39be73
DEV: replaces jquery scrollTop by vanilla js code ( #9543 )
2020-04-24 12:45:47 +02:00
Joffrey JAFFEUX
b871e79c5b
FIX: removes rounding correction as it can be in either direction ( #9538 )
2020-04-23 23:10:40 +02:00
Joffrey JAFFEUX
3bbd8b1258
UX: rework date time input range ( #9524 )
2020-04-22 22:17:53 +02:00
Joffrey JAFFEUX
00f632fb0d
REFACTOR: s/translatedfilterPlaceholder/translatedFilterPlaceholder ( #9521 )
2020-04-22 20:39:55 +02:00
Joffrey JAFFEUX
4c248fc5c4
UX: do not attempt to full width sk on mobile ( #9520 )
2020-04-22 20:39:45 +02:00
Joffrey JAFFEUX
4889dbde49
FIX: differentiate sk outline handling on single/multi ( #9512 )
2020-04-22 13:02:20 +02:00
Joffrey JAFFEUX
5c45363e67
UX: better outline support in sk components ( #9510 )
2020-04-22 10:54:02 +02:00
Joffrey JAFFEUX
62459c845f
DEV: allows a sk component to stop click propagation ( #9495 )
2020-04-21 17:11:40 +02:00
Joffrey JAFFEUX
79058a6d99
DEV: makes sk scroll to current selection ( #9492 )
2020-04-21 16:48:49 +02:00
Joffrey JAFFEUX
4f834f0008
DEV: allows click to propagate outside of header but not outside of sk ( #9491 )
2020-04-21 16:20:05 +02:00
Roman Rizzi
35f51100e1
FEATURE: Users can be ignored for six months. ( #9446 )
2020-04-17 10:27:11 -03:00
Joffrey JAFFEUX
5a8a844e4e
FIX: attempts to listen more reliably to scopedCategoryId changes ( #9431 )
2020-04-15 19:59:27 +02:00
Joffrey JAFFEUX
c4644c61d9
DEV: enforces double quotes ember-template-lint ( #9416 )
2020-04-14 08:18:49 +02:00
Joffrey JAFFEUX
b66b277dc4
DEV: enforces block-indentation of ember-template-lint rules ( #9408 )
2020-04-13 17:17:20 +02:00
Joffrey JAFFEUX
a947b7b839
FIX: prevents registering multiple `topic-notifications-button:changed` ( #9356 )
...
A large topic page will always have the bottom tracking button, and will also have the timeline, meaning we already had 2 tracking events.
But it gets even worse when you know that the timeline button is a component connector which will trigger `didInsertElement` very frequently, meaning we were constantly adding more and more appEvents handlers.
2020-04-06 15:06:26 +02:00
Joffrey JAFFEUX
883901e4c0
FIX: do not attempt to deselect tags if filter is not empty ( #9345 )
2020-04-03 16:27:56 +02:00
Sam Saffron
cade4957ae
DEV: don't use _ cause property is observed
...
Followup on fcc5ef96
2020-04-02 10:22:13 +11:00
Sam Saffron
b8d2261db9
FIX: correctly load drafts based of id
...
Previously we relied on race conditions to correctly open a draft, so this
broke.
New code is deliberate.
Also corrects missing observers on composer action
2020-04-01 14:23:26 +11:00
Sam Saffron
fcc5ef9625
FIX: when switching reply type update options
...
Previously we were not correctly updating reply types leading to inconsistent
behavior when using drop down in composer (for reply type)
2020-03-31 14:40:57 +11:00
Joffrey JAFFEUX
fa5ba6beb8
FIX: ensures mini-tag-chooser display min tags req if no selection ( #9303 )
2020-03-30 19:34:53 +02:00
Vinoth Kannan
dbc323e12a
Fix the typo.
2020-03-25 23:32:32 +05:30
Robin Ward
07813c4a91
Convert select-kit from es6 to js ( #9246 )
...
* Convert select-kit from es6 to js
* Hide more git blames
2020-03-20 12:40:32 -04:00
Vinoth Kannan
aad12822b7
FEATURE: automatically delete replies on a topic after N days. ( #9209 )
2020-03-19 21:06:31 +05:30
Joffrey JAFFEUX
b727e39a42
DEV: gives sk components a way to trigger a search manually ( #9199 )
2020-03-13 12:41:08 +01:00
Joffrey JAFFEUX
683cb28099
DEV: enforces ember-template-lint: no-triple-curlies ( #9165 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-11 09:23:10 +01:00
Joffrey JAFFEUX
e848d98782
FIX: ensures category exists for hideParent in categoryBadgeHTML ( #9161 )
2020-03-11 00:58:46 +01:00
romanrizzi
f795c1b8e8
Revert "DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )"
...
This reverts commit d436b600fb
.
Triple curlies are still necessary for some raw templates.
2020-03-10 15:00:12 -03:00
Joffrey JAFFEUX
3f2c0b42fe
FIX: throttles topic tracking shortcut and enforces topic id ( #9159 )
2020-03-10 17:17:54 +01:00
Joffrey JAFFEUX
d436b600fb
DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-10 16:46:57 +01:00
Joffrey JAFFEUX
020c1b9cf3
FIX: correctly checks if component is in modal ( #9157 )
2020-03-10 12:22:56 +01:00
Joffrey JAFFEUX
78a6b76310
FIX: ensures pinned-options header is showing correct state ( #9156 )
2020-03-10 09:56:55 +01:00
Jarek Radosz
5037b80c9c
Merge imports from the same module ( #9144 )
2020-03-09 17:38:37 +01:00
Joffrey JAFFEUX
4f37233208
DEV: enforces ember-template-lint: simple-unless ( #9146 )
2020-03-09 13:44:34 +01:00
Jarek Radosz
48ba65f406
DEV: Clean up Ember imports ( #8979 )
...
Includes:
* Import `computed` helpers
* Import `@ember/application`
* Import `isBlank` from `@ember/utils`
* Import `A` from `@ember/array`
* Import `EmberArray` from `@ember/array`
* Import `ArrayProxy` from `@ember/array/proxy`
* Import `warn` from `@ember/debug`
* Import `EmberObject` from `@ember/object`
* Import `Application` from `@ember/application`
* Import `EmberRouter` from `@ember/routing/router`
* Import `isPresent` from `@ember/utils`
* Import `computed` from `@ember/object`
* Import `guidFor` from `@ember/object`
* Import `isArray` from `@ember/array`
* Import `TextField` from `@ember/component`
* Import `TextArea` from `@ember/component`
* Import `Promise` from `rsvp`
* Import `Evented` from `@ember/object/evented`
* Replace deprecated `ember-addons/ember-computed-decorators` imports
2020-03-06 23:49:28 +01:00
Joffrey JAFFEUX
bb5990781e
FIX: allows to define placement strategy of select-kit body ( #9109 )
2020-03-06 20:27:33 +01:00
Joffrey JAFFEUX
29c9d8a133
FIX: uses only global allow_uncategorized_topics for category drop ( #9130 )
2020-03-06 20:11:21 +01:00
Joffrey JAFFEUX
ed85cfe141
FIX: prevents click on sk header to bubble ( #9084 )
2020-03-02 20:06:02 +01:00
Joffrey JAFFEUX
2db8ada222
FIX: ensures category url of category drop is built using slug and id ( #9069 )
2020-02-28 17:58:22 +01:00
Joffrey JAFFEUX
501936f0da
FIX: prevents loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:04 +01:00
Joffrey JAFFEUX
56345faf9a
FIX: prevents row click event to be caught by filter input event ( #9059 )
...
This was causing some dropdowns to not work under IE11
2020-02-27 14:04:23 +01:00
Penar Musaraj
d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ( #9030 )
...
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
Joffrey JAFFEUX
f336aeee6f
FIX: ensures scoped search category is searching in all categories ( #9031 )
2020-02-24 19:19:53 +01:00
Joffrey JAFFEUX
0b0290cddb
FIX: muted was not working in topic timeline ( #9021 )
2020-02-21 21:32:58 +01:00
Joffrey JAFFEUX
e807dff6fc
FIX: ensures mini-tag-chooser is respecting max_tags_per_topic ( #9018 )
2020-02-21 12:16:05 +01:00
Jarek Radosz
9f8a27a132
DEV: Import `makeArray` from `discourse-common` instead using `Ember` global ( #8977 )
2020-02-19 00:57:58 +01:00
Joffrey JAFFEUX
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
Joffrey JAFFEUX
67ee79f023
FIX: group members dropdown was broken on mobile ( #8994 )
2020-02-18 23:23:38 +01:00
Vinoth Kannan
2e397c78c4
FIX: use separate site attribute for single category "top tags" list.
...
And use it only in the single category pages.
38dd184a16
2020-02-17 21:09:27 +05:30
David Taylor
f1f9648e88
Revert "FIX: sk body should follow wrapper width ( #8984 )"
...
This was causing very narrow dropdowns in the composer and notification level dropdowns.
This reverts commit d33aaa0292
.
2020-02-17 13:10:26 +00:00
Joffrey JAFFEUX
d33aaa0292
FIX: sk body should follow wrapper width ( #8984 )
2020-02-17 10:39:20 +01:00
Joffrey JAFFEUX
9feace3388
FIX: prevents error when loading tag groups ( #8983 )
2020-02-17 10:39:04 +01:00
Joffrey JAFFEUX
7d94de6439
FIX: brings back castInteger as a safer migration path for sk2 ( #8966 )
2020-02-14 10:00:39 +01:00