require 'rails_helper' describe UserAction do before do UserActionCreator.enable end it { is_expected.to validate_presence_of :action_type } it { is_expected.to validate_presence_of :user_id } describe 'lists' do let(:public_post) { Fabricate(:post) } let(:public_topic) { public_post.topic } let(:user) { Fabricate(:user) } let(:private_post) { Fabricate(:post) } let(:private_topic) do topic = private_post.topic topic.update_columns(category_id: nil, archetype: Archetype::private_message) TopicAllowedUser.create(topic_id: topic.id, user_id: user.id) topic end def log_test_action(opts = {}) UserAction.log_action!({ action_type: UserAction::NEW_PRIVATE_MESSAGE, user_id: user.id, acting_user_id: user.id, target_topic_id: private_topic.id, target_post_id: private_post.id, }.merge(opts)) end describe "integration" do before do # Create some test data using a helper log_test_action log_test_action(action_type: UserAction::GOT_PRIVATE_MESSAGE) log_test_action(action_type: UserAction::NEW_TOPIC, target_topic_id: public_topic.id, target_post_id: public_post.id) log_test_action(action_type: UserAction::BOOKMARK) end def stats_for_user(viewer = nil) UserAction.stats(user.id, Guardian.new(viewer)).map { |r| r["action_type"].to_i }.sort end def stream_count(viewer = nil) UserAction.stream(user_id: user.id, guardian: Guardian.new(viewer)).count end it 'includes the events correctly' do PostActionNotifier.enable mystats = stats_for_user(user) expecting = [UserAction::NEW_TOPIC, UserAction::NEW_PRIVATE_MESSAGE, UserAction::GOT_PRIVATE_MESSAGE, UserAction::BOOKMARK].sort expect(mystats).to eq(expecting) expect(stream_count(user)).to eq(4) other_stats = stats_for_user expecting = [UserAction::NEW_TOPIC] expect(stream_count).to eq(1) expect(other_stats).to eq(expecting) public_topic.trash!(user) expect(stats_for_user).to eq([]) expect(stream_count).to eq(0) # groups category = Fabricate(:category, read_restricted: true) public_topic.recover! public_topic.category = category public_topic.save expect(stats_for_user).to eq([]) expect(stream_count).to eq(0) group = Fabricate(:group) u = Fabricate(:coding_horror) group.add(u) group.save category.set_permissions(group => :full) category.save expect(stats_for_user(u)).to eq([UserAction::NEW_TOPIC]) expect(stream_count(u)).to eq(1) # duplicate should not exception out log_test_action # recategorize belongs to the right user category2 = Fabricate(:category) admin = Fabricate(:admin) public_post.revise(admin, category_id: category2.id) action = UserAction.stream(user_id: public_topic.user_id, guardian: Guardian.new)[0] expect(action.acting_user_id).to eq(admin.id) expect(action.action_type).to eq(UserAction::EDIT) end end describe "mentions" do before do log_test_action(action_type: UserAction::MENTION) end let(:stream) do UserAction.stream( user_id: user.id, guardian: Guardian.new(user) ) end it "is returned by the stream" do expect(stream).to be_present end it "isn't returned when mentions aren't enabled" do SiteSetting.enable_mentions = false expect(stream).to be_blank end end end describe "mentions" do it "returns the mention in the stream" do end end describe 'when user likes' do let(:post) { Fabricate(:post) } let(:likee) { post.user } let(:liker) { Fabricate(:coding_horror) } def likee_stream UserAction.stream(user_id: likee.id, guardian: Guardian.new) end before do @old_count = likee_stream.count end it "creates a new stream entry" do PostAction.act(liker, post, PostActionType.types[:like]) expect(likee_stream.count).to eq(@old_count + 1) end context "successful like" do before do PostAction.act(liker, post, PostActionType.types[:like]) @liker_action = liker.user_actions.find_by(action_type: UserAction::LIKE) @likee_action = likee.user_actions.find_by(action_type: UserAction::WAS_LIKED) end it 'should result in correct data assignment' do expect(@liker_action).not_to eq(nil) expect(@likee_action).not_to eq(nil) expect(likee.user_stat.reload.likes_received).to eq(1) expect(liker.user_stat.reload.likes_given).to eq(1) PostAction.remove_act(liker, post, PostActionType.types[:like]) expect(likee.user_stat.reload.likes_received).to eq(0) expect(liker.user_stat.reload.likes_given).to eq(0) end context 'private message' do let(:post) { Fabricate(:private_message_post) } let(:likee) { post.topic.topic_allowed_users.first.user } let(:liker) { post.topic.topic_allowed_users.last.user } it 'should not increase user stats' do expect(@liker_action).not_to eq(nil) expect(liker.user_stat.reload.likes_given).to eq(0) expect(@likee_action).not_to eq(nil) expect(likee.user_stat.reload.likes_received).to eq(0) PostAction.remove_act(liker, post, PostActionType.types[:like]) expect(liker.user_stat.reload.likes_given).to eq(0) expect(likee.user_stat.reload.likes_received).to eq(0) end end end context "liking a private message" do before do post.topic.update_columns(category_id: nil, archetype: Archetype::private_message) end it "doesn't add the entry to the stream" do PostAction.act(liker, post, PostActionType.types[:like]) expect(likee_stream.count).not_to eq(@old_count + 1) end end end describe 'when a user posts a new topic' do def process_alerts(post) PostAlerter.post_created(post) end before do @post = Fabricate(:old_post) process_alerts(@post) end describe 'topic action' do before do @action = @post.user.user_actions.find_by(action_type: UserAction::NEW_TOPIC) end it 'should exist' do expect(@action).not_to eq(nil) expect(@action.created_at).to be_within(1).of(@post.topic.created_at) end end it 'should not log a post user action' do expect(@post.user.user_actions.find_by(action_type: UserAction::REPLY)).to eq(nil) end describe 'when another user posts on the topic' do before do @other_user = Fabricate(:coding_horror) @mentioned = Fabricate(:admin) @response = Fabricate(:post, reply_to_post_number: 1, topic: @post.topic, user: @other_user, raw: "perhaps @#{@mentioned.username} knows how this works?") process_alerts(@response) end it 'should log user actions correctly' do expect(@response.user.user_actions.find_by(action_type: UserAction::REPLY)).not_to eq(nil) expect(@post.user.user_actions.find_by(action_type: UserAction::RESPONSE)).not_to eq(nil) expect(@mentioned.user_actions.find_by(action_type: UserAction::MENTION)).not_to eq(nil) expect(@post.user.user_actions.joins(:target_post).where('posts.post_number = 2').count).to eq(1) end it 'should not log a double notification for a post edit' do @response.raw = "here it goes again" @response.save! expect(@response.user.user_actions.where(action_type: UserAction::REPLY).count).to eq(1) end end end describe 'when user bookmarks' do before do @post = Fabricate(:post) @user = @post.user PostAction.act(@user, @post, PostActionType.types[:bookmark]) @action = @user.user_actions.find_by(action_type: UserAction::BOOKMARK) end it 'should create a bookmark action correctly' do expect(@action.action_type).to eq(UserAction::BOOKMARK) expect(@action.target_post_id).to eq(@post.id) expect(@action.acting_user_id).to eq(@user.id) expect(@action.user_id).to eq(@user.id) PostAction.remove_act(@user, @post, PostActionType.types[:bookmark]) expect(@user.user_actions.find_by(action_type: UserAction::BOOKMARK)).to eq(nil) end end describe 'secures private messages' do let(:user) do Fabricate(:user) end let(:user2) do Fabricate(:user) end let(:private_message) do PostCreator.create(user, raw: 'this is a private message', title: 'this is the pm title', target_usernames: user2.username, archetype: Archetype::private_message ) end def count_bookmarks UserAction.stream( user_id: user.id, action_types: [UserAction::BOOKMARK], ignore_private_messages: false, guardian: Guardian.new(user) ).count end it 'correctly secures stream' do PostAction.act(user, private_message, PostActionType.types[:bookmark]) expect(count_bookmarks).to eq(1) private_message.topic.topic_allowed_users.where(user_id: user.id).destroy_all expect(count_bookmarks).to eq(0) group = Fabricate(:group) group.add(user) private_message.topic.topic_allowed_groups.create(group_id: group.id) expect(count_bookmarks).to eq(1) end end describe 'synchronize_target_topic_ids' do it 'correct target_topic_id' do post = Fabricate(:post) action = UserAction.log_action!( action_type: UserAction::NEW_PRIVATE_MESSAGE, user_id: post.user.id, acting_user_id: post.user.id, target_topic_id: -1, target_post_id: post.id, ) UserAction.log_action!( action_type: UserAction::NEW_PRIVATE_MESSAGE, user_id: post.user.id, acting_user_id: post.user.id, target_topic_id: -2, target_post_id: post.id, ) UserAction.synchronize_target_topic_ids action.reload expect(action.target_topic_id).to eq(post.topic_id) end end end