discourse/spec
Blake Erickson b53df4d884
FIX: Videos not uploading due to thumbnail generation error (#28493)
If we don't get a `videoWidth` back for a video don't try and generate a
thumbnail for it.

Also as part of this change I switched getImageData, the function
throwing the error, to use video.videoWidth instead of canvas.width
because it's very likely we were setting canvas.width too early before
the width could be read. Now that we are reading the value inside of the
setTimeout hopefully we will actually have a width. Just incase we don't
detect a width we will now exit early instead of throwing an error.

We only need to check for `0` and not null because the value is an
integer and will always return a 0 if it can't be read. https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/videoWidth

See https://meta.discourse.org/t/322363
2024-08-22 13:35:18 -06:00
..
fabricators UX: Use a dropdown for SSL mode for group SMTP (#27932) 2024-07-18 10:33:14 +10:00
fixtures FEATURE: Allow oneboxing private GitHub repo URLs and add private indicator to HTML (#27947) 2024-07-19 12:21:45 +10:00
generator DEV: Silence the output of migration specs (#26365) 2024-03-26 11:32:44 +01:00
helpers DEV: update base url links to respect subfolder installs (#27740) 2024-07-09 12:42:38 +04:00
import_export DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
initializers DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
integration DEV: Enable Rails 7.1 defaults 2024-08-12 10:41:13 +02:00
integrity DEV: Add spec to ensure app works with multiple tagged loggers 2024-08-13 18:10:03 +02:00
jobs FEATURE: add delay to native push notifications (#28314) 2024-08-13 12:12:05 +04:00
lib FIX: Trigger user_logged_out event when the user logs out (#28482) 2024-08-22 21:48:27 +08:00
mailers UX: Use a dropdown for SSL mode for group SMTP (#27932) 2024-07-18 10:33:14 +10:00
migrations DEV: Remove invalid content_security_policy_script_src site setting values from DB (#27588) 2024-06-27 22:17:56 +08:00
models FIX: serialize Flags instead of PostActionType (#28362) 2024-08-14 12:13:46 +10:00
multisite FIX: serialize Flags instead of PostActionType (#28362) 2024-08-14 12:13:46 +10:00
requests DEV: Use `Service::Base` for suspend and silence actions (#28459) 2024-08-22 14:38:56 +03:00
script/import_scripts DEV: Catch missing translations during test runs (#26258) 2024-05-24 22:15:53 +08:00
serializers FIX: broken mentioned users with capitalized usernames (#28421) 2024-08-19 20:57:45 +02:00
services DEV: Allow disabling problem checks programatically (#28440) 2024-08-20 16:42:06 +02:00
support DEV: Add backup helpers for specs (#28394) 2024-08-16 14:51:57 +10:00
system FIX: Videos not uploading due to thumbnail generation error (#28493) 2024-08-22 13:35:18 -06:00
tasks DEV: Stop storing theme-transpiler on filesystem in development (#28198) 2024-08-01 17:59:34 +01:00
views FEATURE: Simplify crawler content for non-canonical post URLs (#26324) 2024-03-26 15:18:46 +00:00
rails_helper.rb DEV: Add backup helpers for specs (#28394) 2024-08-16 14:51:57 +10:00
regenerate_swagger_docs
swagger_helper.rb DEV: Bump rswag-specs from 2.11.0 to 2.13.0 (#24654) 2023-12-07 08:16:47 +08:00