discourse/spec
Matt Marjanović aa4ff47208
FEATURE: Allow `target` attribute in links in user_field descriptions (#19102)
This change adds `target` to the set of attributes allowed by the
HTML sanitizer which is applied to the description of a user_field.

The rationale for this change:

 * If one puts a link (<a>...</a>) in the description of a user_field
   that is present and/or required at sign-up, the expectation is that
   a prospective new user will click on that link during sign-up.
 * Without an appropriate `target` attribute on the link, the new page
   will be loaded in the same window/tab as the sign-up form, but this
   will obliterate any fields that the user had already filled-out on
   the form.  (E.g., hitting the back-button will return to an
   empty form.)
 * Such UX behavior is incredibly aggravating to new users.

This change allows an admin to add a `target` attribute to links, to
instruct the browser to open them in a different window/tab, leaving
a sign-up form intact.
2023-01-06 10:18:35 -03:00
..
fabricators DEV: Specify slug name during Category fabrication 2023-01-06 08:42:26 +08:00
fixtures DEV: Fix png optimization test flakyness (#19535) 2022-12-20 16:05:14 -03:00
helpers FEATURE: Optionally allow a separate `s3_asset_cdn_url` to be specified (#19284) 2022-12-08 10:36:20 +00:00
import_export DEV: Add a rake task to export/import translation overrides (#18487) 2022-10-05 15:22:16 -04:00
initializers Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
integration FEATURE: Track API and user API requests (#19186) 2022-11-29 13:07:42 +02:00
integrity DEV: Compatibility with Ruby 3.2 (#19303) 2022-12-13 16:03:53 -03:00
jobs SECURITY: BCC active user emails from group SMTP (#19725) 2023-01-05 06:07:50 +08:00
lib DEV: Include message-bus request type in HTTP request data (#19762) 2023-01-06 11:26:18 +00:00
mailers FIX: Improve tags in email subjects and add filter headers (#19760) 2023-01-06 10:03:02 +10:00
models FEATURE: Allow `target` attribute in links in user_field descriptions (#19102) 2023-01-06 10:18:35 -03:00
multisite DEV: Change HashtagAutocompleteService to use DiscoursePluginRegistry (#19491) 2022-12-19 13:46:17 +10:00
requests SECURITY: Convert send_digest to a post request (#19746) 2023-01-05 06:57:12 +08:00
script/import_scripts DEV: Remove remaining hardcoded ids (#18735) 2022-10-25 15:29:09 +08:00
serializers DEV: Specify slug name during Category fabrication 2023-01-06 08:42:26 +08:00
services FIX: Add missing email template for `user_watching_category_or_tag` (#19653) 2022-12-29 15:36:53 +01:00
support FIX: Admin can't see user sidebar preferences of other users (#19570) 2022-12-23 11:45:29 +08:00
system FIX: Bookmark auto delete preference usage and default value (#19707) 2023-01-05 08:43:58 +10:00
tasks FIX: Allow attr updates of over-size-limit uploads (#18986) 2022-11-11 17:56:11 +01:00
views DEV: use structured data in topic-list for referencing only (#16235) 2022-12-05 18:00:32 +02:00
rails_helper.rb DEV: Change system spec JS log level to SEVERE by default (#19757) 2023-01-05 16:41:22 +10:00
regenerate_swagger_docs DEV: Add API docs for uploads and API doc watcher (#15387) 2021-12-23 08:40:15 +10:00
swagger_helper.rb DEV: Update rubocop (#18754) 2022-10-26 09:05:15 +08:00