David Taylor
0d0d78841b
FIX: Remove plugin.enabled?
checks at initialization time ( #6166 )
...
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
- An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
- In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.
Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.
I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
- `post_custom_fields_whitelist`
- `whitelist_staff_user_custom_field`
- `add_permitted_post_create_param`
2018-07-25 16:44:09 +01:00
..
2018-06-12 13:06:25 +08:00
2018-07-25 16:03:14 +01:00
2018-06-19 16:13:36 +10:00
2018-07-25 08:26:30 -04:00
2018-06-07 13:28:18 +08:00
2018-06-19 16:13:36 +10:00
2018-07-24 13:51:53 +08:00
2018-05-01 15:43:49 +02:00
2017-09-01 09:28:16 -04:00
2018-07-06 17:16:40 -05:00
2018-07-04 09:42:38 +10:00
2018-07-13 12:51:08 +10:00
2017-07-05 11:12:10 +02:00
2018-06-07 13:28:18 +08:00
2017-07-28 10:20:09 +09:00
2018-04-02 13:52:51 +08:00
2018-04-26 09:15:53 +02:00
2018-07-18 12:37:01 +10:00
2018-07-09 16:54:18 +08:00
2018-06-07 13:28:18 +08:00
2018-07-25 16:44:09 +01:00
2018-03-13 13:41:06 -04:00
2018-06-19 07:48:03 +08:00
2018-06-19 17:58:21 +08:00
2017-08-25 11:52:59 -04:00
2018-07-10 09:53:25 +08:00
2018-07-25 11:40:59 +02:00
2018-07-12 14:18:21 +10:00
2018-07-24 00:10:09 +02:00
2018-04-03 16:11:03 +10:00
2018-06-18 17:20:04 -07:00
2018-07-24 09:00:20 -04:00
2017-04-04 15:59:01 -04:00
2018-01-25 13:56:08 -05:00
2018-06-28 10:12:32 +02:00
2017-07-28 10:20:09 +09:00
2017-09-08 14:07:24 +08:00
2017-11-14 13:20:19 -05:00
2018-01-19 19:52:42 +01:00
2018-05-03 15:41:41 +02:00
2018-06-28 18:15:07 +10:00
2018-06-19 16:13:36 +10:00
2018-07-04 22:51:19 +02:00
2017-07-28 10:20:09 +09:00
2018-06-20 10:47:14 +08:00
2018-06-21 10:56:46 +10:00
2017-07-28 10:20:09 +09:00
2017-01-09 17:18:58 -05:00
2018-06-07 13:16:03 -04:00
2017-07-28 10:20:09 +09:00
2017-07-28 10:20:09 +09:00
2018-04-16 15:41:45 +02:00
2017-06-01 16:21:00 +09:00
2017-11-01 16:43:19 +11:00
2018-04-17 12:07:52 +08:00
2018-07-23 16:51:57 +01:00
2017-07-28 10:20:09 +09:00
2018-06-12 00:09:15 +08:00
2018-05-15 16:05:48 +02:00
2017-11-21 17:10:04 +08:00
2018-07-23 16:51:57 +01:00
2018-07-25 11:04:01 -04:00
2017-10-20 23:03:42 +08:00
2017-07-28 10:20:09 +09:00
2017-07-28 10:20:09 +09:00
2017-03-01 08:28:34 -07:00
2017-11-18 17:16:44 +01:00
2018-06-07 13:28:18 +08:00
2018-03-14 14:37:55 +08:00
2018-03-12 16:55:23 +01:00
2017-12-06 10:45:09 +11:00
2017-12-06 10:45:09 +11:00
2018-06-07 13:28:18 +08:00
2017-09-07 21:36:27 +08:00
2018-07-24 12:00:34 -04:00
2018-06-20 17:53:49 +10:00
2017-10-19 13:55:23 -04:00
2017-07-28 10:20:09 +09:00
2017-10-06 16:20:01 +11:00
2018-07-12 14:18:21 +10:00
2018-03-06 16:49:31 +11:00
2017-11-10 06:45:19 +11:00
2017-07-28 10:20:09 +09:00
2018-02-26 23:28:02 +01:00
2018-06-07 13:28:18 +08:00
2018-06-12 10:09:57 -04:00
2017-09-25 12:25:14 -04:00
2018-05-30 15:33:58 +02:00
2017-07-28 10:20:09 +09:00
2017-07-28 10:20:09 +09:00
2017-07-28 10:20:09 +09:00
2018-02-28 10:45:11 +11:00
2018-07-24 09:41:55 +01:00
2018-07-13 12:51:08 +10:00
2017-07-28 10:20:09 +09:00
2018-06-07 13:28:18 +08:00
2018-02-26 10:25:58 +11:00
2017-07-28 10:20:09 +09:00
2017-12-06 01:47:51 +01:00
2017-08-02 14:00:18 -04:00
2017-09-08 14:07:24 +08:00
2018-07-05 11:07:46 +02:00
2018-07-24 19:25:11 -04:00
2018-05-26 02:09:48 +02:00
2018-01-26 14:01:30 -05:00
2018-07-13 12:51:08 +10:00
2018-06-08 13:56:20 -04:00
2017-09-14 12:07:35 +08:00
2018-06-22 13:20:00 -07:00
2018-03-13 13:41:06 -04:00
2018-04-25 08:44:07 +10:00
2018-06-07 13:28:18 +08:00
2017-12-21 15:30:32 -05:00
2017-07-03 15:26:57 -04:00
2018-07-16 14:44:55 +10:00
2018-07-05 15:10:19 +10:00
2017-07-28 10:20:09 +09:00
2018-07-03 15:57:34 +08:00
2017-07-28 10:20:09 +09:00
2018-06-25 16:09:39 +10:00
2018-06-11 12:48:09 +08:00
2018-04-18 11:32:32 +05:30
2018-04-02 13:52:51 +08:00
2017-07-28 10:20:09 +09:00
2017-07-28 10:20:09 +09:00
2018-06-20 17:53:49 +10:00
2018-03-28 14:48:14 -04:00
2018-01-19 11:35:19 -05:00
2017-07-28 10:20:09 +09:00
2017-09-08 14:07:24 +08:00
2017-03-30 10:23:24 -04:00
2018-02-21 00:12:39 +05:30
2018-02-01 13:25:29 +05:30
2018-03-04 19:04:23 -05:00
2018-03-04 19:04:23 -05:00
2018-06-27 11:41:35 +08:00
2018-04-11 07:17:52 +05:30
2017-07-28 10:20:09 +09:00
2018-03-26 16:06:20 -04:00
2018-06-07 14:21:33 +10:00
2018-06-07 13:28:18 +08:00
2018-06-07 13:28:18 +08:00
2017-07-28 10:20:09 +09:00
2018-07-13 15:10:39 +08:00
2018-06-19 16:13:36 +10:00
2018-07-19 10:22:36 +05:30
2017-07-28 10:20:09 +09:00
2018-07-17 15:50:58 +08:00
2017-12-12 20:17:46 +01:00
2017-03-29 18:19:28 +05:30
2018-06-21 10:41:52 -04:00
2017-07-28 10:20:09 +09:00