mirror of
https://github.com/discourse/discourse.git
synced 2025-02-06 03:18:23 +00:00
0764dc3452
This issue was especially visible in tests. the `@debounce(100)` was not cancelled when changing channel which was causing 404s as we were trying to load messages on a channel which was deleted as the channel has been destroyed at the end of the test. This is still not a perfect solution, as we can only cancel the start of `fetchMessages`, but we can't cancel the actual `chatApi.channel` request which result can potentially happens after channel changed, which we try to mitigate with various checks on to ensure visible channel == loaded messages channel. This commit also tries to make handler naming and cancelling more consistent. <!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
91 lines
2.8 KiB
Ruby
91 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Move message to channel", type: :system, js: true do
|
|
let(:chat) { PageObjects::Pages::Chat.new }
|
|
let(:channel) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
before { chat_system_bootstrap }
|
|
|
|
context "when user" do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1, user: current_user) }
|
|
|
|
before do
|
|
sign_in(current_user)
|
|
channel_1.add(current_user)
|
|
end
|
|
|
|
it "is not available" do
|
|
chat.visit_channel(channel_1)
|
|
channel.select_message(message_1)
|
|
|
|
expect(page).to have_no_content(I18n.t("js.chat.selection.move_selection_to_channel"))
|
|
end
|
|
|
|
context "when can moderate channel" do
|
|
fab!(:group_1) { Fabricate(:group) }
|
|
fab!(:channel_1) { Fabricate(:private_category_channel, group: group_1) }
|
|
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1, user: current_user) }
|
|
|
|
before do
|
|
SiteSetting.enable_category_group_moderation = true
|
|
group_1.add(current_user)
|
|
channel_1.add(current_user)
|
|
channel_1.chatable.update!(reviewable_by_group_id: group_1.id)
|
|
end
|
|
|
|
it "is available" do
|
|
chat.visit_channel(channel_1)
|
|
channel.select_message(message_1)
|
|
|
|
expect(page).to have_content(I18n.t("js.chat.selection.move_selection_to_channel"))
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when admin" do
|
|
fab!(:current_admin_user) { Fabricate(:admin) }
|
|
|
|
before { sign_in(current_admin_user) }
|
|
|
|
context "when dm channel" do
|
|
fab!(:dm_channel_1) { Fabricate(:direct_message_channel, users: [current_admin_user]) }
|
|
fab!(:message_1) do
|
|
Fabricate(:chat_message, chat_channel: dm_channel_1, user: current_admin_user)
|
|
end
|
|
|
|
it "is not available" do
|
|
chat.visit_channel(dm_channel_1)
|
|
channel.select_message(message_1)
|
|
|
|
expect(page).to have_no_content(I18n.t("js.chat.selection.move_selection_to_channel"))
|
|
end
|
|
end
|
|
|
|
context "when category channel" do
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:channel_2) { Fabricate(:chat_channel) }
|
|
fab!(:message_1) do
|
|
Fabricate(:chat_message, chat_channel: channel_1, user: current_admin_user)
|
|
end
|
|
|
|
before do
|
|
channel_1.add(current_admin_user)
|
|
channel_2.add(current_admin_user)
|
|
end
|
|
|
|
it "moves the message" do
|
|
chat.visit_channel(channel_1)
|
|
channel.select_message(message_1)
|
|
click_button(I18n.t("js.chat.selection.move_selection_to_channel"))
|
|
find(".chat-move-message-channel-chooser").click
|
|
find("[data-value='#{channel_2.id}']").click
|
|
click_button(I18n.t("js.chat.move_to_channel.confirm_move"))
|
|
|
|
expect(channel).to have_deleted_message(message_1)
|
|
end
|
|
end
|
|
end
|
|
end
|