Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/system
History
Alan Guo Xiang Tan 68a3328999
FIX: Tags in tag groups not shown in edit nav menu tags modal (#22382) 
What is the problem?

Before this change, the edit navigation menu tags modal was not
displaying tags that belonged to a tag_group when the tags_listed_by_group
site setting was set to true. This is because we are relying on the
/tags endpoint which returned tags in various keys depending on the
tags_listed_by_group site setting. When the site setting is set to
true, tags under belonging to tag groups were returned in the
extra.tag_groups attribute.

What is the fix?

This commit fixes it by pushing all tags in returned under the
`tag_groups` attribute into the list of tags to displayed. In a
following commit, we will move away from the `/tags` endpoint to a
dedicated route to handle the listing of tags in the modal.
 		2023-07-03 14:29:05 +08:00
..
composer DEV: Add diffhtml composer preview specs (#22333) 2023-06-29 09:37:44 +02:00
emojis DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
page_objects FIX: consistent sidebar section external links (#22343) 2023-06-30 12:25:43 +10:00
user_page DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
admin_customize_form_templates_spec.rb DEV: Add support for uploads to form templates (#22232) 2023-06-28 12:49:05 -07:00
admin_customize_themes_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
bookmarks_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
category_edit_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
category_topics_spec.rb FIX: update unread and new count for categories (#22145) 2023-06-21 13:42:30 +10:00
custom_sidebar_sections_spec.rb FIX: consistent sidebar section external links (#22343) 2023-06-30 12:25:43 +10:00
discovery_breadcrumb_navigation_spec.rb DEV: Fix random typos (#22078) 2023-06-13 22:02:21 +02:00
dismiss_topics_spec.rb FIX: change dismiss new button label (#22075) 2023-06-13 13:18:39 +10:00
editing_sidebar_categories_navigation_spec.rb UX: Use modals to edit categories and tags that appear in sidebar (#22295) 2023-06-28 07:20:31 +08:00
editing_sidebar_tags_navigation_spec.rb FIX: Tags in tag groups not shown in edit nav menu tags modal (#22382) 2023-07-03 14:29:05 +08:00
ember_deprecation_test.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
fast_edit_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
filtering_topics_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
hashtag_autocomplete_spec.rb FIX: Add aria-label attribute to cooked hashtags (#22182) 2023-06-20 15:47:17 +10:00
network_disconnected_spec.rb DEV: Use online/offline window events to track network connectivity (#22243) 2023-06-22 09:09:28 -05:00
reviewables_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
search_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
tag_notification_level_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
tag_synonyms_spec.rb DEV: Fix random typos (#22078) 2023-06-13 22:02:21 +02:00
topic_page_spec.rb DEV: Try to de-flake topic page specs (#22065) 2023-06-13 11:05:19 +02:00
topic_summarization_spec.rb DEV: Fix lint and flaky summarization spec (#22303) 2023-06-27 13:18:10 -03:00
user_preferences_interface_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_preferences_navigation_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_selector_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
viewing_category_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
viewing_navigation_menu_preferences_spec.rb UX: Use modals to edit categories and tags that appear in sidebar (#22295) 2023-06-28 07:20:31 +08:00
viewing_sidebar_as_anonymous_user_spec.rb DEV: Fix flaky tests by specifying tag names in asc order (#22271) 2023-06-26 10:09:26 +08:00
viewing_sidebar_mobile_spec.rb FIX: rename everything link to topics (#22076) 2023-06-15 11:36:38 +10:00
viewing_sidebar_spec.rb FIX: small bug with topics and my posts translations (#22179) 2023-06-19 17:51:33 +10:00
viewing_user_private_messages_spec.rb FIX: Broken group messages inboxes when group name is mixed case (#22183) 2023-06-19 17:36:04 +08:00