Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/components
History
Sam Saffron 0a5a6dfded DEV: stop mutating inputs as a side effect 
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.

This handles all the cases where specs caught this.

Mutating inputs makes code harder to reason about. Eg:

```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```

This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
 		2019-04-30 10:25:53 +10:00
..
active_record/connection_adapters DEV: Fix heisentest. 2019-02-19 08:21:51 +08:00
auth FEATURE: Allow API requests to specify the `DISCOURSE_VISIBLE` header 2019-04-15 17:34:34 +01:00
common_passwords Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
concern DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
email DEV: more accurate spec for email iframe handling 2019-04-25 22:32:53 +05:30
file_store DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
freedom_patches FIX: async reload of locales could result in missing translations 2018-10-01 17:14:36 +02:00
guardian SECURITY: Users can pick non-avatar uploads. 2018-12-18 13:38:25 +08:00
highlight_js Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
import Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
middleware FIX: error in response body to blocked crawlers, showing 500 Internal Server Error with status of 403 2018-09-14 15:40:20 -04:00
migration FEATURE: Use amazon s3 inventory to manage upload stats (#6867) 2019-02-01 10:10:48 +05:30
onebox/engine SECURITY: correct local onebox category checks 2018-02-14 10:40:46 +11:00
plugin DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
rate_limiter Add specs for `RateLimiter::LimitExceeded#description`. 2018-06-19 07:48:03 +08:00
scheduler dev, give spec a bit more time waiting on timeout 2018-11-19 16:21:39 +11:00
site_settings DEV: add site setting type group_list for a list of groups 2019-04-29 16:15:22 -04:00
stylesheet DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
svg_sprite FEATURE: Multiple SCSS file support for themes (#7351) 2019-04-12 11:36:08 +01:00
theme_store FEATURE: Multiple SCSS file support for themes (#7351) 2019-04-12 11:36:08 +01:00
validators Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
wizard FEATURE: better wizard privacy controls (#7391) 2019-04-22 19:47:29 +05:30
admin_confirmation_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
admin_user_index_query_spec.rb Improve specs to assert for the right record instead of just a count. 2018-05-17 08:47:24 +08:00
archetype_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
avatar_lookup_spec.rb UX: show full name on /latest page 2018-08-23 14:41:06 +05:30
cache_spec.rb dashboard next: caching, mobile support and new charts 2018-05-03 15:41:41 +02:00
category_badge_spec.rb SECURITY: category badges should HTML escape names 2018-06-28 18:15:07 +10:00
composer_messages_finder_spec.rb Remove unused variable. 2018-10-04 13:21:37 +08:00
content_buffer_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
cooked_post_processor_spec.rb DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
crawler_detection_spec.rb FIX: cubot android devices were detected as crawlers 2018-06-21 10:56:46 +10:00
current_user_spec.rb FEATURE: per client user tokens 2017-02-07 09:22:16 -05:00
directory_helper_spec.rb Prepare for separation of RSpec helper files 2015-12-01 20:39:42 +00:00
discourse_diff_spec.rb correct spec regression 2018-01-30 08:54:37 +11:00
discourse_event_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
discourse_hub_spec.rb fix failing spec when HUB_BASE_URL is present 2018-10-15 15:06:02 -04:00
discourse_i18n_spec.rb FIX: async reload of locales could result in missing translations 2018-10-01 17:14:36 +02:00
discourse_plugin_registry_spec.rb REFACTOR: Serve auth provider information in the site serializer. 2018-08-06 09:25:48 +01:00
discourse_plugin_spec.rb More randomly failing specs fixes. 2016-09-05 19:33:03 +08:00
discourse_redis_spec.rb FIX: Fallback Redis by checking status on master instead of slave. 2019-01-22 12:38:12 +08:00
discourse_spec.rb DEV: Raise exceptions when jobs fail in test mode 2019-04-08 15:59:04 +01:00
discourse_tagging_spec.rb FIX: if mandatory parent tag is missing, add it 2019-04-26 14:46:11 -04:00
discourse_updates_spec.rb REFACTOR: Avoid duplicated logic on server and client. 2017-11-21 17:10:04 +08:00
distributed_memoizer_spec.rb Prepare for separation of RSpec helper files 2015-12-01 20:39:42 +00:00
distributed_mutex_spec.rb DEV: Validity of distributed mutex configurable once per instance. 2019-02-20 09:29:45 +08:00
email_cook_spec.rb FEATURE: convert plain text emails to markdown 2017-12-06 01:47:51 +01:00
email_updater_spec.rb FEATURE: the hide_email_address_taken setting works with the change email address form in user preferences 2017-10-04 11:41:25 -04:00
enum_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
excerpt_parser_spec.rb Revert "FIX: strip spoilers in notification excerpts" 2019-04-15 10:15:17 -04:00
fallback_locale_list_spec.rb FEATURE: Allow plugins to register a new locale 2018-01-25 14:57:41 +01:00
feed_element_installer_spec.rb FEATURE: Replace SimpleRSS with Ruby RSS module (#5311) 2017-12-06 10:45:09 +11:00
feed_item_accessor_spec.rb FEATURE: Replace SimpleRSS with Ruby RSS module (#5311) 2017-12-06 10:45:09 +11:00
file_helper_spec.rb Include response body when raising an error in `FileHelper#download`. 2018-09-13 15:43:58 +08:00
filter_best_posts_spec.rb Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
final_destination_spec.rb FIX: preserve github fragment URL 2018-12-19 12:34:47 +05:30
flag_query_spec.rb FEATURE: New 'Reviewable' model to make reviewable items generic 2019-03-28 12:45:10 -04:00
flag_settings_spec.rb Refactor flag types for more customization 2017-10-19 13:55:23 -04:00
gaps_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
global_path_spec.rb Revert "Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523)"" 2018-10-24 15:14:01 +11:00
guardian_spec.rb Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
has_errors_spec.rb FIX: show proper error message when no user selected for private message 2016-05-05 18:47:08 +05:30
hijack_spec.rb Add Cache-Control header to CORS (#6490) 2018-10-16 10:46:55 +11:00
html_prettify_spec.rb FEATURE: stop escaping special chars in title prettify 2017-03-13 10:02:20 -04:00
html_to_markdown_spec.rb FIX: skip <br> inside <p> if next character is \n 2019-04-14 14:44:54 +05:30
image_sizer_spec.rb FIX: raise exception when getting dimensions of missing image 2018-12-03 10:19:49 -05:00
inline_oneboxer_spec.rb remove unnecessary expectation lines 2018-11-13 16:52:08 +05:30
js_locale_helper_spec.rb DEV: Remove warning. 2019-04-01 10:11:08 +08:00
json_error_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
letter_avatar_spec.rb Prepare for separation of RSpec helper files 2015-12-01 20:39:42 +00:00
method_profiler_spec.rb FIX: stop double counting net calls in logs 2018-02-28 10:45:11 +11:00
new_post_manager_spec.rb UX: Update post actions to "Approve Post" and "Reject Post" 2019-04-23 12:19:11 -04:00
new_post_result_spec.rb Prepare for separation of RSpec helper files 2015-12-01 20:39:42 +00:00
oneboxer_spec.rb FIX: Onebox discourse user not respecting enable names (#7245) 2019-03-25 12:50:14 +05:30
onpdiff_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
pbkdf2_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
pinned_check_spec.rb Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
plain_text_to_markdown_spec.rb FEATURE: convert plain text emails to markdown 2017-12-06 01:47:51 +01:00
post_action_creator_spec.rb FIX: Take action should agree with all pending flags 2019-04-08 12:39:18 -04:00
post_creator_spec.rb FEATURE: Let staff add custom post notices. (#7377) 2019-04-19 17:53:58 +03:00
post_destroyer_spec.rb FIX: Disagree and Restore should not revert edits 2019-04-11 16:21:18 -04:00
post_locker_spec.rb FEATURE: Staff members can lock posts 2018-01-26 14:01:30 -05:00
post_merger_spec.rb DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
post_revisor_spec.rb REFACTOR: Move `queue_jobs` out of `SiteSetting` 2019-03-14 10:47:38 -04:00
pretty_text_spec.rb Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
promotion_spec.rb FIX: do not send tl1 welcome message when a user has the basic user badge 2018-09-19 12:53:36 -07:00
quote_comparer_spec.rb FEATURE: Add `quote-modified` class if a quote has been modified 2018-03-13 13:41:06 -04:00
rate_limiter_spec.rb Add guard for `nil` in our `RateLimiter`. 2018-03-01 13:20:42 +08:00
redis_store_spec.rb Prepare for separation of RSpec helper files 2015-12-01 20:39:42 +00:00
retrieve_title_spec.rb PERF: ability to crawl for titles without extra HEAD req 2018-01-29 15:40:12 +11:00
rtl_spec.rb Nuke all `SiteSetting.stubs` from our codebase. 2017-07-07 15:09:14 +09:00
s3_helper_spec.rb FEATURE: Add SiteSetting for s3_configure_tombstone_policy 2018-09-17 10:57:50 +10:00
s3_inventory_spec.rb Removed unused let blocks (#7446) 2019-04-29 15:08:56 +08:00
score_calculator_spec.rb remove uneeded specs 2018-07-05 15:34:58 +10:00
search_spec.rb DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
secure_session_spec.rb SECURITY: prevent reuse of password reset 2016-12-19 18:00:22 +11:00
site_setting_extension_spec.rb DEV: stop mutating inputs as a side effect 2019-04-30 10:25:53 +10:00
slug_spec.rb FIX: Generate ASCII slug with default locale 2019-04-29 18:29:58 +02:00
spam_handler_spec.rb Nuke all `SiteSetting.stubs` from our codebase. 2017-07-07 15:09:14 +09:00
suggested_topics_builder_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
system_message_spec.rb FEATURE: Add site contact group. (#7152) 2019-03-13 11:34:47 +01:00
text_cleaner_spec.rb FIX: strip invalid byte sequences 2019-02-26 10:09:51 +01:00
text_sentinel_spec.rb FIX: skip some checks for CJK locale in TextSentinel (#7322) 2019-04-05 15:07:49 +02:00
theme_settings_manager_spec.rb FEATURE: Allow string theme settings to display with multiple lines 2019-02-05 14:14:53 +00:00
theme_settings_parser_spec.rb FEATURE: introduces list/compact_list components 2018-08-03 16:41:37 -04:00
timeline_lookup_spec.rb PERF: Don't pluck all the columns just to retrieve a single value. 2018-06-27 11:41:35 +08:00
topic_creator_spec.rb FIX: allow sending PMs to staff via flag even when PMs are disabled (#6938) 2019-01-24 16:56:59 +05:30
topic_publisher_spec.rb FIX: Missing topic edited web hook when publishing a topic. 2019-04-16 14:28:23 +08:00
topic_query_spec.rb DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
topic_retriever_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
topic_view_spec.rb DEV: remove update_attributes which is deprecated in Rails 6 2019-04-29 17:32:25 +10:00
topics_bulk_action_spec.rb Use `PostDestroyer` to delete topics when performing bulk operation (#5202) 2017-09-28 14:22:49 +02:00
trashable_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
trust_level_spec.rb Enums that are used in tables need to be stable 2016-01-08 20:43:11 +05:30
unread_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
url_helper_spec.rb FIX: detect local assets for subfolder installs 2019-04-13 10:35:23 -07:00
user_name_suggester_spec.rb FEATURE: Add support for Unicode usernames and group names 2019-04-23 13:00:27 +02:00
version_spec.rb Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00