mirror of
https://github.com/discourse/discourse.git
synced 2025-03-05 02:39:26 +00:00
bf886662df
This pull request is a full overhaul of the chat-composer and contains various improvements to the thread panel. They have been grouped in the same PR as lots of improvements/fixes to the thread panel needed an improved composer. This is meant as a first step. ### New features included in this PR - A resizable side panel - A clear dropzone area for uploads - A simplified design for image uploads, this is only a first step towards more redesign of this area in the future ### Notable fixes in this PR - Correct placeholder in thread panel - Allows to edit the last message of a thread with arrow up - Correctly focus composer when replying to a message - The reply indicator is added instantly in the channel when starting a thread - Prevents a large variety of bug where the composer could bug and prevent sending message or would clear your input while it has content ### Technical notes To achieve this PR, three important changes have been made: - `<ChatComposer>` has been fully rewritten and is now a glimmer component - The chat composer now takes a `ChatMessage` as input which can directly be used in other operations, it simplifies a lot of logic as we are always working a with a `ChatMessage` - `TextareaInteractor` has been created to wrap the existing `TextareaTextManipulation` mixin, it will make future migrations easier and allow us to have a less polluted `<ChatComposer>` Note ".chat-live-pane" has been renamed ".chat-channel" Design for upload dropzone is from @chapoi
26 lines
678 B
Ruby
26 lines
678 B
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Shortcuts | full page", type: :system, js: true do
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
|
|
let(:chat) { PageObjects::Pages::Chat.new }
|
|
|
|
before do
|
|
chat_system_bootstrap
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when pressing a letter" do
|
|
it "intercepts the event and propagates it to the composer" do
|
|
chat.visit_channel(channel_1)
|
|
find(".header-sidebar-toggle").click # simple way to ensure composer is not focused
|
|
|
|
page.send_keys("e")
|
|
|
|
expect(find(".chat-composer__input").value).to eq("e")
|
|
end
|
|
end
|
|
end
|