mirror of
https://github.com/discourse/discourse.git
synced 2025-02-08 20:34:52 +00:00
32e1eda3fa
* A11Y: Update bulk selection keyboard shortcuts Still a draft, but in current state this: - adds `shift+b` as a keyboard shortcut to toggle bulk select - adds `shift+d` as a keyboard shortcut to dismiss selected topic(s) (this replaces `x r` and `x t` shortcuts) - adds `x` as a keyboard shortcut to toggle selection (while in bulk select mode) - fixes a bug with the `shift+a` shortcut, which was not working properly Note that there is a breaking change here. Previously we had: - `x r` to dismiss new topics - `x t` to dismiss unread topics However, this meant that we couldn't use `x` for selection, because the itsatrap library does not allow the same character to be used both as a single character shortcut and as the start of a sequence. The proposed solution here is more consistent with other apps (Gmail, Github) that use `x` to toggle selection. Also, we never show both "Dismiss New" and "Dismiss Unread" in the same screen, hence it makes sense to consolidate both actions under `shift+d`. * Address review
94 lines
2.7 KiB
Ruby
94 lines
2.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module PageObjects
|
|
module Components
|
|
class TopicList < PageObjects::Components::Base
|
|
TOPIC_LIST_BODY_SELECTOR = ".topic-list-body"
|
|
TOPIC_LIST_ITEM_SELECTOR = "#{TOPIC_LIST_BODY_SELECTOR} .topic-list-item"
|
|
|
|
def topic_list
|
|
TOPIC_LIST_BODY_SELECTOR
|
|
end
|
|
|
|
def has_topics?(count: nil)
|
|
if count.nil?
|
|
page.has_css?(TOPIC_LIST_ITEM_SELECTOR)
|
|
else
|
|
page.has_css?(TOPIC_LIST_ITEM_SELECTOR, count: count)
|
|
end
|
|
end
|
|
|
|
def has_no_topics?
|
|
page.has_no_css?(TOPIC_LIST_ITEM_SELECTOR)
|
|
end
|
|
|
|
def has_topic?(topic)
|
|
page.has_css?(topic_list_item_class(topic))
|
|
end
|
|
|
|
def has_no_topic?(topic)
|
|
page.has_no_css?(topic_list_item_class(topic))
|
|
end
|
|
|
|
def has_topic_checkbox?(topic)
|
|
page.has_css?("#{topic_list_item_class(topic)} input#bulk-select-#{topic.id}")
|
|
end
|
|
|
|
def has_closed_status?(topic)
|
|
page.has_css?("#{topic_list_item_closed(topic)}")
|
|
end
|
|
|
|
def has_unread_badge?(topic)
|
|
page.has_css?("#{topic_list_item_unread_badge(topic)}")
|
|
end
|
|
|
|
def has_no_unread_badge?(topic)
|
|
page.has_no_css?("#{topic_list_item_unread_badge(topic)}")
|
|
end
|
|
|
|
def has_checkbox_selected_on_row?(n)
|
|
page.has_css?("#{TOPIC_LIST_ITEM_SELECTOR}:nth-child(#{n}) input.bulk-select:checked")
|
|
end
|
|
|
|
def has_no_checkbox_selected_on_row?(n)
|
|
page.has_no_css?("#{TOPIC_LIST_ITEM_SELECTOR}:nth-child(#{n}) input.bulk-select:checked")
|
|
end
|
|
|
|
def click_topic_checkbox(topic)
|
|
find("#{topic_list_item_class(topic)} input#bulk-select-#{topic.id}").click
|
|
end
|
|
|
|
def visit_topic_with_title(title)
|
|
find("#{TOPIC_LIST_BODY_SELECTOR} a", text: title).click
|
|
end
|
|
|
|
def visit_topic(topic)
|
|
find("#{topic_list_item_class(topic)} a.raw-topic-link").click
|
|
end
|
|
|
|
def visit_topic_last_reply_via_keyboard(topic)
|
|
find("#{topic_list_item_class(topic)} a.post-activity").native.send_keys(:return)
|
|
end
|
|
|
|
def visit_topic_first_reply_via_keyboard(topic)
|
|
find("#{topic_list_item_class(topic)} button.posts-map").native.send_keys(:return)
|
|
find("#topic-entrance button.jump-top").native.send_keys(:return)
|
|
end
|
|
|
|
private
|
|
|
|
def topic_list_item_class(topic)
|
|
"#{TOPIC_LIST_ITEM_SELECTOR}[data-topic-id='#{topic.id}']"
|
|
end
|
|
|
|
def topic_list_item_closed(topic)
|
|
"#{topic_list_item_class(topic)} .topic-statuses .topic-status svg.locked"
|
|
end
|
|
|
|
def topic_list_item_unread_badge(topic)
|
|
"#{topic_list_item_class(topic)} .topic-post-badges .unread-posts"
|
|
end
|
|
end
|
|
end
|
|
end
|