Martin Brennan
0d809197aa
FIX: Make sure S3 object headers are preserved on copy ( #14302 ) ...
When copying an existing upload stub temporary object
on S3 to its final destination we were not copying across
its additional headers such as content-disposition and
cache-control, which led to issues like attachments not
downloading with their original filename when clicking
the download links in posts.
This is because the metadata_directive = REPLACE option
was not being passed to object.copy_from(), so only the
source object's headers were being used. Added an option
for apply_metadata_to_destination to apply this option
conditionally, because we may not always want to replace
this metadata, but we definitely do when copying a temporary
upload.
2021-09-10 12:59:51 +10:00
2021-06-03 10:52:43 +01:00
2021-06-25 11:34:51 +02:00
2021-09-07 08:46:28 +10:00
2021-09-10 12:59:51 +10:00
2021-08-30 12:31:22 +01:00
2021-08-25 08:46:54 +10:00
2021-06-03 14:47:32 +10:00
2021-08-13 12:00:23 -03:00
2020-05-15 14:23:27 +08:00
2021-07-19 13:54:19 +08:00
2020-04-08 12:42:28 +10:00
2021-07-07 18:57:42 +02:00
2021-08-25 09:37:07 +08:00
2021-07-14 15:18:29 -04:00
2020-03-11 13:30:45 +00:00
2021-07-22 17:42:47 +03:00
2021-09-02 14:55:38 -04:00
2020-07-24 17:19:21 +08:00
2021-05-21 11:43:47 +10:00
2021-01-04 10:34:44 +01:00
2021-08-24 10:46:28 +03:00
2021-05-27 15:00:38 -04:00
2021-03-22 19:41:42 +02:00
2021-08-10 10:25:15 -04:00
2021-06-22 13:00:04 -05:00
2021-02-23 16:20:59 -05:00
2020-06-23 12:09:04 +08:00
2021-04-23 10:24:42 -04:00
2021-06-02 12:43:34 -04:00
2021-02-19 11:03:36 -05:00
2019-12-03 10:05:53 +01:00
2020-03-10 22:13:17 +01:00
2021-05-21 11:43:47 +10:00
2021-04-05 20:31:42 +05:30
2020-12-14 17:49:37 +02:00
2021-07-30 13:36:30 -04:00
2021-08-25 13:25:01 +08:00
2020-10-29 13:01:06 +11:00
2021-05-21 11:43:47 +10:00
2021-05-21 11:43:47 +10:00
2021-05-21 11:43:47 +10:00
2021-01-20 21:32:22 +01:00
2021-05-21 11:43:47 +10:00
2021-05-21 11:43:47 +10:00
2021-06-03 11:39:12 +10:00
2021-05-21 11:43:47 +10:00
2021-05-21 11:43:47 +10:00
2021-09-10 09:20:50 +08:00
2021-07-26 09:14:23 +08:00
2021-06-30 15:51:35 +03:00
2021-08-05 22:07:29 +04:00
2021-08-27 16:26:06 +01:00
2021-09-09 12:03:59 +03:00
2021-08-11 08:39:25 +10:00
2021-05-19 16:04:35 +04:00
2019-11-27 16:11:49 +11:00
2021-09-03 13:15:58 +05:30
2021-09-10 12:59:51 +10:00
2021-07-07 18:57:42 +02:00
2021-07-07 18:57:42 +02:00
2021-06-21 11:06:58 +08:00
2021-05-21 11:43:47 +10:00
2019-11-11 11:18:12 +11:00
2021-07-07 18:57:42 +02:00
2021-07-07 18:57:42 +02:00
2021-05-21 11:43:47 +10:00
2020-07-27 10:23:54 +10:00
2020-09-22 10:17:52 +10:00
2021-05-24 18:13:30 +10:00
2021-05-03 09:21:35 +02:00
2021-03-10 20:15:04 -05:00
2021-06-15 17:25:06 +02:00
2021-01-25 12:04:27 +01:00
2021-04-19 09:43:50 +10:00
2020-03-10 22:13:17 +01:00
2021-08-19 14:43:58 +03:00
2021-07-16 15:25:49 -03:00
2021-07-12 19:35:24 +03:00
2021-08-05 12:56:15 +08:00
2021-07-05 14:17:31 +08:00
2021-06-08 13:25:51 -04:00
2021-08-10 17:25:11 +05:30
2020-12-23 08:51:36 +11:00
2020-10-12 22:54:56 +02:00
0d809197aa