mirror of
https://github.com/discourse/discourse.git
synced 2025-02-06 03:18:23 +00:00
222c8d9b6a
A bit of a mixed bag, this addresses several edge areas of bookmarks and makes them compatible with polymorphic bookmarks (hidden behind the `use_polymorphic_bookmarks` site setting). The main ones are: * ExportUserArchive compatibility * SyncTopicUserBookmarked job compatibility * Sending different notifications for the bookmark reminders based on the bookmarkable type * Import scripts compatibility * BookmarkReminderNotificationHandler compatibility This PR also refactors the `register_bookmarkable` API so it accepts a class descended from a `BaseBookmarkable` class instead. This was done because we kept having to add more and more lambdas/properties inline and it was very messy, so a factory pattern is cleaner. The classes can be tested independently as well. Some later PRs will address some other areas like the discourse narrative bot, advanced search, reports, and the .ics endpoint for bookmarks.
97 lines
3.4 KiB
Ruby
97 lines
3.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Jobs::SyncTopicUserBookmarked do
|
|
fab!(:topic) { Fabricate(:topic) }
|
|
fab!(:post1) { Fabricate(:post, topic: topic) }
|
|
fab!(:post2) { Fabricate(:post, topic: topic) }
|
|
fab!(:post3) { Fabricate(:post, topic: topic) }
|
|
|
|
fab!(:tu1) { Fabricate(:topic_user, topic: topic, bookmarked: false) }
|
|
fab!(:tu2) { Fabricate(:topic_user, topic: topic, bookmarked: false) }
|
|
fab!(:tu3) { Fabricate(:topic_user, topic: topic, bookmarked: true) }
|
|
fab!(:tu4) { Fabricate(:topic_user, topic: topic, bookmarked: true) }
|
|
fab!(:tu5) { Fabricate(:topic_user, topic: topic, bookmarked: true) }
|
|
|
|
it "corrects all topic_users.bookmarked records for the topic" do
|
|
Fabricate(:bookmark, user: tu1.user, post: topic.posts.sample)
|
|
Fabricate(:bookmark, user: tu4.user, post: topic.posts.sample)
|
|
|
|
subject.execute(topic_id: topic.id)
|
|
|
|
expect(tu1.reload.bookmarked).to eq(true)
|
|
expect(tu2.reload.bookmarked).to eq(false)
|
|
expect(tu3.reload.bookmarked).to eq(false)
|
|
expect(tu4.reload.bookmarked).to eq(true)
|
|
expect(tu5.reload.bookmarked).to eq(false)
|
|
end
|
|
|
|
it "does not consider topic as bookmarked if the bookmarked post is deleted" do
|
|
Fabricate(:bookmark, user: tu1.user, post: post1)
|
|
Fabricate(:bookmark, user: tu2.user, post: post1)
|
|
|
|
post1.trash!
|
|
|
|
subject.execute(topic_id: topic.id)
|
|
|
|
expect(tu1.reload.bookmarked).to eq(false)
|
|
expect(tu2.reload.bookmarked).to eq(false)
|
|
end
|
|
|
|
it "works when no topic id is provided (runs for all topics)" do
|
|
Fabricate(:bookmark, user: tu1.user, post: topic.posts.sample)
|
|
Fabricate(:bookmark, user: tu4.user, post: topic.posts.sample)
|
|
|
|
subject.execute
|
|
|
|
expect(tu1.reload.bookmarked).to eq(true)
|
|
expect(tu2.reload.bookmarked).to eq(false)
|
|
expect(tu3.reload.bookmarked).to eq(false)
|
|
expect(tu4.reload.bookmarked).to eq(true)
|
|
expect(tu5.reload.bookmarked).to eq(false)
|
|
end
|
|
|
|
context "for polymorphic bookmarks" do
|
|
before do
|
|
SiteSetting.use_polymorphic_bookmarks = true
|
|
end
|
|
|
|
it "corrects all topic_users.bookmarked records for the topic" do
|
|
Fabricate(:bookmark, user: tu1.user, bookmarkable: topic.posts.sample)
|
|
Fabricate(:bookmark, user: tu4.user, bookmarkable: topic.posts.sample)
|
|
|
|
subject.execute(topic_id: topic.id)
|
|
|
|
expect(tu1.reload.bookmarked).to eq(true)
|
|
expect(tu2.reload.bookmarked).to eq(false)
|
|
expect(tu3.reload.bookmarked).to eq(false)
|
|
expect(tu4.reload.bookmarked).to eq(true)
|
|
expect(tu5.reload.bookmarked).to eq(false)
|
|
end
|
|
|
|
it "does not consider topic as bookmarked if the bookmarked post is deleted" do
|
|
Fabricate(:bookmark, user: tu1.user, bookmarkable: post1)
|
|
Fabricate(:bookmark, user: tu2.user, bookmarkable: post1)
|
|
|
|
post1.trash!
|
|
|
|
subject.execute(topic_id: topic.id)
|
|
|
|
expect(tu1.reload.bookmarked).to eq(false)
|
|
expect(tu2.reload.bookmarked).to eq(false)
|
|
end
|
|
|
|
it "works when no topic id is provided (runs for all topics)" do
|
|
Fabricate(:bookmark, user: tu1.user, bookmarkable: topic.posts.sample)
|
|
Fabricate(:bookmark, user: tu4.user, bookmarkable: topic.posts.sample)
|
|
|
|
subject.execute
|
|
|
|
expect(tu1.reload.bookmarked).to eq(true)
|
|
expect(tu2.reload.bookmarked).to eq(false)
|
|
expect(tu3.reload.bookmarked).to eq(false)
|
|
expect(tu4.reload.bookmarked).to eq(true)
|
|
expect(tu5.reload.bookmarked).to eq(false)
|
|
end
|
|
end
|
|
end
|