Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/system
History
Alan Guo Xiang Tan 2dd9ac6277
DEV: Improve PageObjects::Components::Sidebar#has_tag_section_links? (#22250) 
Why this change?

Predicate matchers are poor at providing good error messages when it
fails if all the predicate matcher does is to return a boolean. Prior to
this change, we were using `has_css? && all?` to assert for the tag
section links. There are two problems here. Firstly, when one of the matchers
fail, the error message does not provide any indication of which matcher
failed making it hard to debug failures. Secondly, the matchers were not
able to assert for the ordering of the tag section links which is an
important behaviour to assert for.

This commit changes `PageObjects::Components::Sidebar#has_tag_section_links?`
such that we make use of assertions to ensure ordering. The usage of
`all` will also provide a clear error message when things go wrong.
 		2023-06-23 08:39:37 +08:00
..
composer DEV: Add custom error messages to form template forms (#22169) 2023-06-20 13:45:58 -07:00
emojis DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
page_objects DEV: Improve PageObjects::Components::Sidebar#has_tag_section_links? (#22250) 2023-06-23 08:39:37 +08:00
user_page DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
admin_customize_form_templates_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
admin_customize_themes_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
bookmarks_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
category_edit_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
category_topics_spec.rb FIX: update unread and new count for categories (#22145) 2023-06-21 13:42:30 +10:00
custom_sidebar_sections_spec.rb DEV: Change `have_section_link` match to use exact text match. (#22148) 2023-06-16 16:36:34 +08:00
discovery_breadcrumb_navigation_spec.rb DEV: Fix random typos (#22078) 2023-06-13 22:02:21 +02:00
dismiss_topics_spec.rb FIX: change dismiss new button label (#22075) 2023-06-13 13:18:39 +10:00
editing_sidebar_categories_navigation_spec.rb UX: Fix edit tags/categories navigation menu modal has no focus on input (#22237) 2023-06-22 09:56:12 +08:00
editing_sidebar_tags_navigation_spec.rb UX: Fix edit tags/categories navigation menu modal has no focus on input (#22237) 2023-06-22 09:56:12 +08:00
ember_deprecation_test.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
fast_edit_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
filtering_topics_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
hashtag_autocomplete_spec.rb FIX: Add aria-label attribute to cooked hashtags (#22182) 2023-06-20 15:47:17 +10:00
network_disconnected_spec.rb DEV: Use online/offline window events to track network connectivity (#22243) 2023-06-22 09:09:28 -05:00
reviewables_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
search_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
tag_notification_level_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
tag_synonyms_spec.rb DEV: Fix random typos (#22078) 2023-06-13 22:02:21 +02:00
topic_page_spec.rb DEV: Try to de-flake topic page specs (#22065) 2023-06-13 11:05:19 +02:00
topic_summarization_spec.rb FEATURE: Custom content summarization strategies. (#21813) 2023-06-13 14:21:46 -03:00
user_preferences_interface_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_preferences_navigation_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_selector_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
viewing_category_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
viewing_navigation_menu_preferences_spec.rb FEATURE: Split navigation preference for count and behavior of sidebar links (#22203) 2023-06-22 19:04:13 +03:00
viewing_sidebar_as_anonymous_user_spec.rb DEV: Improve PageObjects::Components::Sidebar#has_tag_section_links? (#22250) 2023-06-23 08:39:37 +08:00
viewing_sidebar_mobile_spec.rb FIX: rename everything link to topics (#22076) 2023-06-15 11:36:38 +10:00
viewing_sidebar_spec.rb FIX: small bug with topics and my posts translations (#22179) 2023-06-19 17:51:33 +10:00
viewing_user_private_messages_spec.rb FIX: Broken group messages inboxes when group name is mixed case (#22183) 2023-06-19 17:36:04 +08:00