discourse/spec
Martin Brennan 39b2fb8649
FIX: Invalid URLs could raise exceptions when calling UrlHelper.rails_route_from_url (#10782)
Upload.secure_media_url? raised an exceptions when the URL was invalid,
which was a issue in some situations where secure media URLs must be
removed.

For example, sending digests used PrettyText.strip_secure_media,
which used Upload.secure_media_url? to replace secure media with
placeholders. If the URL was invalid, then an exception would be raised
and left unhandled.

Now instead in UrlHelper.rails_route_from_url we return nil if there is something wrong with the URL.

Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2020-09-30 15:20:00 +10:00
..
components FIX: Invalid URLs could raise exceptions when calling UrlHelper.rails_route_from_url (#10782) 2020-09-30 15:20:00 +10:00
fabricators DEV: Move UserApiKey scopes to dedicated table (#10704) 2020-09-29 10:57:48 +01:00
fixtures SECURITY: return error on oversized images 2020-09-14 10:45:11 +10:00
helpers DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
import_export FEATURE: Rake task to export groups (#9450) 2020-04-17 14:59:54 -07:00
initializers FIX: We need to skip users with associated reviewables when auto-approving (#9080) 2020-03-02 14:33:52 -05:00
integration FIX: Pluralized translation overrides didn't work for en_US 2020-08-29 00:11:46 +02:00
integrity DEV: Check English locale for errors in CI 2020-06-03 21:54:58 +02:00
jobs DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
lib DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
mailers FEATURE: Allow email image embed with secure media (#10563) 2020-09-10 09:50:16 +10:00
models FIX: Invalid URLs could raise exceptions when calling UrlHelper.rails_route_from_url (#10782) 2020-09-30 15:20:00 +10:00
multisite DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
requests FIX: Use correct locale for error messages (#10776) 2020-09-29 21:42:45 +02:00
script/import_scripts FIX: improve Vanilla importing (#10478) 2020-08-24 16:19:57 -04:00
serializers DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
services DEV: Move UserApiKey scopes to dedicated table (#10704) 2020-09-29 10:57:48 +01:00
support DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
tasks DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
views/omniauth_callbacks FEATURE: Use full page redirection for all external auth methods (#8092) 2019-10-08 12:10:43 +01:00
rails_helper.rb DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
swagger_helper.rb DEV: Add rswag to aid in api documention (#9546) 2020-04-27 16:40:07 -06:00