Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/test/javascripts/lib
History
Robin Ward f9608c0af5 DEV: Remove INLINE_ONEBOX_* constants 
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and
`INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they
were DRYing up: `inline-onebox-loading` and `inline-onebox`

I normally appreciate constants, but in this case it meant that we had
a lot of JS imports resulting in many more lines of code (and CPU cycles
spent figuring them out.)

It also meant we had an `.erb` file and had to invoke Ruby to create the
JS file, which meant the app was harder to port to Ember CLI.

I removed the constants. It's less DRY but faster and simpler, and
arguably the loss of DRYness is not significant as you can still search
for the `inline-onebox-loading` and `inline-onebox` strings easily if
you are refactoring.
 		2020-05-07 16:14:38 -04:00
..
bbcode-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
bookmark-test.js DEV: Upgrade sinon and fix time based bookmark tests (#9647) 2020-05-07 09:10:32 +10:00
break-string-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
category-badge-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
click-track-edit-history-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
click-track-profile-page-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
click-track-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
computed-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
discourse-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
emoji-store-test.js DEV: Fix some more flaky tests (#9384) 2020-04-08 12:46:43 +02:00
emoji-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
formatter-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
highlight-search-test.js.es6 FIX: remove word boundary regex (\b) for search result highlights. (#9338) 2020-04-15 11:11:00 +05:30
i18n-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
icon-library-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
key-value-store-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
link-mentions-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
load-script-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
oneboxer-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
preload-store-test.js DEV: Move `preload-store` to `discourse/lib/preload-store` 2020-05-06 15:28:06 -04:00
pretty-text-test.js DEV: Remove INLINE_ONEBOX_* constants 2020-05-07 16:14:38 -04:00
sanitizer-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
screen-track-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
search-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
sharing-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
text-direction-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
to-markdown-test.js UX: strip base64 image URLs when converting HTML to markdown. 2020-04-12 21:05:23 +05:30
tooltip-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
upload-short-url-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
uploads-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
url-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
user-search-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
utilities-test.js UX: Improve second factor UI (#9526) 2020-05-05 11:05:25 +10:00
white-lister-test.js Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00