mirror of
https://github.com/discourse/discourse.git
synced 2025-02-05 19:11:13 +00:00
584424594e
This patch replaces the parameters provided to a service through `params` by the contract object. That way, it allows better consistency when accessing input params. For example, if you have a service without a contract, to access a parameter, you need to use `params[:my_parameter]`. But with a contract, you do this through `contract.my_parameter`. Now, with this patch, you’ll be able to access it through `params.my_parameter` or `params[:my_parameter]`. Some methods have been added to the contract object to better mimic a Hash. That way, when accessing/using `params`, you don’t have to think too much about it: - `params.my_key` is also accessible through `params[:my_key]`. - `params.my_key = value` can also be done through `params[:my_key] = value`. - `#slice` and `#merge` are available. - `#to_hash` has been implemented, so the contract object will be automatically cast as a hash by Ruby depending on the context. For example, with an AR model, you can do this: `user.update(**params)`.
61 lines
1.5 KiB
Ruby
61 lines
1.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class SiteSetting::Update
|
|
include Service::Base
|
|
|
|
options { attribute :allow_changing_hidden, :boolean, default: false }
|
|
|
|
policy :current_user_is_admin
|
|
params do
|
|
attribute :setting_name
|
|
attribute :new_value
|
|
|
|
before_validation do
|
|
self.setting_name = setting_name&.to_sym
|
|
self.new_value = new_value.to_s.strip
|
|
end
|
|
|
|
validates :setting_name, presence: true
|
|
|
|
after_validation do
|
|
next if setting_name.blank?
|
|
self.new_value =
|
|
case SiteSetting.type_supervisor.get_type(setting_name)
|
|
when :integer
|
|
new_value.tr("^-0-9", "").to_i
|
|
when :file_size_restriction
|
|
new_value.tr("^0-9", "").to_i
|
|
when :uploaded_image_list
|
|
new_value.blank? ? "" : Upload.get_from_urls(new_value.split("|")).to_a
|
|
when :upload
|
|
Upload.get_from_url(new_value) || ""
|
|
else
|
|
new_value
|
|
end
|
|
end
|
|
end
|
|
policy :setting_is_visible
|
|
policy :setting_is_configurable
|
|
step :save
|
|
|
|
private
|
|
|
|
def current_user_is_admin(guardian:)
|
|
guardian.is_admin?
|
|
end
|
|
|
|
def setting_is_visible(params:, options:)
|
|
options.allow_changing_hidden || !SiteSetting.hidden_settings.include?(params[:setting_name])
|
|
end
|
|
|
|
def setting_is_configurable(params:)
|
|
return true if !SiteSetting.plugins[params[:setting_name]]
|
|
|
|
Discourse.plugins_by_name[SiteSetting.plugins[params[:setting_name]]].configurable?
|
|
end
|
|
|
|
def save(params:, guardian:)
|
|
SiteSetting.set_and_log(params[:setting_name], params[:new_value], guardian.user)
|
|
end
|
|
end
|