discourse/plugins/chat/spec/support
Martin Brennan c07f1e442f
DEV: Fix failing chat spec and add unexpected failure indicator (#20299)
This commit fixes the UpdateUserLastRead spec which was checking
for a message ID that did not exist -- this could fail at times
since message ID 2 could exist. Better to create + destroy a message
since then it's guaranteed we have a unique ID.

This also attempts to clarify a step that we expect to fail which
succeeds instead by adding another emoji next to the success tick and
an explanation text.

Also removes some uses of unless in Services::Base, we generally prefer
to use alternatives, since unless can be hard to parse in a lot of
cases.

Co-authored-by: Loïc Guitaut <loic@discourse.org>
2023-02-15 19:16:13 +01:00
..
api/schemas DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
examples DEV: Apply syntax_tree formatting to `plugins/*` 2023-01-07 11:11:37 +00:00
api_schema_matcher.rb DEV: Move `discourse-chat` to the core repo. (#18776) 2022-11-02 10:41:30 -03:00
chat_helper.rb DEV: Move `discourse-chat` to the core repo. (#18776) 2022-11-02 10:41:30 -03:00
chat_service_matcher.rb DEV: Fix failing chat spec and add unexpected failure indicator (#20299) 2023-02-15 19:16:13 +01:00