A platform for community discussion. Free, open, simple.
Go to file
Régis Hanol 71391cd40d PERF: fix performance of chat email notifications
When chat is enabled, there's a scheduled job that runs every 5 minutes to check whether we need to send a "chat summary" email to users with unread chat messages or mentions.

On Discourse with a large number of users, the query used wasn't optimal and sometimes taking minutes. Which isn't good when the query is called every 5 minutes 😬

This PR reworks the query in `Chat::Mailer.send_unread_mentions_summary`.

Instead of starting from the `users` table, it starts from the `user_chat_channel_memberships` table which is the main piece tying everything together.

The new query is mostly similar to the previous one, with some bug fixes (like ensuring the user has `allow_private_messages` enabled for direct messages) and is also slightly simpler since it doesn't keep track of the `memberships_with_unread_messages` anymore. That part has been moved to the `user_notifications.chat_summary` email method.

The `UserEmailExtension` has been deleted since that was using to N+1 update the `user_chat_channel_memberships.last_unread_mention_when_emailed_it`(quite a mouthful 😛) but that's now done directly in the `user_notifications.chat_summary` email method.

The "plat de résistance" of that PR - the `user_notifications.chat_summary` method has been re-worked for improved performances 🚀

Instead of doing everything in one query, it does 4 tiny ones.

- One to retrieve the list of unread mentions (@something) in "category" channels
- One to retrieve the list of unread messages in "direct message" channels (aka. 1-1 and group discussions)
- One to load all the chat messages for each "category" channels from the last unread mention
- One to load all the chat messages for each "direct message" channels from the last unread message

All the specs for both `Chat::Mailer` and `UserNotification.chat_summary` have been rewriten for easier comprehension and faster execution (mostly by not using chat services which makes the specs go 10x slower...)

Internal ref - t/129848
2024-06-10 14:25:06 +02:00
.devcontainer
.github DEV: Run flake check only on discourse/discourse (#27350) 2024-06-05 18:30:37 +02:00
.vscode-sample
app Build(deps): Bump ember-resolver from 11.0.1 to 12.0.0 (#27390) 2024-06-10 14:24:46 +02:00
bin DEV: Drop Ember 3 feature flag 2024-02-26 12:22:05 +00:00
config DEV: Introduce hidden `s3_inventory_bucket` site setting (#27304) 2024-06-10 13:16:00 +08:00
db FIX: move something else flag to the bottom (#27366) 2024-06-06 15:45:30 +10:00
docs DEV: Add a callback to the validation of user custom fields in the signup form (#27369) 2024-06-06 11:17:06 -06:00
images
lib DEV: Remove non-official plugins from metadata (#27050) 2024-06-10 10:40:36 +01:00
log
migrations DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
patches Revert "DEV: `@babel/plugin-proposal-decorators` -> `decorator-transforms` (#25290)" (#26971) 2024-05-10 12:48:16 +01:00
plugins PERF: fix performance of chat email notifications 2024-06-10 14:25:06 +02:00
public FEATURE: Add Uyghur language (#27183) 2024-05-27 09:58:18 +02:00
script DEV: Improve user generic bulk importer anonymization (#27307) 2024-06-05 11:25:17 +00:00
spec FIX: `Jobs::EnsureS3UploadsExistence` broken for multisite (#27401) 2024-06-10 16:26:39 +08:00
test DEV: Update chrome-launcher from 0.15.2 to 1.1.0 (#25909) 2024-02-27 11:25:11 +01:00
vendor UX: Add chevron icons for expanding and collapsing all toggles in the admin sidebar (#26246) 2024-03-21 10:25:14 +11:00
.editorconfig
.eslintignore
.eslintrc.cjs DEV: Use `@discourse/lint-configs` (#24038) 2023-10-23 12:08:35 +02:00
.git-blame-ignore-revs
.gitattributes DEV: Remove GitHub gjs highlighting workaround (#24791) 2023-12-08 11:55:20 +00:00
.gitignore DEV: git ignored directories should not have trailing slashes (#27130) 2024-05-22 12:33:01 +02:00
.jsdoc DEV: Remove unmaintained tidy-jsdoc dependency (#25110) 2024-01-03 10:30:54 +00:00
.licensed.yml DEV: Add mutex_m to reviewed gems (#27080) 2024-05-20 15:03:33 +08:00
.licensee.json DEV: Allow @glimmer/* packages' MIT style licenses (#27210) 2024-05-28 14:00:52 -03:00
.npmrc
.prettierignore DEV: Patch `deprecated-run-loop-and-computed-dot-access` in production (#25074) 2024-01-02 10:44:26 +00:00
.prettierrc.cjs DEV: Use `@discourse/lint-configs` (#24038) 2023-10-23 12:08:35 +02:00
.rspec
.rspec_parallel
.rubocop.yml DEV: Update rubocop-discourse to latest version 2024-03-04 15:08:35 +01:00
.ruby-gemset.sample
.ruby-version.sample
.streerc
.template-lintrc.cjs DEV: Update js linting setup (#25365) 2024-01-24 15:30:03 +01:00
Brewfile
CODEOWNERS DEV: Add "migrations-tooling" label to PRs for import scripts (#25062) 2023-12-28 21:26:05 +01:00
CONTRIBUTING.md
COPYRIGHT.md
Gemfile DEV: Add `mutex_m` and `drb` to Gemfile to remove deprecation warning (#27012) 2024-05-15 05:44:50 +08:00
Gemfile.lock Build(deps): Bump sprockets-rails from 3.5.0 to 3.5.1 in the rails group (#27391) 2024-06-10 09:00:46 +08:00
LICENSE.txt
README.md Replace Twitter screenshot with X screenshot (#25506) 2024-02-01 09:11:54 -07:00
Rakefile
config.ru
d
discourse.sublime-project
jsconfig.json Enable Embroider/Webpack code spliting for Wizard (#24919) 2023-12-20 13:15:06 +00:00
lefthook.yml
package.json Build(deps-dev): Bump esbuild from 0.21.4 to 0.21.5 (#27389) 2024-06-10 09:01:23 +08:00
translator.yml DEV: Add "automation" plugin to Crowdin (#26497) 2024-04-03 20:00:42 +02:00
yarn.lock Build(deps): Bump ember-resolver from 11.0.1 to 12.0.0 (#27390) 2024-06-10 14:24:46 +02:00

README.md

Discourse is the online home for your community. We offer a 100% open source community platform to those who want complete control over how and where their site is run.

Our platform has been battle-tested for over a decade and continues to evolve to meet users needs for a powerful community platform. Discourse allows you to create discussion topics and connect using real-time chat, as well as access an ever-growing number of official and community themes. In addition, we offer a wide variety of plugins for features ranging from chatbots powered by Discourse AI to functionalities like SQL analysis using the Data Explorer plugin.

To learn more, visit discourse.org and join our support community at meta.discourse.org.

Screenshots

Discourse 3.1

Boing Boing

X Community

Mobile

Browse lots more notable Discourse instances.

Development

To get your environment set up, follow the community setup guide for your operating system.

  1. If you're on macOS, try the macOS development guide.
  2. If you're on Ubuntu, try the Ubuntu development guide.
  3. If you're on Windows, try the Windows 10 development guide.
  4. If you're looking to use a simpler Docker-based install, try the Docker development guide.

If you're familiar with how Rails works and are comfortable setting up your own environment, you can also try out the Discourse Advanced Developer Guide, which is aimed primarily at Ubuntu and macOS environments.

Before you get started, ensure you have the following minimum versions: Ruby 3.2+, PostgreSQL 13, Redis 7. If you're having trouble, please see our TROUBLESHOOTING GUIDE first!

Setting up Discourse

If you want to set up a Discourse forum for production use, see our Discourse Install Guide.

If you're looking for official hosting, see discourse.org/pricing.

Requirements

Discourse is built for the next 10 years of the Internet, so our requirements are high.

Discourse supports the latest, stable releases of all major browsers and platforms:

Browsers Tablets Phones
Apple Safari iPadOS iOS
Google Chrome Android Android
Microsoft Edge
Mozilla Firefox

Additionally, we aim to support Safari on iOS 15.7+.

Built With

  • Ruby on Rails — Our back end API is a Rails app. It responds to requests RESTfully in JSON.
  • Ember.js — Our front end is an Ember.js app that communicates with the Rails API.
  • PostgreSQL — Our main data store is in Postgres.
  • Redis — We use Redis as a cache and for transient data.
  • BrowserStack — We use BrowserStack to test on real devices and browsers.

Plus lots of Ruby Gems, a complete list of which is at /main/Gemfile.

Contributing

Build Status

Discourse is 100% free and open source. We encourage and support an active, healthy community that accepts contributions from the public including you!

Before contributing to Discourse:

  1. Please read the complete mission statements on discourse.org. Yes we actually believe this stuff; you should too.
  2. Read and sign the Electronic Discourse Forums Contribution License Agreement.
  3. Dig into CONTRIBUTING.MD, which covers submitting bugs, requesting new features, preparing your code for a pull request, etc.
  4. Always strive to collaborate with mutual respect.
  5. Not sure what to work on? We've got some ideas.

We look forward to seeing your pull requests!

Security

We take security very seriously at Discourse; all our code is 100% open source and peer reviewed. Please read our security guide for an overview of security measures in Discourse, or if you wish to report a security issue.

The Discourse Team

The original Discourse code contributors can be found in AUTHORS.MD. For a complete list of the many individuals that contributed to the design and implementation of Discourse, please refer to the official Discourse blog and GitHub's list of contributors.

Copyright 2014 - 2023 Civilized Discourse Construction Kit, Inc.

Licensed under the GNU General Public License Version 2.0 (or later); you may not use this work except in compliance with the License. You may obtain a copy of the License in the LICENSE file, or at:

https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

Discourse logo and “Discourse Forum” ®, Civilized Discourse Construction Kit, Inc.

Accessibility

To guide our ongoing effort to build accessible software we follow the W3Cs Web Content Accessibility Guidelines (WCAG). If you'd like to report an accessibility issue that makes it difficult for you to use Discourse, email accessibility@discourse.org. For more information visit discourse.org/accessibility.

Dedication

Discourse is built with love, Internet style.