Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/plugins/chat/spec/system
History
Martin Brennan fc199d42fa
FIX: Add aria-label attribute to cooked hashtags (#22182) 
This commit adds an aria-label attribute to cooked hashtags using
the post/chat message decorateCooked functionality. I have just used
the inner content of the hashtag (the tag/category/channel name) for
the label -- we can reexamine at some point if we want something
different like "Link to dev category" or something, but from what I
can tell things like Twitter don't even have aria-labels for hashtags
so the text would be read out directly.

This commit also refactors any ruby specs checking the HTML of hashtags
to use rspec-html-matchers which is far clearer than having to maintain
the HTML structure in a HEREDOC for comparison, and gives better spec
failures.

c.f. https://meta.discourse.org/t/hashtags-are-getting-a-makeover/248866/23?u=martin
 		2023-06-20 15:47:17 +10:00
..
chat/composer REFACTOR: composer/thread (#21910) 2023-06-07 21:49:15 +02:00
chat_message FIX: various mobile chat improvements (#22132) 2023-06-16 11:36:43 +02:00
list_channels FIX: scroll top after chat activation (#21952) 2023-06-09 17:51:35 +02:00
page_objects REFACTOR: <ChatMessage> component (#22172) 2023-06-19 09:50:54 +02:00
reply_to_message DEV: more reliable thread level spec (#22173) 2023-06-17 14:28:22 +02:00
select_message FIX: allows selection of messages in threads (#22119) 2023-06-15 11:27:31 +02:00
shortcuts DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
thread_list FEATURE: Allow users to manually track threads without replying (#22100) 2023-06-16 12:08:26 +10:00
thread_tracking DEV: more reliable thread level spec (#22173) 2023-06-17 14:28:22 +02:00
user_menu_notifications DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_status DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
anonymous_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
archive_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
bookmark_message_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
browse_page_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_about_page_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_info_pages_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_members_page_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_message_upload_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_selector_modal_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_settings_page_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
channel_thread_message_echoing_spec.rb FEATURE: Allow users to manually track threads without replying (#22100) 2023-06-16 12:08:26 +10:00
chat_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
chat_composer_draft_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
chat_composer_spec.rb REFACTOR: composer/thread (#21910) 2023-06-07 21:49:15 +02:00
chat_message_onebox_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
chat_summarization_spec.rb FEATURE: Custom content summarization strategies. (#21813) 2023-06-13 14:21:46 -03:00
closed_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
create_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
dates_separators_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
deleted_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
deleted_message_spec.rb REFACTOR: <ChatMessage> component (#22172) 2023-06-19 09:50:54 +02:00
document_title_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
draft_message_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
drawer_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
edited_message_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
flag_message_spec.rb FIX: direct message channels can be flagged (#22134) 2023-06-16 11:04:59 +10:00
hashtag_autocomplete_spec.rb FIX: Add aria-label attribute to cooked hashtags (#22182) 2023-06-20 15:47:17 +10:00
jit_messages_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
kick_user_from_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
mention_warnings_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
message_errors_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
message_notifications_mobile_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
message_notifications_with_sidebar_spec.rb UX: Chat unread indicator refactor (#22040) 2023-06-12 14:33:45 +10:00
message_thread_indicator_spec.rb FEATURE: Allow users to manually track threads without replying (#22100) 2023-06-16 12:08:26 +10:00
message_user_info.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
move_message_to_channel_spec.rb REFACTOR: <ChatMessage> component (#22172) 2023-06-19 09:50:54 +02:00
navigation_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
react_to_message_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
read_only_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
reviewables_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
sidebar_navigation_menu_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
sidebars_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
silenced_user_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
single_thread_spec.rb FEATURE: Allow users to manually track threads without replying (#22100) 2023-06-16 12:08:26 +10:00
transcript_spec.rb FIX: allows selection of messages in threads (#22119) 2023-06-15 11:27:31 +02:00
unfollow_dm_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
update_last_read.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
uploads_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_card_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_chat_preferences_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
user_presence.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00
visit_channel_spec.rb DEV: Remove superfluous `js: true` metadata (#21960) 2023-06-07 09:26:58 +08:00