7434116933
* DEV: Add schema checking to api doc testing This commit improves upon rswag which lacks schema checking. rswag really only checks that the https status matches, but this change adds in the json-schema_builder gem which also has schema validation. Now we can define schemas for each of our requests/responses in the `spec/requests/api/schemas` directory which will make our documentation specs a lot cleaner. If we update a serializer by either adding or removing an attribute the tests will now fail (this is a good thing!). Also if you change the type of an attribute say from an array to a string the tests will now fail. This will help significantly with keeping the docs in sync with actual code changes! Now if you change how an endpoint will respond you will have to update the docs too in order for the tests to pass. :D This PR is inspired by: https://www.tealhq.com/post/how-teal-keeps-their-api-tests-and-documentation-in-sync * Swap out json schema validator gem Swapped out the outdated json-schema_builder gem with the json_schemer gem. * Add validation fields to schema In order to have "strict" validation we need to add `additionalProperties: false` to the schema, and we need to specify which attributes are required. Updated the debugging test output to print out the error details if there are any. |
||
|---|---|---|
| .. | ||
| schemas | ||
| shared | ||
| categories_spec.rb | ||
| groups_spec.rb | ||
| invites_spec.rb | ||
| notifications_spec.rb | ||
| posts_spec.rb | ||
| private_messages_spec.rb | ||
| tags_spec.rb | ||
| topics_spec.rb | ||
| users_spec.rb | ||