mirror of
https://github.com/discourse/discourse.git
synced 2025-02-06 19:38:24 +00:00
This code runs on every keyup event in the application, so it needs to be efficient. Previously we were iterating over the whole document using the JQuery :visible selector. Per the JQuery docs at https://api.jquery.com/visible-selector/ > Using this selector heavily can have performance implications, as it may force the browser to re-render the page before it can determine visibility. Tracking the visibility of elements via other methods, using a class for example, can provide better performance. We already had a `hidden` class on the modal element which we can check, so we can check that instead.