mirror of
https://github.com/discourse/discourse.git
synced 2025-02-05 19:11:13 +00:00
775dce1f13
Why this change? The code changes introduced in 5b91dc184418000adaabf0dfe64eebbd8233d6ec resulted in errors being raised when `session.quit` is called when using multiple sessions. From my debugging, this seems to be attributed to the fact that the change introduced resulted in multiple sessions sharing the same instance of `Selenium::WebDriver::Remote::Http::Default`. While sharing the same instance in theory should be fine, but the problem is that `Selenium::WebDriver::Driver` will mutate the `server_url` of the client in `Selenium::WebDriver::Remote::Bridge`. This is problematic because each session created by capbyara relies on a different server URL and this mutation causes all sorts of weird errors to occur. To reproduce the problem, run `LOAD_PLUGINS=1 rspec plugins/chat/spec/system/send_message_spec.rb:76` locally while excluding the changes in this commit.