discourse/spec
Alan Guo Xiang Tan 7aab65887f
UX: Fix edit navigation tags modal height too long on desktop (#24765)
Why this change?

The tags modal loads more tags via infinite loading based on when the last tag in the
given page appears in the viewport for the user. When it comes in to
view, a request is then triggered to fetch additional tags. To ensure
that we are only loading a single page of tags each time the modal is
opened, we previously set a max height on the modal's body to ensure
that the last tag which appears in the modal will be outside of the view
port in the initial load. However, this has regressed recently due to
unknown reasons and resulted in multiple pages of tags being loaded
immediately from the server as the modal's height was not restricted.
This regression was caught by an existing test but was unfortunately
determined as flaky.

What does this change do?

This change restores the max height on the edit navigation menu tags
modal on dekstop.
2023-12-07 09:42:04 +08:00
..
fabricators DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
fixtures DEV: Fix various spec linting issues (#24672) 2023-12-04 13:45:19 +01:00
helpers DEV: Use Discourse::SYSTEM_USER_ID in fixtures/009_users (#24743) 2023-12-07 09:04:45 +10:00
import_export DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
initializers DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
integration DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
integrity DEV: Modernise highlightjs loading (#24197) 2023-11-10 20:39:48 +00:00
jobs DEV: Use Discourse::SYSTEM_USER_ID in fixtures/009_users (#24743) 2023-12-07 09:04:45 +10:00
lib DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
mailers DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
migrations DEV: Switch over category settings to new table - Part 3 (#20657) 2023-09-12 09:51:49 +08:00
models DEV: Use Discourse::SYSTEM_USER_ID in fixtures/009_users (#24743) 2023-12-07 09:04:45 +10:00
multisite DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
requests DEV: Use Discourse::SYSTEM_USER_ID in fixtures/009_users (#24743) 2023-12-07 09:04:45 +10:00
script/import_scripts DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
serializers DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
services DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
support DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
system UX: Fix edit navigation tags modal height too long on desktop (#24765) 2023-12-07 09:42:04 +08:00
tasks DEV: Remove the transpilation message (#23998) 2023-10-19 01:00:15 +02:00
views FIX: Use subfolder-safe url for category in html view (#24595) 2023-11-28 19:08:14 +08:00
rails_helper.rb DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
regenerate_swagger_docs DEV: Add API docs for uploads and API doc watcher (#15387) 2021-12-23 08:40:15 +10:00
swagger_helper.rb DEV: Bump rswag-specs from 2.11.0 to 2.13.0 (#24654) 2023-12-07 08:16:47 +08:00