discourse/app
Keegan George eb987460f2
FEATURE: Select emojis in picker via keyboard (#18163)
* DEV: Make emoji elements focusable

Since emoji elements are of type `<img>` it requires a `tablindex="0"` in order to be focusable.

* WIP: Handle emoji focus/selection via arrow keys

Near completion, however, need a few fixes/improvements and overall code cleanup

* WIP: Testing

* DEV: Fixes and cleanup

* DEV: Follow conventions

* DEV: Improve up/down traversal when recents present

* DEV: Emoji markup in tests should include `tabindex`

* DEV: Add `tabindex` to topic tests

* DEV: Variable name as `searchInput` instead of `searchBar`

* DEV: Use appropriate method name (`_setNumEmojiPerRow`)

* DEV: Add comments and avoid nested if

* WIP: Adding test

* Fix first test

* DEV: Add assertions for arrow keys and escape key

* Some fixes for up/down navigation

This does not fix everything, when going from one section to another,
there are issues

* Fix a small regression

* FIX: Ability to focus on search results

Fixes regression

* Refactor calculating next up/down emoji

* Debugging test failure

* Skip stubborn CI test, add others

Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2022-09-21 13:21:36 -07:00
..
assets FEATURE: Select emojis in picker via keyboard (#18163) 2022-09-21 13:21:36 -07:00
controllers DEV: Update highlight.js to version 11 (#18282) 2022-09-20 12:43:28 -03:00
helpers DEV: Compile splash screen JS with ember-cli before inlining (#18150) 2022-09-01 09:58:48 +01:00
jobs UX: Use dominant color as image loading placeholder (#18248) 2022-09-20 10:28:17 +01:00
mailers FEATURE: Custom unsubscribe options (#17090) 2022-06-21 15:49:47 -03:00
models DEV: Enforce dominant_color length in validation (#18309) 2022-09-21 11:01:21 +01:00
serializers DEV: Ship first pass of new user page navigation behind feature flag (#18285) 2022-09-21 12:32:47 +08:00
services FIX: Don't delete previous messages when we're inside the `sent_recently` window. (#18239) 2022-09-13 12:43:24 -03:00
views DEV: Remove support for legacy plugin JS compilation pipeline (#18293) 2022-09-21 12:38:02 +01:00