discourse/app/assets/javascripts/pretty-text/engines/discourse-markdown
Martin Brennan b2acc416e7
FIX: Server-side hashtag lookups of secure categories for a user (#19377)
* FIX: Use Category.secured(guardian) for hashtag datasource

Follow up to comments in #19219, changing the category
hashtag datasource to use Category.secured(guardian) instead
of Site.new(guardian).categories here since the latter does
more work for not much benefit, and the query time is the
same. Also eliminates some Hash -> Model back and forth
busywork. Add some more specs too.

* FIX: Server-side hashtag lookup cooking user loading

When we were using the PrettyText.options.currentUser
and parsing back and forth with JSON for the hashtag
lookups server-side, we had a bug where the user's
secure categories were not loaded since we never actually
loaded a User model from the database, only parsed it
from JSON.

This commit fixes the issue by instead using the
PretyText.options.userId and looking up the user directly
from the database when calling hashtag_lookup via the
PrettyText::Helpers code when cooking server-side. Added
the missing spec to check for this as well.
2022-12-09 10:34:25 +10:00
..
anchor.js FIX: Generate valid heading ids (#14840) 2021-11-08 20:44:46 +02:00
bbcode-block.js DEV: Update linting setup and fix issues (#17345) 2022-07-06 10:37:54 +02:00
bbcode-inline.js FIX: Empty inline BBCodes were broken (#18276) 2022-09-20 09:50:22 +10:00
category-hashtag.js FEATURE: Generic hashtag autocomplete lookup and markdown cooking (#18937) 2022-11-21 08:37:06 +10:00
censored.js FEATURE: Add support for case-sensitive Watched Words (#17445) 2022-08-02 10:06:03 +02:00
code.js DEV: Extensively use `includes()` (#17541) 2022-07-17 20:48:36 +02:00
custom-typographer-replacements.js FEATURE: Add a typographer rule to replace (pa) with ¶. (#12478) 2021-03-22 15:04:08 -03:00
d-wrap.js FIX: pretty text allow list (#10977) 2020-10-28 13:22:06 +11:00
emoji.js FIX: Watched words replacement emoji render (#19171) 2022-12-01 13:38:16 -08:00
hashtag-autocomplete.js FIX: Server-side hashtag lookups of secure categories for a user (#19377) 2022-12-09 10:34:25 +10:00
helpers.js DEV: Replace deprecated String.prototype.substr() (#16233) 2022-04-01 17:35:17 +02:00
html-img.js DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
image-controls.js UX: Fix alt text cancel button in dark mode (#18644) 2022-10-18 09:40:29 -07:00
mentions.js FEATURE: Enforce mention limits for chat messages (#19034) 2022-12-06 14:54:04 -03:00
newline.js FIX: possible ReDOS in markdown newline rule (#15646) 2022-01-20 22:32:01 +01:00
onebox.js DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
paragraph.js DEV: prettier 2.2.1 (#11862) 2021-01-27 12:39:20 +01:00
quotes.js DEV: Extensively use `startsWith()` (#17540) 2022-07-17 20:16:39 +02:00
table.js DEV: Use method definition syntax consistently (#14915) 2021-11-13 14:01:55 +01:00
text-post-process.js DEV: enforces eslint’s curly rule to the codebase (#10720) 2020-09-22 16:28:28 +02:00
upload-protocol.js DEV: Rename secure_media to secure_uploads (#18376) 2022-09-29 09:24:33 +10:00
watched-words.js FIX: Do not replace hashtag-cooked text with WatchedWords (#19279) 2022-12-01 16:31:06 +10:00