Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/app/assets/javascripts
History
Alan Guo Xiang Tan 7b907ec50a
DEV: Fix flaky table builder system spec (#25272) 
Why this change?

The `Table Builder when editing a table when cancelling table creation should close the modal if there are no changes made` system
test in `spec/system/table_builder_spec.rb` was flaky. It turns out that
when the modal is opened, we have to load some JS/CSS files. While that
is happening, the modal is actually not functional and clicking stuff
in the footer can actually result in an error. In this case, the
`interceptCloseModal` calls the private `_hasChanges` function which
then calls `this.spreadsheet.getHeaders()`. When stuff is still loading,
`this.spreadsheet` has not been set. As a result we get the following
error:

```
Cannot read properties of null (reading 'getHeaders')
```

What does this change do?

Why stuff is loading, we will now hide the footer in the modal.
 		2024-01-16 10:48:49 +08:00
..
admin FIX: use getter and setter for computed properties (#25259) 2024-01-15 15:04:28 +05:30
bootstrap-json DEV: Use correct vendor file when using ember-cli proxy in prod mode (#25224) 2024-01-11 13:27:21 +00:00
confirm-new-email DEV: Add error message styling (#21225) 2023-04-25 08:40:18 -04:00
deprecation-silencer DEV: Unsilence link-to deprecation for ember-cli build (#25197) 2024-01-10 11:01:57 +00:00
dialog-holder Build(deps): Bump ember-auto-import from 2.7.1 to 2.7.2 in /app/assets/javascripts (#25025) 2023-12-27 08:25:43 +08:00
discourse DEV: Fix flaky table builder system spec (#25272) 2024-01-16 10:48:49 +08:00
discourse-common DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
discourse-hbr DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
discourse-i18n Build(deps): Bump the embroider group (#24391) 2023-11-16 12:31:25 +01:00
discourse-markdown-it Build(deps): Bump ember-auto-import from 2.7.1 to 2.7.2 in /app/assets/javascripts (#25025) 2023-12-27 08:25:43 +08:00
discourse-plugins Build(deps): Bump the babel group in /app/assets/javascripts with 2 updates (#25075) 2024-01-02 11:51:42 +01:00
discourse-widget-hbs DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
docs
…
ember-addons
…
ember-cli-progress-ci
…
ember-production-deprecations DEV: Add production-mode shim for `Em` deprecation (#25109) 2024-01-03 10:39:59 +00:00
float-kit DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
locales DEV: convert I18n pseudo package into real package (discourse-i18n) (#23867) 2023-10-12 14:44:01 +01:00
patches DEV: Don't apply this-fallback to strict-mode components (#25216) 2024-01-11 11:35:00 +01:00
pretty-text DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
select-kit DEV: implements category-row as a glimmer template (#25223) 2024-01-11 14:00:04 +01:00
theme-transpiler DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
truth-helpers DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
.licensee.json DEV: Use webpack to load table-builder dependencies (#25018) 2024-01-02 10:47:47 +00:00
.npmrc
…
handlebars-shim.js
…
package-ember3.json DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
package-ember5.json DEV: Use ember 5 in package.json files by default (#25207) 2024-01-10 18:30:50 +01:00
package.json DEV: Switch default Ember version to 5 (#25203) 2024-01-10 12:12:36 +00:00
polyfills.js Drop support for iOS < 15.7 (#19847) 2023-01-16 17:28:59 +00:00
run-patch-package DEV: Automatically retry patch-package on failure (#23583) 2023-09-14 12:25:06 +01:00
service-worker.js.erb FIX: Syntax error (#25101) 2024-01-03 11:01:42 +08:00
yarn-ember3.lock Build(deps): Bump follow-redirects from 1.15.2 to 1.15.4 in /app/assets/javascripts (#25212) 2024-01-11 02:50:30 +01:00
yarn-ember5.lock Build(deps): Bump follow-redirects from 1.15.2 to 1.15.4 in /app/assets/javascripts (#25212) 2024-01-11 02:50:30 +01:00
yarn.lock DEV: Switch default Ember version to 5 (#25203) 2024-01-10 12:12:36 +00:00